| thiemowmde renamed this task from "[Task] Necessary refactorings to restore consistency in the WikibaseLexeme code base" to "[Task] Consistently use interfaces in the WikibaseLexeme code base". thiemowmde removed thiemowmde as the assignee of this task. thiemowmde added a subscriber: RazShuty. thiemowmde updated the task description. (Show Details) |
CHANGES TO TASK DESCRIPTION
Previous changes (e.g. https://gerrit.wikimedia.org/r/376705, which was created for and assigned to the otherwise unrelated ticket T173742) left the code base in an inconsistent state that is hard to read,Numerous previous changes left the Lexeme codebase in an inconsistent state by simply "avoiding" interfaces the Wikibase codebase and components provide for various reasons. hard to maintain,This makes the implementations in the Lexeme codebase considerably different from the established ones in the Wikibase codebase. and more and more problematic to continue working on.
The goal is to restore the consistency of the code base back to a state that enables us to work on closely related tasks from the backlogSuch code becomes harder to read and maintain, most notably editing of forms and senses and the elementsand harder to reuse in situations that type hint against one of they are made ofse interfaces.
#patch-for-review and TODOs:
[x] https://gerrit.wikimedia.org/r/386140
[] https://gerrit.wikimedia.org/r/386140Several classes implementing Wikibase\Lexeme\DataModel\Services\Diff\FormDiff do not fully conform to the DiffOp interface they implement. Content is hold twice in two private properties where it can even conflict with each other.
The goal is to restore the consistency of the code base back to a state that enables us to work on closely related tasks from the backlogSuch code becomes harder to read and maintain, most notably editing of forms and senses and the elementsand harder to reuse in situations that type hint against one of they are made ofse interfaces.
#patch-for-review and TODOs:
...
[] https://gerrit.wikimedia.org/r/383812[x] https://gerrit.wikimedia.org/r/386140
[] https://gerrit.wikimedia.org/r/386140Several classes implementing Wikibase\Lexeme\DataModel\Services\Diff\FormDiff do not fully conform to the DiffOp interface they implement. Content is hold twice in two private properties where it can even conflict with each other.
TASK DETAIL
EMAIL PREFERENCES
To: thiemowmde
Cc: RazShuty, gerritbot, Ladsgroup, Jakob_WMDE, Jonas, WMDE-leszek, daniel, Lydia_Pintscher, thiemowmde, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331
Cc: RazShuty, gerritbot, Ladsgroup, Jakob_WMDE, Jonas, WMDE-leszek, daniel, Lydia_Pintscher, thiemowmde, Aklapper, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
