| daniel renamed this task from "Replace usages of WikiPage::doUpdates and Content::getSecondaryDataUpdates" to "Replace usages of Content::getSecondaryDataUpdates". daniel updated the task description. (Show Details) |
CHANGES TO TASK DESCRIPTION
Currently, code that needs to purge or update data derived from page content (during purge, import, undeletion, etc) does so by calling WikiPage::doEditUpdates and/or by running the DataUpdates returned by Content::getSecondaryLinksUpdate directly.
Note that calls to CFor MCR, calls to Content::getSecondaryLinksUpdate() need to be replaced, since there may be more than one slot (and thus more than one Content object), and callers should not need to know about slots. This also means that calls to ontent::getSecondaryDataUpdates should not be replaced directly with calls to the new ContentHandler::getSecondaryDataUpdates proposed in T194038. Callers should not have to know about individual slots.
Instead, WikiPage::doSecondaryDataUpdates() should be introduced, with an interface similar to WikiPage::doEditUpdates(), which would use a DerivedPageDataUpdater run the combined DataUpdates for all slots.
Note: this task used to call for calls to WikiPage::doEditUpdates(), but there currently is no replacement for this without exposing DerivedPageDataUpdater directly, which we want to avoid. So WikiPage::doEditUpdates() should be un-deprecated, and its signature changed to accept RevisionRecords as well as old style Revision objects.
-----
Considerations for future refactoring:
In the context of the new page update interface for MCR, a new concise interface should be exposed for this purposepurging or updating caches and other derived data. This should be a stateless service, exposing the following methods:
Note that calls to CFor MCR, calls to Content::getSecondaryLinksUpdate() need to be replaced, since there may be more than one slot (and thus more than one Content object), and callers should not need to know about slots. This also means that calls to ontent::getSecondaryDataUpdates should not be replaced directly with calls to the new ContentHandler::getSecondaryDataUpdates proposed in T194038. Callers should not have to know about individual slots.
Instead, WikiPage::doSecondaryDataUpdates() should be introduced, with an interface similar to WikiPage::doEditUpdates(), which would use a DerivedPageDataUpdater run the combined DataUpdates for all slots.
Note: this task used to call for calls to WikiPage::doEditUpdates(), but there currently is no replacement for this without exposing DerivedPageDataUpdater directly, which we want to avoid. So WikiPage::doEditUpdates() should be un-deprecated, and its signature changed to accept RevisionRecords as well as old style Revision objects.
-----
Considerations for future refactoring:
In the context of the new page update interface for MCR, a new concise interface should be exposed for this purposepurging or updating caches and other derived data. This should be a stateless service, exposing the following methods:
...
TASK DETAIL
EMAIL PREFERENCES
To: daniel
Cc: gerritbot, Aklapper, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg
Cc: gerritbot, Aklapper, daniel, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Baloch007, E1presidente, Ramsey-WMF, Cparle, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Susannaanas, Aschroet, Fjalapeno, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
