[Wikidata-bugs] [Maniphest] [Retitled] T195372: Prevent entering of lemmas with the same spelling variant

2018-07-02 Thread CommunityTechBot
CommunityTechBot renamed this task from "bgcaaa" to "Prevent entering of lemmas with the same spelling variant".
TASK DETAILhttps://phabricator.wikimedia.org/T195372EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CommunityTechBotCc: Aklapper, gerritbot, Lexicographical data, KaMan, Esc3300, Pablo-WMDE, Lea_Lacroix_WMDE, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T195372: Prevent entering of lemmas with the same spelling variant

2018-06-04 Thread Pablo-WMDE
Pablo-WMDE renamed this task from "[Bug] Entering two lemmas with the same language code silently fails" to "Prevent entering of lemmas with the same spelling variant".Pablo-WMDE reopened this task as "Open".Pablo-WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONIf I enter two lemmas with the same language code, I should not be able to save.As an editor I want to see lemma validity indicated in the user interface when editing to avoid data loss and confusing behavior.

**AC**
Currently, I can save, the two lemmas are* Lexeme header in edit mode shows then displayed, "publish" but not saved: when I refreshton as disabled whilst the page, onlyinformation in the first one is left.orm is considered invalid
The behaviour should probably to have an error message at saving.** redundant spelling variants for multiple lemmas are considered invalid 
* Lexeme header in edit mode shows the "publish" button as enabled whilst the information in the form is considered valid and different from the state retrieved at page load

What I do```
GIVEN I am on the Lexeme (header) part of a Lexeme page
AND   There exists a lemma with the spelling variant "de"
AND   I switch to the edit mode using the edit button
WHEN  I add an additional lemma with the spelling variant "de"
THEN  The save button is disabled
{F18489759}AND   an error is shown saying "It is not possible to enter two lemmas with the same spelling variant"

What I get after savingGIVEN I am on the Lexeme (header) part of a Lexeme page
AND   There exists a lemma with the spelling variant "de"
AND   I switch to the edit mode using the edit button
WHEN  I add an lemma with the spelling variant "en"
{F18489760}THEN  The save button is enabled

What I get after reloading the pageGIVEN I am on the Lexeme (header) part of a Lexeme page
AND   There exists a lemma with the spelling variant "de"
AND   I switch to the edit mode using the edit button
WHEN  I add an lemma with the spelling variant "en"
AND   I click the save button
THEN  the lemma is saved
AND   if I reload the page the lemma is shown in the lemma section of the page header
```


**Info**
* depends on T196342
* was implemented for form representations in T193636 but implementation of Lexeme header works differently
{F18489758}** produced a mixin (`RedundantLanguageIndicator`) that can be used to determine the validation problem. [[ https://gerrit.wikimedia.org/r/436554 | First steps here ]].TASK DETAILhttps://phabricator.wikimedia.org/T195372EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Lea_Lacroix_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs