Lucas_Werkmeister_WMDE added a comment.
This change was deployed for about four hours yesterday, and during that time it seems to have improved the caching behavior a lot: based on Grafana data (permalink), the overall hit rate went from 8.5% to 60%.
awk -F';' '
$1=="hit" { hit+=$3 }
$1=="miss" {
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)).
TASK DETAILhttps://phabricator.wikimedia.org/T173696EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, ReleaseTaggerBotCc: Krinkle, aaron, gerritbot,
ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)).
TASK DETAILhttps://phabricator.wikimedia.org/T173696EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ReleaseTaggerBotCc: Krinkle, aaron, gerritbot, Ladsgroup,
Lucas_Werkmeister_WMDE added a comment.
Good point, let’s discuss this in T176312: Don’t check format constraint via SPARQL.TASK DETAILhttps://phabricator.wikimedia.org/T173696EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Krinkle,
Lucas_Werkmeister_WMDE added a comment.
@Krinkle thanks for your comments!
And this uses the same Sparql endpoint at https://query.wikidata.org/ as for public queries?
Yup.
but I didn't know it was used e.g. when saving edits (assuming validation happens there).
No, constraint checks are
Krinkle added a comment.
In T173696#3584607, @Krinkle wrote:
[..] why do we need to query an external service to execute a regular _expression_?
In T173696#3584821, @Lucas_Werkmeister_WMDE wrote:
Because checking arbitrary regexes on arbitrary input opens us up to DoS attacks via malicious
Lucas_Werkmeister_WMDE added a comment.
Because checking arbitrary regexes on arbitrary input opens us up to DoS attacks via malicious regexes (e. g. catastrophic backtracking – runtime of checking (x+x+)+y on xxx..xxx is quadratic in input length). This came up during the security review of the
Lucas_Werkmeister_WMDE added a comment.
So change Iaaac950b48 implements caching on the most granular level we have, for the “format constraint” check: does arbitrary text match arbitrary regex? This is very common constraint type – practically all “external identifier” properties have one or more
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T173696EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Ladsgroup, daniel, Aklapper, Jonas, Lucas_Werkmeister_WMDE, Lordiis, GoranSMilovanovic,
Jonas added a project: Wikidata-Sprint.
TASK DETAILhttps://phabricator.wikimedia.org/T173696EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: Ladsgroup, Anomie, daniel, Aklapper, Jonas, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, Agabi10, Izno,
Lucas_Werkmeister_WMDE edited parent tasks, added: T103228: Improve performance of constraint check; removed: T173695: Enable constraint checks by default for users.
TASK DETAILhttps://phabricator.wikimedia.org/T173696EMAIL
11 matches
Mail list logo
