[Wikidata-bugs] [Maniphest] [Updated] T177453: Add wikibase client support for searching wikidata items
Smalyshev removed a project: User-Smalyshev. TASK DETAILhttps://phabricator.wikimedia.org/T177453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: WMDE-leszek, Lucie, dcausse, hoo, Addshore, daniel, Aklapper, Smalyshev, Nandana, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, cmadeo, LawExplorer, Avner, Gehel, FloNight, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T177453: Add wikibase client support for searching wikidata items
Smalyshev edited projects, added Discovery-Search; removed Discovery-Search (Current work). TASK DETAILhttps://phabricator.wikimedia.org/T177453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: WMDE-leszek, Lucie, dcausse, hoo, Addshore, daniel, Aklapper, Smalyshev, Nandana, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, cmadeo, LawExplorer, Avner, Gehel, FloNight, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T177453: Add wikibase client support for searching wikidata items
Smalyshev added a comment. OK, so #1 is basically T194143: Make PropertyLabelResolver that uses ElasticSearch. So I think it should be discussed here. Which leaves us with #2, which is implementing TermSearchInteractor that can do ElasticSearch. For this, we need to identify the use cases for it. I'll look for them and update the task description accordingly.TASK DETAILhttps://phabricator.wikimedia.org/T177453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Lucie, dcausse, hoo, Addshore, daniel, Aklapper, Smalyshev, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, cmadeo, LawExplorer, Avner, Gehel, FloNight, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T177453: Add wikibase client support for searching wikidata items
Smalyshev added a comment. Does it mean that we would make WikbaseClient dependent on CirrusSearch Well, ideally after T190022: Separate the CirrusSearch/Elastic-specific code from Wikibase code base it all will be in WikibaseCirrusSearch extension I presume. and create all necessary query builders into this client? Yes, that's the idea. Have we considered the possibility to run an actual API call to wbsearchentit...@wikidata.org I thought about it but it looks rather serious performance hit (going back through all caching infrastructure, getting all the request init overhead again and then parsing the results). And I understand the main motivation here is performance. If we have page with Lua that requests 20 lookups, having 20 sub-requests may be a bit too much. It also feels a bit wrong to go whole roundtrip when we have most classes and configs sitting right here. I have no clue if the current API output would allow to rebuild TermSearchResult Probably but I am not convinced we should do it. I am right now leaning to the side of we shouldn't.TASK DETAILhttps://phabricator.wikimedia.org/T177453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: dcausse, hoo, Addshore, daniel, Aklapper, Smalyshev, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, cmadeo, LawExplorer, Avner, Gehel, FloNight, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T177453: Add wikibase client support for searching wikidata items
Smalyshev added a project: User-Smalyshev. TASK DETAILhttps://phabricator.wikimedia.org/T177453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: dcausse, hoo, Addshore, daniel, Aklapper, Smalyshev, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, cmadeo, LawExplorer, Avner, Gehel, FloNight, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T177453: Add wikibase client support for searching wikidata items
Smalyshev removed a project: User-Smalyshev. TASK DETAILhttps://phabricator.wikimedia.org/T177453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: hoo, Addshore, daniel, Aklapper, Smalyshev, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, cmadeo, LawExplorer, Avner, Gehel, FloNight, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T177453: Add wikibase client support for searching wikidata items
Smalyshev added a project: User-Smalyshev. TASK DETAILhttps://phabricator.wikimedia.org/T177453EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: hoo, Addshore, daniel, Aklapper, Smalyshev, GoranSMilovanovic, QZanden, EBjune, cmadeo, Avner, debt, Gehel, FloNight, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Mbch331, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
