[Wikidata-bugs] [Maniphest] [Updated] T191537: MediaWiki core's selenium tests flaky when run as part of mwext-mw-selenium-node-composer-jessie job

2018-07-18 Thread gerritbot 
gerritbot added a comment.
Change 445222 abandoned by Hashar:
In development, run all jobs on each requests

Reason:
That was a dirty / quick win patch to test out the failures we had on PageTriage / recentchange job not running.

I definitely love the suggestion Timo made to have the test suite run the job / ensure all jobs get run ( T199446#4429139 ).

So I am abandoning this change in favor of https://gerrit.wikimedia.org/r/#/c/mediawiki/core/ /446543/ "selenium: invoke jobs to enforce eventual consistency"

https://gerrit.wikimedia.org/r/445222TASK DETAILhttps://phabricator.wikimedia.org/T191537EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Anomie, gerritbotCc: gerritbot, Anomie, hashar, Jakob_WMDE, Addshore, Pablo-WMDE, WMDE-leszek, Aklapper, zeljkofilipin, Mringgaard, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Maosef, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, Liudvikas, Izno, Luke081515, thcipriani, Wikidata-bugs, aude, fredw, Physikerwelt, Pkra, Darkdadaah, scfc, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T191537: MediaWiki core's selenium tests flaky when run as part of mwext-mw-selenium-node-composer-jessie job

2018-06-13 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).
TASK DETAILhttps://phabricator.wikimedia.org/T191537EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipin, ReleaseTaggerBotCc: gerritbot, Anomie, hashar, Jakob_WMDE, Addshore, Pablo-WMDE, WMDE-leszek, Aklapper, zeljkofilipin, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Maosef, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, Liudvikas, Luke081515, thcipriani, Wikidata-bugs, aude, fredw, Physikerwelt, Pkra, Darkdadaah, scfc, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T191537: MediaWiki core's selenium tests flaky when run as part of mwext-mw-selenium-node-composer-jessie job

2018-06-13 Thread hashar 
hashar added a parent task: T189762: selenium test for Wikibase is unstable.
TASK DETAILhttps://phabricator.wikimedia.org/T191537EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipin, hasharCc: gerritbot, Anomie, hashar, Jakob_WMDE, Addshore, Pablo-WMDE, WMDE-leszek, Aklapper, zeljkofilipin, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Maosef, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, Liudvikas, Luke081515, thcipriani, Wikidata-bugs, aude, fredw, Physikerwelt, Pkra, Darkdadaah, scfc, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T191537: MediaWiki core's selenium tests flaky when run as part of mwext-mw-selenium-node-composer-jessie job

2018-06-07 Thread Anomie 
Anomie added a comment.

In T191537#4263460, @hashar wrote:
And it is then marked as dirty (whatever it means):


The code tries to only save when something actually changed, instead of saving every time the session goes out of scope. "Marked as dirty" happens when something changed.

I also noticed a backtrace when invoking session_start:

[DBPerformance] Expectation (writes <= 0) by MediaWiki::main not met (actual: 5):
query-m: REPLACE INTO `objectcache` (keyname,value,exptime) VALUES ('X')
#0 includes/libs/rdbms/TransactionProfiler.php(219): Wikimedia\Rdbms\TransactionProfiler->reportExpectationViolated('writes', 'query-m: REPLAC...', 4)
#1 includes/libs/rdbms/database/Database.php(1252): Wikimedia\Rdbms\TransactionProfiler->recordQueryCompletion('query-m: REPLAC...', 1527172580.0906, true, 1)
#2 includes/libs/rdbms/database/Database.php(1147): Wikimedia\Rdbms\Database->doProfiledQuery('REPLACE INTO `o...', 'REPLACE /* SqlB...', true, 'SqlBagOStuff::s...')
#3 includes/libs/rdbms/database/Database.php(2795): Wikimedia\Rdbms\Database->query('REPLACE INTO `o...', 'SqlBagOStuff::s...')
#4 includes/libs/rdbms/database/DatabaseMysqlBase.php(522): Wikimedia\Rdbms\Database->nativeReplace('`objectcache`', Array, 'SqlBagOStuff::s...')
#5 includes/objectcache/SqlBagOStuff.php(361): Wikimedia\Rdbms\DatabaseMysqlBase->replace('objectcache', Array, Array, 'SqlBagOStuff::s...')

That's T154424: TransactionProfiler should not apply to SqlBagOStuff.


In T191537#4263920, @hashar wrote:
I have tried locally with ./node_modules/.bin/wdio  --mochaOpts.grep 'should be re-creatable' but I could not reproduce the issue. That seems to be related to the session management.


From T191537#4143301, it seems to me that the issue may involve a job run post-send (due to $wgJobRunRate) during the login request trying to load the wrong session for some unknown reason and stomping on the cookies. If the "wrong" job doesn't run during that particular request the problem wouldn't be reproduced.TASK DETAILhttps://phabricator.wikimedia.org/T191537EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipin, AnomieCc: gerritbot, Anomie, hashar, Jakob_WMDE, Addshore, Pablo-WMDE, WMDE-leszek, Aklapper, zeljkofilipin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Maosef, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, Liudvikas, Luke081515, thcipriani, Wikidata-bugs, aude, fredw, Physikerwelt, Pkra, Darkdadaah, scfc, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T191537: MediaWiki core's selenium tests flaky when run as part of mwext-mw-selenium-node-composer-jessie job

2018-06-07 Thread hashar 
hashar added a comment.
I have completed fixes for Quibble to let it run Wikibase tests ( T196013 ).  The test job ended up failing with the exact same issue: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php70-docker/5410/

Dummy change: https://gerrit.wikimedia.org/r/#/c/70395/

So I guess I can try reproducing the Quibble environment locally (with all ext dependencies added), then run repeatedly the should be restorable wdio test and see what happens.TASK DETAILhttps://phabricator.wikimedia.org/T191537EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipin, hasharCc: gerritbot, Anomie, hashar, Jakob_WMDE, Addshore, Pablo-WMDE, WMDE-leszek, Aklapper, zeljkofilipin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Maosef, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, Liudvikas, Luke081515, thcipriani, Wikidata-bugs, aude, fredw, Physikerwelt, Pkra, Darkdadaah, scfc, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T191537: MediaWiki core's selenium tests flaky when run as part of mwext-mw-selenium-node-composer-jessie job

2018-06-07 Thread hashar 
hashar added a parent task: T196013: Get Wikibase + dependencies to run with Quibble.
TASK DETAILhttps://phabricator.wikimedia.org/T191537EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipin, hasharCc: gerritbot, Anomie, hashar, Jakob_WMDE, Addshore, Pablo-WMDE, WMDE-leszek, Aklapper, zeljkofilipin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Maosef, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, Liudvikas, Luke081515, thcipriani, Wikidata-bugs, aude, fredw, Physikerwelt, Pkra, Darkdadaah, scfc, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T191537: MediaWiki core's selenium tests flaky when run as part of mwext-mw-selenium-node-composer-jessie job

2018-05-24 Thread zeljkofilipin 
zeljkofilipin added a parent task: T195496: mediawiki-core-qunit-selenium-jessie sometimes fails for extensions.
TASK DETAILhttps://phabricator.wikimedia.org/T191537EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: gerritbot, Anomie, hashar, Jakob_WMDE, Addshore, Pablo-WMDE, WMDE-leszek, Aklapper, zeljkofilipin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Maosef, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, Liudvikas, Luke081515, thcipriani, Wikidata-bugs, Prod, aude, fredw, Physikerwelt, Pkra, Darkdadaah, scfc, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T191537: MediaWiki core's selenium tests flaky when run as part of mwext-mw-selenium-node-composer-jessie job

2018-05-19 Thread gerritbot 
gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T191537EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipin, gerritbotCc: gerritbot, Anomie, hashar, Jakob_WMDE, Addshore, Pablo-WMDE, WMDE-leszek, Aklapper, zeljkofilipin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Liudvikas, Luke081515, thcipriani, Wikidata-bugs, aude, Darkdadaah, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs