[Wikidata-bugs] [Maniphest] [Updated] T198468: Integration of Lexeme page with 'popups' extension

2018-07-02 Thread Jdlrobson 
Jdlrobson added a comment.
@Pablo-WMDE hey, I see what you mean. Since the link element has an href it tries to parse it even though it points to the same page. 
I've opened up T198652 to fix that generic case. Thanks for pointing that out.

Regardless, I'd definitely recommend avoiding href's altogether in this situation. href="" is kinda redundant these days unless you actually want to clear the hash fragment in the address bar.TASK DETAILhttps://phabricator.wikimedia.org/T198468EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: WMDE-leszek, Jdlrobson, Jakob_WMDE, Lydia_Pintscher, Pablo-WMDE, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Ricordisamoa, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198468: Integration of Lexeme page with 'popups' extension

2018-06-29 Thread Jdlrobson 
Jdlrobson added a comment.
Popups is currently not compatible with Wikidata. We disabled it in production, but I suspect forgot to turn it off in labs. :/

I'm actually going to be doing some work on T111231 and T167787 today, following up from some work in the hackathon, as I think it would be pretty straightforward to get Popups and Wikidata working together.

We should either disable it on beta cluster in the mean time, or if it's not too much hassle, retain it as a reminder to fix this.TASK DETAILhttps://phabricator.wikimedia.org/T198468EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JdlrobsonCc: Jdlrobson, Jakob_WMDE, Lydia_Pintscher, Pablo-WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Ricordisamoa, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198468: Integration of Lexeme page with 'popups' extension

2018-06-29 Thread Pablo-WMDE 
Pablo-WMDE added a project: Page-Previews.Pablo-WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONThe [[ https://www.mediawiki.org/wiki/Extension:Popups | popups extension ]] is  [[ https://wikidata.beta.wmflabs.org/wiki/Special:Version | activated on beta ("Page previews") ]]. On the [[ https://wikidata.beta.wmflabs.org/wiki/Lexeme:L42 | lexeme page ]] it tries to preview links to the very same lexeme page on _javascript_-based edit links of this page, e.g. "add statement", "add form", "add sense".
Happens on [[ https://wikidata.beta.wmflabs.org/wiki/Q478607 | items ]], too (e.g. "add statement").

{F23071924}...TASK DETAILhttps://phabricator.wikimedia.org/T198468EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDECc: Jakob_WMDE, Lydia_Pintscher, Pablo-WMDE, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Ricordisamoa, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs