[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-10-22 Thread WMDE-leszek
WMDE-leszek closed this task as "Resolved". WMDE-leszek moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T198455 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-10-21 Thread ReleaseTaggerBot
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.16; 2020-11-03); removed MW-1.36-notes (1.36.0-wmf.13; 2020-10-12). TASK DETAIL https://phabricator.wikimedia.org/T198455 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE,

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-10-21 Thread gerritbot
gerritbot added a comment. Change 632487 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Revert "Reinstate template script injections" https://gerrit.wikimedia.org/r/632487 TASK DETAIL https://phabricator.wikimedia.org/T198455 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-10-07 Thread WMDE-leszek
WMDE-leszek added a comment. This is complete apart from the final removal of template HTML (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/632487/) which is to happen once Wikidata has got `1.36.0-wmf.13` branch code, TASK DETAIL

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-10-07 Thread WMDE-leszek
WMDE-leszek set Due Date to Fri, Oct 23, 12:00 AM. TASK DETAIL https://phabricator.wikimedia.org/T198455 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE, WMDE-leszek Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, noarave, Tarrow, Jakob_WMDE,

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-10-06 Thread gerritbot
gerritbot added a comment. Change 632486 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Reinstate template script injections https://gerrit.wikimedia.org/r/632486 TASK DETAIL https://phabricator.wikimedia.org/T198455 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-10-06 Thread gerritbot
gerritbot added a comment. Change 632487 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] Revert "Reinstate template script injections" https://gerrit.wikimedia.org/r/632487 TASK DETAIL

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-10-06 Thread gerritbot
gerritbot added a comment. Change 632486 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] Reinstate template script injections https://gerrit.wikimedia.org/r/632486 TASK DETAIL

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-10-06 Thread ReleaseTaggerBot
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.13; 2020-10-12); removed MW-1.36-notes (1.36.0-wmf.12; 2020-10-05). TASK DETAIL https://phabricator.wikimedia.org/T198455 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE,

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-10-06 Thread gerritbot
gerritbot added a comment. Change 631771 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Replace script injections with ResourceLoader template loading https://gerrit.wikimedia.org/r/631771 TASK DETAIL https://phabricator.wikimedia.org/T198455 EMAIL

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-10-02 Thread gerritbot
gerritbot added a comment. Change 631771 had a related patch set uploaded (by Noa wmde; owner: Noa wmde): [mediawiki/extensions/WikibaseLexeme@master] Replace script injections with ResourceLoader template loading https://gerrit.wikimedia.org/r/631771 TASK DETAIL

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-10-02 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T198455 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE, gerritbot Cc: Lucas_Werkmeister_WMDE, noarave, Tarrow, Jakob_WMDE, Pablo-WMDE,

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-10-02 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T198455 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE, Maintenance_bot Cc: Lucas_Werkmeister_WMDE, noarave, Tarrow, Jakob_WMDE,

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-10-02 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.12; 2020-10-05). TASK DETAIL https://phabricator.wikimedia.org/T198455 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE, ReleaseTaggerBot Cc: Lucas_Werkmeister_WMDE, noarave,

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-10-02 Thread gerritbot
gerritbot added a comment. Change 631445 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Register extracted vue template as resourceloader template for Qunit tests https://gerrit.wikimedia.org/r/631445 TASK DETAIL https://phabricator.wikimedia.org/T198455

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-10-02 Thread gerritbot
gerritbot added a comment. Change 630901 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Remove duplicated templates from test files https://gerrit.wikimedia.org/r/630901 TASK DETAIL https://phabricator.wikimedia.org/T198455 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-10-02 Thread gerritbot
gerritbot added a comment. Change 630639 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Deduplicate vue templates between php implementation and js tests https://gerrit.wikimedia.org/r/630639 TASK DETAIL https://phabricator.wikimedia.org/T198455 EMAIL

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-10-01 Thread gerritbot
gerritbot added a comment. Change 631445 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] [WIP]Register extracted vue templates as resourceloader templates https://gerrit.wikimedia.org/r/631445

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-10-01 Thread gerritbot
gerritbot added a comment. Change 630901 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Tobias Andersson): [mediawiki/extensions/WikibaseLexeme@master] Remove duplicated templates from test files https://gerrit.wikimedia.org/r/630901 TASK DETAIL

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-10-01 Thread Rosalie_WMDE
Rosalie_WMDE added a comment. while working on this we realised that almost all Qunit test do not run in WikibaseLexeme. See more detail in the task T264207 TASK DETAIL https://phabricator.wikimedia.org/T198455 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-09-28 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T198455 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE, gerritbot Cc: Lucas_Werkmeister_WMDE, noarave, Tarrow, Jakob_WMDE, Pablo-WMDE,

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-09-28 Thread gerritbot
gerritbot added a comment. Change 630639 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] [WIP] Move LexemeView Templates to individual files. https://gerrit.wikimedia.org/r/630639 TASK DETAIL

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-09-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. If I understand correctly, the templates are currently loaded by injecting them into the parser-cached HTML: name=LexemeView.php private function getLemmaVueTemplate() { return <<

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-09-25 Thread noarave
noarave added a comment. After looking into this for a bit and considering @Jakob_WMDE 's comment I believe this boils down to two questions: 1. Which templates are required in order for both JS and PHP unit tests to pass? I have collected the following non-exhaustive list of

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-09-23 Thread Rosalie_WMDE
Rosalie_WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T198455 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE Cc: Tarrow, Jakob_WMDE, Pablo-WMDE, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, DannyS712, Nandana,

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-09-22 Thread WMDE-leszek
WMDE-leszek edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T198455 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: WMDE-leszek Cc: Tarrow,

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-09-15 Thread Addshore
Addshore updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T198455 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Tarrow, Jakob_WMDE, Pablo-WMDE, Akuckartz, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] T198455: Unify WikibaseLexeme vue templates

2020-09-14 Thread Tarrow
Tarrow renamed this task from "Unify vue templates" to "Unify WikibaseLexeme vue templates". TASK DETAIL https://phabricator.wikimedia.org/T198455 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Tarrow, Jakob_WMDE, Pablo-WMDE, Akuckartz,