Addshore closed this task as "Resolved".
TASK DETAIL
https://phabricator.wikimedia.org/T199896
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jakob_WMDE, Addshore
Cc: Jakob_WMDE, Mahir256, amy_rc, Lea_Lacroix_WMDE, Scott_WUaS, robertvazan,
Tpt, Lydi
Maintenance_bot removed a project: Patch-For-Review.
TASK DETAIL
https://phabricator.wikimedia.org/T199896
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jakob_WMDE, Maintenance_bot
Cc: Jakob_WMDE, Mahir256, amy_rc, Lea_Lacroix_WMDE, Scott_WUaS, robe
gerritbot added a comment.
Change 679723 **merged** by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Ensure Sense ChangeOps are
applied after it's added to the Lexeme
https://gerrit.wikimedia.org/r/679723
TASK DETAIL
https://phabricator.wikimedia.org/T199896
EMAIL PRE
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.2; 2021-04-20).
TASK DETAIL
https://phabricator.wikimedia.org/T199896
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jakob_WMDE, ReleaseTaggerBot
Cc: Jakob_WMDE, Mahir256, amy_rc, Lea_Lacroi
gerritbot added a comment.
Change 678582 **merged** by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] wbeditentity: support adding
senses with statements
https://gerrit.wikimedia.org/r/678582
TASK DETAIL
https://phabricator.wikimedia.org/T199896
EMAIL PREFERENCES
htt
gerritbot added a comment.
Change 679723 had a related patch set uploaded (by Jakob; author: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Ensure Sense ChangeOps are
applied after it's added to the Lexeme
https://gerrit.wikimedia.org/r/679723
TASK DETAIL
https://phabricator
gerritbot added a project: Patch-For-Review.
TASK DETAIL
https://phabricator.wikimedia.org/T199896
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jakob_WMDE, gerritbot
Cc: Jakob_WMDE, Mahir256, amy_rc, Lea_Lacroix_WMDE, Scott_WUaS, robertvazan,
Tpt,
gerritbot added a comment.
Change 678582 had a related patch set uploaded (by Jakob; author: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] wbeditentity: support adding
senses with statements
https://gerrit.wikimedia.org/r/678582
TASK DETAIL
https://phabricator.wikimedia.org
Jakob_WMDE added a comment.
Ok, the comments here confused me a bit. It turns out editing statements on
*existing* Senses actually works for both Sense IDs and Lexeme IDs.
Adding a sense statement given a Lexeme ID:
https://wikidata.beta.wmflabs.org/wiki/Special:ApiSandbox#action=wbedite
Jakob_WMDE claimed this task.
Jakob_WMDE moved this task from To Do (prioritised from top to bottom) to Doing
on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
TASK DETAIL
https://phabricator.wikimedia.org/T199896
WORKBOARD
https://phabricator.wikimedia.org/project/board/3539/
robertvazan added a comment.
I just tested editing sense statements using patched Wikidata Toolkit. All
parts of the lexeme are now editable via wbeditentity. Senses can be edited
either as part of the lexeme or on their own. I have not tested more complex
edit operations like the one @Mahir
Addshore removed Jakob_WMDE as the assignee of this task.
Addshore added a subscriber: Jakob_WMDE.
TASK DETAIL
https://phabricator.wikimedia.org/T199896
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Addshore
Cc: Jakob_WMDE, Mahir256, amy_rc, Lea_Lac
Lydia_Pintscher added a comment.
I would say we should support the case Mahir is talking about where you
provide the whole Lexeme content including Senses and statements on Senses. If
we support this for Forms and other entity types I don't think it makes sense
to not support this for Senses
Addshore added a comment.
@Lydia_Pintscher @amy_rc the ACs / BDD is perhaps slightly unclear here. Is
it expected that this should only work the ID being editied via `wbeditentity`
is a sense ID? or also if it is a lexeme ID?
TASK DETAIL
https://phabricator.wikimedia.org/T199896
EMAIL PRE
Mahir256 added a comment.
I would like to assemble a JSON string with which to generate a lexeme using
a single wbeditentity call.
JSON strings of the following form did work prior to this change (with no
statements on forms or senses):
{"lexicalCategory": "Q34698", "language": "Q
amy_rc added a comment.
@Addshore Can you test and resolve this ticket ?
TASK DETAIL
https://phabricator.wikimedia.org/T199896
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jakob_WMDE, amy_rc
Cc: amy_rc, Lea_Lacroix_WMDE, Scott_WUaS, robertvazan
Maintenance_bot removed a project: Patch-For-Review.
TASK DETAIL
https://phabricator.wikimedia.org/T199896
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jakob_WMDE, Maintenance_bot
Cc: Lea_Lacroix_WMDE, Scott_WUaS, robertvazan, Tpt, Lydia_Pintscher,
gerritbot added a comment.
Change 668710 **merged** by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Support editing statements on
senses via wbeditentity
https://gerrit.wikimedia.org/r/668710
TASK DETAIL
https://phabricator.wikimedia.org/T199896
EMAIL PREFERENCES
http
gerritbot added a comment.
Change 668709 **merged** by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] wbeditentity: add test for
adding a Form statement
https://gerrit.wikimedia.org/r/668709
TASK DETAIL
https://phabricator.wikimedia.org/T199896
EMAIL PREFERENCES
https:/
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).
TASK DETAIL
https://phabricator.wikimedia.org/T199896
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jakob_WMDE, ReleaseTaggerBot
Cc: Lea_Lacroix_WMDE, Scott_WUaS, robertvaz
gerritbot added a comment.
Change 670218 **merged** by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master]
EditFormChangeOpDeserializerTest: refactor for readability
https://gerrit.wikimedia.org/r/670218
TASK DETAIL
https://phabricator.wikimedia.org/T199896
EMAIL PREFERENCES
gerritbot added a comment.
Change 670218 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master]
EditFormChangeOpDeserializerTest: refactor for readability
https://gerrit.wikimedia.org/r/670218
TASK DETAIL
https://phabricator.wikimedia.
gerritbot added a project: Patch-For-Review.
TASK DETAIL
https://phabricator.wikimedia.org/T199896
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Jakob_WMDE, gerritbot
Cc: Lea_Lacroix_WMDE, Scott_WUaS, robertvazan, Tpt, Lydia_Pintscher,
WMDE-leszek,
gerritbot added a comment.
Change 668710 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Support editing statements on
senses via wbeditentity
https://gerrit.wikimedia.org/r/668710
TASK DETAIL
https://phabricator.wikimedia.org/T
gerritbot added a comment.
Change 668709 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] wbeditentity: add test for
adding a Form statement
https://gerrit.wikimedia.org/r/668709
TASK DETAIL
https://phabricator.wikimedia.org/T199
Jakob_WMDE claimed this task.
Jakob_WMDE moved this task from To Do (prioritised from top to bottom) to Doing
on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
TASK DETAIL
https://phabricator.wikimedia.org/T199896
WORKBOARD
https://phabricator.wikimedia.org/project/board/3539/
robertvazan added a comment.
@Lea_Lacroix_WMDE I have recently (a few weeks ago) tested all possible
lexeme edit operations. The only thing that does not work is editing statements
on senses. Senses themselves can be created, but any sense statements in the
edit request are ignored.
TASK DE
Lea_Lacroix_WMDE added a comment.
Question: is the problem occurring only on Senses, or also on Forms?
TASK DETAIL
https://phabricator.wikimedia.org/T199896
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lea_Lacroix_WMDE
Cc: Lea_Lacroix_WMDE, Sco
darthmon_wmde moved this task from Prioritized Product (prioritised from top to
bottom) to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board.
darthmon_wmde edited projects, added Wikidata-Campsite
(Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.
TASK DETAIL
https://phabri
darthmon_wmde set the point value for this task to "8".
TASK DETAIL
https://phabricator.wikimedia.org/T199896
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: darthmon_wmde
Cc: Lea_Lacroix_WMDE, Scott_WUaS, robertvazan, Tpt, Lydia_Pintscher,
WMDE-lesz
Lucas_Werkmeister_WMDE updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T199896
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE
Cc: Lea_Lacroix_WMDE, Scott_WUaS, robertvazan, Tpt, Lydia_Pintscher,
WMD
noarave updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T199896
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: noarave
Cc: Lea_Lacroix_WMDE, Scott_WUaS, robertvazan, Tpt, Lydia_Pintscher,
WMDE-leszek, Addshore, Lucas_Werk
Lydia_Pintscher updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T199896
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lydia_Pintscher
Cc: Lea_Lacroix_WMDE, Scott_WUaS, robertvazan, Tpt, Lydia_Pintscher,
WMDE-leszek, Adds
Lydia_Pintscher added a project: Wikidata-Campsite.
Lydia_Pintscher added a comment.
bumping because of it being needed for
https://github.com/Wikidata/Wikidata-Toolkit/issues/437
TASK DETAIL
https://phabricator.wikimedia.org/T199896
EMAIL PREFERENCES
https://phabricator.wikimedia.org/se
Lydia_Pintscher raised the priority of this task from "Medium" to "High".
Lydia_Pintscher added a comment.
True. Changing to high.
TASK DETAIL
https://phabricator.wikimedia.org/T199896
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lydia_Pintsche
robertvazan added a comment.
Shouldn't this be a higher priority? It's a blocker for Wiktionary imports
and assisted editing, two big sources of growth.
TASK DETAIL
https://phabricator.wikimedia.org/T199896
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferenc
36 matches
Mail list logo