[Wikidata-bugs] [Maniphest] T257447: Don’t load Repo settings in PHP entry point

[Ladsgroup]

Ladsgroup moved this task from Verification to Done on the Wikibase Extension 
Decoupling and Registration (Sprint 4) board.
Ladsgroup closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T257447

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4916/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, Tarrow, Aklapper, Lucas_Werkmeister_WMDE, Hazizibinmahdi, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T257447: Don’t load Repo settings in PHP entry point

[darthmon_wmde]

darthmon_wmde edited projects, added Wikibase Extension Decoupling and 
Registration (Sprint 4); removed Wikibase Extension Decoupling and Registration 
(Sprint 3).

TASK DETAIL
  https://phabricator.wikimedia.org/T257447

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, darthmon_wmde
Cc: Ladsgroup, Tarrow, Aklapper, Lucas_Werkmeister_WMDE, Hazizibinmahdi, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T257447: Don’t load Repo settings in PHP entry point

[Maintenance_bot]

Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T257447

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Maintenance_bot
Cc: Ladsgroup, Tarrow, Aklapper, Lucas_Werkmeister_WMDE, Hazizibinmahdi, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, 
joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, 
Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T257447: Don’t load Repo settings in PHP entry point

[gerritbot]

gerritbot added a comment.


  Change 615574 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Don’t load Repo settings in PHP entry 
point
  
  https://gerrit.wikimedia.org/r/615574

TASK DETAIL
  https://phabricator.wikimedia.org/T257447

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Ladsgroup, Tarrow, Aklapper, Lucas_Werkmeister_WMDE, Alter-paule, 
Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T257447: Don’t load Repo settings in PHP entry point

[ReleaseTaggerBot]

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.2; 2020-07-28).

TASK DETAIL
  https://phabricator.wikimedia.org/T257447

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, ReleaseTaggerBot
Cc: Ladsgroup, Tarrow, Aklapper, Lucas_Werkmeister_WMDE, Alter-paule, 
Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T257447: Don’t load Repo settings in PHP entry point

[gerritbot]

gerritbot added a comment.


  Change 615579 **merged** by jenkins-bot:
  [mediawiki/extensions/WikibaseMediaInfo@master] Avoid using $wgWBRepoSettings 
directly
  
  https://gerrit.wikimedia.org/r/615579

TASK DETAIL
  https://phabricator.wikimedia.org/T257447

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Ladsgroup, Tarrow, Aklapper, Lucas_Werkmeister_WMDE, Alter-paule, 
Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T257447: Don’t load Repo settings in PHP entry point

[gerritbot]

gerritbot added a comment.


  Change 615579 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [mediawiki/extensions/WikibaseMediaInfo@master] Avoid using $wgWBRepoSettings 
directly
  
  https://gerrit.wikimedia.org/r/615579

TASK DETAIL
  https://phabricator.wikimedia.org/T257447

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Ladsgroup, Tarrow, Aklapper, Lucas_Werkmeister_WMDE, Alter-paule, 
Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T257447: Don’t load Repo settings in PHP entry point

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T257447

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Ladsgroup, Tarrow, Aklapper, Lucas_Werkmeister_WMDE, Alter-paule, 
Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T257447: Don’t load Repo settings in PHP entry point

[gerritbot]

gerritbot added a comment.


  Change 615574 had a related patch set uploaded (by Ladsgroup; owner: 
Ladsgroup):
  [mediawiki/extensions/Wikibase@master] Don’t load Repo settings in PHP entry 
point
  
  https://gerrit.wikimedia.org/r/615574

TASK DETAIL
  https://phabricator.wikimedia.org/T257447

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Ladsgroup, Tarrow, Aklapper, Lucas_Werkmeister_WMDE, Hazizibinmahdi, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T257447: Don’t load Repo settings in PHP entry point

[Ladsgroup]

Ladsgroup claimed this task.
Ladsgroup moved this task from Backlog to Doing on the Wikibase Extension 
Decoupling and Registration (Sprint 3) board.
Ladsgroup added a comment.
Restricted Application added a project: User-Ladsgroup.


  I try to see what I can do about this.

TASK DETAIL
  https://phabricator.wikimedia.org/T257447

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4875/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, Tarrow, Aklapper, Lucas_Werkmeister_WMDE, Hazizibinmahdi, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T257447: Don’t load Repo settings in PHP entry point

[Ladsgroup]

Ladsgroup added a comment.


  In T257447#6312364 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > I looked a bit into the Repo settings to see how this could be done. One 
thing that surprised me is that Repo barely uses the “config values can be 
callbacks to compute the real value on-demand” feature, which is used much more 
in Client – in Repo, the only three callbacks are:
  
  I think it's mostly because the client is being called way more often (around 
100 times more) than repo. So performance issues in repo doesn't show itself in 
the big picture (but it doesn't mean we should ignore those TBH). Can we make 
sure using mediawiki standard config system would not decrease the performance?
  
  > This might make Repo a much more attractive candidate for porting to 
MediaWiki’s standard config system than Client.
  
  I'd be a fan of changing to that but I feel it would be lots of changes. 
Maybe we can turn RepoSettings to a facade of the actual config? There are some 
issues like that the standard config doesn't support set method (which I think 
is good thing) but changing/fixing it might be quite fun (or hacky)

TASK DETAIL
  https://phabricator.wikimedia.org/T257447

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, Tarrow, Aklapper, Lucas_Werkmeister_WMDE, Akuckartz, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T257447: Don’t load Repo settings in PHP entry point

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.
Restricted Application added a project: Wikidata.


  I looked a bit into the Repo settings to see how this could be done. One 
thing that surprised me is that Repo barely uses the “config values can be 
callbacks to compute the real value on-demand” feature, which is used much more 
in Client – in Repo, the only three callbacks are:
  
'dataRightsUrl' => function() {
return $GLOBALS['wgRightsUrl'];
},

'dataRightsText' => function() {
return $GLOBALS['wgRightsText'];
},

'conceptBaseUri' => function() {
$uri = preg_replace( '!^//!', 'http://', $GLOBALS['wgServer'] );
return $uri . '/entity/';
},
  
  This might make Repo a much more attractive candidate for porting to 
MediaWiki’s standard config system than Client.
  
  Besides that, if we don’t load the default config in the PHP entry point, 
we’ll have the same problem as in Client (see T256252 
 and I193008a732 
): if the value from `LocalSettings` 
(written for a Wikibase where the default config was loaded in the PHP entry 
point) and the default value are both nonempty arrays, then we won’t know if 
the two should be merged, or if the `LocalSettings` value should overwrite the 
default value completely.
  
  The default config has the following nonempty arrays:
  
  - `string-limits`: Associative array of arrays. I don’t think we even support 
unsetting any entries of this array (code like 
`WikibaseRepo::getDefaultInstance()->getSettings()->getSetting( 'string-limits' 
)['VT:monolingualtext']` doesn’t seem to account for that option), so 
`wfArrayPlus2d` should be fine.
  
  - `urlSchemes`: List of strings. Probably the biggest problem – we can’t 
distinguish between `$wgWBRepoSettings['urlSchemes'][] = 'gopher';` and 
`$wgWBRepoSettings['urlSchemes'] = [ 'gopher' ];`, and both of these seem to be 
valid things that one might want to do, at least in principle (Gopher 
 is of course a bit silly as 
an example). I think here we’ll have to bite the bullet and introduce a new way 
to remove URL schemes from the list (`$wgWBRepoSettings['mailto'] = false`? 
though then the array has mixed string and numeric keys), and then send an 
email around and tell people to update their configs accordingly.
  
  - `entityDataFormats`. List of strings. I believe the default value is the 
full list of possible entity data formats, so the only useful change to this 
list is to remove entries from it – so the custom value should probably 
overwrite the default value, without merging.
  
  - `canonicalLanguageCodes`: Associative array of strings. I think it would be 
pointless for anyone to remove entries from this, so we can probably use a 
standard `array_merge`. But if we want to support removing canonical language 
codes, we can update our code to treat `false` values like absent keys, and 
then tell people to change `LocalSettings` code like `unset( 
$wgWBRepoSettings['canonicalLanguageCodes']['simple'] );` to something like 
`$wgWBRepoSettings['canonicalLanguageCodes']['simple'] = false;`.
  
  - `globeUris`: Associative array of strings. Behaves like 
`canonicalLanguageCodes`, I’d say.
  
  - `pagePropertiesRdf`: Associative array of arrays. I’m not sure why anyone 
would configure this, to be honest. `wfArrayPlus2d`, I guess, and likewise use 
`false` to support removing a page property?

TASK DETAIL
  https://phabricator.wikimedia.org/T257447

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Tarrow, Aklapper, Lucas_Werkmeister_WMDE, Akuckartz, darthmon_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs