[Wikidata-bugs] [Maniphest] T257449: Remove WB_NO_CONFIGURE_EXAMPLE_REPO constant / hack

2020-07-23 Thread Ladsgroup 
Ladsgroup moved this task from Verification to Done on the Wikibase Extension 
Decoupling and Registration (Sprint 3) board.
Ladsgroup closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T257449

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4875/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Ladsgroup
Cc: Ladsgroup, Samantha_Alipio_WMDE, Tarrow, Aklapper, Lucas_Werkmeister_WMDE, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T257449: Remove WB_NO_CONFIGURE_EXAMPLE_REPO constant / hack

2020-07-21 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.2; 2020-07-28).

TASK DETAIL
  https://phabricator.wikimedia.org/T257449

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot
Cc: Ladsgroup, Samantha_Alipio_WMDE, Tarrow, Aklapper, Lucas_Werkmeister_WMDE, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T257449: Remove WB_NO_CONFIGURE_EXAMPLE_REPO constant / hack

2020-07-21 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T257449

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Maintenance_bot
Cc: Ladsgroup, Samantha_Alipio_WMDE, Tarrow, Aklapper, Lucas_Werkmeister_WMDE, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, 
joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, 
Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T257449: Remove WB_NO_CONFIGURE_EXAMPLE_REPO constant / hack

2020-07-21 Thread gerritbot 
gerritbot added a comment.


  Change 614795 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Don’t configure example repo in client 
example config
  
  https://gerrit.wikimedia.org/r/614795

TASK DETAIL
  https://phabricator.wikimedia.org/T257449

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Ladsgroup, Samantha_Alipio_WMDE, Tarrow, Aklapper, Lucas_Werkmeister_WMDE, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T257449: Remove WB_NO_CONFIGURE_EXAMPLE_REPO constant / hack

2020-07-20 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the 
Wikibase Extension Decoupling and Registration (Sprint 3) board.
Lucas_Werkmeister_WMDE added a comment.


  Announcement sent 
 
(not so brief after all, I guess).

TASK DETAIL
  https://phabricator.wikimedia.org/T257449

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4875/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Ladsgroup, Samantha_Alipio_WMDE, Tarrow, Aklapper, Lucas_Werkmeister_WMDE, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T257449: Remove WB_NO_CONFIGURE_EXAMPLE_REPO constant / hack

2020-07-20 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T257449

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Ladsgroup, Samantha_Alipio_WMDE, Tarrow, Aklapper, Lucas_Werkmeister_WMDE, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T257449: Remove WB_NO_CONFIGURE_EXAMPLE_REPO constant / hack

2020-07-20 Thread gerritbot 
gerritbot added a comment.


  Change 614795 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
owner: Lucas Werkmeister (WMDE)):
  [mediawiki/extensions/Wikibase@master] Don’t configure example repo in client 
example config
  
  https://gerrit.wikimedia.org/r/614795

TASK DETAIL
  https://phabricator.wikimedia.org/T257449

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Ladsgroup, Samantha_Alipio_WMDE, Tarrow, Aklapper, Lucas_Werkmeister_WMDE, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T257449: Remove WB_NO_CONFIGURE_EXAMPLE_REPO constant / hack

2020-07-20 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE moved this task from Backlog to Doing on the Wikibase 
Extension Decoupling and Registration (Sprint 3) board.
Lucas_Werkmeister_WMDE added a comment.


  Alright, then I’ll draft a brief announcement.

TASK DETAIL
  https://phabricator.wikimedia.org/T257449

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4875/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Ladsgroup, Samantha_Alipio_WMDE, Tarrow, Aklapper, Lucas_Werkmeister_WMDE, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T257449: Remove WB_NO_CONFIGURE_EXAMPLE_REPO constant / hack

2020-07-20 Thread Tarrow 
Tarrow added a comment.


  @Samantha_Alipio_WMDE said in the daily today that she's happy for us to go 
with the suggestion from @Lucas_Werkmeister_WMDE

TASK DETAIL
  https://phabricator.wikimedia.org/T257449

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tarrow
Cc: Ladsgroup, Samantha_Alipio_WMDE, Tarrow, Aklapper, Lucas_Werkmeister_WMDE, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T257449: Remove WB_NO_CONFIGURE_EXAMPLE_REPO constant / hack

2020-07-16 Thread Ladsgroup 
Ladsgroup added subscribers: Samantha_Alipio_WMDE, Ladsgroup.
Ladsgroup added a comment.


  In T257449#6294324 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > I think the best solution to this is to just remove the whole example repo 
from `WikibaseClient.example.php` – or, more likely, to wrap it in `if ( false 
)` instead of `if ( !defined( 'WB_NO_CONFIGURE_EXAMPLE_REPO' ) )`, just like 
the already existing block for a `$wgLBFactoryConf` which is also disabled with 
`if ( false )`.
  >
  > Whether this affects any end users depends on how the example files are 
typically used, I suppose. The configured example repo isn’t very useful as a 
whole: the repo URL is http://repo.example.org. But it’s possible that people 
are loading the example settings and then only overriding the repo URL while 
keeping, say, the repo article path and script path.
  >
  > But I think that should be tractable with an announcement to the 
wikidata-tech mailing list, informing users that if they have a client wiki 
that’s not also a repo, they may need to update their configuration. (I assume 
most wikibase clients are also repos – wikibase-docker, in particular, only 
supports this mode as far as I’m aware.)
  >
  > (Wikimedia production should be unaffected anyways, as we don’t use the 
example settings at all there.)
  
  Maybe a decision for @Samantha_Alipio_WMDE ?

TASK DETAIL
  https://phabricator.wikimedia.org/T257449

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, Samantha_Alipio_WMDE, Tarrow, Aklapper, Lucas_Werkmeister_WMDE, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs