[Wikidata-bugs] [Maniphest] T261942: Investigate adding and removing space when string is reported as "Malformed input", then allowing save

[Addshore]

Addshore closed this task as "Resolved".
Addshore added a comment.


  Investigation is done and parent ticket is also done and closed

TASK DETAIL
  https://phabricator.wikimedia.org/T261942

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova, Addshore
Cc: Lucas_Werkmeister_WMDE, toan, Lydia_Pintscher, Nikki, Aklapper, Addshore, 
Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T261942: Investigate adding and removing space when string is reported as "Malformed input", then allowing save

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  I think I know the answer to one question: why does this issue only affect 
the data type string, not e. g. external ID or URL? Because string is the only 
data type we parse in JavaScript.
  
  For every other data type, we parse the value in JavaScript by sending it to 
the `wbparsevalue` API and thereby calling the PHP parser. The PHP parser for 
strings is fairly simple, but one thing it does is remove leading and trailing 
whitespace, such as the `\r\n` that are causing the problem. (Another thing it 
does is Unicode normalization.) The JS parser doesn’t do this, so when the 
Wikibase frontend tries to send a string value that was parsed in JS (and 
therefore still has the `\r\n`) to the backend, there’s an error because the 
whitespace should have been removed. My proposed solution 
 is to 
stop using the JS `StringParser` and parse strings via PHP too, like all other 
data values.
  
  I have some idea about another question: why does this issue go away if you 
add and remove a space elsewhere in the string? Because ValueView already 
removes line breaks from the input. 
.
 It subscribes to the `eachchange` event and replaces all line breaks (DOS or 
Unix) with the empty string. Then why does the bug exist at all? That’s the 
part I don’t understand… at the HTML level, the `\r\n` is gone immediately 
after paste, but I guess it must be persisted somewhere in JS until the next 
time the input changes.

TASK DETAIL
  https://phabricator.wikimedia.org/T261942

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova, Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, toan, Lydia_Pintscher, Nikki, Aklapper, Addshore, 
Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T261942: Investigate adding and removing space when string is reported as "Malformed input", then allowing save

[Lydia_Pintscher]

Lydia_Pintscher added a comment.


  Moving this back to verification because we didn't actually sit down as 
discussed to go over what the overall desired enstate should be.

TASK DETAIL
  https://phabricator.wikimedia.org/T261942

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova, Lydia_Pintscher
Cc: toan, Lydia_Pintscher, Nikki, Aklapper, Addshore, Akuckartz, Iflorez, 
darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T261942: Investigate adding and removing space when string is reported as "Malformed input", then allowing save

[toan]

toan added a comment.


  This looks like it has been investigated fully. moving to done.

TASK DETAIL
  https://phabricator.wikimedia.org/T261942

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova, toan
Cc: toan, Lydia_Pintscher, Nikki, Aklapper, Addshore, Akuckartz, Iflorez, 
darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T261942: Investigate adding and removing space when string is reported as "Malformed input", then allowing save

[guergana.tzatchkova]

guergana.tzatchkova added a comment.


  Hidden white spaces seem to be causing the problem:
  
  F32351647: image.png 

TASK DETAIL
  https://phabricator.wikimedia.org/T261942

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova
Cc: Lydia_Pintscher, Nikki, Aklapper, Addshore, Akuckartz, Iflorez, 
darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T261942: Investigate adding and removing space when string is reported as "Malformed input", then allowing save

[guergana.tzatchkova]

guergana.tzatchkova claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T261942

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova
Cc: Lydia_Pintscher, Nikki, Aklapper, Addshore, Akuckartz, Iflorez, 
darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T261942: Investigate adding and removing space when string is reported as "Malformed input", then allowing save

[Lydia_Pintscher]

Lydia_Pintscher updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T261942

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Lydia_Pintscher, Nikki, Aklapper, Addshore, Akuckartz, darthmon_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T261942: Investigate adding and removing space when string is reported as "Malformed input", then allowing save

[Lydia_Pintscher]

Lydia_Pintscher moved this task from Prioritized Product to 
Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board.
Lydia_Pintscher edited projects, added Wikidata-Campsite 
(Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T261942

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3402/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Lydia_Pintscher, Nikki, Aklapper, Addshore, Akuckartz, Iflorez, 
darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T261942: Investigate adding and removing space when string is reported as "Malformed input", then allowing save

[Addshore]

Addshore added a subscriber: Lydia_Pintscher.
Addshore added a project: Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T261942

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Lydia_Pintscher, Nikki, Aklapper, Addshore, Akuckartz, darthmon_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T261942: Investigate adding and removing space when string is reported as "Malformed input", then allowing save

[Addshore]

Addshore created this task.
Addshore added a project: Wikidata.

TASK DESCRIPTION
  In order to understand why the case described in T261071 
 we should do a little investigation.
  This will allow us to properly understand the current state and also figure 
out where we want to end up.
  The description of that ticket includes the full steps to reproduce.
  The outcome of this investigation would be a clear description of what is 
happening in Wikibase and the UI that results in the edit eventually being 
allowed.
  This could be compared with editing another value type which has a different 
set of API calls and steps as part of the edit process.

TASK DETAIL
  https://phabricator.wikimedia.org/T261942

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Nikki, Aklapper, Addshore, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs