Addshore added a comment.
When deployed (happening this week) any impact on the cache should be visible
at
https://grafana-rw.wikimedia.org/d/u5wAugyik/wikibase-statsdrecordingsimplecache?orgId=1=now-7d=now=wikibase.repo.formatterCache
DB impact could potentially be seen in
WMDE-leszek closed this task as "Resolved".
WMDE-leszek moved this task from Test (Verification) to Done on the
Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
WMDE-leszek claimed this task.
WMDE-leszek added a comment.
Development work done. Performance impact unknown and not
WMDE-leszek removed WMDE-leszek as the assignee of this task.
TASK DETAIL
https://phabricator.wikimedia.org/T263999
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: WMDE-leszek
Cc: WMDE-leszek, Addshore, Tarrow, Lucas_Werkmeister_WMDE, toan, Aklapper,
WMDE-leszek closed subtask T266144: Use a caching service in
newLanguageIndependentLuaBindings() as Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T263999
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: WMDE-leszek
Cc: WMDE-leszek,
Lucas_Werkmeister_WMDE closed subtask T266145: Clarify language fallback
description of various interfaces as Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T263999
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE
Cc:
noarave added a project: Story.
TASK DETAIL
https://phabricator.wikimedia.org/T263999
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: noarave
Cc: WMDE-leszek, Addshore, Tarrow, Lucas_Werkmeister_WMDE, toan, Aklapper,
Akuckartz, Iflorez, alaa_wmde,
noarave closed subtask T266141: Check that getting labels with and without
language fallbacks doesn’t share the cache inappropriately as
Resolved.
TASK DETAIL
https://phabricator.wikimedia.org/T263999
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To:
Lucas_Werkmeister_WMDE added a comment.
Task inspection notes:
- `newLanguageDependentLuaBindings()` creates a
`CachingFallbackLabelDescriptionLookup` to take care of the caching.
`newLanguageIndependentLuaBindings()` doesn’t create a caching version of the
`TermLookup` it injects into
Lucas_Werkmeister_WMDE updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T263999
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Addshore, Tarrow, Lucas_Werkmeister_WMDE, toan,
WMDE-leszek added subscribers: Tarrow, Addshore, WMDE-leszek.
WMDE-leszek added a comment.
@Addshore: The team will work on it. When discussing the task, @tarrow
brought the question on whether we know what is the expected performance impact
of this change, or do we just anticipate there
WMDE-leszek moved this task from Prioritized Tech to
Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board.
WMDE-leszek edited projects, added Wikidata-Campsite
(Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.
TASK DETAIL
https://phabricator.wikimedia.org/T263999
WORKBOARD
WMDE-leszek set the point value for this task to "8".
TASK DETAIL
https://phabricator.wikimedia.org/T263999
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: WMDE-leszek
Cc: Lucas_Werkmeister_WMDE, toan, Aklapper, Akuckartz, darthmon_wmde, Nandana,
Lucas_Werkmeister_WMDE added a comment.
> - `mw.wikibase.getLabel` does consider "language fallback"
> - `mw.wikibase.getLabelByLang` does only get the label in the language
request, not performing any "fallback" logic
> - Conclusion of the above: those method should use distinct cache
WMDE-leszek updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T263999
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: WMDE-leszek
Cc: toan, Aklapper, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86,
GoranSMilovanovic,
WMDE-leszek updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T263999
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: WMDE-leszek
Cc: toan, Aklapper, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86,
GoranSMilovanovic,
Addshore updated the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T263999
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Addshore
Cc: toan, Aklapper, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86,
GoranSMilovanovic, QZanden,
toan renamed this task from "Language dependent lua-calls does not end up in
formatterCache" to "Some lua-calls with language specified does not end up in
formatterCache".
TASK DETAIL
https://phabricator.wikimedia.org/T263999
EMAIL PREFERENCES
17 matches
Mail list logo