[Wikidata-bugs] [Maniphest] T268645: Pywikibot crashing on ratelimit after the ratelimit removal from bot group in 2020

2020-12-10 Thread Xqt
Xqt edited parent tasks, added: T269823: Pywikibot release 5.2.0 dependencies; 
removed: T268464: Pywikibot release 5.3.0 dependencies.

TASK DETAIL
  https://phabricator.wikimedia.org/T268645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Mpaa, Aklapper, pywikibot-bugs-list, Multichill, Xqt, JohnsonLee01, SHEKH, 
Dijkstra, Khutuck, Akuckartz, Zkhalido, Viztor, Nandana, Wenyi, Lahi, Gq86, 
GoranSMilovanovic, QZanden, Tbscho, MayS, LawExplorer, Mdupont, JJMC89, 
Dvorapa, _jensen, rosalieper, Altostratus, Avicennasis, Scott_WUaS, mys_721tx, 
Wikidata-bugs, aude, jayvdb, Masti, Alchimista, Mbch331, Rxy
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] T268645: Pywikibot crashing on ratelimit after the ratelimit removal from bot group in 2020

2020-12-05 Thread Xqt
Xqt closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T268645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Mpaa, Aklapper, pywikibot-bugs-list, Multichill, Xqt, JohnsonLee01, SHEKH, 
Dijkstra, Khutuck, Akuckartz, Zkhalido, Viztor, Nandana, Wenyi, Lahi, Gq86, 
GoranSMilovanovic, QZanden, Tbscho, MayS, LawExplorer, Mdupont, JJMC89, 
Dvorapa, _jensen, rosalieper, Altostratus, Avicennasis, Scott_WUaS, mys_721tx, 
Wikidata-bugs, aude, jayvdb, Masti, Alchimista, Mbch331, Rxy
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] T268645: Pywikibot crashing on ratelimit after the ratelimit removal from bot group in 2020

2020-12-05 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T268645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt, Maintenance_bot
Cc: Mpaa, Aklapper, pywikibot-bugs-list, Multichill, Xqt, JohnsonLee01, SHEKH, 
Dijkstra, Khutuck, Akuckartz, Zkhalido, Viztor, Nandana, Wenyi, Lahi, Gq86, 
GoranSMilovanovic, QZanden, Tbscho, MayS, LawExplorer, Mdupont, JJMC89, 
Dvorapa, _jensen, rosalieper, Altostratus, Avicennasis, Scott_WUaS, mys_721tx, 
Wikidata-bugs, aude, jayvdb, Masti, Alchimista, Mbch331, Rxy, Alter-paule, 
Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, 
Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] T268645: Pywikibot crashing on ratelimit after the ratelimit removal from bot group in 2020

2020-12-05 Thread gerritbot
gerritbot added a comment.


  Change 643491 **merged** by jenkins-bot:
  [pywikibot/core@master] [bugfix] _is_wikibase_error_retryable rewritten
  
  https://gerrit.wikimedia.org/r/643491

TASK DETAIL
  https://phabricator.wikimedia.org/T268645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt, gerritbot
Cc: Mpaa, Aklapper, pywikibot-bugs-list, Multichill, Xqt, JohnsonLee01, SHEKH, 
Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Akuckartz, Zkhalido, Hook696, 
Kent7301, joker88john, Viztor, CucyNoiD, Nandana, Wenyi, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, Tbscho, 
MayS, LawExplorer, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, _jensen, 
rosalieper, Altostratus, Avicennasis, Scott_WUaS, mys_721tx, Wikidata-bugs, 
aude, jayvdb, Masti, Alchimista, Mbch331, Rxy
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] T268645: Pywikibot crashing on ratelimit after the ratelimit removal from bot group in 2020

2020-12-05 Thread Xqt
Xqt changed the subtype of this task from "Task" to "Bug Report".

TASK DETAIL
  https://phabricator.wikimedia.org/T268645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Mpaa, Aklapper, pywikibot-bugs-list, Multichill, Xqt, JohnsonLee01, SHEKH, 
Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Akuckartz, Zkhalido, Hook696, 
Kent7301, joker88john, Viztor, CucyNoiD, Nandana, Wenyi, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, Tbscho, 
MayS, LawExplorer, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, _jensen, 
rosalieper, Altostratus, Avicennasis, Scott_WUaS, mys_721tx, Wikidata-bugs, 
aude, jayvdb, Masti, Alchimista, Mbch331, Rxy
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] T268645: Pywikibot crashing on ratelimit after the ratelimit removal from bot group in 2020

2020-11-25 Thread gerritbot
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T268645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt, gerritbot
Cc: Mpaa, Aklapper, pywikibot-bugs-list, Multichill, Xqt, JohnsonLee01, SHEKH, 
Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Akuckartz, Zkhalido, Hook696, 
Kent7301, joker88john, Viztor, CucyNoiD, Nandana, Wenyi, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, Tbscho, 
MayS, LawExplorer, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, _jensen, 
rosalieper, Altostratus, Avicennasis, Scott_WUaS, mys_721tx, Wikidata-bugs, 
aude, jayvdb, Masti, Alchimista, Mbch331, Rxy
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] T268645: Pywikibot crashing on ratelimit after the ratelimit removal from bot group in 2020

2020-11-25 Thread gerritbot
gerritbot added a comment.


  Change 643491 had a related patch set uploaded (by Xqt; owner: Xqt):
  [pywikibot/core@master] [bugfix] _is_wikibase_error_retryable rewritten
  
  https://gerrit.wikimedia.org/r/643491

TASK DETAIL
  https://phabricator.wikimedia.org/T268645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt, gerritbot
Cc: Mpaa, Aklapper, pywikibot-bugs-list, Multichill, Xqt, JohnsonLee01, SHEKH, 
Dijkstra, Khutuck, Akuckartz, Zkhalido, Viztor, Nandana, Wenyi, Lahi, Gq86, 
GoranSMilovanovic, QZanden, Tbscho, MayS, LawExplorer, Mdupont, JJMC89, 
Dvorapa, _jensen, rosalieper, Altostratus, Avicennasis, Scott_WUaS, mys_721tx, 
Wikidata-bugs, aude, jayvdb, Masti, Alchimista, Mbch331, Rxy
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] T268645: Pywikibot crashing on ratelimit after the ratelimit removal from bot group in 2020

2020-11-24 Thread Mpaa
Mpaa added a comment.


  According to this test, there are several actions that might emit 
'wikibase-api-failed-save' as message.
  
https://github.com/wikimedia/Wikibase/blob/e388e5b69ee0487566d7a8a77196ac0056f49747/repo/tests/phpunit/includes/Api/ApiUserBlockedTest.php
  
  Shouldn't they be all checked in:
  
if code == 'failed-save' and \
   self.action == 'wbeditentity' and \
   self._is_wikibase_error_retryable(result['error']):
self.wait()
continue
  
  instead of 'wbeditentity' only?

TASK DETAIL
  https://phabricator.wikimedia.org/T268645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt, Mpaa
Cc: Mpaa, Aklapper, pywikibot-bugs-list, Multichill, Xqt, JohnsonLee01, SHEKH, 
Dijkstra, Khutuck, Akuckartz, Zkhalido, Viztor, Nandana, Wenyi, Lahi, Gq86, 
GoranSMilovanovic, QZanden, Tbscho, MayS, LawExplorer, Mdupont, JJMC89, 
Dvorapa, _jensen, rosalieper, Altostratus, Avicennasis, Scott_WUaS, mys_721tx, 
Wikidata-bugs, aude, jayvdb, Masti, Alchimista, Mbch331, Rxy
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] T268645: Pywikibot crashing on ratelimit after the ratelimit removal from bot group in 2020

2020-11-24 Thread Xqt
Xqt added a parent task: T268464: Pywikibot release 5.2.0 dependencies.

TASK DETAIL
  https://phabricator.wikimedia.org/T268645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Aklapper, pywikibot-bugs-list, Multichill, Xqt, JohnsonLee01, SHEKH, 
Dijkstra, Khutuck, Akuckartz, Zkhalido, Viztor, Nandana, Wenyi, Lahi, Gq86, 
GoranSMilovanovic, QZanden, Tbscho, MayS, LawExplorer, Mdupont, JJMC89, 
Dvorapa, _jensen, rosalieper, Altostratus, Avicennasis, Scott_WUaS, mys_721tx, 
Wikidata-bugs, aude, jayvdb, Masti, Alchimista, Mbch331, Rxy
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] T268645: Pywikibot crashing on ratelimit after the ratelimit removal from bot group in 2020

2020-11-24 Thread Xqt
Xqt claimed this task.
Xqt added a comment.


  Referring the first patch mentioned above I think wbeditentity action is 
related to the first error name but not valid for actionthrottledtext. The 
should always cause a wait cycle.

TASK DETAIL
  https://phabricator.wikimedia.org/T268645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Aklapper, pywikibot-bugs-list, Multichill, Xqt, JohnsonLee01, SHEKH, 
Dijkstra, Khutuck, Akuckartz, Zkhalido, Viztor, Nandana, Wenyi, Lahi, Gq86, 
GoranSMilovanovic, QZanden, Tbscho, MayS, LawExplorer, Mdupont, JJMC89, 
Dvorapa, _jensen, rosalieper, Altostratus, Avicennasis, Scott_WUaS, mys_721tx, 
Wikidata-bugs, aude, jayvdb, Masti, Alchimista, Mbch331, Rxy
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] T268645: Pywikibot crashing on ratelimit after the ratelimit removal from bot group in 2020

2020-11-24 Thread Multichill
Multichill added a comment.


  In T268645#6645735 , @Xqt 
wrote:
  
  > Looks like it is the same as T192912 

  >
  > Due to
  >
  >   if code == 'failed-save' and \
  >  self.action == 'wbeditentity' and \
  >  self._is_wikibase_error_retryable(result['error']):
  >   self.wait()
  >   continue
  >
  > it seems that action is not `'wbeditentity'`; any idea what it was?
  
  Either 
https://www.wikidata.org/w/api.php?action=help&recursivesubmodules=1#wbcreateclaim
 or 
https://www.wikidata.org/w/api.php?action=help&recursivesubmodules=1#wbsetqualifier
 I think.
  We have a whole list of possible Wikibase actions that trigger a write. If I 
look at self.write = self.action in {] that seems to be quite complete. 
Maybe in the start of the init define a list of normal write actions and a list 
of wbwrite actions and update both checks to use these lists? First check would 
use both lists and the code you pasted the wikibase list.

TASK DETAIL
  https://phabricator.wikimedia.org/T268645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Multichill
Cc: Aklapper, pywikibot-bugs-list, Multichill, Xqt, JohnsonLee01, SHEKH, 
Dijkstra, Khutuck, Akuckartz, Zkhalido, Viztor, Nandana, Wenyi, Lahi, Gq86, 
GoranSMilovanovic, QZanden, Tbscho, MayS, LawExplorer, Mdupont, JJMC89, 
Dvorapa, _jensen, rosalieper, Altostratus, Avicennasis, Scott_WUaS, mys_721tx, 
Wikidata-bugs, aude, jayvdb, Masti, Alchimista, Mbch331, Rxy
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] T268645: Pywikibot crashing on ratelimit after the ratelimit removal from bot group in 2020

2020-11-24 Thread Xqt
Xqt triaged this task as "High" priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T268645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Aklapper, pywikibot-bugs-list, Multichill, Xqt, JohnsonLee01, SHEKH, 
Dijkstra, Khutuck, Akuckartz, Zkhalido, Viztor, Nandana, Wenyi, Lahi, Gq86, 
GoranSMilovanovic, QZanden, Tbscho, MayS, LawExplorer, Mdupont, JJMC89, 
Dvorapa, _jensen, rosalieper, Altostratus, Avicennasis, Scott_WUaS, mys_721tx, 
Wikidata-bugs, aude, jayvdb, Masti, Alchimista, Mbch331, Rxy
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] T268645: Pywikibot crashing on ratelimit after the ratelimit removal from bot group in 2020

2020-11-24 Thread Xqt
Xqt added a comment.


  Looks like it is the same as T192912 


TASK DETAIL
  https://phabricator.wikimedia.org/T268645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Aklapper, pywikibot-bugs-list, Multichill, Xqt, JohnsonLee01, SHEKH, 
Dijkstra, Khutuck, Akuckartz, Zkhalido, Viztor, Nandana, Wenyi, Lahi, Gq86, 
GoranSMilovanovic, QZanden, Tbscho, MayS, LawExplorer, Mdupont, JJMC89, 
Dvorapa, _jensen, rosalieper, Altostratus, Avicennasis, Scott_WUaS, mys_721tx, 
Wikidata-bugs, aude, jayvdb, Masti, Alchimista, Mbch331, Rxy
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] T268645: Pywikibot crashing on ratelimit after the ratelimit removal from bot group in 2020

2020-11-24 Thread Multichill
Multichill created this task.
Multichill added projects: Pywikibot, Wikidata.
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper.

TASK DESCRIPTION
  I noticed I got:
   pywikibot.data.api.APIError: failed-save: The save has failed.
  [help: See https://www.wikidata.org/w/api.php for API usage. Subscribe to the 
mediawiki-api-announce mailing list at 
; for 
notice of API deprecations and breaking changes.;
   messages: [{'name': 'wikibase-api-failed-save', 'html': {'*': 'The save has 
failed.'}, 'parameters': []}, {'name': 'actionthrottledtext', 'html': {'*': 'As 
an anti-abuse measure, you are limited from performing this action too many 
times in a short space of time, and you have exceeded this limit.\nPlease try 
again in a few minutes.'}, 'parameters': []}]]
  CRITICAL: Exiting due to uncaught exception 
  
  I just assume this is because of T258354 

  
  I run the latest version
  Pywikibot: [ssh] pywikibot-core.git (fed71d9 
,
 g13736, 2020/11/23, 11:03:20, master)
  Release version: 5.2.0.dev0
  
  I assumed that this was already handled based on T192912 
 and T253180 
 where @Xqt patched up Pywikibot to 
handle these cases

TASK DETAIL
  https://phabricator.wikimedia.org/T268645

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Multichill
Cc: Aklapper, pywikibot-bugs-list, Multichill, Xqt, JohnsonLee01, SHEKH, 
Dijkstra, Khutuck, Akuckartz, Zkhalido, Viztor, Nandana, Wenyi, Lahi, Gq86, 
GoranSMilovanovic, QZanden, Tbscho, MayS, LawExplorer, Mdupont, JJMC89, 
Dvorapa, _jensen, rosalieper, Altostratus, Avicennasis, Scott_WUaS, mys_721tx, 
Wikidata-bugs, aude, jayvdb, Masti, Alchimista, Mbch331, Rxy
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs