[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-10-11 Thread Manuel 
Manuel closed this task as "Declined".
Manuel added a comment.


  We have split this task in two parts (see T268689#8036398 
) and successfully deployed 
the first part: T317863: Only save Lexeme language codes with uppercase item 
IDs (mis-x-Qid), not lowercase (mis-x-qid) 

  
  I have decided not to follow up with the second part at this point in favor 
of a more general evaluation of normalization (see T319022#8307285 
).
  
  -> Declining this parent task for now.

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Manuel
Cc: karapayneWMDE, Michael, Manuel, ItamarWMDE, Esc3300, Lydia_Pintscher, 
Lucas_Werkmeister_WMDE, Nikki, mrephabricator, Astuthiodit_1, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-10-11 Thread Manuel 
Manuel closed subtask T319022: Automatically normalize lowercase and uppercase 
in Lexeme language code when saving instead of showing an error as 
Declined.

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Manuel
Cc: karapayneWMDE, Michael, Manuel, ItamarWMDE, Esc3300, Lydia_Pintscher, 
Lucas_Werkmeister_WMDE, Nikki, mrephabricator, Astuthiodit_1, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-10-11 Thread Manuel 
Manuel updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Manuel
Cc: karapayneWMDE, Michael, Manuel, ItamarWMDE, Esc3300, Lydia_Pintscher, 
Lucas_Werkmeister_WMDE, Nikki, mrephabricator, Astuthiodit_1, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-10-10 Thread Lydia_Pintscher 
Lydia_Pintscher closed subtask T317863: Only save Lexeme language codes with 
uppercase item IDs (mis-x-Qid), not lowercase (mis-x-qid) as 
Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: karapayneWMDE, Michael, Manuel, ItamarWMDE, Esc3300, Lydia_Pintscher, 
Lucas_Werkmeister_WMDE, Nikki, mrephabricator, Astuthiodit_1, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-09-30 Thread karapayneWMDE 
karapayneWMDE added a subtask: T319022: Automatically normalize lowercase q in 
item IDs to uppercase Q when saving instead of showing an error.

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: karapayneWMDE
Cc: karapayneWMDE, Michael, Manuel, ItamarWMDE, Esc3300, Lydia_Pintscher, 
Lucas_Werkmeister_WMDE, Nikki, mrephabricator, Astuthiodit_1, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-09-19 Thread karapayneWMDE 
karapayneWMDE edited projects, added Wikidata Dev Team (Sprint-∞); removed 
Wikidata Dev Team.
karapayneWMDE changed the point value for this task from "8" to "5".

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: karapayneWMDE
Cc: karapayneWMDE, Michael, Manuel, ItamarWMDE, Esc3300, Lydia_Pintscher, 
Lucas_Werkmeister_WMDE, Nikki, mrephabricator, Astuthiodit_1, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-09-19 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  (Note: estimate of 5 is for subtask 1 [disallow lowercase qid], excluding 
subtask 2 [normalize case generally])

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: karapayneWMDE, Michael, Manuel, ItamarWMDE, Esc3300, Lydia_Pintscher, 
Lucas_Werkmeister_WMDE, Nikki, mrephabricator, Astuthiodit_1, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-09-19 Thread karapayneWMDE 
karapayneWMDE added a comment.


  sprint planning -subtask 1 accepted into sprint 6. subtask 2 will be 
converted into a unique task and added to the product backlog

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: karapayneWMDE
Cc: karapayneWMDE, Michael, Manuel, ItamarWMDE, Esc3300, Lydia_Pintscher, 
Lucas_Werkmeister_WMDE, Nikki, mrephabricator, Astuthiodit_1, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-08-09 Thread karapayneWMDE 
karapayneWMDE moved this task from Sprint-♾ to Unified prioritized backlog on 
the Wikidata Dev Team board.
karapayneWMDE edited projects, added Wikidata Dev Team; removed Wikidata Dev 
Team (Sprint-♾).

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6016/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: karapayneWMDE
Cc: Michael, Manuel, ItamarWMDE, Esc3300, Lydia_Pintscher, 
Lucas_Werkmeister_WMDE, Nikki, mrephabricator, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-08-03 Thread Manuel 
Manuel added a project: Wikidata Dev Team (Sprint-♾).
Manuel added a comment.


  This fell through the cracks as we removed it from our "Special:NewLexeme 
revival" work board without adding it to the new unified board. Adding it to 
the prioritized column of our sprint work board.

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Manuel
Cc: Michael, Manuel, ItamarWMDE, Esc3300, Lydia_Pintscher, 
Lucas_Werkmeister_WMDE, Nikki, mrephabricator, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-07-15 Thread Lydia_Pintscher 
Lydia_Pintscher removed a project: Special:NewLexeme revival.

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Michael, Manuel, ItamarWMDE, Esc3300, Lydia_Pintscher, 
Lucas_Werkmeister_WMDE, Nikki, mrephabricator, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-07-12 Thread Manuel 
Manuel added a comment.


  Thank you, @Michael, for pointing this out! That was actually the original 
intention of my AC. What we then added during sprint planning could also be 
read differently, so I fixed it!

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Manuel
Cc: Michael, Manuel, ItamarWMDE, Esc3300, Lydia_Pintscher, 
Lucas_Werkmeister_WMDE, Nikki, mrephabricator, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-07-12 Thread Manuel 
Manuel updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Manuel
Cc: Michael, Manuel, ItamarWMDE, Esc3300, Lydia_Pintscher, 
Lucas_Werkmeister_WMDE, Nikki, mrephabricator, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-06-29 Thread Michael 
Michael added a comment.


  In T268689#8036484 , 
@Manuel wrote:
  
  > From your question @Michael about reconfirmation, I assume that part 2 is 
more complex than we hoped for (in terms of work needed or the result we get, 
e.g. as it would require modifying a non-lexeme-specific part of the code, if I 
understand correctly)?
  
  Mh, not necessarily "more complex than we hoped for", but surely more complex 
than part 1 and quite separate from part 1. So there is the option here to 
treat them separately from a product perspective and the core functionality of 
this story would already be implemented with part 1.
  Also, we could probably expand the scope of part 2 to "save any language code 
regardless of capitalization in the correct, standardized way instead of 
showing an error". For example, when the user enters `en-GB` then could just 
save this as `en-gb` instead of showing an error about an unknown language 
code, like we currently do. (Which is also suboptimal copy, because the 
language code is in fact known, just it is capitalized wrong.)

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Manuel, ItamarWMDE, Esc3300, Lydia_Pintscher, 
Lucas_Werkmeister_WMDE, Nikki, mrephabricator, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-06-29 Thread Manuel 
Manuel added a comment.


  Yes, my intention was to normalize the capitalization of all parts of the 
string (mis-x- lowercase, Qid uppercase). From your question about 
reconfirmation, I assume that part 2 is more complex than we hoped for (in 
terms of work needed or the result we get, e.g. as it would require modifying a 
non-lexeme-specific part of the code, if I understand correctly)?

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Manuel
Cc: Michael, Manuel, ItamarWMDE, Esc3300, Lydia_Pintscher, 
Lucas_Werkmeister_WMDE, LucasWerkmeister, Nikki, mrephabricator, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-06-29 Thread Michael 
Michael added a comment.


  **breakdown notes**
  
  - The scope of this task is to ensure that language codes that include a Q-id 
are saved in a standardized way
  
  Subtask 1: make sure only codes with an uppercase `Q`-id  are saved (sub-task 
will be created when this story is picked up)
  
  - show error if saving a language `mis-x-` code with a lowercase item id
  - this will need adjusting the LexemeTermLanguageValidator 

 as discussed in T268689#6646820 

  - this should get us ~80% of the benefit of this story
  
  Subtask 2: automatically normalize lowercase `q` in item IDs to uppercase `Q` 
when saving instead of showing an error
  
  - this task might benefit from having its priority reconfirmed by @Manuel
  - it might make sense to do this for other parts of the language code as well
  - This might have to happen in ChangeOpLemmaEdit 


TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Manuel, ItamarWMDE, Esc3300, Lydia_Pintscher, 
Lucas_Werkmeister_WMDE, LucasWerkmeister, Nikki, mrephabricator, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, 
Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-06-29 Thread guergana.tzatchkova 
guergana.tzatchkova updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova
Cc: Manuel, ItamarWMDE, Esc3300, Lydia_Pintscher, Lucas_Werkmeister_WMDE, 
LucasWerkmeister, Nikki, mrephabricator, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-06-28 Thread Manuel 
Manuel added a comment.


  I have now clarified the edge cases that we discovered in sprint planning and 
modified the task description accordingly:
  
  - If an editor enters both the Q and q version to the same Item then the edit 
should fail (with our standard message saying you cannot save two Lemmas with 
the same code). This is the standard behavior, so we will not have to deal with 
the edge case of "if an item has both Q and q" in a special way.
  - Reverts should just go back to the original version (without 
normalization). This way we will not have to deal with normalization edge cases.

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Manuel
Cc: Manuel, ItamarWMDE, Esc3300, Lydia_Pintscher, Lucas_Werkmeister_WMDE, 
LucasWerkmeister, Nikki, mrephabricator, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-06-28 Thread Manuel 
Manuel updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Manuel
Cc: Manuel, ItamarWMDE, Esc3300, Lydia_Pintscher, Lucas_Werkmeister_WMDE, 
LucasWerkmeister, Nikki, mrephabricator, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-06-28 Thread karapayneWMDE 
karapayneWMDE updated the task description.
karapayneWMDE set the point value for this task to "8".

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: karapayneWMDE
Cc: Manuel, ItamarWMDE, Esc3300, Lydia_Pintscher, Lucas_Werkmeister_WMDE, 
LucasWerkmeister, Nikki, mrephabricator, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-06-23 Thread ItamarWMDE 
ItamarWMDE added a comment.


  Looks great! :D Thank you!

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Manuel, ItamarWMDE, Esc3300, Lydia_Pintscher, Lucas_Werkmeister_WMDE, 
LucasWerkmeister, Nikki, mrephabricator, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-06-23 Thread Manuel 
Manuel added a project: Special:NewLexeme revival.

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Manuel
Cc: Manuel, ItamarWMDE, Esc3300, Lydia_Pintscher, Lucas_Werkmeister_WMDE, 
LucasWerkmeister, Nikki, mrephabricator, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-06-22 Thread Manuel 
Manuel added subscribers: ItamarWMDE, Manuel.
Manuel added a comment.
Restricted Application added a project: User-ItamarWMDE.


  Hi @ItamarWMDE this has acceptance criteria now! Ready? :)

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Manuel
Cc: Manuel, ItamarWMDE, Esc3300, Lydia_Pintscher, Lucas_Werkmeister_WMDE, 
LucasWerkmeister, Nikki, mrephabricator, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-06-22 Thread Manuel 
Manuel updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Manuel
Cc: Esc3300, Lydia_Pintscher, Lucas_Werkmeister_WMDE, LucasWerkmeister, Nikki, 
mrephabricator, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2022-06-22 Thread Manuel 
Manuel updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Manuel
Cc: Esc3300, Lydia_Pintscher, Lucas_Werkmeister_WMDE, LucasWerkmeister, Nikki, 
mrephabricator, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2021-07-23 Thread Esc3300 
Esc3300 added a project: Language codes.

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Esc3300
Cc: Esc3300, Lydia_Pintscher, Lucas_Werkmeister_WMDE, LucasWerkmeister, Nikki, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2021-07-23 Thread Esc3300 
Esc3300 updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Esc3300
Cc: Esc3300, Lydia_Pintscher, Lucas_Werkmeister_WMDE, LucasWerkmeister, Nikki, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2021-07-23 Thread Esc3300 
Esc3300 added a comment.


  Personally, I'd use lowercase, as almost all language codes in Wikidata are 
lowercased and  lang(?lemma) also gives lowercase, not uppercase. See 
https://w.wiki/3fnb

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Esc3300
Cc: Esc3300, Lydia_Pintscher, Lucas_Werkmeister_WMDE, LucasWerkmeister, Nikki, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2021-07-23 Thread Lydia_Pintscher 
Lydia_Pintscher added a project: Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Lydia_Pintscher, Lucas_Werkmeister_WMDE, LucasWerkmeister, Nikki, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2020-12-22 Thread LucasWerkmeister 
LucasWerkmeister added a comment.


  In general that should also be possible, though I haven’t yet looked at where 
in the code that would happen.

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: LucasWerkmeister
Cc: Lydia_Pintscher, Lucas_Werkmeister_WMDE, LucasWerkmeister, Nikki, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, 
LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2020-12-19 Thread Lydia_Pintscher 
Lydia_Pintscher added subscribers: Lucas_Werkmeister_WMDE, Lydia_Pintscher.
Lydia_Pintscher added a comment.


  @Lucas_Werkmeister_WMDE Would it also be possible to automatically convert 
them to upper case instead of rejecting them? That seems better if we know 
what's intended.

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Lydia_Pintscher, Lucas_Werkmeister_WMDE, LucasWerkmeister, Nikki, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, 
LawExplorer, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2020-12-01 Thread Nikki 
Nikki added a comment.


  There were 10 lexemes in the 2020-11-27 lexeme dump which I've also fixed. 
They came from two users, Jacek Janowski and Tokyo Akademia, which was the case 
for most of the previous ones I fixed too.

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Nikki
Cc: LucasWerkmeister, Nikki, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2020-11-24 Thread Nikki 
Nikki added a comment.


  The vast majority of the time people use `Q`, people are presumably copying 
the ID from the item page. I just fixed all the ones which had `q`, but I'll 
have to wait until the next lexeme dump to find out if I got them all (or if 
any new ones appeared).

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Nikki
Cc: LucasWerkmeister, Nikki, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2020-11-24 Thread LucasWerkmeister 
LucasWerkmeister added a comment.


  `mis-x-Q1` validation happens in LexemeTermLanguageValidator 
:
  
// ...
if ( count( $parts ) > 1 && !$this->isValidItemId( $parts[1] ) 
) {
$context->addViolation( new InvalidItemId( $parts[1] ) 
);
}
}
private function isValidItemId( $id ) {
return preg_match( ItemId::PATTERN, $id );
}
  
  `ItemId::PATTERN` allows both lower- and uppercase Q. If we’d noticed this 
during initial development, we probably should’ve allowed only one of them 
here. But given that lexemes with both now exist on Wikidata, that might be too 
heavy-handed…
  
  On the other hand – it’s in change-op validation, not in the core data model. 
So maybe if we add such a restriction, it only applies to new edits, and you 
can still edit existing lexemes with such language codes. Not sure.

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: LucasWerkmeister
Cc: LucasWerkmeister, Nikki, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268689: Lexeme language code allows both upper and lowercase qids in -x-qid syntax

2020-11-24 Thread Nikki 
Nikki created this task.
Nikki added a project: Wikidata Lexicographical data.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION
  See https://test.wikidata.org/wiki/Lexeme:L97
  
  It treats `mis-x-Q1` and `mis-x-q1` as separate codes and allows both even 
though they are semantically identical.
  
  This only happens with the qid part of the code. If you try to save `mis` and 
`MIS`, `mis-x-Q1` and `mis-X-Q1` or `en-gb` and `en-GB`, it rejects the second 
of each pair.

TASK DETAIL
  https://phabricator.wikimedia.org/T268689

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Nikki
Cc: Nikki, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs