[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[amy_rc]

amy_rc closed this task as "Resolved".
amy_rc added a comment.


  💃

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, amy_rc
Cc: amy_rc, Michael, Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Ladsgroup]

Ladsgroup added a comment.


  In T268982#6787430 , 
@Michael wrote:
  
  > I don't have a great overview yet of what has been done in the last days, 
but it would seem that this PR still needs to be merged: 
https://github.com/wmde/query-builder/pull/157 ?
  
  That's sorta my fault. We got the fix in DS released and applied in QB and I 
forgot that this PR is also needed. Now approved.

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Ladsgroup
Cc: amy_rc, Michael, Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Charlie_WMDE]

Charlie_WMDE added a comment.


  that's the one i tried out. i thought it said 38x37.x when i tested it but 
now it says 38x32.8 which i think is fine. can be merged then from my side!

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Charlie_WMDE
Cc: amy_rc, Michael, Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Michael]

Michael added a comment.


  I don't have a great overview yet of what has been done in the last days, but 
it would seem that this PR still needs to be merged: 
https://github.com/wmde/query-builder/pull/157 ?

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: amy_rc, Michael, Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Charlie_WMDE]

Charlie_WMDE added a comment.


  i seem to still have the same problem. maybe it's my browser?

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Charlie_WMDE
Cc: amy_rc, Michael, Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[amy_rc]

amy_rc added a comment.


  @Charlie_WMDE Lydia and me tested and it looks good. Can you check this from 
design perceptive and then resolve the ticket?

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, amy_rc
Cc: amy_rc, Michael, Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Ladsgroup]

Ladsgroup moved this task from ❌ Blocked to Test (Verification) on the Wikidata 
Query Builder board.
Ladsgroup added a comment.


  The icon size should be now deployed.

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4990/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Ladsgroup
Cc: Michael, Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Charlie_WMDE]

Charlie_WMDE closed subtask T272053: (MS 2) Make the last condition removable 
as well as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Charlie_WMDE
Cc: Michael, Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Lydia_Pintscher]

Lydia_Pintscher moved this task from Wikidata Query Builder - sprint 6 to ❌ 
Blocked on the Wikidata Query Builder board.
Lydia_Pintscher edited projects, added Wikidata Query Builder; removed Wikidata 
Query Builder (Wikidata Query Builder - sprint 6).

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4990/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Lydia_Pintscher
Cc: Michael, Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[amy_rc]

amy_rc triaged this task as "High" priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, amy_rc
Cc: Michael, Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Michael]

Michael claimed this task.
Michael added a comment.
Restricted Application added a project: User-Michael.


  I'll look into the icon size

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Lydia_Pintscher]

Lydia_Pintscher moved this task from Test (Verification) to To Do on the 
Wikidata Query Builder (Wikidata Query Builder - sprint 6) board.
Lydia_Pintscher added a comment.


  Moving back to todo for adressing Charlie's last point about the icon size.

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5143/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Charlie_WMDE]

Charlie_WMDE added a subtask: T272053: Make the last condition removable as 
well.

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Charlie_WMDE
Cc: Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Charlie_WMDE]

Charlie_WMDE added a comment.


  After discussing this topic with Lydia, we agreed to make following change in 
this ticket:
  
  > - size of the icon only component should be M. in firefox the measurements 
seem to be a bit off. should be 38x32px but appears as 38x33.4px (in chrome 
it's 38x32.89)
  
  and following changes in a separate ticket (link will follow):
  
  > - remove the disabled state of the trashcan (last condition can be deleted 
as well)
  > - when no condition remains, a placeholder text becomes visible

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Charlie_WMDE
Cc: Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Charlie_WMDE]

Charlie_WMDE added a comment.


  Removing or disabling the trashcan is an inconsistent behavior.  we'd rather 
have to find arguments for why we *should* remove or disable it. I couldn't 
find any. if there's no good reason (preventing the user to make an error for 
example) to disable/remove the button, then we should keep consistency and let 
people remove conditions, no matter how many are on the screen. if the user 
wants to delete the last condition, why stop them? they will always be able to 
create a new one so we're not maneuvering them into a cul-de-sac. additionally, 
it might be faster this way than clearing all the fields of the last condition, 
should they realize that they don't need that input either.
  
  the placeholder is already implemented for the empty results section, so 
should be easy to replicate. Additionally, it is a good practice and a way to 
get some early feedback on this pattern, since i can foresee us using this on 
Wikidata as well, on a new item page without statements for example.
  
  all this leads me to believe, that from a UX-perspective the button should 
stay.
  
  Hope this makes sense. Happy to explain further if something is unclear.

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Charlie_WMDE
Cc: Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Lydia_Pintscher]

Lydia_Pintscher added a comment.


  In T268982#6728955 , 
@Charlie_WMDE wrote:
  
  > regarding this ticket, the specs were, as amir mentioned, outdated. that's 
on me. my question to @Lydia_Pintscher  is, how do we proceed. base the 
verification off of the old specs and create a separate ticket?
  >
  > changes that would have to me made are:
  >
  > - remove the disabled state of the trashcan (last condition can be deleted 
as well)
  > - when no condition remains, a placeholder text becomes visible
  > - size of the icon only component should be M. in firefox the measurements 
seem to be a bit off
  >
  > everything else looks great! \o/
  
  I think the size changes we can do in this ticket.
  
  About removing the last condition: could you clarify why we should allow 
people to remove the last condition? I can't think of a case where this would 
make sense. In addition we have the work of creating the state where the 
placeholder is shown.

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Charlie_WMDE]

Charlie_WMDE added a comment.


  regarding this ticket, the specs were, as amir mentioned, outdated. that's on 
me. my question to @Lydia_Pintscher  is, how do we proceed. base the 
verification off of the old specs and create a separate ticket?
  
  changes that would have to me made are:
  
  - remove the disabled state of the trashcan (last condition can be deleted as 
well)
  - when no condition remains, a placeholder text becomes visible
  - size of the icon only component should be M. in firefox the measurements 
seem to be a bit off
  
  everything else looks great! \o/

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Charlie_WMDE
Cc: Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Lydia_Pintscher]

Lydia_Pintscher moved this task from Wikidata Query Builder - sprint 5 to 
Wikidata Query Builder - sprint 6 on the Wikidata Query Builder board.
Lydia_Pintscher edited projects, added Wikidata Query Builder (Wikidata Query 
Builder - sprint 6); removed Wikidata Query Builder (Wikidata Query Builder - 
sprint 5).

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4990/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331, Manishsamota
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Lydia_Pintscher]

Lydia_Pintscher closed subtask T268658: Create Quiet icon-only button component 
as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Manishsamota, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Lydia_Pintscher]

Lydia_Pintscher closed subtask T271093: Extract RemoveCondition component that 
wraps the DS Button as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Manishsamota, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Lydia_Pintscher]

Lydia_Pintscher closed subtask T270707: Implement Remove Condition logic as 
"Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Manishsamota, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Charlie_WMDE]

Charlie_WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Charlie_WMDE
Cc: Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Manishsamota, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Charlie_WMDE]

Charlie_WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Charlie_WMDE
Cc: Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Manishsamota, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[guergana.tzatchkova]

guergana.tzatchkova moved this task from Ready to pick up to Wikidata Query 
Builder - sprint 5 on the Wikidata Query Builder board.
guergana.tzatchkova edited projects, added Wikidata Query Builder (Wikidata 
Query Builder - sprint 5); removed Wikidata Query Builder.

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4990/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova
Cc: Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Manishsamota, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Ladsgroup]

Ladsgroup added a comment.


  These specs seem to be rather old.

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Lydia_Pintscher]

Lydia_Pintscher closed subtask T268397: (MS 2) concatenate multiple query 
blocks/conditions with AND as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Lydia_Pintscher]

Lydia_Pintscher added a subscriber: Charlie_WMDE.
Lydia_Pintscher added a comment.


  @Ladsgroup See 
https://www.figma.com/file/hZpaYX0xNNhK0L7kBvN6WK/Query-Builder?node-id=1367%3A22573
 for general idea. Not sure about the exact specs. @Charlie_WMDE will have 
those.

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Ladsgroup]

Ladsgroup added a comment.


  This doesn't a design spec attached to it. Am I missing something? (I was 
thinking of implementing it without design system for now, with less than 
optimal look) but can't find any design to get some inspiration from :D

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, Aklapper, Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Lydia_Pintscher]

Lydia_Pintscher set the point value for this task to "8".

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Aklapper, Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Lydia_Pintscher]

Lydia_Pintscher updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Aklapper, Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Lydia_Pintscher]

Lydia_Pintscher added a subtask: T268658: Create Quiet icon-only button 
component.

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Aklapper, Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Lydia_Pintscher]

Lydia_Pintscher added a subtask: T268397: (MS 2) concatenate multiple query 
blocks/conditions with AND.

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Aklapper, Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268982: (MS 2) remove a query block/condition

[Lydia_Pintscher]

Lydia_Pintscher created this task.
Lydia_Pintscher added a project: Wikidata Query Builder.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION
  As an editor I want to be able to remove query conditions I added to my 
visual query if they are no longer useful.
  
  **Problem:**
  People can add query blocks but not remove them. Not good.
  
  **Screenshots/mockups:**
  TODO
  
  **BDD**
  GIVEN an existing visual query 
  THEN I can remove an existing condition unless it is the last remaining 
condition
  
  **Acceptance criteria:**
  
  [ ] query conditions can be removed from a query until at least 1 condition 
remains

TASK DETAIL
  https://phabricator.wikimedia.org/T268982

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Aklapper, Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs