[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

Charlie_WMDE closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T270712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Charlie_WMDE Cc: amy_rc, Charlie_WMDE, Sarai-WMDE, Michael, Lydia_Pintscher, Aklapper,

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

Lydia_Pintscher moved this task from Wikidata Query Builder - sprint 6 to Peer Review on the Wikidata Query Builder board. Lydia_Pintscher edited projects, added Wikidata Query Builder; removed Wikidata Query Builder (Wikidata Query Builder - sprint 6). TASK DETAIL

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

Michael added a comment. In T270712#6747720 , @Charlie_WMDE wrote: > Sorry, just noticed one more thing! > > The margin between the checkbox and the "add condition" button is missing as can be seen here

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

Charlie_WMDE moved this task from Done to Test (Verification) on the Wikidata Query Builder (Wikidata Query Builder - sprint 6) board. Charlie_WMDE added a comment. Sorry, just noticed one more thing! The margin between the checkbox and the "add condition" button is missing as can be

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

Charlie_WMDE reopened this task as "Open". TASK DETAIL https://phabricator.wikimedia.org/T270712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Charlie_WMDE Cc: amy_rc, Charlie_WMDE, Sarai-WMDE, Michael, Lydia_Pintscher, Aklapper,

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

Charlie_WMDE closed this task as "Resolved". Charlie_WMDE moved this task from Test (Verification) to Done on the Wikidata Query Builder (Wikidata Query Builder - sprint 6) board. Charlie_WMDE added a comment. looks great, thanks! TASK DETAIL https://phabricator.wikimedia.org/T270712

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

Michael moved this task from Doing to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 6) board. Michael added a comment. https://github.com/wmde/query-builder/pull/149 TASK DETAIL https://phabricator.wikimedia.org/T270712 WORKBOARD

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

Michael moved this task from Test (Verification) to Doing on the Wikidata Query Builder (Wikidata Query Builder - sprint 6) board. Michael added a comment. In T270712#6743184 , @amy_rc wrote: > Observations: > > 1. When removing the

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

amy_rc added a comment. Observations: F33997725: image.png TASK DETAIL https://phabricator.wikimedia.org/T270712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, amy_rc Cc: amy_rc,

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

Charlie_WMDE added a comment. just realised this is strictly the UI ticket, not including the functionality. sorry about that! TASK DETAIL https://phabricator.wikimedia.org/T270712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael,

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

Charlie_WMDE added a comment. When i try to run the query with letters instead of a number, it's as if the checkbox isn't selected at all ie. i get all the results. I understand we won't do validation in this ticket, but the fallback behavior should be the default setting imo which is a

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

Michael moved this task from Doing to Peer Review on the Wikidata Query Builder (Wikidata Query Builder - sprint 6) board. Michael added a comment. https://github.com/wmde/query-builder/pull/146 TASK DETAIL https://phabricator.wikimedia.org/T270712 WORKBOARD

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

Michael claimed this task. Michael moved this task from To Do to Doing on the Wikidata Query Builder (Wikidata Query Builder - sprint 6) board. Restricted Application added a project: User-Michael. TASK DETAIL https://phabricator.wikimedia.org/T270712 WORKBOARD

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

guergana.tzatchkova added a comment. @Lydia_Pintscher The missing point you mention is part of the validation / number component. I think we should create a separate ticket for that TASK DETAIL https://phabricator.wikimedia.org/T270712 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

Lydia_Pintscher moved this task from Test (Verification) to To Do on the Wikidata Query Builder (Wikidata Query Builder - sprint 6) board. Lydia_Pintscher added a subscriber: i_amy. Lydia_Pintscher added a comment. @i_amy and I looked at it: - The limiting works \o/ - I don't think we

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

Sarai-WMDE added a comment. Do we want to implement the following TextInput behaviour as part of this task? These are specs we discussed in our catch up, but were only added to the main story (T270179 ): - Displaying a placeholder (instead of

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

Michael added a comment. Note for verification: **Only the functionality should be verified for now.** The validation has been postponed until development work on the Quantity component has started and we know the capabilities of the NumberInput used therein. Consequently, this is just a

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

guergana.tzatchkova closed subtask T270765: Use Limit Component as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T270712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova Cc: Lydia_Pintscher, Aklapper,

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

Lydia_Pintscher moved this task from Wikidata Query Builder - sprint 5 to Wikidata Query Builder - sprint 6 on the Wikidata Query Builder board. Lydia_Pintscher edited projects, added Wikidata Query Builder (Wikidata Query Builder - sprint 6); removed Wikidata Query Builder (Wikidata Query

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

Lydia_Pintscher closed subtask T270760: Create Limit component as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T270712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova, Lydia_Pintscher Cc: Lydia_Pintscher, Aklapper,

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

guergana.tzatchkova added a comment. https://github.com/wmde/query-builder/pull/118 TASK DETAIL https://phabricator.wikimedia.org/T270712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova Cc: Lydia_Pintscher, Aklapper,

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

guergana.tzatchkova updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T270712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova Cc: Lydia_Pintscher, Aklapper, guergana.tzatchkova, Manishsamota, Akuckartz,

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

guergana.tzatchkova updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T270712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova Cc: Lydia_Pintscher, Aklapper, guergana.tzatchkova, Manishsamota, Akuckartz,

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

guergana.tzatchkova claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T270712 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova Cc: Lydia_Pintscher, Aklapper, guergana.tzatchkova, Manishsamota, Akuckartz, Nandana,

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

guergana.tzatchkova moved this task from Incoming to Wikidata Query Builder - sprint 5 on the Wikidata Query Builder board. guergana.tzatchkova edited projects, added Wikidata Query Builder (Wikidata Query Builder - sprint 5); removed Wikidata Query Builder. TASK DETAIL

[Wikidata-bugs] [Maniphest] T270712: add limit ui elements to QB

guergana.tzatchkova created this task. guergana.tzatchkova added projects: Wikidata, Wikidata Query Builder. TASK DESCRIPTION *add dummy checkbox that will be replaced by checkbox component from Wikit once it is finished - use TextInput component - TextInput has the default = 100 if the