[Wikidata-bugs] [Maniphest] T272130: consider moving the repository from github to gerrit

2021-01-29 Thread Ladsgroup 
Ladsgroup added a project: Security-Team.
Ladsgroup added a comment.


  Hello security team, it would be great if we can have a comment on this 
ticket on whether it's okay to have it on github or not. We are planning to 
deploy this to production as a static site.

TASK DETAIL
  https://phabricator.wikimedia.org/T272130

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Michael, Ladsgroup, Jakob_WMDE, DannyS712, Aklapper, Lydia_Pintscher, 
Devnull, Akuckartz, Dsharpe, Nandana, sbassett, Lahi, Gq86, GoranSMilovanovic, 
QZanden, EBjune, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Luke081515, Wikidata-bugs, aude, Bawolff, csteipp, Mbch331, Rxy, Jay8g, 
Krenair, chasemp
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T272130: consider moving the repository from github to gerrit

2021-01-29 Thread Michael 
Michael added a comment.


  In T272130#6777630 , 
@Ladsgroup wrote:
  
  > I can ask security team to comment
  
  Yes, an official statement from them would be appreciated.

TASK DETAIL
  https://phabricator.wikimedia.org/T272130

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Ladsgroup, Jakob_WMDE, DannyS712, Aklapper, Lydia_Pintscher, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T272130: consider moving the repository from github to gerrit

2021-01-26 Thread Lydia_Pintscher 
Lydia_Pintscher triaged this task as "Medium" priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T272130

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4990/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Michael, Ladsgroup, Jakob_WMDE, DannyS712, Aklapper, Lydia_Pintscher, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T272130: consider moving the repository from github to gerrit

2021-01-26 Thread Ladsgroup 
Ladsgroup added a comment.


  Automated mirroring to diffusion is a no-go and got banned already by wmf 
security. Termbox is now migrated to gerrit. We can have the deploy repo in 
gerrit and manually deploy it (similar to what's happening to wdqs gui) but 
still it's better to keep it under github.com/wikimedia org IMO (mostly because 
of access rules and reducing attack vectors).
  
  Options:
  
  - Move it to gerrit
  - Keep it in github but have a deploy repo manually updated in gerrit.
- If it's going to stay in github: It can be in wikimedia or wmde. It's 
going to be complicated. IIRC security team really wants the code to be in one 
org so they can apply the same policies (like mandatory 2FA for admins) and 
also reducing the attack vector.
  
  For original development, it made sense since the CI was pretty easy to setup 
but if we want to deploy this in WMF production, I think it makes sense to move 
it to gerrit due to security and integration reasons. I don't know about 
others. I can ask security team to comment

TASK DETAIL
  https://phabricator.wikimedia.org/T272130

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Michael, Ladsgroup, Jakob_WMDE, DannyS712, Aklapper, Lydia_Pintscher, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T272130: consider moving the repository from github to gerrit

2021-01-20 Thread Michael 
Michael added a comment.


  Things to maybe do:
  
  [ ] come up with a list of options
  [ ] talk to engineering managers about what to do
  [ ] talk to other wmde engineers about what to do
  [ ] maybe talk to wmf security people about what is required for security 
approval
  - ...

TASK DETAIL
  https://phabricator.wikimedia.org/T272130

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Ladsgroup, Jakob_WMDE, DannyS712, Aklapper, Lydia_Pintscher, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T272130: consider moving the repository from github to gerrit

2021-01-19 Thread Jakob_WMDE 
Jakob_WMDE added a comment.


  In T272130#6756811 , 
@Ladsgroup wrote:
  
  > I don't know why we decided to go with github (maybe @Jakob_WMDE 
remembers?) I'm definitely fine with moving to gerrit.
  
  IIRC we chose github over gerrit to keep code review on one platform (with 
wikit) and for the easier CI setup. We also said if for production we need it 
to be on a WMF-hosted server, we could mirror it to Diffusion as we did for 
Termbox before.

TASK DETAIL
  https://phabricator.wikimedia.org/T272130

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jakob_WMDE
Cc: Ladsgroup, Jakob_WMDE, DannyS712, Aklapper, Lydia_Pintscher, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T272130: consider moving the repository from github to gerrit

2021-01-18 Thread Ladsgroup 
Ladsgroup added subscribers: Jakob_WMDE, Ladsgroup.
Ladsgroup added a comment.


  I don't know why we decided to go with github (maybe @Jakob_WMDE remembers?) 
I'm definitely fine with moving to gerrit.

TASK DETAIL
  https://phabricator.wikimedia.org/T272130

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, Jakob_WMDE, DannyS712, Aklapper, Lydia_Pintscher, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T272130: consider moving the repository from github to gerrit

2021-01-15 Thread Lydia_Pintscher 
Lydia_Pintscher created this task.
Lydia_Pintscher added a project: Wikidata Query Builder.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION
  As part of getting ready for deployment of the Query Builder we should 
consider moving the code from github to a gerrit repository.

TASK DETAIL
  https://phabricator.wikimedia.org/T272130

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Aklapper, Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs