[Wikidata-bugs] [Maniphest] T272329: EntitySchema tests are failing on master

2021-01-20 Thread matmarex
matmarex removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T272329 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, matmarex Cc: Addshore, Ladsgroup, WMDE-leszek, matmarex, Aklapper, SCIdude, Aku

[Wikidata-bugs] [Maniphest] T272329: EntitySchema tests are failing on master

2021-01-20 Thread matmarex
matmarex added a comment. Thanks! TASK DETAIL https://phabricator.wikimedia.org/T272329 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, matmarex Cc: Addshore, Ladsgroup, WMDE-leszek, matmarex, Aklapper, Alter-paule, Beast1

[Wikidata-bugs] [Maniphest] T272329: EntitySchema tests are failing on master

2021-01-20 Thread Ladsgroup
Ladsgroup moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Ladsgroup closed this task as "Resolved". Ladsgroup added a comment. The browser test is unrelated and it's caused by the patch itself. A noop change on master passes ^.

[Wikidata-bugs] [Maniphest] T272329: EntitySchema tests are failing on master

2021-01-20 Thread gerritbot
gerritbot added a comment. Change 657352 **abandoned** by Ladsgroup: [mediawiki/extensions/EntitySchema@master] [DNM] Test jenkins on master Reason: https://gerrit.wikimedia.org/r/657352 TASK DETAIL https://phabricator.wikimedia.org/T272329 EMAIL PREFERENCES https://phabricato

[Wikidata-bugs] [Maniphest] T272329: EntitySchema tests are failing on master

2021-01-20 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26). TASK DETAIL https://phabricator.wikimedia.org/T272329 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot Cc: Addshore, Ladsgroup, WMDE-l

[Wikidata-bugs] [Maniphest] T272329: EntitySchema tests are failing on master

2021-01-20 Thread gerritbot
gerritbot added a comment. Change 657352 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/EntitySchema@master] [DNM] Test jenkins on master https://gerrit.wikimedia.org/r/657352 TASK DETAIL https://phabricator.wikimedia.org/T272329 EMAIL PREFE

[Wikidata-bugs] [Maniphest] T272329: EntitySchema tests are failing on master

2021-01-20 Thread gerritbot
gerritbot added a comment. Change 657344 **merged** by jenkins-bot: [mediawiki/extensions/EntitySchema@master] Fix EntitySchemaSlotDiffRendererTest for diff marker change https://gerrit.wikimedia.org/r/657344 TASK DETAIL https://phabricator.wikimedia.org/T272329 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T272329: EntitySchema tests are failing on master

2021-01-20 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T272329 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, gerritbot Cc: Addshore, Ladsgroup, WMDE-leszek, matmarex, Aklapper, Alter-paule,

[Wikidata-bugs] [Maniphest] T272329: EntitySchema tests are failing on master

2021-01-20 Thread gerritbot
gerritbot added a comment. Change 657344 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/EntitySchema@master] Fix EntitySchemaSlotDiffRendererTest for diff marker change https://gerrit.wikimedia.org/r/657344 TASK D

[Wikidata-bugs] [Maniphest] T272329: EntitySchema tests are failing on master

2021-01-20 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T272329 WORKBOARD https://phabricator.wikimedia.

[Wikidata-bugs] [Maniphest] T272329: EntitySchema tests are failing on master

2021-01-19 Thread matmarex
matmarex added a comment. I don't think that's needed right now, I would just update the tests if that's the only thing that's required to make them stop failing. There are also some Selenium test failures which look more "interesting". TASK DETAIL https://phabricator.wikimedia.org/T27

[Wikidata-bugs] [Maniphest] T272329: EntitySchema tests are failing on master

2021-01-19 Thread Ladsgroup
Ladsgroup added a comment. The tests for diff renderer is really fragile. it'll break with basically every change in diff renderer (it also breaks with change of wiki's language). It needs a rework... TASK DETAIL https://phabricator.wikimedia.org/T272329 EMAIL PREFERENCES https://phabri

[Wikidata-bugs] [Maniphest] T272329: EntitySchema tests are failing on master

2021-01-19 Thread Ladsgroup
Ladsgroup added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞). Ladsgroup added a comment. Yes, it's correct. I'm incident manager for wikidata team this week. I see how this can be moved forward. TASK DETAIL https://phabricator.wikimedia.org/T272329 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] T272329: EntitySchema tests are failing on master

2021-01-18 Thread matmarex
matmarex created this task. matmarex added a project: Shape Expressions. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION EntitySchema tests are failing on master. This patch should not be failing the tests: https://ger