[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

amy_rc closed this task as "Resolved". amy_rc added a comment.  closing the ticket as the investigation is done. TASK DETAIL https://phabricator.wikimedia.org/T273039 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete, amy_rc Cc: amy_rc,

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

bete added a comment. In T273039#676 , @Sarai-WMDE wrote: >> It is entirely possible to instead have a prop that says something like inheritStyles=true or isStandalone=false. > > The prop option sounds good to me too. > >

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

Sarai-WMDE added a comment. > It is entirely possible to instead have a prop that says something like inheritStyles=true or isStandalone=false. The prop option sounds good to me too. Can we consider the investigation done, then? I'd update the component ticket accordingly. Thanks

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

bete added a comment. In T273039#6799706 , @ItamarWMDE wrote: >> We could, in the future, extend that to support routing libraries like vue-router. > > This argument is enough to win me over. Usually I'm not in favor of creating

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

ItamarWMDE added a comment. > We could, in the future, extend that to support routing libraries like vue-router. This argument is enough to win me over. Usually I'm not in favor of creating components simply for styling purposes, and since we already expose a global CSS file that is

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

bete added a comment. In T273039#6799656 , @Michael wrote: > In T273039#6799614 , @Sarai-WMDE wrote: > >> Is it safe to assume that we'd probably need two link variants then? A

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

Michael added a comment. In T273039#6799614 , @Sarai-WMDE wrote: > Is it safe to assume that we'd probably need two link variants then? A //Link// (with its own, autonomous style – e.g. our "Show query in the Query Service") and an

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

Sarai-WMDE added a comment. The color of links should never be inherited, exactly; only the font-family, size, weight and line-height of embedded links should be adjusted. Is it safe to assume that we'd probably need two link variants then? A //Link// (with its own, autonomous style –

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

Michael added a comment. In T273039#6799559 , @Sarai-WMDE wrote: > Regarding the component approach, and related to the second criteria: how can we make sure the component is embeddable? Meaning, that it can inherit the styles of

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

Sarai-WMDE added a comment. Itamar and I had only an initial discussion on Mattermost, where the working idea of creating the WiKit link as a set of classes rather than as a component was introduced by him. I later brought up that approach to the hike while looking at the Link component

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

bete added a comment. @Michael unfortunately , I don't have the notes, as I was note part of the meeting. but maybe @Sarai-WMDE has them ? TASK DETAIL https://phabricator.wikimedia.org/T273039 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

Michael added a comment. In T273039#6799165 , @bete wrote: > @Michael yes! future extensions are another good reason for components. > I believe @ItamarWMDE and @Sarai-WMDE already had a deep dive into this topic. but maybe with the

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

bete added a comment. @Michael yes! future extensions are another good reason for components. I believe @ItamarWMDE and @Sarai-WMDE already had a deep dive into this topic. but maybe with the points mentioned above, that might help them get closer to a decision TASK DETAIL

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

Michael added a subscriber: ItamarWMDE. Michael added a comment. I looked it up and vuetify uses their button component v-btn for links, which is The Wrong Thing To Do. So that isn't providing any insight for us. While I also slightly lean towards a

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

bete added a comment. @Lydia_Pintscher I put all my findings here. please feel free if you've any questions TASK DETAIL https://phabricator.wikimedia.org/T273039 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: bete, Michael,

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

bete added a comment. **conclusion:** As far as implementation goes, there doesn't seem to be too much technical difficulty in going either way. echoing on some of the points @Michael mentioned above, I'll list some of the pros and cons. I haven't found much info on veutify but on

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

bete added a comment. Implementation using props (vue components) can be accomplished easily. an example can be found here TASK DETAIL https://phabricator.wikimedia.org/T273039 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

bete added a comment. **regarding the second acceptance criteria:** Its a much rarer case. However, we can expand our mixin to accept a third parameter (font-size) to override the size. default value can just be set to 'inherit' so the link can inherit the font-size of the parent. TASK

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

bete added a comment. So far, I focused mostly on implementation using mixing (since we have more experience with the component approach). **regarding the first criteria**, mentioned above: It's possible to achieve the desired effect with mixins. code snippet: @mixin

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T273039 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete, Sarai-WMDE Cc: bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, Lydia_Pintscher, Akuckartz, Nandana,

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

bete claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T273039 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc: bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86,

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

bete added a comment. In T273039#6790844 , @Michael wrote: > Some initial brainstormy thoughts: > > Pro Component > > - better abstraction/encapsulation of "internals" > - same argument as to why a button is a DS component and

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

Michael added a comment. Some initial brainstormy thoughts: Pro Component - better abstraction/encapsulation of "internals" - same argument as to why a button is a DS component and not just a set of styles - could maybe apply //some// validation on the URL to prevent mistakes

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

Lydia_Pintscher renamed this task from "investigation: links as components vs. reusable styles" to "investigation: links as components vs. reusable styles [timebox: 1d]". Lydia_Pintscher added a project: Wikidata Design System. Lydia_Pintscher updated the task description. TASK DETAIL