[Wikidata-bugs] [Maniphest] T275542: (MS 6) using the tooltip component in the QB

2021-04-01 Thread amy_rc
amy_rc closed this task as "Resolved". amy_rc added a comment. As we have tickets for 'keyboard support and responsiveness' , closing this ticket. 🎇 TASK DETAIL https://phabricator.wikimedia.org/T275542 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] T275542: (MS 6) using the tooltip component in the QB

2021-03-30 Thread Ladsgroup
Ladsgroup added a comment. so for keyboard support and responsiveness, we have tickets in the process to be tackled. Can we call this done or should we do something else first? TASK DETAIL https://phabricator.wikimedia.org/T275542 EMAIL PREFERENCES https://phabricator.wikimedia.org/setti

[Wikidata-bugs] [Maniphest] T275542: (MS 6) using the tooltip component in the QB

2021-03-30 Thread Sarai-WMDE
Sarai-WMDE added a comment. Following up on @Charlie_WMDE 's comment: > the popover should also close off-focus, right? sure! we decided to document the missing keyboard navigation events of the popover component in T277738 > not being

[Wikidata-bugs] [Maniphest] T275542: (MS 6) using the tooltip component in the QB

2021-03-19 Thread Charlie_WMDE
Charlie_WMDE added a comment. behavior seems fine. the lack of border on focus and not being read by the screen reader should be fixed. the popover should also close off-focus, right? when navigating via keyboard and selecting the popover, it stays open, even when i move on to select ano

[Wikidata-bugs] [Maniphest] T275542: (MS 6) using the tooltip component in the QB

2021-03-19 Thread Ladsgroup
Ladsgroup added a comment. I'm pretty sure it worked before merging. Maybe broke with the new wikit? :( TASK DETAIL https://phabricator.wikimedia.org/T275542 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Sarai-WMDE, Ladsgroup, Mich

[Wikidata-bugs] [Maniphest] T275542: (MS 6) using the tooltip component in the QB

2021-03-19 Thread Michael
Michael added a comment. In T275542#6928039 , @Sarai-WMDE wrote: > It looks like the popover trigger button is not receiving focus on tab anymore. I receives focus, but no border or anything is shown. That's not ideal and we surely

[Wikidata-bugs] [Maniphest] T275542: (MS 6) using the tooltip component in the QB

2021-03-19 Thread Sarai-WMDE
Sarai-WMDE added a comment. It looks like the popover trigger button is not receiving focus on tab anymore. I also noticed that the order of the keyboard navigation on the Property and Value fields should be corrected, since the fields' label is not announced before the focus is placed

[Wikidata-bugs] [Maniphest] T275542: (MS 6) using the tooltip component in the QB

2021-03-15 Thread amy_rc
amy_rc closed subtask T274346: Add named slot for icon to Design System components with label as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T275542 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, amy_rc Cc: Ladsgroup, Michae

[Wikidata-bugs] [Maniphest] T275542: (MS 6) using the tooltip component in the QB

2021-03-11 Thread Ladsgroup
Ladsgroup moved this task from Doing to Peer Review on the Wikidata Query Builder board. Ladsgroup added a comment. https://github.com/wmde/query-builder/pull/216 TASK DETAIL https://phabricator.wikimedia.org/T275542 WORKBOARD https://phabricator.wikimedia.org/project/board/4990/ EMAIL

[Wikidata-bugs] [Maniphest] T275542: (MS 6) using the tooltip component in the QB

2021-03-10 Thread Ladsgroup
Ladsgroup added a comment. Thanks. It needs a pre-release. I do it. TASK DETAIL https://phabricator.wikimedia.org/T275542 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Ladsgroup, Michael, bete, Aklapper, Charlie_WMDE, maantietaja,

[Wikidata-bugs] [Maniphest] T275542: (MS 6) using the tooltip component in the QB

2021-03-10 Thread bete
bete added a comment. @Ladsgroup the DS ticket is merged now , FYI TASK DETAIL https://phabricator.wikimedia.org/T275542 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, bete Cc: Ladsgroup, Michael, bete, Aklapper, Charlie_WMDE, maantiet

[Wikidata-bugs] [Maniphest] T275542: (MS 6) using the tooltip component in the QB

2021-03-09 Thread Ladsgroup
Ladsgroup renamed this task from "(MS 6) 🛑 using the tooltip component in the QB" to "(MS 6) using the tooltip component in the QB". TASK DETAIL https://phabricator.wikimedia.org/T275542 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: L

[Wikidata-bugs] [Maniphest] T275542: (MS 6) using the tooltip component in the QB

2021-03-09 Thread Michael
Michael added a comment. Decided not to break it down into sub-tasks. All is done in this ticket. Steps to do: [ ] create a `InfoTooltip` component in Query Builder consisting of the `Icon` (`info-outlined`) and the `Popover` - c.f. the exact specs in the mocks

[Wikidata-bugs] [Maniphest] T275542: (MS 6) using the tooltip component in the QB

2021-03-09 Thread amy_rc
amy_rc closed subtask T273041: (MS 6) Create popover component as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T275542 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: amy_rc Cc: bete, Aklapper, Charlie_WMDE, maantietaja, Akuckartz, Nanda

[Wikidata-bugs] [Maniphest] T275542: (MS 6) using the tooltip component in the QB

2021-03-09 Thread bete
bete added a comment. this PR has to be merged and released first, before starting this ticket TASK DETAIL https://phabricator.wikimedia.org/T275542 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete Cc:

[Wikidata-bugs] [Maniphest] T275542: (MS 6) using the tooltip component in the QB

2021-03-09 Thread Charlie_WMDE
Charlie_WMDE renamed this task from "(MS 6) tooltips for some of the UI components" to "(MS 6) using the tooltip component in the QB". Charlie_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T275542 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings