[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase

Michael added a comment. Makes sense, thanks! Running a codesearch with the regex from the description does reveal new matches, but they are all in the two categories already mentioned above: phpunit XML syntax and the spam-blacklist name:

[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase

Lucas_Werkmeister_WMDE added a comment. I think `NoBadUsageTestBase` would work for cases where we want to prevent PHP things (e.g. `DB_MASTER` instead of `DB_PRIMARY`), but for such a general check, I’m not convinced it’s worth checking automatically. TASK DETAIL

[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase

Michael added a subscriber: Lucas_Werkmeister_WMDE. Michael added a comment. In T277971#9607911 , @Reedy wrote: > [...] > > If someone has double checked that no new instances (that again are first party, and can be fixed) have come

[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase

Reedy added a comment. I think as long as the first party ones are fixed, that's the main thing. Tasks like T254650: Rename TitleBlacklist and T254649: Rename SpamBlacklist exist to fix those

[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase

Michael added a comment. The stylelint one has been fixed in the meantime. From looking at the description, all the remaining occurrences are either 1) upstream-syntax (phpunit) or 2) directly referencing upstream syntax or naming (SpamBlacklist, phpunit.xml's whitelist) How do we

[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase

JArguello-WMF added a comment. Hi, @Reedy and @toan, I'm trying to use T-shirt sizes to measure the effort required for each task to invite folks at the WMF to join and decide which ones they'd like to tackle by giving them information about the effort and any other info you consider

[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T277971 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Aklapper, Reedy, Invadibot, maantietaja, Akuckartz, darthmon_wmde, Nandana,

[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase

gerritbot added a comment. Change 673657 **merged** by jenkins-bot: [wikibase/termbox@master] Improve wording of a comment https://gerrit.wikimedia.org/r/673657 TASK DETAIL https://phabricator.wikimedia.org/T277971 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase

Reedy updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T277971 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Reedy Cc: Aklapper, Reedy, Invadibot, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696,

[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T277971 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Aklapper, Reedy, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696,

[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase

gerritbot added a comment. Change 673657 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [wikibase/termbox@master] Improve wording of a comment https://gerrit.wikimedia.org/r/673657 TASK DETAIL https://phabricator.wikimedia.org/T277971 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T277971: Address Voice and Tone issues in Wikibase

Reedy created this task. Reedy added projects: Voice & Tone, Wikibase, MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-WikibaseClient. Restricted Application added a project: Wikidata. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T277971 EMAIL PREFERENCES