[Wikidata-bugs] [Maniphest] T278962: allow sitelinks to redirects if redirect badge is used

[Lydia_Pintscher]

Lydia_Pintscher updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T278962

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: amy_rc, Mohammed_Sadat_WMDE, Bugreporter, Lea_Lacroix_WMDE, Taylor, 
Lucas_Werkmeister_WMDE, Addshore, Jakob_WMDE, MSGJ, Simon_Villeneuve, 
ChristianKl, Eugene, seav, kaldari, Naseweis520, Fuzheado, Gamaliel, 
ItamarWMDE, Ladsgroup, DemonDays64, DannyS712, JAnD, Hsarrazin, deryckchan, 
agray, MisterSynergy, Liuxinyu970226, Delasse, Jheald, Aklapper, 
Lydia_Pintscher, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T278962: allow sitelinks to redirects if redirect badge is used

[Lydia_Pintscher]

Lydia_Pintscher added a comment.


  Automatically adding badges based on a magicwork on the client is quite a 
different can of worms. It would involve considerably more work than I can 
justify here to get it to the state where it does what people expect incl. 
querying for sitelinks with those badges. Given that we've been trying to find 
a solution for this for years and people are rightfully complaining that this 
hasn't been solved in a long time I think we need to go ahead as laid out in 
the task description. It is not the perfect solution but one we can make happen 
now.

TASK DETAIL
  https://phabricator.wikimedia.org/T278962

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Bugreporter, Lea_Lacroix_WMDE, Taylor, Lucas_Werkmeister_WMDE, Addshore, 
Jakob_WMDE, MSGJ, Simon_Villeneuve, ChristianKl, Eugene, seav, kaldari, 
Naseweis520, Fuzheado, Gamaliel, ItamarWMDE, Ladsgroup, DemonDays64, DannyS712, 
JAnD, Hsarrazin, deryckchan, agray, MisterSynergy, Liuxinyu970226, Delasse, 
Jheald, Aklapper, Lydia_Pintscher, Invadibot, maantietaja, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T278962: allow sitelinks to redirects if redirect badge is used

[Taylor]

Taylor added a comment.


  **Support**. Discard the badges and use `__VALIDREDIRECT__` instead. Let 
wikidata autodetect "redirect to page" vs "redirect to section" and display 
appropriate icon, and autodetect `__VALIDREDIRECT__` too resulting in 
"intentional redirect" vs "dubious redirect" (redirect but magic word missing) 
vs "misuse of VALIDREDIRECT" (target is an empty page, or a redirect, or a page 
(not section) not linked to wikidata). I do not see the point with "Q16956589" 
either. Make it as simple as possible. The originally intended solution with 2 
independent badges allows for a large number of dubious states.

TASK DETAIL
  https://phabricator.wikimedia.org/T278962

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Taylor
Cc: Bugreporter, Lea_Lacroix_WMDE, Taylor, Lucas_Werkmeister_WMDE, Addshore, 
Jakob_WMDE, MSGJ, Simon_Villeneuve, ChristianKl, Eugene, seav, kaldari, 
Naseweis520, Fuzheado, Gamaliel, ItamarWMDE, Ladsgroup, DemonDays64, DannyS712, 
JAnD, Hsarrazin, deryckchan, agray, MisterSynergy, Liuxinyu970226, Delasse, 
Jheald, Aklapper, Lydia_Pintscher, Invadibot, maantietaja, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T278962: allow sitelinks to redirects if redirect badge is used

[Bugreporter]

Bugreporter added a comment.


  My original idea (before the badge exists) is if user added a sitelink to a 
redirect page tagged with a magic word, Wikibase software will no longer follow 
the redirect (see 
https://www.wikidata.org/wiki/Wikidata:Requests_for_comment/Allow_the_creation_of_links_to_redirects_in_Wikidata#Support
 #49). Introduce a badge may be helpful, but it may be a problem if a redirect 
is turned to an article or vice versa.

TASK DETAIL
  https://phabricator.wikimedia.org/T278962

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Bugreporter
Cc: Bugreporter, Lea_Lacroix_WMDE, Taylor, Lucas_Werkmeister_WMDE, Addshore, 
Jakob_WMDE, MSGJ, Simon_Villeneuve, ChristianKl, Eugene, seav, kaldari, 
Naseweis520, Fuzheado, Gamaliel, ItamarWMDE, Ladsgroup, DemonDays64, DannyS712, 
JAnD, Hsarrazin, deryckchan, agray, MisterSynergy, Liuxinyu970226, Delasse, 
Jheald, Aklapper, Lydia_Pintscher, Invadibot, maantietaja, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T278962: allow sitelinks to redirects if redirect badge is used

[Jheald]

Jheald added a comment.


  On many wikipedias the template "wikidata redirect' is available : 
https://www.wikidata.org/wiki/Q16956589

TASK DETAIL
  https://phabricator.wikimedia.org/T278962

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jheald
Cc: Bugreporter, Lea_Lacroix_WMDE, Taylor, Lucas_Werkmeister_WMDE, Addshore, 
Jakob_WMDE, MSGJ, Simon_Villeneuve, ChristianKl, Eugene, seav, kaldari, 
Naseweis520, Fuzheado, Gamaliel, ItamarWMDE, Ladsgroup, DemonDays64, DannyS712, 
JAnD, Hsarrazin, deryckchan, agray, MisterSynergy, Liuxinyu970226, Delasse, 
Jheald, Aklapper, Lydia_Pintscher, Invadibot, maantietaja, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T278962: allow sitelinks to redirects if redirect badge is used

[Bugreporter]

Bugreporter added a comment.


  I think we should tag the local pages with a specific magic word like 
`__VALIDREDIRECT__`.

TASK DETAIL
  https://phabricator.wikimedia.org/T278962

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Bugreporter
Cc: Bugreporter, Lea_Lacroix_WMDE, Taylor, Lucas_Werkmeister_WMDE, Addshore, 
Jakob_WMDE, MSGJ, Simon_Villeneuve, ChristianKl, Eugene, seav, kaldari, 
Naseweis520, Fuzheado, Gamaliel, ItamarWMDE, Ladsgroup, DemonDays64, DannyS712, 
JAnD, Hsarrazin, deryckchan, agray, MisterSynergy, Liuxinyu970226, Delasse, 
Jheald, Aklapper, Lydia_Pintscher, Invadibot, maantietaja, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T278962: allow sitelinks to redirects if redirect badge is used

[Jheald]

Jheald added a comment.


  Re not removing a badge :  note that it may be important for a user or bot to 
be able to //change// a badge, in particular from 'sitelink to redirect' 
(Q70893996) to 'intentional sitelink to redirect' (Q70894304), if the user 
determines that the redirect is valuable.
  
  I'm not sure I'd lose too much sleep about users potentially removing badges, 
given that most redirects are currently unbadged, and quite possibly sitelinks 
to new redirects created by merges on wikipedias may not be badged.

TASK DETAIL
  https://phabricator.wikimedia.org/T278962

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jheald
Cc: Lea_Lacroix_WMDE, Taylor, Lucas_Werkmeister_WMDE, Addshore, Jakob_WMDE, 
MSGJ, Simon_Villeneuve, ChristianKl, Eugene, seav, kaldari, Naseweis520, 
Fuzheado, Gamaliel, ItamarWMDE, Ladsgroup, DemonDays64, DannyS712, JAnD, 
Hsarrazin, deryckchan, agray, MisterSynergy, Liuxinyu970226, Delasse, Jheald, 
Aklapper, Lydia_Pintscher, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T278962: allow sitelinks to redirects if redirect badge is used

[Lydia_Pintscher]

Lydia_Pintscher updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T278962

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Taylor, Lucas_Werkmeister_WMDE, Addshore, Jakob_WMDE, MSGJ, 
Simon_Villeneuve, ChristianKl, Eugene, seav, kaldari, Naseweis520, Fuzheado, 
Gamaliel, ItamarWMDE, Ladsgroup, DemonDays64, DannyS712, JAnD, Hsarrazin, 
deryckchan, agray, MisterSynergy, Liuxinyu970226, Delasse, Jheald, Aklapper, 
Lydia_Pintscher, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T278962: allow sitelinks to redirects if redirect badge is used

[Lydia_Pintscher]

Lydia_Pintscher updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T278962

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Taylor, Lucas_Werkmeister_WMDE, Addshore, Jakob_WMDE, MSGJ, 
Simon_Villeneuve, ChristianKl, Eugene, seav, kaldari, Naseweis520, Fuzheado, 
Gamaliel, ItamarWMDE, Ladsgroup, DemonDays64, DannyS712, JAnD, Hsarrazin, 
deryckchan, agray, MisterSynergy, Liuxinyu970226, Delasse, Jheald, Aklapper, 
Lydia_Pintscher, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T278962: allow sitelinks to redirects if redirect badge is used

[Lydia_Pintscher]

Lydia_Pintscher added a comment.


  In T278962#6961465 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > I assume removing the badge from a sitelink should be disallowed if the 
target page is (currently) a redirect?
  
   good catch. Will add to the description.

TASK DETAIL
  https://phabricator.wikimedia.org/T278962

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Taylor, Lucas_Werkmeister_WMDE, Addshore, Jakob_WMDE, MSGJ, 
Simon_Villeneuve, ChristianKl, Eugene, seav, kaldari, Naseweis520, Fuzheado, 
Gamaliel, ItamarWMDE, Ladsgroup, DemonDays64, DannyS712, JAnD, Hsarrazin, 
deryckchan, agray, MisterSynergy, Liuxinyu970226, Delasse, Jheald, Aklapper, 
Lydia_Pintscher, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T278962: allow sitelinks to redirects if redirect badge is used

[Taylor]

Taylor added a comment.


  > I assume removing the badge from a sitelink should be disallowed if the 
target page is (currently) a redirect?
  
  Sure.
  
  Some further thougts:
  
  
https://www.wikidata.org/wiki/Wikidata:Project_chat#BUG:_%22intentional_sitelink_to_redirect%22_does_not_work
  
  Instead of 2 independent badges giving 4 possible values, create just 1 with 
2 mutually exclusive values:
  
  - deliberate redirect
  - dubious redirect (should be strongly deprecated if supported at all)
  
  Further, there could be an additional independent badge about page redirect 
vs section redirect.
  
  See wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T278962

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Taylor
Cc: Taylor, Lucas_Werkmeister_WMDE, Addshore, Jakob_WMDE, MSGJ, 
Simon_Villeneuve, ChristianKl, Eugene, seav, kaldari, Naseweis520, Fuzheado, 
Gamaliel, ItamarWMDE, Ladsgroup, DemonDays64, DannyS712, JAnD, Hsarrazin, 
deryckchan, agray, MisterSynergy, Liuxinyu970226, Delasse, Jheald, Aklapper, 
Lydia_Pintscher, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T278962: allow sitelinks to redirects if redirect badge is used

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  I assume removing the badge from a sitelink should be disallowed if the 
target page is (currently) a redirect?

TASK DETAIL
  https://phabricator.wikimedia.org/T278962

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Addshore, Jakob_WMDE, MSGJ, Simon_Villeneuve, 
ChristianKl, Eugene, seav, kaldari, Naseweis520, Fuzheado, Gamaliel, 
ItamarWMDE, Ladsgroup, DemonDays64, DannyS712, JAnD, Hsarrazin, deryckchan, 
agray, MisterSynergy, Liuxinyu970226, Delasse, Jheald, Aklapper, 
Lydia_Pintscher, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T278962: allow sitelinks to redirects if redirect badge is used

[Lydia_Pintscher]

Lydia_Pintscher moved this task from Incoming to Prioritized Product 
(prioritised from top to bottom) on the Wikidata-Campsite board.
Lydia_Pintscher triaged this task as "High" priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T278962

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3402/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Addshore, Jakob_WMDE, MSGJ, Simon_Villeneuve, ChristianKl, Eugene, seav, 
kaldari, Naseweis520, Fuzheado, Gamaliel, ItamarWMDE, Ladsgroup, DemonDays64, 
DannyS712, JAnD, Hsarrazin, deryckchan, agray, MisterSynergy, Liuxinyu970226, 
Delasse, Jheald, Aklapper, Lydia_Pintscher, Invadibot, maantietaja, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T278962: allow sitelinks to redirects if redirect badge is used

[Lydia_Pintscher]

Lydia_Pintscher created this task.
Lydia_Pintscher added projects: Wikidata, Wikidata-Campsite.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  **Problem:**
  We want to allow sitelinks to redirects but only under certain conditions. In 
detail this means:
  
  - The default behavior stays rejecting of adding of sitelinks that are links 
to redirected pages
  - A sitelink to a redirected pages can be added to an Item if and only if a 
redirect badge (sitelink to redirect (Q70893996), intentional sitelink to 
redirect (Q70894304))  
is added in the same edit
  - Adding a redirect badge to an existing redirect sitelink is possible
  
  **Context:**
  
  - In T235420  we added badges to 
indicate sitelinks to redirects but they can't be used because the edits 
related to them are disallowed
  - https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/602422 
contains some work in this direction but is probably not the right approach, 
(per Adam's comment at T235420#6791998 
)  Adam notes: "Looking at 
the patch lots of the code will end up being reused, but it will need the 
addition of some checks etc to optionally pass 
MediaWikiPageNameNormalizer::NOFOLLOW_REDIRECT into the service etc."
  
  **BDD**
  GIVEN an Item
  AND a page on the client that is a redirect
  WHEN adding the page as a sitelink to the Item
  AND not adding a redirect badge in the same edit
  THEN the edit is rejected
  
  GIVEN an Item
  AND a page on the client that is a redirect
  WHEN adding the page as a sitelink to the Item
  AND adding a redirect badge in the same edit
  THEN the sitelink and associated badge are stored
  
  GIVEN an Item
  AND a sitelink to a client page
  AND the client page is a redirect
  WHEN adding a redirect badge to the sitelink
  THEN the badge is stored with the sitelink
  
  **Acceptance criteria:**
  
  - Default behavior remains unchanged
  - Sitelinks to redirect pages are accepted if and only if there is a redirect 
badge attached to them

TASK DETAIL
  https://phabricator.wikimedia.org/T278962

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Aklapper, Lydia_Pintscher, Invadibot, maantietaja, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs