[Wikidata-bugs] [Maniphest] T281677: Make SummaryFormatterTest a proper unit test

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the 
Wikibase Service Migration board.
Lucas_Werkmeister_WMDE added a comment.


$ vendor/bin/phpunit 
extensions/Wikibase/repo/tests/phpunit/unit/ServiceWiring/SummaryFormatterTest.php
 
PHPUnit 8.5.15 by Sebastian Bergmann and contributors.

.   1 / 1 
(100%)

Time: 133 ms, Memory: 20.00 MB

OK (1 test, 28 assertions)

TASK DETAIL
  https://phabricator.wikimedia.org/T281677

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5203/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Invadibot, maantietaja, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T281677: Make SummaryFormatterTest a proper unit test

[Maintenance_bot]

Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T281677

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Maintenance_bot
Cc: Aklapper, Lucas_Werkmeister_WMDE, Invadibot, maantietaja, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Lalamarie69, Alter-paule, 
Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, 
Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T281677: Make SummaryFormatterTest a proper unit test

[gerritbot]

gerritbot added a comment.


  Change 684299 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Introduce MessageInLanguageProvider 
service
  
  https://gerrit.wikimedia.org/r/684299

TASK DETAIL
  https://phabricator.wikimedia.org/T281677

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Aklapper, Lucas_Werkmeister_WMDE, Invadibot, Lalamarie69, maantietaja, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T281677: Make SummaryFormatterTest a proper unit test

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T281677

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Aklapper, Lucas_Werkmeister_WMDE, Invadibot, Lalamarie69, maantietaja, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T281677: Make SummaryFormatterTest a proper unit test

[gerritbot]

gerritbot added a comment.


  Change 684299 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] Introduce MessageInLanguageProvider 
service
  
  https://gerrit.wikimedia.org/r/684299

TASK DETAIL
  https://phabricator.wikimedia.org/T281677

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Aklapper, Lucas_Werkmeister_WMDE, Invadibot, maantietaja, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T281677: Make SummaryFormatterTest a proper unit test

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase Service Migration.

TASK DESCRIPTION
  The `SummaryFormatterTest` service wiring test currently fails when run as a 
pure unit test because `OutputFormatSnakFormatterFactory::getSnakFormatter()` 
uses `wfMessage()`. We should fix that.
  
  In general, `wfMessage()` is tricky to replace in service wiring because it 
depends on the user language, which we don’t want to use in services (compare 
T279415: Remove calls to deprecated WikibaseRepo::getUserLanguage 
). However, in this case it actually 
wants a message in a specific language, so I think we can create a new service 
(e.g. `MessageInLanguageProvider`), similar to `MessageLocalizer` but agnostic 
of the user language, and use that.

TASK DETAIL
  https://phabricator.wikimedia.org/T281677

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Invadibot, maantietaja, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs