[Wikidata-bugs] [Maniphest] T281712: Don’t inject LanguageNameLookup into ViewFactory

2021-05-04 Thread ItamarWMDE 
ItamarWMDE closed this task as "Resolved".
ItamarWMDE moved this task from Up for review to Done on the Wikibase Service 
Migration board.

TASK DETAIL
  https://phabricator.wikimedia.org/T281712

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5203/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, ItamarWMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, ItamarWMDE, Invadibot, maantietaja, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T281712: Don’t inject LanguageNameLookup into ViewFactory

2021-05-03 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T281712

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Maintenance_bot
Cc: Lucas_Werkmeister_WMDE, Aklapper, ItamarWMDE, Invadibot, maantietaja, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Addshore, Mbch331, 
Lalamarie69, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, 
CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, 
Maathavan
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T281712: Don’t inject LanguageNameLookup into ViewFactory

2021-05-03 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).

TASK DETAIL
  https://phabricator.wikimedia.org/T281712

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot
Cc: Lucas_Werkmeister_WMDE, Aklapper, ItamarWMDE, Invadibot, Lalamarie69, 
maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Addshore, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T281712: Don’t inject LanguageNameLookup into ViewFactory

2021-05-03 Thread gerritbot 
gerritbot added a comment.


  Change 684425 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Inject LanguageNameLookupFactory into 
ViewFactory
  
  https://gerrit.wikimedia.org/r/684425

TASK DETAIL
  https://phabricator.wikimedia.org/T281712

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, ItamarWMDE, Invadibot, Lalamarie69, 
maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Addshore, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T281712: Don’t inject LanguageNameLookup into ViewFactory

2021-05-03 Thread gerritbot 
gerritbot added a comment.


  Change 684424 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Introduce LanguageNameLookupFactory 
repo service
  
  https://gerrit.wikimedia.org/r/684424

TASK DETAIL
  https://phabricator.wikimedia.org/T281712

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, ItamarWMDE, Invadibot, Lalamarie69, 
maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Addshore, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T281712: Don’t inject LanguageNameLookup into ViewFactory

2021-05-03 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE edited parent tasks, added: T281721: Remove calls to 
deprecated WikibaseRepo::getLanguageNameLookup(); removed: T279415: Remove 
calls to deprecated WikibaseRepo::getUserLanguage.

TASK DETAIL
  https://phabricator.wikimedia.org/T281712

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, ItamarWMDE, Invadibot, Lalamarie69, 
maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Addshore, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T281712: Don’t inject LanguageNameLookup into ViewFactory

2021-05-03 Thread gerritbot 
gerritbot added a comment.


  Change 684425 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] Inject LanguageNameLookupFactory into 
ViewFactory
  
  https://gerrit.wikimedia.org/r/684425

TASK DETAIL
  https://phabricator.wikimedia.org/T281712

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, ItamarWMDE, Invadibot, Lalamarie69, 
maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Addshore, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T281712: Don’t inject LanguageNameLookup into ViewFactory

2021-05-03 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T281712

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, ItamarWMDE, Invadibot, Lalamarie69, 
maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Addshore, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T281712: Don’t inject LanguageNameLookup into ViewFactory

2021-05-03 Thread gerritbot 
gerritbot added a comment.


  Change 684424 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] Introduce LanguageNameLookupFactory 
repo service
  
  https://gerrit.wikimedia.org/r/684424

TASK DETAIL
  https://phabricator.wikimedia.org/T281712

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, ItamarWMDE, Invadibot, maantietaja, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Addshore, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T281712: Don’t inject LanguageNameLookup into ViewFactory

2021-05-03 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE moved this task from Incoming to Doing on the Wikibase 
Service Migration board.

TASK DETAIL
  https://phabricator.wikimedia.org/T281712

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5203/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, ItamarWMDE, Invadibot, maantietaja, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Addshore, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T281712: Don’t inject LanguageNameLookup into ViewFactory

2021-05-03 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikibase Service Migration, wdwb-tech, 
Wikidata.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  The `ViewFactory` currently gets a `LanguageNameLookup` service injected, 
which already contains the user language, but then `ViewFactory::newItemView()` 
and other methods are also called with a `$language` argument. It doesn’t make 
sense to have the language at both levels here. (Also, the `LanguageNameLookup` 
service itself needs the user language, which we don’t want to use in the 
service wiring.)
  
  I think the solution will be fairly similar to what @ItamarWMDE did in 
T281449 : create a new 
`LanguageNameLookupFactory` service and inject //that// into `ViewFactory`. 
(I’m kind of tempted to skip `LanguageNameLookupFactory` and just hard-code 
`new LanguageNameLookup( $language->getCode() )` in `ViewFactory`, but we 
created factory services for the text provider and number localizer too, so I 
guess we should have a language name lookup factory as well.)

TASK DETAIL
  https://phabricator.wikimedia.org/T281712

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, ItamarWMDE, Invadibot, maantietaja, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Addshore, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs