[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork in Wikit

[Addshore]

Addshore closed this task as "Resolved".
Addshore added a comment.


  I didnt actually check this, but the changes look good and im sure this will 
be reopened if it doesnt work

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Addshore
Cc: Michael, Lucas_Werkmeister_WMDE, Addshore, bete, Jakob_WMDE, Aklapper, 
Tonina_Zhelyazkova_WMDE, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork in Wikit

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to 
bottom) to Test (Verification) on the Wikidata-Campsite 
(Wikidata-Campsite-Iteration-∞) board.
Lucas_Werkmeister_WMDE added a comment.


  Nevermind, apparently the browser tests are just flaky sometimes. Now they’re 
green on another pull request.

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Addshore, bete, Jakob_WMDE, Aklapper, 
Tonina_Zhelyazkova_WMDE, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork in Wikit

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Hm, but in 
https://github.com/wmde/wikit/runs/3020051173?check_suite_focus=true a totally 
different set of tests failed?
  
sauceChrome  Results for:  emits first and last index on scroll change 
 sauceChrome  ✖ Timed out while waiting for element <.***-Lookup> to be 
present for 2 milliseconds. - expected "found" but got: "not found" 
(20824ms) 
 sauceChrome  at DescribeInstance. 
(/home/runner/work/***/***/vue-components/tests/e2e/specs/Lookup.test.js:7:5) 
 sauceChrome  at new Promise () 
 sauceChrome  ✖ Timed out while waiting for element <.***-OptionsMenu> to 
be present for 2 milliseconds. - expected "found" but got: "not found" 
(20961ms) 
 sauceChrome  at DescribeInstance. 
(/home/runner/work/***/***/vue-components/tests/e2e/specs/Lookup.test.js:43:5) 
 sauceChrome  at processTicksAndRejections 
(internal/process/task_queues.js:95:5) 
 sauceChrome  Error while running .executeScript() protocol action: 
javascript error: Cannot read property 'scrollIntoView' of undefined 
 sauceChrome  ✖ Testing if element <.first-visible-element-index> contains 
text '2' in 5000ms - expected "contains text '2'" but got: "element could not 
be located" (20416ms) 
 sauceChrome  at DescribeInstance. 
(/home/runner/work/***/***/vue-components/tests/e2e/specs/Lookup.test.js:45:12) 
 sauceChrome  at processTicksAndRejections 
(internal/process/task_queues.js:95:5) 
 sauceChrome  ✖ sauceChrome [Lookup Menu] emits first and last index on 
scroll change (1m 23s / 83850ms) 
 sauceChrome  Timed out while waiting for element <.***-Lookup> to be 
present for 2 milliseconds. - expected "found" but got: "not found" 
(20824ms) 
 sauceChrome  at DescribeInstance. 
(/home/runner/work/***/***/vue-components/tests/e2e/specs/Lookup.test.js:7:5) 
 sauceChrome at new Promise () 
 sauceChrome Timed out while waiting for element <.***-OptionsMenu> to 
be present for 2 milliseconds. - expected "found" but got: "not found" 
(20961ms) 
 sauceChrome  at DescribeInstance. 
(/home/runner/work/***/***/vue-components/tests/e2e/specs/Lookup.test.js:43:5) 
 sauceChrome at processTicksAndRejections 
(internal/process/task_queues.js:95:5) 
 sauceChrome Testing if element <.first-visible-element-index> contains 
text '2' in 5000ms - expected "contains text '2'" but got: "element could not 
be located" (20416ms) 
 sauceChrome  at DescribeInstance. 
(/home/runner/work/***/***/vue-components/tests/e2e/specs/Lookup.test.js:45:12) 
 sauceChrome at processTicksAndRejections 
(internal/process/task_queues.js:95:5)

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Addshore, bete, Jakob_WMDE, Aklapper, 
Tonina_Zhelyazkova_WMDE, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork in Wikit

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Example run: 
https://github.com/wmde/wikit/runs/3020043314?check_suite_focus=true
  
sauceIE  [Button] Test Suite 
 sauceIE  === 
 sauceIE  - Connecting to ondemand.saucelabs.com on port 80... 
 sauceIE  ℹ Connected to ondemand.saucelabs.com on port 80 (13160ms). 
 sauceIE  Using: internet explorer (11) on WINDOWS platform. 
 sauceIE  Results for:  is visible 
 sauceIE  POST http://ondemand.saucelabs.com 
/wd/hub/session/4b58afbb2c294a48a222c976cd1be3bc/elements - ECONNRESET 
 sauceIE  Error: socket hang up 
 sauceIE  at connResetException (internal/errors.js:609:14) 
 sauceIE  Error while running .locateMultipleElements() protocol action: 
Error ECONNRESET: socket hang up 
 sauceIE  ✖ Timed out while waiting for element <.***-Button> to be present 
for 2 milliseconds. - expected "found" but got: "not found" (60091ms) 
 sauceIE  at DescribeInstance. 
(/home/runner/work/***/***/vue-components/tests/e2e/specs/Button.test.js:16:5) 
 sauceIE  at processTicksAndRejections 
(internal/process/task_queues.js:97:5) 
 sauceIE  ✔ Testing if element <.***-Button> is visible (621ms) 
 sauceIE  ✖ sauceIE [Button] is visible (1m 10s / 70636ms) 
 sauceIE  Timed out while waiting for element <.***-Button> to be present 
for 2 milliseconds. - expected "found" but got: "not found" (60091ms) 
 sauceIE  at DescribeInstance. 
(/home/runner/work/***/***/vue-components/tests/e2e/specs/Button.test.js:16:5) 
 sauceIE at processTicksAndRejections 
(internal/process/task_queues.js:97:5) 
 sauceIE  [Lookup Menu] Test Suite

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Addshore, bete, Jakob_WMDE, Aklapper, 
Tonina_Zhelyazkova_WMDE, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork in Wikit

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE moved this task from Test (Verification) to To Do 
(prioritised from top to bottom) on the Wikidata-Campsite 
(Wikidata-Campsite-Iteration-∞) board.
Lucas_Werkmeister_WMDE added a comment.


  It turns out #439 was slightly faulty, and some CI didn’t run. I fixed that 
in #444 , but it looks like in the 
meantime, something broke in the browser tests, so now that CI is running 
again, it’s failing on master.

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Addshore, bete, Jakob_WMDE, Aklapper, 
Tonina_Zhelyazkova_WMDE, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork in Wikit

[Michael]

Michael added a comment.


  This recently added Setting on GitHub seems relevant here: 
https://github.blog/changelog/2021-07-01-github-actions-new-settings-for-maintainers/

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Michael
Cc: Michael, Lucas_Werkmeister_WMDE, Addshore, bete, Jakob_WMDE, Aklapper, 
Tonina_Zhelyazkova_WMDE, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork in Wikit

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the 
Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Lucas_Werkmeister_WMDE added a comment.


  https://github.com/wmde/wikit/pull/439

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Addshore, bete, Jakob_WMDE, Aklapper, 
Tonina_Zhelyazkova_WMDE, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Jonas, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork in Wikit

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to 
bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Addshore, bete, Jakob_WMDE, Aklapper, 
Tonina_Zhelyazkova_WMDE, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Jonas, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork in Wikit

[Tonina_Zhelyazkova_WMDE]

Tonina_Zhelyazkova_WMDE added a comment.


  In T283911#7166299 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > To understand the requirements better: how much functionality do we need to 
have? From looking at the workflow, it seems like it should be fairly easy to 
get basic CI working, but without Chromatic, Saucelabs, and Netlify. Would that 
be useful?
  
  Yes, that would be useful. When grooming this task we suspected services that 
use a token won't be able to be run on PRs from fork repos at all.
  I think making CI run basic tests (unit and linting) + what Michael suggested 
regarding documenting how to manually run the rest of CI is sufficient to solve 
the problem.
  
  p.s. I did not see  the button mentioned in 
https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks
 when I was reviewing https://github.com/wmde/wikit/pull/431

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tonina_Zhelyazkova_WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Addshore, bete, Jakob_WMDE, Aklapper, 
Tonina_Zhelyazkova_WMDE, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Jonas, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork in Wikit

[Addshore]

Addshore renamed this task from "Run GitHub actions on PRs opened from a fork" 
to "Run GitHub actions on PRs opened from a fork in Wikit".
Addshore added a project: wikidata-campsite-a-b-split.

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Michael, Lucas_Werkmeister_WMDE, Addshore, bete, Jakob_WMDE, Aklapper, 
Tonina_Zhelyazkova_WMDE, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Jonas, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  > Yes, and I think this is as good as we can (safely) do in this regard.
  
  Well, I assume we should be able to run (some?) browser tests directly in 
GitHub actions instead of via a third-party service. The question is how 
important that is to us (which is why I’m still waiting for an answer to 
T283911#7166299  before I 
pick this up).

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Addshore, bete, Jakob_WMDE, Aklapper, 
Tonina_Zhelyazkova_WMDE, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Jonas, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

[Michael]

Michael added a comment.


  In T283911#7169942 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > I’m not sure about the first-time contributors things, but as I understand 
it, the main problem is that pull requests from forks won’t have access to 
secrets, so they’ll be missing various API keys.
  
  Yes, and I think this is as good as we can (safely) do in this regard. This 
blog post goes into a bit more detail as to why: 
https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
  
  As far as I can see it:, you already specified it well:
  
  [ ] Make the things that //can// run without secrets (i.e. basic CI), run 
automatically on pull requests from forks as well.
  [ ] Create some kind of documentation/instructions for how to manually run 
the rest of CI 

 (netlify, saucelabs) after review, so that the patch can be merged.

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Lucas_Werkmeister_WMDE, Addshore, bete, Jakob_WMDE, Aklapper, 
Tonina_Zhelyazkova_WMDE, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Jonas, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  I’m not sure about the first-time contributors things, but as I understand 
it, the main problem is that pull requests from forks won’t have access to 
secrets, so they’ll be missing various API keys.

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, Addshore, bete, Jakob_WMDE, Aklapper, 
Tonina_Zhelyazkova_WMDE, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Jonas, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

[Michael]

Michael added a comment.


  Mh, reading up on it, it seems to be a bit more complex.  The above works not 
for first-time contributors. In those cases there is apparently a way for 
manually Approving workflow runs from public forks 
.
 After their first pull request was merged, future pull request will apparently 
trigger the full `pull_request` workflows as usual.

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Lucas_Werkmeister_WMDE, Addshore, bete, Jakob_WMDE, Aklapper, 
Tonina_Zhelyazkova_WMDE, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Jonas, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

[Michael]

Michael added a comment.


  In T283911#7166299 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > To understand the requirements better: how much functionality do we need to 
have? From looking at the workflow, it seems like it should be fairly easy to 
get basic CI working, but without Chromatic, Saucelabs, and Netlify. Would that 
be useful?
  
  I'm confused. Wouldn't something like the following:
  
- on: push
+ on: [push, pull_request]
  
  just run the entire workflow (including Netlify, etc.) on every pull request, 
regardless of whether it comes from a local contributor or a fork?
  
  It might even make sense to do something like
  
- on: push
+ on: pull_request
  
  What am I missing?

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Lucas_Werkmeister_WMDE, Addshore, bete, Jakob_WMDE, Aklapper, 
Tonina_Zhelyazkova_WMDE, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Jonas, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  To understand the requirements better: how much functionality do we need to 
have? From looking at the workflow, it seems like it should be fairly easy to 
get basic CI working, but without Chromatic, Saucelabs, and Netlify. Would that 
be useful?

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Addshore, bete, Jakob_WMDE, Aklapper, 
Tonina_Zhelyazkova_WMDE, Invadibot, maantietaja, Akuckartz, Iflorez, alaa_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Jonas, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

[Addshore]

Addshore edited projects, added Wikidata-Campsite 
(Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, bete, Jakob_WMDE, Aklapper, Tonina_Zhelyazkova_WMDE, Invadibot, 
maantietaja, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

[Addshore]

Addshore set the point value for this task to "5".

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, bete, Jakob_WMDE, Aklapper, Tonina_Zhelyazkova_WMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Volker_E, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

[Addshore]

Addshore added a project: Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, bete, Jakob_WMDE, Aklapper, Tonina_Zhelyazkova_WMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Volker_E, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

[Addshore]

Addshore triaged this task as "Medium" priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, bete, Jakob_WMDE, Aklapper, Tonina_Zhelyazkova_WMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Volker_E, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

[Addshore]

Addshore updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, bete, Jakob_WMDE, Aklapper, Tonina_Zhelyazkova_WMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

[Tonina_Zhelyazkova_WMDE]

Tonina_Zhelyazkova_WMDE added a project: wdwb-tech.

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tonina_Zhelyazkova_WMDE
Cc: Addshore, bete, Jakob_WMDE, Aklapper, Tonina_Zhelyazkova_WMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

[Tonina_Zhelyazkova_WMDE]

Tonina_Zhelyazkova_WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tonina_Zhelyazkova_WMDE
Cc: Addshore, bete, Jakob_WMDE, Aklapper, Tonina_Zhelyazkova_WMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

[Tonina_Zhelyazkova_WMDE]

Tonina_Zhelyazkova_WMDE added a comment.


  The below is chat history from a conversation with @Addshore
  
  > We have the same problem on gerrit CI with jenkins: there is an allow list 
of contributors that have real CI run, otherwise they just have "checks" like 
linting run and the solution there is either:
  >
  > 1. Trust them, add their email to the whitelist and run the CI
  >
  > or
  >
  > 2. run "recheck" as a trusted contributor, that will run CI
  >
  > both of those can possibly also be done for wikit
  
  
  
  > Another option with a github only flavour would be
  >
  > 1. if you like the code, create a new internal branch on the repo for the 
code
  > 2. change the base of the PR to that branch anhd merge,
  > 3. make a new PR from that branch
  >
  > this is annoying as the contributor that wrote it can't alter the new PR, 
but they can submit more PRs to the PR
  > but then on the inner PR you have CI running fully etc, and the user can 
still add aditional things etc la la la
  
  
  
  > for some jobs, like publish netlify, a little dance can be done, like have 
a pull_request one do the build of the site and run code, and have that trigger 
some other job that does the actual publish with the secret (but doesnt run any 
code)
  > I also saw things like this that would allow you to do that 
https://github.com/marketplace/actions/wait-for-check
  > So you start 2 jobs, and have 1 wait for th other to finish. And the reason 
the waiting would be needed is something like this 
https://github.community/t/triggering-a-new-workflow-from-another-workflow/16250
 because 1 workflow can not trigger another workflow

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tonina_Zhelyazkova_WMDE
Cc: Addshore, bete, Jakob_WMDE, Aklapper, Tonina_Zhelyazkova_WMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T283911: Run GitHub actions on PRs opened from a fork

[Maintenance_bot]

Maintenance_bot added a project: Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T283911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: bete, Jakob_WMDE, Aklapper, Tonina_Zhelyazkova_WMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org