[Wikidata-bugs] [Maniphest] T284443: Reduce bot requests in Wikibase selenium tests

[Michael]

Michael moved this task from Backlog to Tech on the 
MediaWiki-extensions-WikibaseClient board.
Michael edited projects, added wmde-wikidata-tech, Wikibase Product Platform 
Team WPP; removed [DEPRECATED] wdwb-tech.

TASK DETAIL
  https://phabricator.wikimedia.org/T284443

WORKBOARD
  https://phabricator.wikimedia.org/project/board/114/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Tarrow, Lucas_Werkmeister_WMDE, kostajh, Aklapper, 
Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, 
Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, 
Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, Ullasoff
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T284443: Reduce bot requests in Wikibase selenium tests

[Michael]

Michael added a comment.


  See https://github.com/wmde/wdio-wikibase/pull/41 for work related to this

TASK DETAIL
  https://phabricator.wikimedia.org/T284443

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Addshore, Tarrow, Lucas_Werkmeister_WMDE, kostajh, Aklapper, 786, 
Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, zeljkofilipin, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T284443: Reduce bot requests in Wikibase selenium tests

[Addshore]

Addshore triaged this task as "Low" priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T284443

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, Tarrow, Lucas_Werkmeister_WMDE, kostajh, Aklapper, Biggs657, 
Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, zeljkofilipin, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T284443: Reduce bot requests in Wikibase selenium tests

[gerritbot]

gerritbot added a comment.


  Change 698484 **abandoned** by Kosta Harlan:
  
  [mediawiki/extensions/Wikibase@master] [WIP] selenium: Reuse WikibaseApi, 
update to wdio-wikibase 5.2.0
  
  Reason:
  
  
  
  https://gerrit.wikimedia.org/r/698484

TASK DETAIL
  https://phabricator.wikimedia.org/T284443

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Addshore, Tarrow, Lucas_Werkmeister_WMDE, kostajh, Aklapper, Biggs657, 
Invadibot, Lalamarie69, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, zeljkofilipin, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T284443: Reduce bot requests in Wikibase selenium tests

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  In T284443#7138764 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > (…the CSRF token race condition seems to be real: I got CSRF token errors 
in this WikibaseLexeme change 
 
where I’m trying to merge the MWBot instances again.)
  
  In PS3 those errors vanished (that version logs in immediately after creating 
the MWBot instance – I assume previously, some requests with edit token were 
made before logging in, and then the wrong token continued to be used after 
login, because MWBot doesn’t seem to reset it automatically), so I’d welcome 
review on that change now. If it looks sensible, I think we should try to do 
something similar in wdio-wikibase as well.

TASK DETAIL
  https://phabricator.wikimedia.org/T284443

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Addshore, Tarrow, Lucas_Werkmeister_WMDE, kostajh, Aklapper, Invadibot, 
Lalamarie69, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, zeljkofilipin, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T284443: Reduce bot requests in Wikibase selenium tests

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added subscribers: Tarrow, Addshore.
Lucas_Werkmeister_WMDE added a comment.


  Apparently using different MWBot instances was a deliberate change about two 
years ago, departing from the previous state of using the same mwbot for 
everything: see Wikibase change 
 and 
WikibaseLexeme change 
.
 CC @Addshore and @Tarrow. (Neither change has a task attached, but the CSRF 
token race condition seems to be real: I got CSRF token errors in this 
WikibaseLexeme change 
 
where I’m trying to merge the MWBot instances again.)

TASK DETAIL
  https://phabricator.wikimedia.org/T284443

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Addshore, Tarrow, Lucas_Werkmeister_WMDE, kostajh, Aklapper, Invadibot, 
Lalamarie69, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, zeljkofilipin, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T284443: Reduce bot requests in Wikibase selenium tests

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Yes, but if the chronology protector stuff works out, then I suspect it would 
make sense to pass an `MWBot` into wdio-wikibase, and it wouldn’t create its 
own instance at all. (WIP is at 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/698517 
if you’re interested.)

TASK DETAIL
  https://phabricator.wikimedia.org/T284443

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, kostajh, Aklapper, Invadibot, Lalamarie69, 
maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
zeljkofilipin, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T284443: Reduce bot requests in Wikibase selenium tests

[kostajh]

kostajh added a comment.


  In T284443#7138458 , 
@kostajh wrote:
  
  > In T284443#7138433 , 
@Lucas_Werkmeister_WMDE wrote:
  >
  >> Can we hold off on this for a bit? I’m looking into making the `bot` 
support chronology protector better in T277862 
, which also requires sharing the 
same instance; if that works, we can hopefully draw some lessons from that for 
wdio-wikibase.
  >
  > That's OK with me, although the patches should (in theory, completely 
non-tested) have the sharing same instance part already done in wdio-wikibase 
plus the extension.
  
  Oops, I didn't include the submodules. But I have those updated as well.

TASK DETAIL
  https://phabricator.wikimedia.org/T284443

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: Lucas_Werkmeister_WMDE, kostajh, Aklapper, Invadibot, Lalamarie69, 
maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
zeljkofilipin, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T284443: Reduce bot requests in Wikibase selenium tests

[kostajh]

kostajh added a comment.


  In T284443#7138433 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > Can we hold off on this for a bit? I’m looking into making the `bot` 
support chronology protector better in T277862 
, which also requires sharing the 
same instance; if that works, we can hopefully draw some lessons from that for 
wdio-wikibase.
  
  That's OK with me, although the patches should (completely non tested) have 
the sharing same instance part already done in wdio-wikibase plus the extension.

TASK DETAIL
  https://phabricator.wikimedia.org/T284443

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: Lucas_Werkmeister_WMDE, kostajh, Aklapper, Invadibot, Lalamarie69, 
maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
zeljkofilipin, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T284443: Reduce bot requests in Wikibase selenium tests

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Can we hold off on this for a bit? I’m looking into making the `bot` support 
chronology protector better in T277862 
, which also requires sharing the 
same instance; if that works, we can hopefully draw some lessons from that for 
wdio-wikibase.

TASK DETAIL
  https://phabricator.wikimedia.org/T284443

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, kostajh, Aklapper, Invadibot, Lalamarie69, 
maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
zeljkofilipin, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T284443: Reduce bot requests in Wikibase selenium tests

[Maintenance_bot]

Maintenance_bot added a project: Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T284443

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: kostajh, Aklapper, Invadibot, Lalamarie69, maantietaja, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, zeljkofilipin, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T284443: Reduce bot requests in Wikibase selenium tests

[Addshore]

Addshore edited projects, added wdwb-tech; removed wdwb-tech (wdwb-tech (small 
tasks)).

TASK DETAIL
  https://phabricator.wikimedia.org/T284443

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: kostajh, Aklapper, Lalamarie69, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, lucamauri, Giuliamocci, 
Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, Wikidata-bugs, zeljkofilipin, 
Addshore
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T284443: Reduce bot requests in Wikibase selenium tests

[Addshore]

Addshore added a project: wdwb-tech (wdwb-tech (small tasks)).

TASK DETAIL
  https://phabricator.wikimedia.org/T284443

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: kostajh, Aklapper, Lalamarie69, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, lucamauri, Giuliamocci, 
Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, Wikidata-bugs, zeljkofilipin, 
Addshore
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T284443: Reduce bot requests in Wikibase selenium tests

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T284443

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: kostajh, Aklapper, Lalamarie69, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, lucamauri, Giuliamocci, 
Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, Wikidata-bugs, zeljkofilipin
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T284443: Reduce bot requests in Wikibase selenium tests

[gerritbot]

gerritbot added a comment.


  Change 698484 had a related patch set uploaded (by Kosta Harlan; author: 
Kosta Harlan):
  
  [mediawiki/extensions/Wikibase@master] selenium: Reuse WikibaseApi, update to 
wdio-wikibase 5.2.0
  
  https://gerrit.wikimedia.org/r/698484

TASK DETAIL
  https://phabricator.wikimedia.org/T284443

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: kostajh, Aklapper, Akuckartz, lucamauri, Wikidata-bugs, zeljkofilipin
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T284443: Reduce bot requests in Wikibase selenium tests

[kostajh]

kostajh added a comment.


  Similarly, there are lots of calls to `Api.bot()` inside individual tests, 
and these could be consolidated into a single bot created in the `before()` 
hook.

TASK DETAIL
  https://phabricator.wikimedia.org/T284443

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: kostajh, Aklapper, Akuckartz, lucamauri, Wikidata-bugs, zeljkofilipin
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T284443: Reduce bot requests in Wikibase selenium tests

[kostajh]

kostajh added a comment.


  See https://github.com/wmde/wdio-wikibase/pull/37

TASK DETAIL
  https://phabricator.wikimedia.org/T284443

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: kostajh, Aklapper, Akuckartz, lucamauri, Wikidata-bugs, zeljkofilipin
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T284443: Reduce bot requests in Wikibase selenium tests

[kostajh]

kostajh created this task.
kostajh added projects: Browser-Tests, MediaWiki-extensions-WikibaseClient.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  I noticed that Wikibase Selenium tests involve a lot of overhead with browser 
requests related to mwbot, and we could consolidate some of these.
  
  For example, instead of creating a new MWBot every time `createItem()` is 
called, which in turn requires logging in and retrieving an edit token, we 
could create a single bot instance and store this in the class. We'd have to 
change the style of calling `createItem()` to do something like `const api = 
new WikibaseApi(); api.createItem()` rather than the existing 
`WikibaseApi.createItem()` but that doesn't seem too onerous.
  
  We could also create a single WikibaseApi object in a beforeSuite() hook and 
reference that in all tests rather than creating a fresh one before each test.

TASK DETAIL
  https://phabricator.wikimedia.org/T284443

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: kostajh, Aklapper, Akuckartz, lucamauri, Wikidata-bugs, zeljkofilipin
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org