[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T284896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Samwilson, Maintenance_bot Cc: Tenniscourtisland, Jdlrobson, Samwilson, Invadibot, maantietaja,

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

gerritbot added a comment. Change 722709 **merged** by jenkins-bot: [mediawiki/extensions/WikidataPageBanner@REL1_36] Add link parameter to customize link target https://gerrit.wikimedia.org/r/722709 TASK DETAIL https://phabricator.wikimedia.org/T284896 EMAIL PREFERENCES https:

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

Samwilson added a comment. Thanks @Jdlrobson! I've updated the docs, and backported to 1.36, and will now update the WMAU website. TASK DETAIL https://phabricator.wikimedia.org/T284896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Samwilson Cc:

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T284896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Samwilson, gerritbot Cc: Tenniscourtisland, Jdlrobson, Samwilson, Suran38, Biggs657, Invadibot, Lalamar

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

gerritbot added a comment. Change 722709 had a related patch set uploaded (by Samwilson; author: Samwilson): [mediawiki/extensions/WikidataPageBanner@REL1_36] Add link parameter to customize link target https://gerrit.wikimedia.org/r/722709 TASK DETAIL https://phabricator.wikimed

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T284896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Samwilson, Maintenance_bot Cc: Tenniscourtisland, Jdlrobson, Samwilson, Invadibot, maantietaja,

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.2; 2021-09-28). TASK DETAIL https://phabricator.wikimedia.org/T284896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Samwilson, ReleaseTaggerBot Cc: Tenniscourtisland, Jdlrobson, Samwilson,

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

Jdlrobson closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T284896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Samwilson, Jdlrobson Cc: Tenniscourtisland, Jdlrobson, Samwilson, Suran38, Biggs657, Invadibot, Lalamarie6

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

gerritbot added a comment. Change 712916 **merged** by jenkins-bot: [mediawiki/extensions/WikidataPageBanner@master] Add link parameter to customize link target https://gerrit.wikimedia.org/r/712916 TASK DETAIL https://phabricator.wikimedia.org/T284896 EMAIL PREFERENCES https:/

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

Samwilson changed the task status from "Stalled" to "Open". Samwilson added a comment. No longer stalled. Patch is ready for review. TASK DETAIL https://phabricator.wikimedia.org/T284896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Samwils

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

Samwilson changed the task status from "Open" to "Stalled". Samwilson added a comment. This is stalled awaiting T24 . TASK DETAIL https://phabricator.wikimedia.org/T284896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/ema

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T284896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Samwilson, gerritbot Cc: Tenniscourtisland, Jdlrobson, Samwilson, Biggs657, Invadibot, Lalamarie69, maa

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

gerritbot added a comment. Change 712916 had a related patch set uploaded (by Samwilson; author: Samwilson): [mediawiki/extensions/WikidataPageBanner@master] Add link parameter to customize link target https://gerrit.wikimedia.org/r/712916 TASK DETAIL https://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

Samwilson claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T284896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Samwilson Cc: Tenniscourtisland, Jdlrobson, Samwilson, Invadibot, maantietaja, Akuckartz, Canley, Demian, Nandana, Lahi

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

Jdlrobson added a comment. I'm happy to defer to your best judgement here Sam :) I can review providing it has tests. TASK DETAIL https://phabricator.wikimedia.org/T284896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Tenniscourt

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

Samwilson added a comment. I'm happy to work on this, if you agree that a new `link` param is the right way to go (I don't want to start if it's not likely to be accepted). The link param would also give Wikivoyage the option of not linking, they'd just need to update their template. Seems p

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

Jdlrobson added a comment. I guess you're right. I'm not sure why this was made into a link if attribution was not the reason. With respect to "to prevent users clicking on something that is just decoration." I am wondering if this should be default behaviour but I'd want to check in with E

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

Samwilson added a comment. I'm not sure I understand the concern about attribution: surely the same problem applies to any image in a wiki that's not got a link? And MediaWiki has had those forever. If Wikivoyage wants to always link to the banner image, they'd just have to //not// add

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

Jdlrobson added a project: Readers-Web-Backlog (Tracking). TASK DETAIL https://phabricator.wikimedia.org/T284896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Tenniscourtisland, Jdlrobson, Samwilson, Invadibot, maantietaja, Akuckartz,

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

Jdlrobson added a comment. @samwilson got it. I guess the challenge here is making sure the image is still attributed. We'd probably want to talk to the Wikivoyage community first with around revisiting that. Perhaps some text can be added in the footer to handle the attribution to add link

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

Tenniscourtisland added a comment. Ah my apologies. I see. This will still be very very useful for the banners also, as similar issues remain for those also. We ideally want the option of them being unlinked/static to avoid navigational confusion. Thanks! TASK DETAIL https://phab

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

Samwilson added a comment. Good points @Tenniscourtisland On the matter of images in general though, note that the `[[File:Example.jpg|link=Foo]]` syntax already exists and solves this problem for those images (I've just made the change

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

Tenniscourtisland added a comment. Two further points: - Images are commonly used like buttons on websites these days. Media Wiki doesn't currently seem to have that capacity. This would enable images to be used in that way. - When you click on an image at the moment it takes you to th

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

Samwilson added a comment. A couple of ideas: - to prevent users clicking on something that is just decoration. - to link to the more suitable page for a given image (e.g. an image might have multiple versions, one of which is the banner-cropped one, and they all be listed on a single

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

Samwilson updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T284896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Samwilson Cc: Jdlrobson, Samwilson, Invadibot, maantietaja, Akuckartz, Canley, Nandana, Lahi, Gq86, GoranSMi

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

Jdlrobson added a comment. Could you eloborate a bit on the usecase here? Thanks! TASK DETAIL https://phabricator.wikimedia.org/T284896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Jdlrobson, Samwilson, Invadibot, maantietaja, Aku

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

Maintenance_bot added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T284896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Samwilson, Invadibot, maantietaja, Akuckartz, Canley, Nandana, Lahi, Gq86, GoranSMilo

[Wikidata-bugs] [Maniphest] T284896: Add 'link' param to {{PAGEBANNER}} to change target

Samwilson created this task. Samwilson added projects: Wikidata-Page-Banner, Wikimedia Australia. TASK DESCRIPTION It'd be useful to be able to change the target of a banner's link. A `link=Page name` parameter would be in line with standard image syntax. TASK DETAIL https://phabricator.wiki