Peter closed this task as "Resolved".
Peter added a comment.
Cool, lets close this for now.
TASK DETAIL
https://phabricator.wikimedia.org/T287769
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Peter
Cc: ItamarWMDE, larissagaulia, RhinosF1,
ItamarWMDE added a comment.
@Peter Thank you for your response. I agree, that can probably skip the alert
for now. However, when we resume working on QueryBuilder, we would be in touch
in order to set up some kind of way to inform us about degraded JS performance.
TASK DETAIL
Lydia_Pintscher added a comment.
Thank you. Taking it with me.
TASK DETAIL
https://phabricator.wikimedia.org/T287769
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Peter, Lydia_Pintscher
Cc: larissagaulia, RhinosF1, dpifke, conny-kawohl_WMDE,
Peter added a comment.
@Lydia_Pintscher I think the main concern from the beginning would be if the
JavaScript performance got worse over time and we wanted to add an alert for
that. Today when I look at the metric (we measure CPU long tasks
Lydia_Pintscher added a comment.
Yes I can. Can you help me understand again what type of alert we are talking
about?
TASK DETAIL
https://phabricator.wikimedia.org/T287769
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Peter, Lydia_Pintscher
larissagaulia added a comment.
Hi @Lydia_Pintscher, could you help us identify someone that could receive
the alerts? Thanks ;)
TASK DETAIL
https://phabricator.wikimedia.org/T287769
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Peter,
Peter added a comment.
So it turns out I never added the alert. I can add it now, but who should
receive it?
TASK DETAIL
https://phabricator.wikimedia.org/T287769
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Peter
Cc: RhinosF1, dpifke,
Krinkle removed a project: Patch-For-Review.
TASK DETAIL
https://phabricator.wikimedia.org/T287769
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Peter, Krinkle
Cc: RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE,
Peter added a comment.
I think this is ok as it is now. I can add a simple alert for the size and
then if it fires we can sit-down and have look together.
TASK DETAIL
https://phabricator.wikimedia.org/T287769
EMAIL PREFERENCES
Ladsgroup added a comment.
Sure. If you need a call or chat. Feel free to ping me in IRC.
TASK DETAIL
https://phabricator.wikimedia.org/T287769
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Peter, Ladsgroup
Cc: RhinosF1, dpifke,
Peter added a comment.
Cool @Ladsgroup, do you have time so I can walk you through the data we
collect?
TASK DETAIL
https://phabricator.wikimedia.org/T287769
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Peter
Cc: RhinosF1, dpifke,
Ladsgroup added a comment.
We have it now \o/
https://grafana.wikimedia.org/d/00282/webpagerelay-drilldown?orgId=1=sitespeed_io=desktop=webpagereplay=query_wikidata_org=Main_page=chrome=100=median=https:%2F%2Fsynthetic-tests-result-wikimedia.s3.amazonaws.com
TASK DETAIL
gerritbot added a comment.
Change 712966 **merged** by jenkins-bot:
[performance/synthetic-monitoring-tests@master] Add test for wikidata Query
Builder
https://gerrit.wikimedia.org/r/712966
TASK DETAIL
https://phabricator.wikimedia.org/T287769
EMAIL PREFERENCES
Peter added a comment.
Cool, I just added a comment to the your push @Ladsgroup !
TASK DETAIL
https://phabricator.wikimedia.org/T287769
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Peter
Cc: RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE,
Ladsgroup added a comment.
I want to start with something simple and slowly migrate to something more
complex. Specially since basically every interaction's bottleneck is API
response time (e.g. for lookup for property ID, loading the WDQS results, etc.)
and not the app itself. Other reason
Peter added a comment.
@Ladsgroup I'm thinking maybe a user journey is better to measure instead of
a cold hit? Then we can measure every part of it? Let me explain, I think like
this:
1. You add user timings that is meaningful to you (like either the full JS
execution or parts of it
Ladsgroup added a comment.
Thanks. I started it, the problem is that the URL is not up so we can't merge
the patches, I hope I did them correctly at least. Does that look correct to
you?
TASK DETAIL
https://phabricator.wikimedia.org/T287769
EMAIL PREFERENCES
gerritbot added a project: Patch-For-Review.
TASK DETAIL
https://phabricator.wikimedia.org/T287769
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Peter, gerritbot
Cc: dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, Michael,
gerritbot added a comment.
Change 712966 had a related patch set uploaded (by Ladsgroup; author: Amir
Sarabadani):
[performance/synthetic-monitoring-tests@master] Add query builder
https://gerrit.wikimedia.org/r/712966
TASK DETAIL
https://phabricator.wikimedia.org/T287769
EMAIL
Peter added a comment.
I'll start with this later this week. One thing you can start with is this:
> We don't have ongoing measurement of javascript performance so it might get
worse without us noticing.
You can use the User Timing API
dpifke moved this task from Inbox to Doing: Goal-oriented on the
Performance-Team board.
dpifke assigned this task to Peter.
TASK DETAIL
https://phabricator.wikimedia.org/T287769
WORKBOARD
https://phabricator.wikimedia.org/project/board/1212/
EMAIL PREFERENCES
Lydia_Pintscher added a comment.
You can ;-)
As Amir said, we'd like to deploy the tool as soon as possible.
TASK DETAIL
https://phabricator.wikimedia.org/T287769
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lydia_Pintscher
Cc: dpifke,
Ladsgroup added a comment.
The plan is basically to deploy it really soon. I can't talk on behalf of
WMDE on the final day but it's basically as soon as possible (specially since
the security readiness review is done)
TASK DETAIL
https://phabricator.wikimedia.org/T287769
EMAIL
dpifke added a comment.
Do you have a timeline when you were hoping to launch this?
TASK DETAIL
https://phabricator.wikimedia.org/T287769
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: dpifke
Cc: dpifke, conny-kawohl_WMDE, karapayneWMDE,
Ladsgroup created this task.
Ladsgroup added projects: Performance-Team, Wikidata Query Builder, Wikidata.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
Description
---
//(Please provide the context of the performance review, and describe how the
25 matches
Mail list logo
