[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-11-24 Thread ReleaseTaggerBot
ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.11; 
2021-11-30); removed MW-1.38-notes (1.38.0-wmf.6; 2021-10-26).

TASK DETAIL
  https://phabricator.wikimedia.org/T293860

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot
Cc: cscott, Lucas_Werkmeister_WMDE, Michael, Aklapper, hashar, 786, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Rosalie_WMDE, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, 
aude, Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-11-24 Thread gerritbot
gerritbot added a comment.


  Change 732355 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Rename ParserOutput and OutputPage 
variables to disambiguate
  
  https://gerrit.wikimedia.org/r/732355

TASK DETAIL
  https://phabricator.wikimedia.org/T293860

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: cscott, Lucas_Werkmeister_WMDE, Michael, Aklapper, hashar, 786, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Rosalie_WMDE, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, 
aude, Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread ReleaseTaggerBot
ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.6; 
2021-10-26); removed MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).

TASK DETAIL
  https://phabricator.wikimedia.org/T293860

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot
Cc: cscott, Lucas_Werkmeister_WMDE, Michael, Aklapper, hashar, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread gerritbot
gerritbot added a comment.


  Change 732272 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Update deprecated calls in 
ShortDescHandler
  
  https://gerrit.wikimedia.org/r/732272

TASK DETAIL
  https://phabricator.wikimedia.org/T293860

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: cscott, Lucas_Werkmeister_WMDE, Michael, Aklapper, hashar, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread hashar
hashar closed this task as "Resolved".
hashar added a comment.


  There was just a few of those happening in production (once per hour or so). 
I have deployed the change to production. Thank you for the quick fix!

TASK DETAIL
  https://phabricator.wikimedia.org/T293860

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, hashar
Cc: cscott, Lucas_Werkmeister_WMDE, Michael, Aklapper, hashar, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread Stashbot
Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2021-10-20T17:00:47Z] 
 Synchronized php-1.38.0-wmf.5/extensions/Wikibase/client: 
Update deprecated calls to ParserOutput in ShortDescHandler - T293860 
 (duration: 01m 03s)

TASK DETAIL
  https://phabricator.wikimedia.org/T293860

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Stashbot
Cc: cscott, Lucas_Werkmeister_WMDE, Michael, Aklapper, hashar, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).

TASK DETAIL
  https://phabricator.wikimedia.org/T293860

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot
Cc: cscott, Lucas_Werkmeister_WMDE, Michael, Aklapper, hashar, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread gerritbot
gerritbot added a comment.


  Change 732332 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@wmf/1.38.0-wmf.5] Update deprecated calls in 
ShortDescHandler
  
  https://gerrit.wikimedia.org/r/732332

TASK DETAIL
  https://phabricator.wikimedia.org/T293860

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: cscott, Lucas_Werkmeister_WMDE, Michael, Aklapper, hashar, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread gerritbot
gerritbot added a comment.


  Change 732332 had a related patch set uploaded (by C. Scott Ananian; author: 
Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@wmf/1.38.0-wmf.5] Update deprecated calls in 
ShortDescHandler
  
  https://gerrit.wikimedia.org/r/732332

TASK DETAIL
  https://phabricator.wikimedia.org/T293860

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: cscott, Lucas_Werkmeister_WMDE, Michael, Aklapper, hashar, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread gerritbot
gerritbot added a comment.


  Change 732354 **abandoned** by C. Scott Ananian:
  
  [mediawiki/extensions/Wikibase@master] Rename usages of deprecated 
ParserOutput::{get,set}Property() (take 2)
  
  Reason:
  
  Abandon in favor of I70706415ae657f6783b7ae78e2dbe1b96ca31dbe
  
  https://gerrit.wikimedia.org/r/732354

TASK DETAIL
  https://phabricator.wikimedia.org/T293860

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: cscott, Lucas_Werkmeister_WMDE, Michael, Aklapper, hashar, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  It is covered by tests, the tests just happen to mock the parser output 
instead of using the real implementation.

TASK DETAIL
  https://phabricator.wikimedia.org/T293860

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: cscott, Lucas_Werkmeister_WMDE, Michael, Aklapper, hashar, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread gerritbot
gerritbot added a comment.


  Change 732355 had a related patch set uploaded (by C. Scott Ananian; author: 
C. Scott Ananian):
  
  [mediawiki/extensions/Wikibase@master] Rename ParserOutput and OutputPage 
variables to disambiguate
  
  https://gerrit.wikimedia.org/r/732355

TASK DETAIL
  https://phabricator.wikimedia.org/T293860

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: cscott, Lucas_Werkmeister_WMDE, Michael, Aklapper, hashar, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread cscott
cscott added a comment.


  (Also, just sayin': this would have been caught by CI if 
`ShortDescHandler::doHandle()` were covered by any tests...)

TASK DETAIL
  https://phabricator.wikimedia.org/T293860

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, cscott
Cc: cscott, Lucas_Werkmeister_WMDE, Michael, Aklapper, hashar, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread gerritbot
gerritbot added a comment.


  Change 732354 had a related patch set uploaded (by C. Scott Ananian; author: 
C. Scott Ananian):
  
  [mediawiki/extensions/Wikibase@master] Rename usages of deprecated 
ParserOutput::{get,set}Property() (take 2)
  
  https://gerrit.wikimedia.org/r/732354

TASK DETAIL
  https://phabricator.wikimedia.org/T293860

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: cscott, Lucas_Werkmeister_WMDE, Michael, Aklapper, hashar, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Yeah, I didn’t realize the two classes were so confusingly similar, sorry for 
being a bit too harsh there. (I did a quick git grep and just assumed most of 
them would be other ParserOutput calls, since they were on variables like 
`$out`.)

TASK DETAIL
  https://phabricator.wikimedia.org/T293860

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: cscott, Lucas_Werkmeister_WMDE, Michael, Aklapper, hashar, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread cscott
cscott added a comment.


  In T293860#7443715 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > Okay, maybe not “easily”, given that `OutputPage` has similar methods that 
weren’t renamed, and in the codesearch context it’s not immediately obvious if 
an `$out` variable is a `ParserOutput` or an `OutputPage`.
  
  This.  It's quite hard to tell the difference between OutputPage and 
ParserOutput and apparently I missed a few.  My apologies!
  
  I'll note that one motivation for the change is to more clearly distinguish 
page properties (which are db-backed) from the similar OutputPage properties.

TASK DETAIL
  https://phabricator.wikimedia.org/T293860

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, cscott
Cc: cscott, Lucas_Werkmeister_WMDE, Michael, Aklapper, hashar, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread hashar
hashar added a parent task: T287216: ParserOutput should implement 
ContentMetadataCollector.

TASK DETAIL
  https://phabricator.wikimedia.org/T293860

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, hashar
Cc: Lucas_Werkmeister_WMDE, Michael, Aklapper, hashar, Suran38, Biggs657, 
Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, 
Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread hashar
hashar added a comment.


  That has been deprecated as part of T287216: ParserOutput should implement 
ContentMetadataCollector  specially 
by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/727402 .  A code search 
has definitely been done and the patch has a bunch of `Depends-On`.
  
  There was a patch for Wikibase 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/727403 and I 
guess after that another change introduced ParserOutput:getProperty before the 
hard deprecation patch got merged in core?  Though CI should have caught when 
attempting to merge the mediawiki/core patch.  So I don't quite know :-\

TASK DETAIL
  https://phabricator.wikimedia.org/T293860

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, hashar
Cc: Lucas_Werkmeister_WMDE, Michael, Aklapper, hashar, Suran38, Biggs657, 
Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, 
Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE added a comment.


  Okay, maybe not “easily”, given that `OutputPage` has similar methods that 
weren’t renamed, and in the codesearch context it’s not immediately obvious if 
an `$out` variable is a `ParserOutput` or an `OutputPage`.

TASK DETAIL
  https://phabricator.wikimedia.org/T293860

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Michael, Aklapper, hashar, Suran38, Biggs657, 
Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, 
Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread gerritbot
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T293860

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lucas_Werkmeister_WMDE, Michael, Aklapper, hashar, Suran38, Biggs657, 
Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, 
Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread gerritbot
gerritbot added a comment.


  Change 732272 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] Update deprecated calls in 
ShortDescHandler
  
  https://gerrit.wikimedia.org/r/732272

TASK DETAIL
  https://phabricator.wikimedia.org/T293860

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lucas_Werkmeister_WMDE, Michael, Aklapper, hashar, Invadibot, maantietaja, 
Akuckartz, darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, 
aude, Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Why were `getProperty()` and `setProperty()` hard-deprecated when there are 
still callers in production-deployed extensions that can easily be found with 
codesearch?

TASK DETAIL
  https://phabricator.wikimedia.org/T293860

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Michael, Aklapper, hashar, Invadibot, maantietaja, 
Akuckartz, darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, 
aude, Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread Maintenance_bot
Maintenance_bot added a project: Wikidata.
Restricted Application added a project: wdwb-tech.

TASK DETAIL
  https://phabricator.wikimedia.org/T293860

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: Aklapper, hashar, Invadibot, maantietaja, Akuckartz, darthmon_wmde, 
Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T293860: PHP Deprecated: Use of ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from Wikibase\Client\Hooks\ShortDescHandler::doHandle]

2021-10-20 Thread hashar
hashar created this task.
hashar added projects: Wikimedia-production-error, 
MediaWiki-extensions-WikibaseClient, Wikidata-Campsite.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  Error
  -
  
  - mwversion: `1.38.0-wmf.5`
  - reqId: `b189c229-467f-484e-9b29-c8fe6bd4e5b7`
  - Find reqId in Logstash 

  - Find normalized_message in Logstash 

  
  Deprecated usage of `ParserOutput::getProperty` and 
`ParserOutput::setProperty` in 
extensions/Wikibase/client/includes/Hooks/ShortDescHandler.php(94)
  
  **ParserOutput::setProperty**
  
  name=normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of 
ParserOutput::setProperty was deprecated in MediaWiki 1.38. [Called from 
Wikibase\Client\Hooks\ShortDescHandler::doHandle]
  
  
  
  name=exception.trace
from 
/srv/mediawiki/php-1.38.0-wmf.5/extensions/Wikibase/client/includes/Hooks/ShortDescHandler.php(94)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, 
string, string, array)
#1 /srv/mediawiki/php-1.38.0-wmf.5/includes/debug/MWDebug.php(375): 
trigger_error(string, integer)
#2 /srv/mediawiki/php-1.38.0-wmf.5/includes/debug/MWDebug.php(351): 
MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.38.0-wmf.5/includes/debug/MWDebug.php(230): 
MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.38.0-wmf.5/includes/GlobalFunctions.php(1005): 
MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.38.0-wmf.5/includes/parser/ParserOutput.php(1171): 
wfDeprecated(string, string)
#6 
/srv/mediawiki/php-1.38.0-wmf.5/extensions/Wikibase/client/includes/Hooks/ShortDescHandler.php(94):
 ParserOutput->setProperty(string, string)
#7 
/srv/mediawiki/php-1.38.0-wmf.5/extensions/Wikibase/client/includes/Hooks/ShortDescHandler.php(26):
 Wikibase\Client\Hooks\ShortDescHandler->doHandle(Parser, string, string)
#8 /srv/mediawiki/php-1.38.0-wmf.5/includes/parser/Parser.php(3398): 
Wikibase\Client\Hooks\ShortDescHandler::handle(Parser, string)
#9 /srv/mediawiki/php-1.38.0-wmf.5/includes/parser/Parser.php(3081): 
Parser->callParserFunction(PPFrame_Hash, string, array)
#10 /srv/mediawiki/php-1.38.0-wmf.5/includes/parser/PPFrame_Hash.php(276): 
Parser->braceSubstitution(array, PPFrame_Hash)
#11 /srv/mediawiki/php-1.38.0-wmf.5/includes/parser/Parser.php(2917): 
PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#12 /srv/mediawiki/php-1.38.0-wmf.5/includes/parser/Parser.php(936): 
Parser->replaceVariables(string, PPFrame_Hash)
#13 
/srv/mediawiki/php-1.38.0-wmf.5/includes/api/ApiExpandTemplates.php(145): 
Parser->preprocess(string, Title, ParserOptions, NULL, PPFrame_Hash)
#14 /srv/mediawiki/php-1.38.0-wmf.5/includes/api/ApiMain.php(1878): 
ApiExpandTemplates->execute()
#15 /srv/mediawiki/php-1.38.0-wmf.5/includes/api/ApiMain.php(857): 
ApiMain->executeAction()
#16 /srv/mediawiki/php-1.38.0-wmf.5/includes/api/ApiMain.php(828): 
ApiMain->executeActionWithErrorHandling()
#17 /srv/mediawiki/php-1.38.0-wmf.5/api.php(90): ApiMain->execute()
#18 /srv/mediawiki/php-1.38.0-wmf.5/api.php(45): wfApiMain()
#19 /srv/mediawiki/w/api.php(3): require(string)
#20 {main}
  
  **ParserOutput::getProperty**
  
  name=normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of 
ParserOutput::getProperty was deprecated in MediaWiki 1.38. [Called from 
Wikibase\Client\Hooks\ShortDescHandler::doHandle]
  
  
  
  name=exception.trace
from 
/srv/mediawiki/php-1.38.0-wmf.5/extensions/Wikibase/client/includes/Hooks/ShortDescHandler.php(88)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, 
string, string, array)
#1 /srv/mediawiki/php-1.38.0-wmf.5/includes/debug/MWDebug.php(375): 
trigger_error(string, integer)
#2 /srv/mediawiki/php-1.38.0-wmf.5/includes/debug/MWDebug.php(351): 
MWDebug::sendRawDeprecated(string, boolean, string)
#3 /srv/mediawiki/php-1.38.0-wmf.5/includes/debug/MWDebug.php(230): 
MWDebug::deprecatedMsg(string, string, string, integer)
#4 /srv/mediawiki/php-1.38.0-wmf.5/includes/GlobalFunctions.php(1005): 
MWDebug::deprecated(string, string, string, integer)
#5 /srv/mediawiki/php-1.38.0-wmf.5/includes/parser/ParserOutput.php(1185): 
wfDeprecated(string, string)
#6