[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-11 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo, Maintenance_bot
Cc: Michael, Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Nirmos, Cwek, 
Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Arlolra, Jackmcbarn, 
Mbch331, 786, Suran38, Biggs657, Lalamarie69, Juan90264, Alter-paule, 
Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, 
Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-11 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE assigned this task to Pchelolo.
Lucas_Werkmeister_WMDE added a comment.


  I think this is done, thanks everyone!

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo, Lucas_Werkmeister_WMDE
Cc: Michael, Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, 
786, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Nirmos, Cwek, Wikidata-bugs, aude, 
Dinoguy1000, Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-11 Thread gerritbot 
gerritbot added a comment.


  Change 737943 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Remove \u201Csaved in parser 
cache\u201D workaround
  
  https://gerrit.wikimedia.org/r/737943

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Michael, Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, 
786, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Nirmos, Cwek, Wikidata-bugs, aude, 
Dinoguy1000, Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-10 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Michael, Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, 
786, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Nirmos, Cwek, Wikidata-bugs, aude, 
Dinoguy1000, Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-10 Thread gerritbot 
gerritbot added a comment.


  Change 737943 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] Remove \u201Csaved in parser 
cache\u201D workaround
  
  https://gerrit.wikimedia.org/r/737943

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Michael, Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Nirmos, Cwek, 
Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-09 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: Michael, Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, 
Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Nirmos, Cwek, 
Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Arlolra, Jackmcbarn, 
Mbch331, 786, Suran38, Biggs657, Lalamarie69, Juan90264, Alter-paule, 
Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, 
Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-09 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  Alright, thanks! The Wikibase workaround got merged too, we can later remove 
the one line that regexps out the comment.

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, 
786, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Nirmos, Cwek, Wikidata-bugs, aude, 
Dinoguy1000, Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-09 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ReleaseTaggerBot
Cc: Michael, Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, 
786, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Nirmos, Cwek, Wikidata-bugs, aude, 
Dinoguy1000, Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-09 Thread gerritbot 
gerritbot added a comment.


  Change 737685 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Fix LuaWikibaseIntegrationTest
  
  https://gerrit.wikimedia.org/r/737685

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Michael, Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, 
786, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Nirmos, Cwek, Wikidata-bugs, aude, 
Dinoguy1000, Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-09 Thread Pchelolo 
Pchelolo added a comment.


  ok. I guess I agree. let's squash them together.

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo
Cc: Michael, Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, 
786, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Nirmos, Cwek, Wikidata-bugs, aude, 
Dinoguy1000, Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-09 Thread gerritbot 
gerritbot added a comment.


  Change 737708 **abandoned** by Lucas Werkmeister (WMDE):
  
  [mediawiki/extensions/Wikibase@master] Strip \u201Csaved in parser 
cache\u201D comments from parse response
  
  Reason:
  
  squashed into parent change
  
  https://gerrit.wikimedia.org/r/737708

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Michael, Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, 
786, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Nirmos, Cwek, Wikidata-bugs, aude, 
Dinoguy1000, Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-09 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a subscriber: Michael.
Lucas_Werkmeister_WMDE added a comment.


  In T295357#7492602 , 
@Pchelolo wrote:
  
  > Hm... Indeed you're right, it did remove it by making the content 
uncacheable. But it was a bad thing. 
  > I still stand firm in my believe that it's a problem with tests, not with 
the patch :)
  >
  > What's the possible fix on the server side? We can detect that 
'disablelimitreport' was set, and then strip the 'saved in parser cache' 
comment from the output. But this would be a horrible hack for no reason. If 
it's possible to fix the tests - let's please do it. We can add the horrible 
hack but only if you need more time to fix the tests, the hack would only be 
temporary and will go away.
  
  Well, we can hack around it in our tests, but it’s not really nice either. 
@Michael said on Gerrit:
  
  > Mh, this is ok as a workaround for now to make CI green again, but I think 
I would prefer to remove this line again when the issue is fixed in core
  
  As the API user, I just want the HTML parse for the Wikitext, and I’m not 
interested in extra comments the parser wants to add. (I found/remembered 
another piece of code 

 that assumes there are no comments in the response, though that case probably 
won’t be broken by this change, since it uses text+contentmodel instead of 
page.) `disablelimitreport` has been a fairly reliable way to remove those 
comments so far – if you think it shouldn’t control the “saved in parser cache” 
comment, then maybe there could be a separate flag to disable that comment, but 
I think that should be communicated as a significant change in the output, at 
least.
  
  From a technical perspective, it’s not clear to me why stripping the “saved 
in parser cache” comment would have to be such a horrible hack, when you just 
(apparently) managed to move the limit report around in such a way that parser 
output can be cached regardless of the “disable limit report” setting – can’t 
the “saved in parser cache” part be moved into a similar area separate from the 
main HTML

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, 
786, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Nirmos, Cwek, Wikidata-bugs, aude, 
Dinoguy1000, Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-09 Thread Ladsgroup 
Ladsgroup added a comment.


  Specially given the fact that the timestamp in the report doesn't change.

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, 786, 
Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Nirmos, Cwek, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-09 Thread Ladsgroup 
Ladsgroup added a comment.


  I have been looking into the code to understand the problem better and I have 
a hypothesis now. By putting debugger and such in calling the API, I can 
confirm that it doesn't add the report to the output if `disablelimitreport` is 
set but it still shows up in the result which leads to assuming that it's been 
part of ParserCache output. The fix would be to wait for a month for the old 
cases to expire.

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, 786, 
Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Nirmos, Cwek, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-09 Thread Pchelolo 
Pchelolo added a comment.


  Hm... Indeed you're right, it did remove it by making the content 
uncacheable. But it was a bad thing. 
  I still stand firm in my believe that it's a problem with tests, not with the 
patch :)
  
  What's the possible fix on the server side? We can detect that 
'disablelimitreport' was set, and then strip the 'saved in parser cache' 
comment from the output. But this would be a horrible hack for no reason. If 
it's possible to fix the tests - let's please do it. We can add the horrible 
hack but only if you need more time to fix the tests, the hack would only be 
temporary and will go away.

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo
Cc: Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, 786, 
Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Nirmos, Cwek, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-09 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  > 'disablelimitreport' is a different thing 'saved in parser cache' comment. 
These are 2 completely different comments from different systems. The reason 
'saved in parser cache' started showing up is because we can not save more 
things in parser cache, and I guess one of your tests now has content that can 
be saved. There's never been a way to remove 'saved in parser cache' comment 
from the output.
  
  This might all be technically true, but the practical consequence I see is 
that, previously, `disablelimitreport` effectively removed the “saved in parser 
cache” comment, and now it doesn’t anymore. Even if it only did that by making 
the content uncacheable altogether, that doesn’t change the fact that the API 
output is now different, in my opinion.

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, 786, 
Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Nirmos, Cwek, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-09 Thread Pchelolo 
Pchelolo added a comment.


  'disablelimitreport' is a different thing 'saved in parser cache' comment. 
These are 2 completely different comments from different systems. The reason 
'saved in parser cache' started showing up is because we can not save more 
things in parser cache, and I guess one of your tests now has content that can 
be saved. There's never been a way to remove 'saved in parser cache' comment 
from the output.
  
  The updates to the tests I've made were because limit report comment and 
saved in parser cache comment got reordered.
  
  Agreed with @Ladsgroup that differences in HTML comments not a blocker.

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo
Cc: Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, 786, 
Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Nirmos, Cwek, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-09 Thread Pchelolo 
Pchelolo added a comment.


  > But isn’t this something that should be avoided?
  
  The update to the tests made it ready for reordering of the 2 comments in 
HTML. LimitReport comment now comes after the saved in parser cache comment, 
not before.
  
  I don't think reordering 2 comments in HTML can be considered a breaking 
change. Whatever CI started failing because of it should be updated to not be 
so sensitive.

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo
Cc: Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, 786, 
Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Nirmos, Cwek, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-09 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a project: Wikidata-Campsite (Team A Hearth 🏰🔥).

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, 786, 
Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Nirmos, Cwek, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-09 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  In T295357#7492427 , 
@Ladsgroup wrote:
  
  > 
  
  Also, you can possibly disable limit reporting for the test or the wiki by 
setting `$wgEnableParserLimitReporting` to false.
  
  Surely that can’t be the right fix, given that there’s already a 
`disablelimitreport` API parameter which we send…

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, 786, 
Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Nirmos, Cwek, Wikidata-bugs, aude, Dinoguy1000, 
Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-09 Thread gerritbot 
gerritbot added a comment.


  Change 737708 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] Strip \u201Csaved in parser 
cache\u201D comments from parse response
  
  https://gerrit.wikimedia.org/r/737708

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, 786, 
Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Nirmos, Cwek, Wikidata-bugs, aude, Dinoguy1000, 
Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-09 Thread Ladsgroup 
Ladsgroup added a comment.


  I'm not sure if this is a train blocker, it adds a HTML comment to an API 
response, it changes things but it doesn't break anything as far as I see. 
Tests breaking because heavily depending on the output is a bad pattern 
("brittle test"). Also, you can possibly disable limit reporting for the test 
or the wiki by setting `$wgEnableParserLimitReporting` to false.

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, 786, 
Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Nirmos, Cwek, Wikidata-bugs, aude, Dinoguy1000, 
Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-09 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, 786, 
Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Nirmos, Cwek, Wikidata-bugs, aude, Dinoguy1000, 
Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-09 Thread gerritbot 
gerritbot added a comment.


  Change 737685 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] Refactor LuaWikibaseIntegrationTest
  
  https://gerrit.wikimedia.org/r/737685

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Nirmos, Cwek, 
Wikidata-bugs, aude, Dinoguy1000, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-09 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  Tentatively marking as a train blocker, since I assume it will affect other 
`action=parse` users as well.

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Nirmos, Cwek, 
Wikidata-bugs, aude, Dinoguy1000, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-09 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a parent task: T293950: 1.38.0-wmf.9 deployment 
blockers.

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Nirmos, Cwek, 
Wikidata-bugs, aude, Dinoguy1000, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-09 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  It looks like the commit also anticipates this API change, by updating the 
ApiParse tests:
  
diff --git a/tests/phpunit/includes/api/ApiParseTest.php 
b/tests/phpunit/includes/api/ApiParseTest.php
index 4e54c44729..b9bf2d2425 100644
--- a/tests/phpunit/includes/api/ApiParseTest.php
+++ b/tests/phpunit/includes/api/ApiParseTest.php
@@ -100,6 +100,9 @@ private function doAssertParsedTo( $expected, array 
$res, $warnings, callable $c
 
 $html = substr( $html, strlen( $expectedStart ) );
 
+$possibleParserCache = '/\n)\n/';
+$html = preg_replace( $possibleParserCache, '', $html );
+
 if ( $res[1]->getBool( 'disablelimitreport' ) ) {
 $expectedEnd = "";
 $this->assertSame( $expectedEnd, substr( $html, -strlen( 
$expectedEnd ) ) );
@@ -112,7 +115,7 @@ private function doAssertParsedTo( $expected, array 
$res, $warnings, callable $c
 } else {
 $expectedEnd = '#\n)\n' .
 ')\n' .
-'(\n)\n)?$#s';
+'$#s';
 $this->assertRegExp( $expectedEnd, $html );
 
 $html = preg_replace( $expectedEnd, '', $html );
  
  But isn’t this something that should be avoided?

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Nirmos, Cwek, 
Wikidata-bugs, aude, Dinoguy1000, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-09 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  > Move limit report rendering to ParserOutput 
 looks like the most 
likely culprit to me.
  
  Confirmed – I managed to reproduce the error locally 
(`node_modules/.bin/mocha --timeout 0 
tests/api-testing/LuaWikibaseIntegrationTest.js` in the Wikibase directory, 
assuming you have an `.api-testing.config.json` config file there), and 
reverting that commit fixes the errors.

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Nirmos, Cwek, 
Wikidata-bugs, aude, Dinoguy1000, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set

2021-11-09 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, MediaWiki-Parser.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  Wikibase gate-and-submit builds are failing (example build 
)
 because the `action=parse` API returns an unexpected HTML comment now:
  
  counterexample
AssertionError: expected '\n\n' to equal ''
+ expected - actual

-
-
  
  Usually, this comment is only there when the `disablelimitreport` parameter 
is not set. Compare this English Wikipedia request 

 with this Beta English Wikipedia Request 

 using the same parameters – the Beta version has this extra comment as well:
  
\n
  
  Note that this only happens when using `page=`, not with `text=` + 
`contentmodel=wikitext`. (Which makes sense – with `text=`, you wouldn’t expect 
the result to be stored in the parser cache.)
  
  I think this is a regression in MediaWiki core that should be fixed there, 
rather than being handled in the Wikibase API integration tests – other API 
users might also expect the `action=parse&disablelimitreport=` result to not 
have this comment. Move limit report rendering to ParserOutput 
 looks like the most 
likely culprit to me.

TASK DETAIL
  https://phabricator.wikimedia.org/T295357

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Ladsgroup, daniel, Pchelolo, Lucas_Werkmeister_WMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Nirmos, Cwek, 
Wikidata-bugs, aude, Dinoguy1000, Arlolra, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org