[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

2022-01-18 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE moved this task from Peer Review to Our work done on the 
Wikidata-Campsite (Team A Hearth ) board.
Lucas_Werkmeister_WMDE added a comment.


  Wikibase CI is looking much better as far as I can tell; 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/545650 still 
has errors after rebasing, but they’re different ones now. I think we can close 
this particular task as done.

TASK DETAIL
  https://phabricator.wikimedia.org/T298682

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5612/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, aaron, Aklapper, kostajh, hashar, Invadibot, 
maantietaja, Akuckartz, DannyS712, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, zeljkofilipin, Jdforrester-WMF, Addshore, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

2022-01-18 Thread ReleaseTaggerBot 
ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.19; 
2022-01-24); removed MW-1.38-notes (1.38.0-wmf.18; 2022-01-17).

TASK DETAIL
  https://phabricator.wikimedia.org/T298682

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot
Cc: Lucas_Werkmeister_WMDE, aaron, Aklapper, kostajh, hashar, Invadibot, 
maantietaja, Akuckartz, DannyS712, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, zeljkofilipin, Jdforrester-WMF, Addshore, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

2022-01-18 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T298682

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Maintenance_bot
Cc: Lucas_Werkmeister_WMDE, aaron, Aklapper, kostajh, hashar, Invadibot, 
maantietaja, Akuckartz, DannyS712, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, zeljkofilipin, Jdforrester-WMF, Addshore, 
Mbch331, 786, Suran38, Biggs657, Lalamarie69, Juan90264, Alter-paule, 
Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, 
Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

2022-01-18 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  Alright, let’s see if these errors happen less often now.

TASK DETAIL
  https://phabricator.wikimedia.org/T298682

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, aaron, Aklapper, kostajh, hashar, 786, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, zeljkofilipin, Jdforrester-WMF, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

2022-01-18 Thread gerritbot 
gerritbot added a comment.


  Change 754495 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Support idGenerator=auto and use it in 
CI
  
  https://gerrit.wikimedia.org/r/754495

TASK DETAIL
  https://phabricator.wikimedia.org/T298682

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, aaron, Aklapper, kostajh, hashar, 786, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, zeljkofilipin, Jdforrester-WMF, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

2022-01-18 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a project: Wikidata-Campsite (Team A Hearth ).

TASK DETAIL
  https://phabricator.wikimedia.org/T298682

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, aaron, Aklapper, kostajh, hashar, 786, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, zeljkofilipin, Jdforrester-WMF, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

2022-01-17 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.18; 2022-01-17).

TASK DETAIL
  https://phabricator.wikimedia.org/T298682

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot
Cc: Lucas_Werkmeister_WMDE, aaron, Aklapper, kostajh, hashar, 786, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, zeljkofilipin, 
Jdforrester-WMF, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

2022-01-17 Thread gerritbot 
gerritbot added a comment.


  Change 754500 **merged** by jenkins-bot:
  
  [mediawiki/core@master] Add ConnectionManager::getLazyWriteConnectionRef()
  
  https://gerrit.wikimedia.org/r/754500

TASK DETAIL
  https://phabricator.wikimedia.org/T298682

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, aaron, Aklapper, kostajh, hashar, 786, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, zeljkofilipin, 
Jdforrester-WMF, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

2022-01-17 Thread gerritbot 
gerritbot added a comment.


  Change 754500 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/core@master] Add ConnectionManager::getLazyWriteConnectionRef()
  
  https://gerrit.wikimedia.org/r/754500

TASK DETAIL
  https://phabricator.wikimedia.org/T298682

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, aaron, Aklapper, kostajh, hashar, 786, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, zeljkofilipin, 
Jdforrester-WMF, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

2022-01-17 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE added a comment.


  I went with a compromise between the two suggestions, introducing an `auto` 
type but only configuring it in CI and not yet making it the default.

TASK DETAIL
  https://phabricator.wikimedia.org/T298682

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, aaron, Aklapper, kostajh, hashar, 786, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, zeljkofilipin, 
Jdforrester-WMF, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

2022-01-17 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T298682

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lucas_Werkmeister_WMDE, aaron, Aklapper, kostajh, hashar, 786, Suran38, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, 
CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, zeljkofilipin, 
Jdforrester-WMF, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

2022-01-17 Thread gerritbot 
gerritbot added a comment.


  Change 754495 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] Support idGenerator=auto and use it in 
CI
  
  https://gerrit.wikimedia.org/r/754495

TASK DETAIL
  https://phabricator.wikimedia.org/T298682

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lucas_Werkmeister_WMDE, aaron, Aklapper, kostajh, hashar, Invadibot, 
maantietaja, Akuckartz, DannyS712, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, zeljkofilipin, Jdforrester-WMF, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

2022-01-17 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  It looks like this is now sometimes happening even with non-parallel builds 
(unless you changed something so they’re parallel by default?), e.g. in #96773 

 for change 731277 
.

TASK DETAIL
  https://phabricator.wikimedia.org/T298682

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, aaron, Aklapper, kostajh, hashar, Invadibot, 
maantietaja, Akuckartz, DannyS712, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, zeljkofilipin, Jdforrester-WMF, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

2022-01-17 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  Or maybe the default config should be that Wikibase autodetects whether MySQL 
is used or not? (In production I think we’d still want to explicitly configure 
this particular implementation.) The `UpsertSqlIdGenerator` is well tested in 
production by this point, and I’m not aware of any reason not to use it if 
you’re on MySQL.

TASK DETAIL
  https://phabricator.wikimedia.org/T298682

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, aaron, Aklapper, kostajh, hashar, Invadibot, 
maantietaja, Akuckartz, DannyS712, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, zeljkofilipin, Jdforrester-WMF, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

2022-01-17 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  In T298682#7601346 , 
@hashar wrote:
  
  > I am guessing the CI config would require a similar adjustment?
  
  Yes, we might want to set
  
$wgWBRepoSettings['idGenerator'] = 'mysql-upsert';
  
  However, that’s MySQL/MariaDB-specific (as the value implies), and I don’t 
know if we support / plan to support running Wikibase CI on other RDBMSes, so 
I’m not sure if this belongs into Wikibase’s `repo/config/Wikibase.ci.php` or 
should be somewhere else.

TASK DETAIL
  https://phabricator.wikimedia.org/T298682

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, aaron, Aklapper, kostajh, hashar, Invadibot, 
maantietaja, Akuckartz, DannyS712, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, zeljkofilipin, Jdforrester-WMF, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

2022-01-06 Thread aaron 
aaron added a comment.


  \Wikibase\Repo\Store\Sql\SqlIdGenerator definitely looks prone to deadlocks. 
It should probably work more like TableNameStore (named locks + auto-commit 
trx).

TASK DETAIL
  https://phabricator.wikimedia.org/T298682

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: aaron
Cc: aaron, Aklapper, kostajh, hashar, Invadibot, maantietaja, Akuckartz, 
DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
zeljkofilipin, Jdforrester-WMF, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

2022-01-06 Thread kostajh 
kostajh added projects: MediaWiki-extensions-WikibaseRepository, Browser-Tests.

TASK DETAIL
  https://phabricator.wikimedia.org/T298682

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: Aklapper, kostajh, hashar, Invadibot, maantietaja, Akuckartz, DannyS712, 
Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, zeljkofilipin, 
Jdforrester-WMF, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

2022-01-06 Thread hashar 
hashar added a comment.


  Maybe related is T194299 , there 
are mentions of `$wgWBRepoSettings['idGenerator'] = 'mysql-upsert'`, I don't 
know what the default is or what is set on the CI job.
  
  The comment T194299#4840260 
 has the same deadlock on 
INSERT then there are tasks to use a separate database connection for the id 
generator: T213817  and T215147 
.
  
  I am guessing the CI config would require a similar adjustment?

TASK DETAIL
  https://phabricator.wikimedia.org/T298682

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar
Cc: Aklapper, kostajh, hashar, Invadibot, maantietaja, Akuckartz, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

2022-01-06 Thread hashar 
hashar added a parent task: T226869: Run browser tests in parallel.

TASK DETAIL
  https://phabricator.wikimedia.org/T298682

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar
Cc: Aklapper, kostajh, hashar, Invadibot, maantietaja, Akuckartz, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298682: Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId deadlock on wb_id_counters when running selenium tests in parallel

2022-01-06 Thread hashar 
hashar created this task.
hashar added projects: Wikidata, ci-test-error.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: wdwb-tech.

TASK DESCRIPTION
  The webdriver.io Selenium tests are run serially. As part of T226869 
 I have made a change to run up to 4 
tests in parallel with 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/545650 which 
has failures.
  
  counterexample, name=repo/tests/selenium/specs/item.js
Error in "item.can add a statement using the keyboard"
Error: internal_api_error_DBQueryError: [3b6a7dfcb49300fd1f95a0e6] 
Exception caught: A database query error has occurred. This may indicate a bug 
in the software.
  
  There is db error attached to the CI build:
  
Wed Jan 5 20:01:59 UTC 2022 030379ee3accwikidb  Error 1213 from 
Wikibase\Repo\Store\Sql\SqlIdGenerator::generateNewId, Deadlock found when 
trying to get lock; try restarting transaction 
(localhost:/workspace/db/quibble-mysql-fkbo30y1/socket) INSERT INTO 
`wb_id_counters` (id_value,id_type) VALUES (1,'wikibase-item') 
localhost:/workspace/db/quibble-mysql-fkbo30y1/socket
#0 /workspace/src/includes/libs/rdbms/database/Database.php(1758): 
Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, 
string)
#1 /workspace/src/includes/libs/rdbms/database/Database.php(1302): 
Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, 
boolean)
#2 /workspace/src/includes/libs/rdbms/database/Database.php(2530): 
Wikimedia\Rdbms\Database->query(string, string, integer)
#3 /workspace/src/includes/libs/rdbms/database/Database.php(2510): 
Wikimedia\Rdbms\Database->doInsert(string, array, string)
#4 
/workspace/src/extensions/Wikibase/repo/includes/Store/Sql/SqlIdGenerator.php(103):
 Wikimedia\Rdbms\Database->insert(string, array, string)
#5 
/workspace/src/extensions/Wikibase/repo/includes/Store/Sql/SqlIdGenerator.php(59):
 
Wikibase\Repo\Store\Sql\SqlIdGenerator->generateNewId(Wikimedia\Rdbms\DatabaseMysqli,
 string)
#6 
/workspace/src/extensions/Wikibase/repo/includes/Store/RateLimitingIdGenerator.php(37):
 Wikibase\Repo\Store\Sql\SqlIdGenerator->getNewId(string)
#7 
/workspace/src/extensions/Wikibase/repo/includes/Store/Sql/WikiPageEntityStore.php(166):
 Wikibase\Repo\Store\RateLimitingIdGenerator->getNewId(string)
#8 
/workspace/src/extensions/Wikibase/lib/includes/Store/TypeDispatchingEntityStore.php(59):
 
Wikibase\Repo\Store\Sql\WikiPageEntityStore->assignFreshId(Wikibase\DataModel\Entity\Item)
#9 
/workspace/src/extensions/Wikibase/repo/includes/Api/EntitySavingHelper.php(298):
 
Wikibase\Lib\Store\TypeDispatchingEntityStore->assignFreshId(Wikibase\DataModel\Entity\Item)
#10 
/workspace/src/extensions/Wikibase/repo/includes/Api/EntitySavingHelper.php(228):
 Wikibase\Repo\Api\EntitySavingHelper->createEntity(string, NULL, string)
#11 
/workspace/src/extensions/Wikibase/repo/includes/Api/ModifyEntity.php(381): 
Wikibase\Repo\Api\EntitySavingHelper->loadEntity(array, NULL, string)
#12 
/workspace/src/extensions/Wikibase/repo/includes/Api/ModifyEntity.php(305): 
Wikibase\Repo\Api\ModifyEntity->loadEntityFromSavingHelper(NULL)
#13 /workspace/src/includes/api/ApiMain.php(1889): 
Wikibase\Repo\Api\ModifyEntity->execute()
#14 /workspace/src/includes/api/ApiMain.php(868): ApiMain->executeAction()
#15 /workspace/src/includes/api/ApiMain.php(839): 
ApiMain->executeActionWithErrorHandling()
#16 /workspace/src/api.php(90): ApiMain->execute()
#17 /workspace/src/api.php(45): wfApiMain()
#18 {main}
  
  This can be reproduced by setting wdio maxInstances to 4:
  
  https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/545650

TASK DETAIL
  https://phabricator.wikimedia.org/T298682

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar
Cc: Aklapper, kostajh, hashar, Invadibot, maantietaja, Akuckartz, DannyS712, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org