[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Sarai-WMDE added a comment. > But just wondering if we should keep the button on failed uploads? Agh, good point. Sounds like a big oversight to me. The primary use of that button would be to allow uploaders to check the updated status of their CSV files. Failed uploads won't collect

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Arian_Bozorg closed this task as "Resolved". Arian_Bozorg moved this task from Product Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T304794 WORKBOARD https://phabricator.wikimedia.org/project/board/6017/ EMAIL

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Arian_Bozorg added a comment. This looks all good according to the acceptance criteria! Thank you so much :) But just wondering if we should keep the button on failed uploads? TASK DETAIL https://phabricator.wikimedia.org/T304794 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Sarai-WMDE added a comment. LGTUX! Buttons looking awesome and consistent. Thanks, Lucas! TASK DETAIL https://phabricator.wikimedia.org/T304794 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Sarai-WMDE Cc:

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Lucas_Werkmeister_WMDE moved this task from Peer Review to Product Verification on the Wikidata Dev Team (Sprint-∞) board. Lucas_Werkmeister_WMDE added a comment. Okay, should be ready to verify at https://mismatch-finder.toolforge.org/store/imports now :) TASK DETAIL

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Sarai-WMDE added a comment. > I mean, I’ve uploaded what I think is a fix… and when I try that pull request locally, it looks to me like the Wikit GIFs you posted. Yep. Should have taken a look at the PR before posting that. Your previous comment made me assume that the only change done

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Lucas_Werkmeister_WMDE added a comment. > I'd say we shouldn't spend any more time on this unless the fix is apparent right away. I mean, I’ve uploaded what I think is a fix… and when I try that pull request locally, it looks to me like the Wikit GIFs you posted. TASK DETAIL

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Sarai-WMDE added a subscriber: LucasWerkmeister. Sarai-WMDE added a comment. Hey, @LucasWerkmeister. Thanks so much for looking into this! Sorry for being so vague in that initial comment. The difference in styling is not only related to the box-shadow, but to the active background and

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board. Lucas_Werkmeister_WMDE added a comment. Alright, I think it was the `box-shadow` indeed (at least I didn’t notice a difference when reordering the pseudo-classes):

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T304794 WORKBOARD https://phabricator.wikimedia.org/project/board/6017/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T304794 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: guergana.tzatchkova, noarave,

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Sarai-WMDE added a comment. Even if the token replacement was correctly done, the Mismatch Store buttons are not displaying the same styling as WiKit buttons when active. My guess is that this might be due to the order of the pseudo-classes: compare WiKit

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Sarai-WMDE added a comment. Indeed! Thanks for the exhaustive value/token replacement, Lucas  TASK DETAIL https://phabricator.wikimedia.org/T304794 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Sarai-WMDE Cc:

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board. Lucas_Werkmeister_WMDE added a comment. Fun fact: the difference between the buttons’ font-family is -'Lato', sans-serif +-apple-system, "BlinkMacSystemFont", "Segoe UI",

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board. TASK DETAIL https://phabricator.wikimedia.org/T304794 WORKBOARD https://phabricator.wikimedia.org/project/board/6017/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Sarai-WMDE added a comment. > Hi, @Sarai-WMDE I am a bit confused by the comment. Which one has the correct font? The primary WiKit button used to 'Download statistics' displays the right styles. The font styles of the new 'Download CSV' button seem to be overridden by the

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

guergana.tzatchkova added a comment. In T304794#8497452 , @Sarai-WMDE wrote: > Positioning and behavior look great! Nevertheless, the 'Download CSV' button seems to be inheriting the app's font styles (font-weight and family), which

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Sarai-WMDE attached a referenced file: F35971449: Screenshot 2023-01-04 at 11.35.22.png. TASK DETAIL https://phabricator.wikimedia.org/T304794 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: noarave, Michael, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

noarave moved this task from Product Verification to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board. noarave added a comment. Moving back to To Do since style is not fixed yet TASK DETAIL https://phabricator.wikimedia.org/T304794 WORKBOARD

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Sarai-WMDE added a comment. Positioning and behavior look great! Nevertheless, the 'Download CSV' button seems to be inheriting the app's font styles (font-weight and family), which are overriding WiKit's. Here's a screenshot of the two buttons for comparison: {F35971449} This made

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

noarave closed subtask T325159: Add link for import results CSV to import status page as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T304794 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave Cc: Michael, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

noarave closed subtask T325158: Add route for import results CSV as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T304794 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave Cc: Michael, Lucas_Werkmeister_WMDE, Sarai-WMDE, Aklapper,

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

noarave closed subtask T325177: Give import results CSVs a more specific file name as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T304794 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave Cc: Michael, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Sarai-WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T304794 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE Cc: Michael, Lucas_Werkmeister_WMDE, Sarai-WMDE, Aklapper, Lydia_Pintscher, Astuthiodit_1,

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Sarai-WMDE added a comment. >> 2. Button copy & icon: Is there a clearer way to express the action (e.g. 'Download csv file')? > > How about something like "Download review results" or "Download review decisions" or "Download results"? Thanks for the copy proposals! They would all

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Lydia_Pintscher added a comment. Makes sense. Extra subtask or not: As you prefer. TASK DETAIL https://phabricator.wikimedia.org/T304794 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lucas_Werkmeister_WMDE, Sarai-WMDE,

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Lucas_Werkmeister_WMDE added a comment. @Lydia_Pintscher: In task breakdown, we decided that the URL should look like https://mismatch-finder.toolforge.org/store/imports//results.csv; however, we think it would make sense to add a response header so that the name under which the file is

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

karapayneWMDE moved this task from Unified prioritized backlog to Sprint-∞ on the Wikidata Dev Team board. karapayneWMDE edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T304794 WORKBOARD

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

karapayneWMDE set the point value for this task to "8". TASK DETAIL https://phabricator.wikimedia.org/T304794 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: karapayneWMDE Cc: Sarai-WMDE, Aklapper, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE,

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Lydia_Pintscher added a comment. In T304794#8457425 , @Sarai-WMDE wrote: > Initial mocks are available in this Figma page .

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Sarai-WMDE added a comment. Initial mocks are available in this Figma page . Some open questions: 1. Button placement: I don’t think it’s a problem, but if we feel that the

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Lydia_Pintscher added a subscriber: Sarai-WMDE. Lydia_Pintscher added a comment. handing this over to @Sarai-WMDE for a mockup TASK DETAIL https://phabricator.wikimedia.org/T304794 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T304794 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Aklapper, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja,

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Arian_Bozorg updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T304794 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Aklapper, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja,

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Lydia_Pintscher added a project: Wikidata Dev Team. Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T304794 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Aklapper, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Lydia_Pintscher triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T304794 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Aklapper, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot,

[Wikidata-bugs] [Maniphest] T304794: Give mismatch providers access to reviews for their uploads

Lydia_Pintscher created this task. Lydia_Pintscher added projects: Mismatch Finder, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION As a mismatch provider I want to see what reviews mismatch reviewers made on mismatches I uploaded in order to better understand