[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[Jdrewniak]

Jdrewniak removed Jdrewniak as the assignee of this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdrewniak
Cc: Jdrewniak, Edtadros, bwang, alexhollender_WMF, Aklapper, ovasileva, 
Jdlrobson, sgrabarczuk, KieranMcCann, Remagoxer, Romain, Theklan, me, JCW555, 
hnijhuis, Nishu02, BeautifulBold, Suran38, Patafisik_WMF, Selby, Peteosx1x, 
NavinRizwi, Winter, Iniquity, Wikidata-bugs, Dinoguy1000, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[Jdrewniak]

Jdrewniak moved this task from Incoming to Groomed on the Web-Team-Backlog 
board.
Jdrewniak added a comment.


  It seems like this issue is still present. To summarize my understanding, 
there was a patch 

 merged into PageBanner, but it didn't actually fix the issue. From @bwang's 
comment on that patch:
  
  > After some more investigating, there are two issues that need to be fixed 
for this task to work.
  >
  > 1. Ensure stickyHeader.js can query for a unique "heading" element on pages 
with page banners. Either by updating the selector used in Vector to be a 
class, or by adding code to the page banner extension that removes the original 
h1 element.
  > 2. The template data for the title is empty when page banner is used, still 
unsure if that's something that can be updated in page banner extension or can 
be handled in Vector.
  
  Additionally, the stickyHeader namespace logic is handled client-side with 
this this line 

  
const allowedNamespaceNumbers = [ 0, 2, 4, 10, 12, 14, 100, 828 ];
  
  which doesn't include namespace 104, for pages like: 
https://eu.wikipedia.org/wiki/Txikipedia:Munduko_zazpi_mirariak.

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

WORKBOARD
  https://phabricator.wikimedia.org/project/board/67/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdrewniak
Cc: Edtadros, bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, 
sgrabarczuk, KieranMcCann, Remagoxer, Romain, Theklan, me, JCW555, hnijhuis, 
Nishu02, BeautifulBold, Suran38, Patafisik_WMF, Selby, Peteosx1x, NavinRizwi, 
Winter, Iniquity, Wikidata-bugs, Dinoguy1000, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[Jdlrobson]

Jdlrobson assigned this task to Jdrewniak.

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdrewniak, Jdlrobson
Cc: Edtadros, bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, 
sgrabarczuk, KieranMcCann, Remagoxer, Romain, Theklan, me, JCW555, hnijhuis, 
Nishu02, BeautifulBold, Suran38, Patafisik_WMF, Selby, Peteosx1x, NavinRizwi, 
Winter, Iniquity, Wikidata-bugs, Dinoguy1000, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[bwang]

bwang removed bwang as the assignee of this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bwang
Cc: Edtadros, bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, 
sgrabarczuk, KieranMcCann, Remagoxer, Romain, Theklan, JCW555, hnijhuis, 
Nishu02, BeautifulBold, Suran38, Patafisik_WMF, Selby, Universal_Omega, 
Peteosx1x, NavinRizwi, Demian, Winter, Iniquity, Agabi10, Volker_E, 
Wikidata-bugs, Dinoguy1000, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[ovasileva]

ovasileva edited parent tasks, added: T317632: [EPIC] Visual refinements pt2; 
removed: T301780: [Epic] Visual design & layout refinements.

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bwang, ovasileva
Cc: Edtadros, bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, 
sgrabarczuk, KieranMcCann, Remagoxer, Romain, Theklan, hnijhuis, Nishu02, 
BeautifulBold, Suran38, Patafisik_WMF, Selby, Universal_Omega, Peteosx1x, 
NavinRizwi, Demian, Winter, JJMC89, Iniquity, Agabi10, Volker_E, Wikidata-bugs, 
Dinoguy1000, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[ovasileva]

ovasileva edited projects, added Readers-Web-Backlog; removed 
Readers-Web-Backlog (Kanbanana-FY-2021-22).

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bwang, ovasileva
Cc: Edtadros, bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, 
sgrabarczuk, KieranMcCann, Remagoxer, Romain, Theklan, Nishu02, BeautifulBold, 
Suran38, Patafisik_WMF, Selby, Universal_Omega, Peteosx1x, NavinRizwi, Demian, 
Winter, JJMC89, Iniquity, Agabi10, Volker_E, Wikidata-bugs, Dinoguy1000, 
Lydia_Pintscher, cjming
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[Aklapper]

Aklapper removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bwang, Aklapper
Cc: Edtadros, bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, 
sgrabarczuk, KieranMcCann, Remagoxer, Romain, Theklan, Nishu02, BeautifulBold, 
Suran38, Patafisik_WMF, cjming, Selby, Universal_Omega, Peteosx1x, NavinRizwi, 
Demian, Winter, JJMC89, Iniquity, Agabi10, Volker_E, Wikidata-bugs, 
Dinoguy1000, Lydia_Pintscher, Hellket777, 786, Biggs657, Juan90264, 
Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, 
Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, 
Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[bwang]

bwang added a comment.


  I tagged the wrong task, pls ignore the patch above

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bwang
Cc: Edtadros, bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, 
sgrabarczuk, KieranMcCann, Remagoxer, Romain, Theklan, Hellket777, Nishu02, 
BeautifulBold, 786, Suran38, Biggs657, Patafisik_WMF, cjming, Selby, 
Universal_Omega, Juan90264, Peteosx1x, Alter-paule, NavinRizwi, Beast1978, 
Un1tY, Demian, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, 
Cpaulf30, Af420, Bsandipan, Winter, Lewizho99, JJMC89, Maathavan, Iniquity, 
Agabi10, Neuronton, Volker_E, Wikidata-bugs, Dinoguy1000, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bwang, gerritbot
Cc: Edtadros, bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, 
sgrabarczuk, KieranMcCann, Remagoxer, Romain, Theklan, Hellket777, Nishu02, 
BeautifulBold, 786, Suran38, Biggs657, Patafisik_WMF, cjming, Selby, 
Universal_Omega, Juan90264, Peteosx1x, Alter-paule, NavinRizwi, Beast1978, 
Un1tY, Demian, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, 
Cpaulf30, Af420, Bsandipan, Winter, Lewizho99, JJMC89, Maathavan, Iniquity, 
Agabi10, Neuronton, Volker_E, Wikidata-bugs, Dinoguy1000, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[gerritbot]

gerritbot added a comment.


  Change 807219 had a related patch set uploaded (by Bernard Wang; author: 
Bernard Wang):
  
  [mediawiki/skins/Vector@master] WIP: Add collapsed TOC to sticky header
  
  https://gerrit.wikimedia.org/r/807219

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bwang, gerritbot
Cc: Edtadros, bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, 
sgrabarczuk, KieranMcCann, Remagoxer, Romain, Theklan, Nishu02, BeautifulBold, 
Suran38, Patafisik_WMF, cjming, Selby, Universal_Omega, Peteosx1x, NavinRizwi, 
Demian, Winter, JJMC89, Iniquity, Agabi10, Volker_E, Wikidata-bugs, 
Dinoguy1000, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[Theklan]

Theklan added a comment.


  Atari is Portal. Is NS 100, and it's used in all Wikimedia projects. Totally 
related: T303258 , where I explain 
why portals should be also considered by the design team.
  
  I think that for consistency the sticky header should be shown in any page, 
regardless of the ns.

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bwang, Theklan
Cc: Edtadros, bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, 
sgrabarczuk, KieranMcCann, Remagoxer, Romain, Theklan, Nishu02, BeautifulBold, 
Suran38, Patafisik_WMF, cjming, Selby, Universal_Omega, Peteosx1x, NavinRizwi, 
Demian, Winter, JJMC89, Iniquity, Agabi10, Volker_E, Wikidata-bugs, 
Dinoguy1000, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[ovasileva]

ovasileva added a comment.


  In T306744#8042604 , 
@Jdlrobson wrote:
  
  > https://eu.wikipedia.org/wiki/Atari:Hezkuntza/Lehiaketak/2022/04 is 
namespace 100.
  > https://eu.wikipedia.org/wiki/Txikipedia:Munduko_zazpi_mirariak is 
namespace 104.
  >
  > @bwang is correct that the sticky header is not enabled on either of these 
namespaces:
  > 
https://gerrit.wikimedia.org/g/mediawiki/skins/Vector/+/615181154cf668a54220b18e77b994d4d64668b1/resources/skins.vector.es6/stickyHeader.js#467
  > .
  
  I think this is okay?  I'm not entirely sure what the atari namespace is.  
For Txikipedia - I suppose it would make sense to have the header appear here 
for consistency with the main namespace.  On the other hand, few of the 
articles here are long enough to make it particularly useful (by design).  
@Theklan - any thoughts on this one?

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bwang, ovasileva
Cc: Edtadros, bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, 
sgrabarczuk, KieranMcCann, Remagoxer, Romain, Theklan, Nishu02, BeautifulBold, 
Suran38, Patafisik_WMF, cjming, Selby, Universal_Omega, Peteosx1x, NavinRizwi, 
Demian, Winter, JJMC89, Iniquity, Agabi10, Volker_E, Wikidata-bugs, 
Dinoguy1000, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[Jdlrobson]

Jdlrobson moved this task from Needs More Work to Ready for Signoff on the 
Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson added a comment.


  https://eu.wikipedia.org/wiki/Atari:Hezkuntza/Lehiaketak/2022/04 is namespace 
100.
  https://eu.wikipedia.org/wiki/Txikipedia:Munduko_zazpi_mirariak is namespace 
104.
  
  @bwang is correct that the sticky header is not enabled on either of these 
namespaces:
  
https://gerrit.wikimedia.org/g/mediawiki/skins/Vector/+/615181154cf668a54220b18e77b994d4d64668b1/resources/skins.vector.es6/stickyHeader.js#467
  
  I suggest creating a follow up to task to add them if we want that.

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5465/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bwang, Jdlrobson
Cc: Edtadros, bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, 
sgrabarczuk, KieranMcCann, Remagoxer, Romain, Theklan, Nishu02, BeautifulBold, 
Suran38, Patafisik_WMF, cjming, Selby, Universal_Omega, Peteosx1x, NavinRizwi, 
Demian, Winter, JJMC89, Iniquity, Agabi10, Volker_E, Wikidata-bugs, 
Dinoguy1000, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[bwang]

bwang added a comment.


  Ok I figured it out, my previous patch didnt work because the original 
#firstHeading element was just hidden with CSS, when it really needs to be 
removed so that there is a unique element to query for for the sticky 
intersection element

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bwang
Cc: Edtadros, bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, 
sgrabarczuk, KieranMcCann, Remagoxer, Romain, Theklan, Nishu02, BeautifulBold, 
Suran38, Patafisik_WMF, cjming, Selby, Universal_Omega, Peteosx1x, NavinRizwi, 
Demian, Winter, JJMC89, Iniquity, Agabi10, Volker_E, Wikidata-bugs, 
Dinoguy1000, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[bwang]

bwang added a comment.


  I'm still investigating why the sticky header isnt showing. For the first 
link in the description 
(https://eu.wikipedia.org/wiki/Txikipedia:Munduko_zazpi_mirariak) I believe its 
because the sticky header isnt available in that namespace 104. For the second, 
(https://eu.wikipedia.org/wiki/Atari:Hezkuntza/Lehiaketak/2022/04) I havent 
found any obvious reason why its not working. I probably have to setup page 
banners locally to reproduce and debug.

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bwang
Cc: Edtadros, bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, 
sgrabarczuk, KieranMcCann, Remagoxer, Romain, Theklan, Nishu02, BeautifulBold, 
Suran38, Patafisik_WMF, cjming, Selby, Universal_Omega, Peteosx1x, NavinRizwi, 
Demian, Winter, JJMC89, Iniquity, Agabi10, Volker_E, Wikidata-bugs, 
Dinoguy1000, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[bwang]

bwang claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bwang
Cc: Edtadros, bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, 
sgrabarczuk, KieranMcCann, Remagoxer, Romain, Theklan, Nishu02, BeautifulBold, 
Suran38, Patafisik_WMF, cjming, Selby, Universal_Omega, Peteosx1x, NavinRizwi, 
Demian, Winter, JJMC89, Iniquity, Agabi10, Volker_E, Wikidata-bugs, 
Dinoguy1000, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[Edtadros]

Edtadros reassigned this task from Edtadros to ovasileva.
Edtadros added a comment.


  Test Result - Prod
  --
  
  **Status:** ❓ 
  **Environment:** euwiki
  **OS:** macOS Monterey
  **Browser:** Chrome
  **Device:** MBP
  **Emulated Device:**NA
  
  **Test Artifact(s):**
  
  QA Steps
  
  
  ❓ AC1: @ovasileva , I initially thought that what should happen based on the 
description is that the sticky header would show.  However, since I wasn't able 
to get it to show (even with the param), I'm no longer sure it should show, but 
rather that they should "both be the same" and not show.  What is the expected 
result?
  
  F35247838: Screen Recording 2022-06-16 at 4.17.38 PM.mov.gif 

  
  F35247839: Screen Recording 2022-06-16 at 4.15.36 PM.mov.gif 


TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ovasileva, Edtadros
Cc: Edtadros, bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, 
sgrabarczuk, KieranMcCann, Remagoxer, Romain, Theklan, NHillard-WMF, Nishu02, 
BeautifulBold, Suran38, Patafisik_WMF, cjming, Selby, Universal_Omega, 
Peteosx1x, NavinRizwi, Demian, Winter, JJMC89, Iniquity, Agabi10, Volker_E, 
Wikidata-bugs, Dinoguy1000, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[Maintenance_bot]

Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Edtadros, Maintenance_bot
Cc: bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, sgrabarczuk, 
KieranMcCann, Remagoxer, Romain, Theklan, Nishu02, BeautifulBold, Suran38, 
Patafisik_WMF, cjming, Selby, Peteosx1x, NavinRizwi, Demian, Winter, JJMC89, 
Iniquity, Agabi10, Volker_E, Wikidata-bugs, Dinoguy1000, Lydia_Pintscher, 
Fernandobacasegua34, 786, Biggs657, Lalamarie69, Juan90264, Alter-paule, 
Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, 
Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[ReleaseTaggerBot]

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Edtadros, ReleaseTaggerBot
Cc: bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, sgrabarczuk, 
KieranMcCann, Remagoxer, Romain, Theklan, Fernandobacasegua34, Nishu02, 
BeautifulBold, 786, Suran38, Biggs657, Patafisik_WMF, cjming, Lalamarie69, 
Selby, Juan90264, Peteosx1x, Alter-paule, NavinRizwi, Beast1978, Un1tY, Demian, 
Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, 
Af420, Bsandipan, Winter, Lewizho99, JJMC89, Maathavan, Iniquity, Agabi10, 
Neuronton, Volker_E, Wikidata-bugs, Dinoguy1000, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[gerritbot]

gerritbot added a comment.


  Change 802825 **merged** by jenkins-bot:
  
  [mediawiki/extensions/WikidataPageBanner@master] Add #firstHeading id to 
banner template
  
  https://gerrit.wikimedia.org/r/802825

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Edtadros, gerritbot
Cc: bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, sgrabarczuk, 
KieranMcCann, Remagoxer, Romain, Theklan, Fernandobacasegua34, Nishu02, 
BeautifulBold, 786, Suran38, Biggs657, Patafisik_WMF, cjming, Lalamarie69, 
Selby, Juan90264, Peteosx1x, Alter-paule, NavinRizwi, Beast1978, Un1tY, Demian, 
Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, 
Af420, Bsandipan, Winter, Lewizho99, JJMC89, Maathavan, Iniquity, Agabi10, 
Neuronton, Volker_E, Wikidata-bugs, Dinoguy1000, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[bwang]

bwang moved this task from Code Review to QA on the Readers-Web-Backlog 
(Kanbanana-FY-2021-22) board.
bwang reassigned this task from Jdlrobson to Edtadros.

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5465/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Edtadros, bwang
Cc: bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, sgrabarczuk, 
KieranMcCann, Remagoxer, Romain, Theklan, Fernandobacasegua34, Nishu02, 
BeautifulBold, 786, Suran38, Biggs657, Patafisik_WMF, cjming, Lalamarie69, 
Selby, Juan90264, Peteosx1x, Alter-paule, NavinRizwi, Beast1978, Un1tY, Demian, 
Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, 
Af420, Bsandipan, Winter, Lewizho99, JJMC89, Maathavan, Iniquity, Agabi10, 
Neuronton, Volker_E, Wikidata-bugs, Dinoguy1000, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[Jdlrobson]

Jdlrobson claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, sgrabarczuk, 
KieranMcCann, Remagoxer, Romain, Theklan, Fernandobacasegua34, Nishu02, 
BeautifulBold, 786, Suran38, Biggs657, Patafisik_WMF, cjming, Lalamarie69, 
Selby, Juan90264, Peteosx1x, Alter-paule, NavinRizwi, Beast1978, Un1tY, Demian, 
Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, 
Af420, Bsandipan, Winter, Lewizho99, JJMC89, Maathavan, Iniquity, Agabi10, 
Neuronton, Volker_E, Wikidata-bugs, Dinoguy1000, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[bwang]

bwang moved this task from Doing to Code Review on the Readers-Web-Backlog 
(Kanbanana-FY-2021-22) board.
bwang removed bwang as the assignee of this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5465/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bwang
Cc: bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, sgrabarczuk, 
KieranMcCann, Remagoxer, Romain, Theklan, Nishu02, BeautifulBold, Suran38, 
Patafisik_WMF, cjming, Selby, Peteosx1x, NavinRizwi, Demian, Winter, JJMC89, 
Iniquity, Agabi10, Volker_E, Wikidata-bugs, Dinoguy1000, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, sgrabarczuk, 
KieranMcCann, Remagoxer, Romain, Theklan, Fernandobacasegua34, Nishu02, 
BeautifulBold, 786, Suran38, Biggs657, Patafisik_WMF, cjming, Lalamarie69, 
Selby, Juan90264, Peteosx1x, Alter-paule, NavinRizwi, Beast1978, Un1tY, Demian, 
Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, 
Af420, Bsandipan, Winter, Lewizho99, JJMC89, Maathavan, Iniquity, Agabi10, 
Neuronton, Volker_E, Wikidata-bugs, Dinoguy1000, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[gerritbot]

gerritbot added a comment.


  Change 802825 had a related patch set uploaded (by Bernard Wang; author: 
Bernard Wang):
  
  [mediawiki/extensions/WikidataPageBanner@master] Add #firstHeading id to 
banner template
  
  https://gerrit.wikimedia.org/r/802825

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: bwang, alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, sgrabarczuk, 
KieranMcCann, Remagoxer, Romain, Theklan, Nishu02, BeautifulBold, Suran38, 
Patafisik_WMF, cjming, Selby, Peteosx1x, NavinRizwi, Demian, Winter, JJMC89, 
Iniquity, Agabi10, Volker_E, Wikidata-bugs, Dinoguy1000, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[bwang]

bwang claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bwang
Cc: alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, sgrabarczuk, 
KieranMcCann, Remagoxer, Romain, Theklan, Nishu02, BeautifulBold, Suran38, 
Patafisik_WMF, bwang, cjming, Selby, Peteosx1x, NavinRizwi, Demian, Winter, 
JJMC89, Iniquity, Agabi10, Volker_E, Wikidata-bugs, Dinoguy1000, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[Jdlrobson]

Jdlrobson set the point value for this task to "3".

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, sgrabarczuk, 
KieranMcCann, Remagoxer, Romain, Theklan, Nishu02, BeautifulBold, Suran38, 
Patafisik_WMF, bwang, cjming, Selby, Peteosx1x, NavinRizwi, Demian, Winter, 
JJMC89, Iniquity, Agabi10, Volker_E, Wikidata-bugs, Dinoguy1000, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[Jdlrobson]

Jdlrobson moved this task from Needs Analysis to Upcoming on the 
Readers-Web-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson removed a project: Wikidata.
Jdlrobson added a comment.


  I flagged this a while ago. The banner replaces the heading element that we 
use to trigger the sticky header. If we are to fix this, we'd likely want to 
make a change inside #WikidataPageBanner 
 to make sure the 
heading there is marked up consistently so that Vector's code picks it up.

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5465/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, sgrabarczuk, 
KieranMcCann, Remagoxer, Romain, Theklan, NHillard-WMF, Nishu02, BeautifulBold, 
Suran38, Patafisik_WMF, bwang, cjming, Selby, Peteosx1x, NavinRizwi, Demian, 
Winter, JJMC89, Iniquity, Agabi10, Volker_E, Wikidata-bugs, Dinoguy1000, 
Lydia_Pintscher, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[ovasileva]

ovasileva triaged this task as "Medium" priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ovasileva
Cc: alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, sgrabarczuk, 
KieranMcCann, Remagoxer, Romain, Theklan, NHillard-WMF, Astuthiodit_1, Nishu02, 
BeautifulBold, Suran38, Patafisik_WMF, karapayneWMDE, bwang, cjming, Invadibot, 
Selby, maantietaja, Peteosx1x, NavinRizwi, ItamarWMDE, Akuckartz, Demian, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, JJMC89, 
Iniquity, _jensen, rosalieper, Agabi10, Scott_WUaS, Volker_E, Wikidata-bugs, 
aude, Dinoguy1000, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[Maintenance_bot]

Maintenance_bot added a project: Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, sgrabarczuk, 
KieranMcCann, Remagoxer, Romain, Theklan, NHillard-WMF, Astuthiodit_1, Nishu02, 
BeautifulBold, Suran38, Patafisik_WMF, karapayneWMDE, bwang, cjming, Invadibot, 
Selby, maantietaja, Peteosx1x, NavinRizwi, ItamarWMDE, Akuckartz, Demian, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Winter, JJMC89, 
Iniquity, _jensen, rosalieper, Agabi10, Scott_WUaS, Volker_E, Wikidata-bugs, 
aude, Dinoguy1000, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T306744: Sticky header doesn't show the page title if PAGEBANNER is used

[Bugreporter]

Bugreporter added a project: Wikidata-Page-Banner.

TASK DETAIL
  https://phabricator.wikimedia.org/T306744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Bugreporter
Cc: alexhollender_WMF, Aklapper, ovasileva, Jdlrobson, sgrabarczuk, 
KieranMcCann, Remagoxer, Romain, Theklan, NHillard-WMF, Nishu02, BeautifulBold, 
Suran38, Patafisik_WMF, bwang, cjming, Selby, Peteosx1x, NavinRizwi, Demian, 
Winter, JJMC89, Iniquity, Agabi10, Volker_E, Wikidata-bugs, Dinoguy1000, 
Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org