[Wikidata-bugs] [Maniphest] T307601: Reversed ordering of search results in mobile Wikidata Firefox

2022-05-05 Thread ovasileva 
ovasileva triaged this task as "Medium" priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T307601

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ovasileva
Cc: ovasileva, Jdlrobson, Aklapper, Mormegil, Fernandobacasegua34, 
Astuthiodit_1, Nishu02, 786, Suran38, Biggs657, karapayneWMDE, bwang, cjming, 
Invadibot, Lalamarie69, MPhamWMF, maantietaja, Juan90264, Alter-paule, 
Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, mojoaxel, Bsandipan, GoranSMilovanovic, QZanden, EBjune, LawExplorer, 
Winter, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T307601: Reversed ordering of search results in mobile Wikidata Firefox

2022-05-05 Thread Jdlrobson 
Jdlrobson added a comment.


  The proposed patch makes sense to fix this. I'd want us to thoroughly test 
this on production data on several projects with some real data though before 
merging (we can do this by passing a production domain to the mw.Api parameter)

TASK DETAIL
  https://phabricator.wikimedia.org/T307601

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: ovasileva, Jdlrobson, Aklapper, Mormegil, Fernandobacasegua34, 
Astuthiodit_1, Nishu02, 786, Suran38, Biggs657, karapayneWMDE, bwang, cjming, 
Invadibot, Lalamarie69, MPhamWMF, maantietaja, Juan90264, Alter-paule, 
Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, mojoaxel, Bsandipan, GoranSMilovanovic, QZanden, EBjune, LawExplorer, 
Winter, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T307601: Reversed ordering of search results in mobile Wikidata Firefox

2022-05-05 Thread Jdlrobson 
Jdlrobson updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T307601

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: ovasileva, Jdlrobson, Aklapper, Mormegil, Fernandobacasegua34, 
Astuthiodit_1, Nishu02, 786, Suran38, Biggs657, karapayneWMDE, bwang, cjming, 
Invadibot, Lalamarie69, MPhamWMF, maantietaja, Juan90264, Alter-paule, 
Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, mojoaxel, Bsandipan, GoranSMilovanovic, QZanden, EBjune, LawExplorer, 
Winter, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T307601: Reversed ordering of search results in mobile Wikidata Firefox

2022-05-05 Thread Jdlrobson 
Jdlrobson renamed this task from "Reversed ordering of search results in mobile 
Wikidata" to "Reversed ordering of search results in mobile Wikidata Firefox".

TASK DETAIL
  https://phabricator.wikimedia.org/T307601

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: ovasileva, Jdlrobson, Aklapper, Mormegil, Fernandobacasegua34, 
Astuthiodit_1, Nishu02, 786, Suran38, Biggs657, karapayneWMDE, bwang, cjming, 
Invadibot, Lalamarie69, MPhamWMF, maantietaja, Juan90264, Alter-paule, 
Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, mojoaxel, Bsandipan, GoranSMilovanovic, QZanden, EBjune, LawExplorer, 
Winter, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T307601: Reversed ordering of search results in mobile Wikidata

2022-05-05 Thread Mormegil 
Mormegil added a comment.


  Oh, great, that at least explains why I’m the first the report and fix this.
  
  Yeah, the implementation-defined 

 behavior of `array.sort` when given an inconsistent comparator (I mentioned it 
in the commit message) is obviously in play here: I’m using Firefox where the 
sort results are reversed, while in Chrome, Chromium-based browsers (I tested 
Edge), and in IE, the “always return +1” broken comparator results in the 
original sorting order (while “always return -1” results in the reversed order).
  
  You can try `[1,2,3,4].sort(function(){return 1})` in a browser console: 
Firefox gives `[4,3,2,1]`, Chromium and IE give `[1,2,3,4]`.

TASK DETAIL
  https://phabricator.wikimedia.org/T307601

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mormegil
Cc: ovasileva, Jdlrobson, Aklapper, Mormegil, Fernandobacasegua34, 
Astuthiodit_1, Nishu02, 786, Suran38, Biggs657, karapayneWMDE, bwang, cjming, 
Invadibot, Lalamarie69, MPhamWMF, maantietaja, Juan90264, Alter-paule, 
Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, mojoaxel, Bsandipan, GoranSMilovanovic, QZanden, EBjune, LawExplorer, 
Winter, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T307601: Reversed ordering of search results in mobile Wikidata

2022-05-05 Thread ovasileva 
ovasileva added a comment.


  @Mormegil - I'm not able to reproduce:
   F35104272: Screen Shot 2022-05-05 at 8.05.32 AM.png 


TASK DETAIL
  https://phabricator.wikimedia.org/T307601

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ovasileva
Cc: ovasileva, Jdlrobson, Aklapper, Mormegil, Fernandobacasegua34, 
Astuthiodit_1, Nishu02, 786, Suran38, Biggs657, karapayneWMDE, bwang, cjming, 
Invadibot, Lalamarie69, MPhamWMF, maantietaja, Juan90264, Alter-paule, 
Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, mojoaxel, Bsandipan, GoranSMilovanovic, QZanden, EBjune, LawExplorer, 
Winter, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T307601: Reversed ordering of search results in mobile Wikidata

2022-05-04 Thread Jdlrobson 
Jdlrobson added a project: Readers-Web-Backlog (Kanbanana-FY-2021-22).
Jdlrobson added a comment.


  Patch for review.

TASK DETAIL
  https://phabricator.wikimedia.org/T307601

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: Jdlrobson, Aklapper, Mormegil, Fernandobacasegua34, Astuthiodit_1, Nishu02, 
786, Suran38, Biggs657, karapayneWMDE, bwang, cjming, Invadibot, Lalamarie69, 
MPhamWMF, maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, ItamarWMDE, 
Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, mojoaxel, Bsandipan, 
GoranSMilovanovic, QZanden, EBjune, LawExplorer, Winter, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T307601: Reversed ordering of search results in mobile Wikidata

2022-05-04 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T307601

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Mormegil, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, 
Biggs657, karapayneWMDE, Invadibot, Lalamarie69, MPhamWMF, maantietaja, 
Juan90264, Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, mojoaxel, Bsandipan, GoranSMilovanovic, QZanden, 
EBjune, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T307601: Reversed ordering of search results in mobile Wikidata

2022-05-04 Thread gerritbot 
gerritbot added a comment.


  Change 789220 had a related patch set uploaded (by Mormegil; author: 
Mormegil):
  
  [mediawiki/extensions/MobileFrontend@master] Fix search result ordering
  
  https://gerrit.wikimedia.org/r/789220

TASK DETAIL
  https://phabricator.wikimedia.org/T307601

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Mormegil, Astuthiodit_1, karapayneWMDE, Invadibot, MPhamWMF, 
maantietaja, CBogen, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, mojoaxel, 
GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T307601: Reversed ordering of search results in mobile Wikidata

2022-05-04 Thread Mormegil 
Mormegil created this task.
Mormegil added projects: Wikidata, MobileFrontend, Discovery-Search.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  **List of steps to reproduce** (step by step, including full links if 
applicable):
  
  - Go to https://m.wikidata.org/ (let’s say in a private window, to be sure)
  - Write something reasonable into the top search bar; let’s say //obama//.
  
  **What happens?**:
  Notice the results start with many less important items without an image 
(some Obama’s ancestor in Q96197836, fictional spy car in Q91269986, …), and, 
finally, //at the very end//, the 44th president of the United States (Q76).
  
  **What should have happened instead?**:
  Barrack Obama is an obvious candidate to be the first search result for the 
“obama” query; definitely it should not be the //last// result.
  
  
  
  The mobile search results on Wikidata are so obviously wrong I have sometimes 
sadly remarked it seems they are shown reversed. I did not know this was 
//literally true//! The client-side mobile frontend displays the results in a 
reversed order than what it has received from the search API! (It seems 
unbelievable nobody have reported that yet, but… I guess everyone is so used to 
less-then-stellar quality of search on Wikimedia projects… Dunno, but I could 
not find an existing report for this.)

TASK DETAIL
  https://phabricator.wikimedia.org/T307601

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mormegil
Cc: Aklapper, Mormegil, Astuthiodit_1, karapayneWMDE, Invadibot, MPhamWMF, 
maantietaja, CBogen, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, mojoaxel, 
GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org