[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

Arian_Bozorg closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T322686 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Arian_Bozorg Cc: Arian_Bozorg, Michael, noarave, Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE,

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

Arian_Bozorg added a comment. Hi all, Based on the discussion here we are going to close the ticket. If you *strongly* disagree please feel free to reopen the ticket. TASK DETAIL https://phabricator.wikimedia.org/T322686 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

Michael removed projects: Patch-For-Review, User-Michael. Michael moved this task from Peer Review to Product Verification on the Wikidata Dev Team (Sprint-∞) board. Michael removed Michael as the assignee of this task. Michael added a comment. I'm closing the open PRs, and am handing this

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

gerritbot added a comment. Change 857705 **abandoned** by Michael Große: [mediawiki/extensions/WikibaseLexeme@master] Ensure that infopanel comes directly after main app in tab-order Reason: We probably don't want to do this after all (this discussion in task)

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

Sarai-WMDE added a comment. In T322686#8401616 , @Sarai-WMDE wrote: >> You can actually create the lexeme without tabbing out of the lexical category field at all, by pressing Enter there. > > Probably @Nikki (like myself) wasn't

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

Lucas_Werkmeister_WMDE added a comment. In T322686#8400106 , @Michael wrote: > That's not the intended tab-flow #328 + Ensure that infopanel comes directly after main app in tab-order (Ia8f374ae)

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

Sarai-WMDE added a comment. > You can actually create the lexeme without tabbing out of the lexical category field at all, by pressing Enter there. Probably @Nikki (like myself) wasn't aware of this behavior, which removes the need to actually tab and select the button in order to

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

noarave added a comment. > What motivated this decision? I think this is the context in which this was decided: https://phabricator.wikimedia.org/T305359#7955779 It is consistent with other parts of Wikidata, but i remembered we scrambled over this quite a bit. TASK DETAIL

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

Sarai-WMDE added a comment. > You can actually create the lexeme without tabbing out of the lexical category field at all, by pressing Enter there. Oh wow. Ok, that actually removes the extra tabbing inconvenience for heavy keyboard users entirely. At the same time, this sounds quite

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

Michael added a comment. That's not the intended tab-flow #328 + Ensure that infopanel comes directly after main app in tab-order (Ia8f374ae) . I will have to look into that again 廊 TASK DETAIL

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

Lucas_Werkmeister_WMDE added a comment. > Again, no solution seems to be perfect, and I feel that responding to this request is actually making us apply antipatterns and modifying a perfectly valid default tab flow. I feel the same way, to be honest… I think leaving the tab order as it

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T322686 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, gerritbot Cc: Michael, noarave, Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE, Nikki,

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

gerritbot added a comment. Change 857705 had a related patch set uploaded (by Michael Große; author: Michael Große): [mediawiki/extensions/WikibaseLexeme@master] Ensure that infopanel comes directly after main app in tab-order https://gerrit.wikimedia.org/r/857705 TASK DETAIL

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

Sarai-WMDE attached a referenced file: F35786262: Nov-16-2022 15-33-34.gif. TASK DETAIL https://phabricator.wikimedia.org/T322686 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Sarai-WMDE Cc: Michael, noarave, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

Sarai-WMDE attached a referenced file: F35786452: Group 1.png. TASK DETAIL https://phabricator.wikimedia.org/T322686 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, Sarai-WMDE Cc: Michael, noarave, Lucas_Werkmeister_WMDE, mrephabricator,

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

Sarai-WMDE added a comment. I see your point. But the outcome of modifying the default tab order as a result of the changes applied via #328 is disrupting the page's structure and navigation order for both keyboard and screen reader

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

Michael added a comment. > Subtracting interactive elements from the flow (using `tabindex=-1`) is definitely not ideal either, but has a smaller impact/override effect on the overall navigation flow. Why? I might agree with this //if// those elements are actually still reliably

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

Sarai-WMDE added a comment. In T322686#8399322 , @Michael wrote: >> Add tabindex=-1 to the copyright/terms of use links (this seems to be the preferred way a11y-wise ) > > I think, I would challenge that notion in that generality.

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

Michael added a comment. Now we have two PRs up that show-case the different options: - https://github.com/wmde/new-lexeme-special-page/pull/328 (move inputs and create lexeme button to the beginning of the tab-order) - https://github.com/wmde/new-lexeme-special-page/pull/329 (make

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

Michael claimed this task. Michael moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board. Michael added a comment. Restricted Application added a project: User-Michael. > Add tabindex=-1 to the copyright/terms of use links (this seems to be the preferred way

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

noarave added a comment. **Task breakdown notes:** - We see two possible ways forward with this: 1. Add tabindex=-1 to the copyright/terms of use links (this seems to be the preferred way a11y-wise ) 2. Add

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

Lydia_Pintscher moved this task from Unified prioritized backlog to Sprint-∞ on the Wikidata Dev Team board. Lydia_Pintscher edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T322686 WORKBOARD

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T322686 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lucas_Werkmeister_WMDE, mrephabricator, Sarai-WMDE, Nikki, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

Lucas_Werkmeister_WMDE added a comment. In T322686#8390013 , @mrephabricator wrote: > I will point out that the terms and conditions section does not actually render as intended in every locale. For pnb it shows raw wiki markup and the

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

Lydia_Pintscher set the point value for this task to "5". TASK DETAIL https://phabricator.wikimedia.org/T322686 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: mrephabricator, Sarai-WMDE, Nikki, Lydia_Pintscher, Astuthiodit_1,

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

Lydia_Pintscher updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T322686 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: mrephabricator, Sarai-WMDE, Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE,

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

mrephabricator added a comment. I will point out that the terms and conditions section does not actually render as intended in every locale. For pnb it shows raw wiki markup and the links do not resolve. TASK DETAIL https://phabricator.wikimedia.org/T322686 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

Sarai-WMDE added a comment. Hello there. There's no perfect solution for this: If we placed the text below the button, we would risk hiding the conditions from screen reader users (and making them easier to ignore, due to reading order, for everyone else). I think we should follow the usual

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

Lydia_Pintscher triaged this task as "High" priority. TASK DETAIL https://phabricator.wikimedia.org/T322686 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Sarai-WMDE, Nikki, Lydia_Pintscher, Astuthiodit_1, karapayneWMDE,

[Wikidata-bugs] [Maniphest] T322686: tab behaviour issue on Special:NewLexeme

Lydia_Pintscher created this task. Lydia_Pintscher added projects: Special:NewLexeme revival, Wikidata Lexicographical data, Wikidata Dev Team, Wikidata. TASK DESCRIPTION **Problem:** The terms of use/license info text is between the input fields and the submit button. The current tab order