[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

Arian_Bozorg closed this task as "Resolved". Arian_Bozorg added a comment. Thanks so much! TASK DETAIL https://phabricator.wikimedia.org/T329488 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova, Arian_Bozorg Cc: Arian_Bozorg,

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

Sarai-WMDE added a comment. In T329488#8782147 , @Sarai-WMDE wrote: > Keyboard navigation appears to work correctly. The specified keyboard shortcuts

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

Lucas_Werkmeister_WMDE added a comment. In T329488#8782147 , @Sarai-WMDE wrote: > Nevertheless, the tested version of the component doesn't allow selecting an option from the menu on click (see gif below). Ah, I think that’s a

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

Sarai-WMDE added a comment. Keyboard navigation appears to work correctly. The specified keyboard shortcuts were tested in Netlify (https://894028--clicky-sparqly.netlify.app/) using

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

guergana.tzatchkova added a comment. In T329488#8771553 , @guergana.tzatchkova wrote: > Still missing: Resetting the highlightedIndex from the resetting the scroll too. This issue will be fixed in a separate ticket: T334664

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

guergana.tzatchkova added a comment. In T329488#8776625 , @ItamarWMDE wrote: > I think it would be best to open up new tickets to be triaged later as a way forward. While it's not perfect, IMO this is good enough as an early version,

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

Sarai-WMDE added a comment. Restricted Application added a project: User-ItamarWMDE. In T329488#8776625 , @ItamarWMDE wrote: > I think it would be best to open up new tickets to be triaged later as a way forward. While it's not perfect,

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

ItamarWMDE added a comment. I think it would be best to open up new tickets to be triaged later as a way forward. While it's not perfect, IMO this is good enough as an early version, and we can deal with the loose ends and improvements later on if needed. TASK DETAIL

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

guergana.tzatchkova added a comment. Still missing: Resetting the highlightedIndex from the resetting the scroll too. TASK DETAIL https://phabricator.wikimedia.org/T329488 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova Cc:

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

Sarai-WMDE added a subscriber: LucasWerkmeister. Sarai-WMDE added a comment. Thanks for your comments @guergana.tzatchkova and @LucasWerkmeister. TL;DR: yes, keyboard highlight should be reset on blur. > If one language is highlighted [via keyboard] and the menu is closed and opened

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

gerritbot added a comment. Change 906584 **merged** by jenkins-bot: [wikidata/query-builder@master] Add browser tests for keyboard navigation of Language Selector https://gerrit.wikimedia.org/r/906584 TASK DETAIL https://phabricator.wikimedia.org/T329488 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

guergana.tzatchkova claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T329488 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova Cc: noarave, Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, Aklapper, ItamarWMDE,

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

gerritbot added a comment. Change 906584 had a related patch set uploaded (by Guergana Tzatchkova; author: Guergana Tzatchkova): [wikidata/query-builder@master] Add browser tests for keyboard navigation of Language Selector https://gerrit.wikimedia.org/r/906584 TASK DETAIL

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

gerritbot added a comment. Change 894028 **merged** by jenkins-bot: [wikidata/query-builder@master] Add Keyboard navigation to the language selector https://gerrit.wikimedia.org/r/894028 TASK DETAIL https://phabricator.wikimedia.org/T329488 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

Lucas_Werkmeister_WMDE added a comment. I think another option would be to (also?) reset the highlighted language on input. Currently, typing into the input field highlights the first available language. TASK DETAIL https://phabricator.wikimedia.org/T329488 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

guergana.tzatchkova added a comment. @Sarai-WMDE we have a question here. This is the deploy of this ticket here: https://894028--clicky-sparqly.netlify.app/ Once the the arrows have highlighted the languages and changed the index, there is always something selected. If one language is

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

noarave moved this task from Peer Review to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board. noarave added a comment. I think this thing is as far as it could go functionality wise. Browser tests might make sense. i've unassigned myself for now so that someone else could pick this up

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

noarave removed noarave as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T329488 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave Cc: noarave, Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, Aklapper, ItamarWMDE,

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

Sarai-WMDE added a comment. Perfect!  TASK DETAIL https://phabricator.wikimedia.org/T329488 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, Sarai-WMDE Cc: Lucas_Werkmeister_WMDE, Amiti44, Sarai-WMDE, Aklapper, ItamarWMDE,

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

Lucas_Werkmeister_WMDE added a comment. Alright, thanks! We already implemented looping in one direction in the change – now we know that’s correct, and also we should “close the loop” and do it in the other direction too. TASK DETAIL https://phabricator.wikimedia.org/T329488 EMAIL

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

Sarai-WMDE added a subscriber: LucasWerkmeister. Sarai-WMDE added a comment. Thanks for your questions, @LucasWerkmeister  Answering inline: > According to the Figma specs, “When the focus is placed on the first option of the menu, [the up arrow key] moves the focus back to the

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

Lucas_Werkmeister_WMDE added a comment. In T329488#8742267 , @gerritbot wrote: > Change 904555 had a related patch set uploaded (by Michael Große; author: Michael Große): > > [mediawiki/extensions/EntitySchema@master] More

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

gerritbot added a comment. Change 904555 had a related patch set uploaded (by Michael Große; author: Michael Große): [mediawiki/extensions/EntitySchema@master] More consistently recommend mwcli in README instead of fresh-node https://gerrit.wikimedia.org/r/904555 TASK DETAIL

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T329488 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, gerritbot Cc: Sarai-WMDE, Aklapper, ItamarWMDE, guergana.tzatchkova, Themindcoder, Adamm71,

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

gerritbot added a comment. Change 894028 had a related patch set uploaded (by Noa wmde; author: Noa wmde): [wikidata/query-builder@master] Add Keyboard navigation to the language selector https://gerrit.wikimedia.org/r/894028 TASK DETAIL https://phabricator.wikimedia.org/T329488

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

noarave claimed this task. Restricted Application added a project: User-Noarave. TASK DETAIL https://phabricator.wikimedia.org/T329488 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave Cc: Sarai-WMDE, Aklapper, ItamarWMDE, guergana.tzatchkova,

[Wikidata-bugs] [Maniphest] T329488: Query Builder: Add keyboard navigation to Language Selector Component

guergana.tzatchkova renamed this task from "Query Builder: Add keyboard navigaton to Language Selector Component" to "Query Builder: Add keyboard navigation to Language Selector Component". TASK DETAIL https://phabricator.wikimedia.org/T329488 EMAIL PREFERENCES