[Wikidata-bugs] [Maniphest] T348729: [WtC-M2] Adapt MSMF's layout to Codex's grid system

2024-04-02 Thread Arian_Bozorg 
Arian_Bozorg closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T348729

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, Arian_Bozorg
Cc: karapayneWMDE, HasanAkgun_WMDE, Aklapper, Sarai-WMDE, 
Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T348729: [WtC-M2] Adapt MSMF's layout to Codex's grid system

2024-02-06 Thread Sarai-WMDE 
Sarai-WMDE added a comment.


  Thanks for the speedy fix! :)

TASK DETAIL
  https://phabricator.wikimedia.org/T348729

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, Sarai-WMDE
Cc: karapayneWMDE, HasanAkgun_WMDE, Aklapper, Sarai-WMDE, 
Danny_Benjafield_WMDE, Astuthiodit_1, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T348729: [WtC-M2] Adapt MSMF's layout to Codex's grid system

2024-02-02 Thread noarave 
noarave moved this task from Doing to Peer Review on the Wikidata Dev Team 
(Quality Tools "Sprint") board.
noarave added a comment.


  https://github.com/wmde/wikidata-mismatch-finder/pull/874

TASK DETAIL
  https://phabricator.wikimedia.org/T348729

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6750/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: karapayneWMDE, HasanAkgun_WMDE, Aklapper, Sarai-WMDE, 
Danny_Benjafield_WMDE, Astuthiodit_1, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T348729: [WtC-M2] Adapt MSMF's layout to Codex's grid system

2024-01-31 Thread Sarai-WMDE 
Sarai-WMDE added a comment.


  This looks great! I only found a couple of small things to fix:
  
  1. **Footer padding**: The horizontal padding of the Footer is not matching 
the specs/ aligned with the page margins (it remains 24px above the 1120px 
breakpoint, it becomes 16px below 720px instead of 640px)
  2. **Heading wrapping**: Even if a gap has been implemented between the 
headings and their adjacent buttons, the buttons still don't take the space 
that is made available for then when the titles wrap (they display ellipsis 
even if there's enough room for them). I believe there's an easy fix for this: 
we just need to target these buttons and apply`flex-shrink: 0;` to them (see 
clarifying screenshots below).
  
  | Current state in staging | With 
flex-shrink 0   |
  | F41735650: Screenshot 2024-01-31 at 20.30.56.png 
   
 | F41735652: Screenshot 2024-01-31 at 
20.31.42.png   
  |
  | There's enough space for the button, but it still displays ellipsis. | The 
button takes the available space |
  |

TASK DETAIL
  https://phabricator.wikimedia.org/T348729

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, Sarai-WMDE
Cc: karapayneWMDE, HasanAkgun_WMDE, Aklapper, Sarai-WMDE, 
Danny_Benjafield_WMDE, Astuthiodit_1, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T348729: [WtC-M2] Adapt MSMF's layout to Codex's grid system

2024-01-24 Thread noarave 
noarave moved this task from Doing to Peer Review on the Wikidata Dev Team 
(Quality Tools "Sprint") board.
noarave added a comment.


  https://github.com/wmde/wikidata-mismatch-finder/pull/849

TASK DETAIL
  https://phabricator.wikimedia.org/T348729

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6750/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: karapayneWMDE, HasanAkgun_WMDE, Aklapper, Sarai-WMDE, 
Danny_Benjafield_WMDE, Astuthiodit_1, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T348729: [WtC-M2] Adapt MSMF's layout to Codex's grid system

2024-01-23 Thread noarave 
noarave claimed this task.
noarave moved this task from Backlog to Doing on the Wikidata Dev Team (Quality 
Tools "Sprint") board.
Restricted Application added a project: User-Noarave.

TASK DETAIL
  https://phabricator.wikimedia.org/T348729

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6750/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: karapayneWMDE, HasanAkgun_WMDE, Aklapper, Sarai-WMDE, 
Danny_Benjafield_WMDE, Astuthiodit_1, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T348729: [WtC-M2] Adapt MSMF's layout to Codex's grid system

2024-01-19 Thread Sarai-WMDE 
Sarai-WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T348729

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: karapayneWMDE, HasanAkgun_WMDE, Aklapper, Sarai-WMDE, 
Danny_Benjafield_WMDE, Astuthiodit_1, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T348729: [WtC-M2] Adapt MSMF's layout to Codex's grid system

2024-01-09 Thread karapayneWMDE 
karapayneWMDE added a comment.


  Sprint Planning: review status. if still stalled, move back to stalled

TASK DETAIL
  https://phabricator.wikimedia.org/T348729

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: karapayneWMDE
Cc: karapayneWMDE, HasanAkgun_WMDE, Aklapper, Sarai-WMDE, 
Danny_Benjafield_WMDE, Astuthiodit_1, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T348729: [WtC-M2] Adapt MSMF's layout to Codex's grid system

2023-12-14 Thread ItamarWMDE 
ItamarWMDE renamed this task from "[SW] [WtC-M2] Adapt MSMF's layout to Codex's 
grid system" to "[WtC-M2] Adapt MSMF's layout to Codex's grid system".

TASK DETAIL
  https://phabricator.wikimedia.org/T348729

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: HasanAkgun_WMDE, Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T348729: [WtC-M2] Adapt MSMF's layout to Codex's grid system and breakpoints

2023-10-12 Thread Sarai-WMDE 
Sarai-WMDE created this task.
Sarai-WMDE added projects: Wikidata Dev Team, Mismatch Finder, Wikidata.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  Problem
  ---
  
  The Mismatch finder tool was originally designed following WiKit's grid 
system and breakpoints. With the creation of Codex, a new set of standard grids 
and breakpoints were introduced and, with them, some differences in spacing and 
margins that we now need to resolve.
  
  Solution
  
  
  In both the home and the results views of the Mismatch finder, we'll need to 
(please see specs for details):
  
  - Apply new max-width values to paragraphs and page content
  - Replace WiKit breakpoint values by Codex's
  - Adjust the page (and header and footer) margins according to each breakpoint
  - Improve the placement of the "Random mismatches" button on mobile: its 
placement should change when a spacing of 1.5em cannot be maintained between 
the TextArea label and the button in narrower screens
  
  | Specifications are available in Figma 

 |
  |
  
  Please note that all specs indicate needed changes exclusively.
  
  Acceptance criteria
  ---
  
  [ ] The Mismatch Finder's layout is adjusted to follow the new Codex grid 
system
  [ ] Mismatch Finder use Codex's breakpoints

TASK DETAIL
  https://phabricator.wikimedia.org/T348729

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org