[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[DAlangi_WMF]

DAlangi_WMF closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF
Cc: Tacsipacsi, xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, 
Krinkle, Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, 
LennardHofmann, Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, 
Invadibot, Ywats0ns, caldera, maantietaja, NavinRizwi, CBogen, ItamarWMDE, 
Akuckartz, 94rain, Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, 
GoranSMilovanovic, TJH2018, Nattes, QZanden, KimKelting, EnricoCNC, 
LawExplorer, SundanceRaphael, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, 
Izno, alex-mashin, Wikidata-bugs, aude, geraki, Dinoguy1000, Gryllida, jeblad, 
jayvdb, MrStradivarius, Catrope, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[Krinkle]

Krinkle added a comment.


  With the last patch merged, feel free to close it.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF, Krinkle
Cc: Tacsipacsi, xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, 
Krinkle, Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, 
LennardHofmann, Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, 
Invadibot, Ywats0ns, caldera, maantietaja, NavinRizwi, CBogen, ItamarWMDE, 
Akuckartz, 94rain, Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, 
GoranSMilovanovic, TJH2018, Nattes, QZanden, KimKelting, EnricoCNC, 
LawExplorer, SundanceRaphael, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, 
Izno, alex-mashin, Wikidata-bugs, aude, geraki, Dinoguy1000, Gryllida, jeblad, 
jayvdb, MrStradivarius, Catrope, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[DAlangi_WMF]

DAlangi_WMF added a comment.


  @Krinkle, is this good to be resolved now or should we wait till end of week?

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF
Cc: Tacsipacsi, xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, 
Krinkle, Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, 
LennardHofmann, Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, 
Invadibot, Ywats0ns, caldera, maantietaja, NavinRizwi, CBogen, ItamarWMDE, 
Akuckartz, 94rain, Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, 
GoranSMilovanovic, TJH2018, Nattes, QZanden, KimKelting, EnricoCNC, 
LawExplorer, SundanceRaphael, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, 
Izno, alex-mashin, Wikidata-bugs, aude, geraki, Dinoguy1000, Gryllida, jeblad, 
jayvdb, MrStradivarius, Catrope, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[DAlangi_WMF]

DAlangi_WMF updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF
Cc: Tacsipacsi, xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, 
Krinkle, Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, 
LennardHofmann, Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, 
Invadibot, Ywats0ns, caldera, maantietaja, NavinRizwi, CBogen, ItamarWMDE, 
Akuckartz, 94rain, Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, 
GoranSMilovanovic, TJH2018, Nattes, QZanden, KimKelting, EnricoCNC, 
LawExplorer, SundanceRaphael, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, 
Izno, alex-mashin, Wikidata-bugs, aude, geraki, Dinoguy1000, Gryllida, jeblad, 
jayvdb, MrStradivarius, Catrope, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[ReleaseTaggerBot]

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.14; 
2024-01-16); removed MW-1.42-notes (1.42.0-wmf.10; 2023-12-19).

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF, ReleaseTaggerBot
Cc: Tacsipacsi, xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, 
Krinkle, Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, 
LennardHofmann, Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, 
Invadibot, Ywats0ns, caldera, maantietaja, NavinRizwi, CBogen, ItamarWMDE, 
Akuckartz, 94rain, Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, 
GoranSMilovanovic, TJH2018, Nattes, QZanden, KimKelting, EnricoCNC, 
LawExplorer, SundanceRaphael, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, 
Izno, alex-mashin, Wikidata-bugs, aude, geraki, Dinoguy1000, Gryllida, jeblad, 
jayvdb, MrStradivarius, Catrope, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[Maintenance_bot]

Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF, Maintenance_bot
Cc: Tacsipacsi, xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, 
Krinkle, Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, 
LennardHofmann, Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, 
Invadibot, Ywats0ns, caldera, maantietaja, NavinRizwi, CBogen, ItamarWMDE, 
Akuckartz, 94rain, Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, 
GoranSMilovanovic, TJH2018, Nattes, QZanden, KimKelting, EnricoCNC, 
LawExplorer, SundanceRaphael, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, 
Izno, alex-mashin, Wikidata-bugs, aude, geraki, Dinoguy1000, Gryllida, jeblad, 
jayvdb, MrStradivarius, Catrope, Jackmcbarn, Mbch331, Isabelladantes1983, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 786, Biggs657, 
Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, 
CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, 
Maathavan, Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[gerritbot]

gerritbot added a comment.


  Change 983714 **merged** by jenkins-bot:
  
  [mediawiki/extensions/CommonsMetadata@master] Replace getPageViewLanguage() 
with ParserOutput->getLanguage()
  
  https://gerrit.wikimedia.org/r/983714

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF, gerritbot
Cc: Tacsipacsi, xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, 
Krinkle, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, 
Mohamed-Awnallah, Adamm71, Jersione, Hellket777, mrephabricator, 
LennardHofmann, LisafBia6531, Astuthiodit_1, 786, lbowmaker, BTullis, Biggs657, 
karapayneWMDE, toberto, Invadibot, Ywats0ns, caldera, maantietaja, Juan90264, 
Alter-paule, NavinRizwi, Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, 94rain, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, 
GoranSMilovanovic, TJH2018, Nattes, QZanden, KimKelting, EnricoCNC, 
LawExplorer, Lewizho99, Maathavan, SundanceRaphael, _jensen, rosalieper, 
Taiwania_Justo, Neuronton, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, 
geraki, Dinoguy1000, Gryllida, jeblad, jayvdb, MrStradivarius, Catrope, 
Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[Tacsipacsi]

Tacsipacsi updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF, Tacsipacsi
Cc: Tacsipacsi, xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, 
Krinkle, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, 
Mohamed-Awnallah, Adamm71, Jersione, Hellket777, mrephabricator, 
LennardHofmann, LisafBia6531, Astuthiodit_1, 786, lbowmaker, BTullis, Biggs657, 
karapayneWMDE, toberto, Invadibot, Ywats0ns, caldera, maantietaja, Juan90264, 
Alter-paule, NavinRizwi, Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, 94rain, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, 
GoranSMilovanovic, TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, _jensen, rosalieper, Taiwania_Justo, Neuronton, 
Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, geraki, Dinoguy1000, 
Gryllida, jeblad, jayvdb, MrStradivarius, Catrope, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[DAlangi_WMF]

DAlangi_WMF added a comment.


  In T350806#9412606 , 
@Krinkle wrote:
  
  > @DAlangi_WMF The problematic hook that initiated this task (via the parent 
task) is `onPageContentLanguage()` which is called by 
Title->getPageViewLanguage(), but not directly. The hook call resides in 
`ContentHandler::getPageViewLanguage() -> 
ContentHandler->getPageViewLanguage()`.
  >
  > The reason Wikibase is out of scope, is that it implements a custom method 
called `getPageViewLanguage` in a subclass of ContentHandler, and shares no 
code with the base class in core. After we deprecate and remove this, the 
Wikibase continues to work on its own.
  >
  > CommonsMetadata, however, does call into the affected core code. It makes 
the same kind of mistake as the other extensions we patched in this task, 
namely it deals with a ParserOutput, but instead of asking the ParserOutput 
object what the language of the HTML is, it tries to "guess" by invoking global 
state of `ContentHandler::getPageViewLanguage`.
  
  Ack! I'll review and test the patch you made. Thanks for clarifying. 

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF
Cc: xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, 
Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Mohamed-Awnallah, 
Adamm71, Jersione, Hellket777, mrephabricator, LennardHofmann, LisafBia6531, 
Astuthiodit_1, 786, lbowmaker, BTullis, Biggs657, karapayneWMDE, toberto, 
Invadibot, Ywats0ns, caldera, maantietaja, Juan90264, Alter-paule, NavinRizwi, 
Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, 94rain, CucyNoiD, Nandana, Gaboe420, lucamauri, Patriccck, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, 
GoranSMilovanovic, TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, _jensen, rosalieper, Taiwania_Justo, Neuronton, 
Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, geraki, Dinoguy1000, 
Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, Catrope, Jackmcbarn, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[DAlangi_WMF]

DAlangi_WMF updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF
Cc: xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, 
Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Mohamed-Awnallah, 
Adamm71, Jersione, Hellket777, mrephabricator, LennardHofmann, LisafBia6531, 
Astuthiodit_1, 786, lbowmaker, BTullis, Biggs657, karapayneWMDE, toberto, 
Invadibot, Ywats0ns, caldera, maantietaja, Juan90264, Alter-paule, NavinRizwi, 
Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, 94rain, CucyNoiD, Nandana, Gaboe420, lucamauri, Patriccck, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, 
GoranSMilovanovic, TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, _jensen, rosalieper, Taiwania_Justo, Neuronton, 
Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, geraki, Dinoguy1000, 
Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, Catrope, Jackmcbarn, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[Krinkle]

Krinkle added a comment.


  @DAlangi_WMF The problematic hook that initiated this task (via the parent 
task) is `onPageContentLanguage()` which is called by 
Title->getPageViewLanguage(), but not directly. The hook call resides in 
`ContentHandler::getPageViewLanguage() -> 
ContentHandler->getPageViewLanguage()`.
  
  The reason Wikibase is out of scope, is that it implements a custom method 
called `getPageViewLanguage` in a subclass of ContentHandler, and shares no 
code with the base class in core. After we deprecate and remove this, the 
Wikibase continues to work on its own.
  
  CommonsMetadata, however, does call into the affected core code. It makes the 
same kind of mistake as the other extensions we patched in this task, namely it 
deals with a ParserOutput, but instead of asking the ParserOutput object what 
the language of the HTML is, it tries to "guess" by invoking global state of 
`ContentHandler::getPageViewLanguage`.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF, Krinkle
Cc: xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, 
Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Mohamed-Awnallah, 
Adamm71, Jersione, Hellket777, mrephabricator, LennardHofmann, LisafBia6531, 
Astuthiodit_1, 786, lbowmaker, BTullis, Biggs657, karapayneWMDE, toberto, 
Invadibot, Ywats0ns, caldera, maantietaja, Juan90264, Alter-paule, NavinRizwi, 
Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, 94rain, CucyNoiD, Nandana, Gaboe420, lucamauri, Patriccck, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, 
GoranSMilovanovic, TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, _jensen, rosalieper, Taiwania_Justo, Neuronton, 
Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, geraki, Dinoguy1000, 
Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, Catrope, Jackmcbarn, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF, gerritbot
Cc: xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, 
Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Mohamed-Awnallah, 
Adamm71, Jersione, Hellket777, mrephabricator, LennardHofmann, LisafBia6531, 
Astuthiodit_1, 786, lbowmaker, BTullis, Biggs657, karapayneWMDE, toberto, 
Invadibot, Ywats0ns, caldera, maantietaja, Juan90264, Alter-paule, NavinRizwi, 
Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, 94rain, CucyNoiD, Nandana, Gaboe420, lucamauri, Patriccck, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, 
GoranSMilovanovic, TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, _jensen, rosalieper, Taiwania_Justo, Neuronton, 
Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, geraki, Dinoguy1000, 
Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, Catrope, Jackmcbarn, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[gerritbot]

gerritbot added a comment.


  Change 983714 had a related patch set uploaded (by Krinkle; author: Krinkle):
  
  [mediawiki/extensions/CommonsMetadata@master] Replace getPageViewLanguage() 
with ParserOutput->getLanguage()
  
  https://gerrit.wikimedia.org/r/983714

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF, gerritbot
Cc: xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, 
Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, LennardHofmann, 
Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
caldera, maantietaja, NavinRizwi, CBogen, ItamarWMDE, Akuckartz, 94rain, 
Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, 
TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, SundanceRaphael, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, 
geraki, Dinoguy1000, Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, 
Catrope, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[DAlangi_WMF]

DAlangi_WMF added a comment.


  @Krinkle, what would be a good next logical step here? Maybe double check 
callers again (just in case), then if none found, soft and hard deprecate 
`Title::getPageViewLanguage()`?

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF
Cc: xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, 
Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, LennardHofmann, 
Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
caldera, maantietaja, NavinRizwi, CBogen, ItamarWMDE, Akuckartz, 94rain, 
Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, 
TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, SundanceRaphael, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, 
geraki, Dinoguy1000, Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, 
Catrope, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[DAlangi_WMF]

DAlangi_WMF updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF
Cc: xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, 
Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, LennardHofmann, 
Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
caldera, maantietaja, NavinRizwi, CBogen, ItamarWMDE, Akuckartz, 94rain, 
Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, 
TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, SundanceRaphael, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, 
geraki, Dinoguy1000, Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, 
Catrope, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[DAlangi_WMF]

DAlangi_WMF added a comment.


  In T350806#9410485 , 
@matmarex wrote:
  
  > As discovered above, Wikibase (and CommonsMetadata too) actually use the 
ContentHandler::getPageViewLanguage rather than Title::getPageViewLanguage. I'm 
not sure if it was intended to be in scope for this task? It's similarly bad 
and indirectly reads from global state in the same way.
  
  I can confirm that CommonsMetadata and Wikibase are not in scope for this 
task. In fact, I did a patch first for Wikibase and we ended up realizing that 
it's not in scope and I just verified CommonsMetadata as well. It calls 
`getPageViewLanguage()` on ContentHandler instead of Title: 
https://gerrit.wikimedia.org/g/mediawiki/extensions/CommonsMetadata/+/92d3152feb3148322c41aef1187842082b967a92/src/HookHandler.php#155

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF
Cc: xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, 
Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, LennardHofmann, 
Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
caldera, maantietaja, NavinRizwi, CBogen, ItamarWMDE, Akuckartz, 94rain, 
Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, 
TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, SundanceRaphael, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, 
geraki, Dinoguy1000, Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, 
Catrope, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[matmarex]

matmarex updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF, matmarex
Cc: xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, 
Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, LennardHofmann, 
Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
caldera, maantietaja, NavinRizwi, CBogen, ItamarWMDE, Akuckartz, 94rain, 
Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, 
TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, SundanceRaphael, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, 
geraki, Dinoguy1000, Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, 
Catrope, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[matmarex]

matmarex added a comment.


  As discovered above, Wikibase (and CommonsMetadata too) actually use the 
ContentHandler::getPageViewLanguage rather than Title::getPageViewLanguage. I'm 
not sure if it was intended to be in scope for this task? It's similarly bad 
and indirectly reads from global state in the same way.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF, matmarex
Cc: xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, 
Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, LennardHofmann, 
Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
caldera, maantietaja, NavinRizwi, CBogen, ItamarWMDE, Akuckartz, 94rain, 
Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, 
TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, SundanceRaphael, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, 
geraki, Dinoguy1000, Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, 
Catrope, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[Maintenance_bot]

Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF, Maintenance_bot
Cc: xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, 
Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, LennardHofmann, 
Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
caldera, maantietaja, NavinRizwi, CBogen, ItamarWMDE, Akuckartz, 94rain, 
Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, 
TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, SundanceRaphael, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, 
geraki, Dinoguy1000, Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, 
Catrope, Jackmcbarn, Mbch331, Isabelladantes1983, Themindcoder, Adamm71, 
Jersione, Hellket777, LisafBia6531, 786, Biggs657, Juan90264, Alter-paule, 
Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, 
Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[DAlangi_WMF]

DAlangi_WMF updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF
Cc: xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, 
Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Mohamed-Awnallah, 
Adamm71, Jersione, Hellket777, mrephabricator, LennardHofmann, LisafBia6531, 
Astuthiodit_1, 786, lbowmaker, BTullis, Biggs657, karapayneWMDE, toberto, 
Invadibot, Ywats0ns, caldera, maantietaja, Juan90264, Alter-paule, NavinRizwi, 
Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, 94rain, CucyNoiD, Nandana, Gaboe420, lucamauri, Patriccck, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, 
GoranSMilovanovic, TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, _jensen, rosalieper, Taiwania_Justo, Neuronton, 
Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, geraki, Dinoguy1000, 
Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, Catrope, Jackmcbarn, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[gerritbot]

gerritbot added a comment.


  Change 982768 **abandoned** by D3r1ck01:
  
  [mediawiki/extensions/Wikibase@master] Content: Use `getPageLanguage()` not 
`getPageViewLanguage()`
  
  Reason:
  
  
  
  https://gerrit.wikimedia.org/r/982768

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF, gerritbot
Cc: xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, 
Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Mohamed-Awnallah, 
Adamm71, Jersione, Hellket777, mrephabricator, LennardHofmann, LisafBia6531, 
Astuthiodit_1, 786, lbowmaker, BTullis, Biggs657, karapayneWMDE, toberto, 
Invadibot, Ywats0ns, caldera, maantietaja, Juan90264, Alter-paule, NavinRizwi, 
Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, 94rain, CucyNoiD, Nandana, Gaboe420, lucamauri, Patriccck, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, 
GoranSMilovanovic, TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, _jensen, rosalieper, Taiwania_Justo, Neuronton, 
Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, geraki, Dinoguy1000, 
Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, Catrope, Jackmcbarn, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[matmarex]

matmarex added a comment.


  In T350806#9401468 , @Tgr 
wrote:
  
  > I think the more correct approach would be some kind of service that takes 
a title and a request context (or user identity + WebRequest) and looks up the 
language, so that the dependencies are made explicit.
  
  I think that's basically LanguageConverter::getPreferredVariant(), and see 
T346996  about making it a service 
instead of reading from the globals.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF, matmarex
Cc: xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, 
Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Mohamed-Awnallah, 
Adamm71, Jersione, Hellket777, mrephabricator, LennardHofmann, LisafBia6531, 
Astuthiodit_1, 786, lbowmaker, BTullis, Biggs657, karapayneWMDE, toberto, 
Invadibot, Ywats0ns, caldera, maantietaja, Juan90264, Alter-paule, NavinRizwi, 
Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, 94rain, CucyNoiD, Nandana, Gaboe420, lucamauri, Patriccck, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, 
GoranSMilovanovic, TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, _jensen, rosalieper, Taiwania_Justo, Neuronton, 
Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, geraki, Dinoguy1000, 
Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, Catrope, Jackmcbarn, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF, gerritbot
Cc: xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, 
Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Mohamed-Awnallah, 
Adamm71, Jersione, Hellket777, mrephabricator, LennardHofmann, LisafBia6531, 
Astuthiodit_1, 786, lbowmaker, BTullis, Biggs657, karapayneWMDE, toberto, 
Invadibot, Ywats0ns, caldera, maantietaja, Juan90264, Alter-paule, NavinRizwi, 
Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, 94rain, CucyNoiD, Nandana, Gaboe420, lucamauri, Patriccck, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, 
GoranSMilovanovic, TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, _jensen, rosalieper, Taiwania_Justo, Neuronton, 
Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, geraki, Dinoguy1000, 
Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, Catrope, Jackmcbarn, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[gerritbot]

gerritbot added a comment.


  Change 982768 had a related patch set uploaded (by D3r1ck01; author: Derick 
Alangi):
  
  [mediawiki/extensions/Wikibase@master] Content: Use `getPageLanguage()` not 
`getPageViewLanguage()`
  
  https://gerrit.wikimedia.org/r/982768

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF, gerritbot
Cc: xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, 
Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, LennardHofmann, 
Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
caldera, maantietaja, NavinRizwi, CBogen, ItamarWMDE, Akuckartz, 94rain, 
Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, 
TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, SundanceRaphael, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, 
geraki, Dinoguy1000, Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, 
Catrope, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[Krinkle]

Krinkle edited projects, added MediaWiki-Platform-Team; removed 
MediaWiki-Platform-Team (Radar).

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF, Krinkle
Cc: xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, 
Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, LennardHofmann, 
Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
caldera, maantietaja, NavinRizwi, CBogen, ItamarWMDE, Akuckartz, 94rain, 
Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, 
TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, SundanceRaphael, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, 
geraki, Dinoguy1000, Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, 
Catrope, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[Krinkle]

Krinkle removed a project: User-xSavitar.
Krinkle reassigned this task from xSavitar to DAlangi_WMF.
Krinkle added a subscriber: xSavitar.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DAlangi_WMF, Krinkle
Cc: xSavitar, Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, 
Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, LennardHofmann, 
Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
caldera, maantietaja, NavinRizwi, CBogen, ItamarWMDE, Akuckartz, 94rain, 
Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, 
TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, SundanceRaphael, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, 
geraki, Dinoguy1000, Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, 
Catrope, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[Krinkle]

Krinkle assigned this task to xSavitar.
Restricted Application added a project: User-xSavitar.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: xSavitar, Krinkle
Cc: Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, 
Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, LennardHofmann, 
Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
caldera, maantietaja, NavinRizwi, CBogen, ItamarWMDE, Akuckartz, 94rain, 
Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, 
TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, SundanceRaphael, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, 
geraki, Dinoguy1000, Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, 
Catrope, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[Tgr]

Tgr added a comment.


  > - **Language code**. If using Title::getPageViewLanguage to associate page 
language outside a pageview perspective, it is likely incorrect. Consider using 
`Title->getPageLanguage()` instead.
  
  I'm not sure this is correct. I've just run into this in T353199: 
prop=description does not respect language variants properly 
 which I think is caused by using 
`Title::getPageLanguage()` where `Title::getPageViewLanguage()` should have 
been used. Architecturally that method is terrible - it pretends that the 
language is derived from the title, when in reality it can depend on any number 
of things including site configuration, page configuration, user preferences, 
URL parameters or request headers (although to a lesser extent this is true of 
`Title::getPageLanguage()` as well) but functionally it's often going to be 
more correct.
  
  (I guess it depends on your definition of "pageview perspective", but if you 
include anything that's connected to a web request then you are left with very 
little that can actually be deprecated.)
  
  I think the more correct approach would be some kind of service that takes a 
title and a request context (or user identity + WebRequest) and looks up the 
language, so that the dependencies are made explicit.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tgr
Cc: Tgr, WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, 
Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, LennardHofmann, 
Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
caldera, maantietaja, NavinRizwi, CBogen, ItamarWMDE, Akuckartz, 94rain, 
Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, 
TJH2018, Nattes, QZanden, EnricoCNC, LawExplorer, SundanceRaphael, _jensen, 
rosalieper, Taiwania_Justo, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, 
geraki, Dinoguy1000, Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, 
Catrope, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[matmarex]

matmarex added a project: StructuredDiscussions.
matmarex updated the task description.
Restricted Application added a project: Growth-Team.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matmarex
Cc: WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, 
Mohamed-Awnallah, mrephabricator, LennardHofmann, Astuthiodit_1, lbowmaker, 
BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, caldera, maantietaja, 
NavinRizwi, CBogen, ItamarWMDE, Akuckartz, 94rain, Nandana, lucamauri, 
Patriccck, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, TJH2018, Nattes, QZanden, 
EnricoCNC, LawExplorer, SundanceRaphael, _jensen, rosalieper, Taiwania_Justo, 
Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, geraki, Dinoguy1000, 
Gryllida, jeblad, jayvdb, MrStradivarius, Tacsipacsi, Catrope, Jackmcbarn, 
Mbch331, Tgr
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[Maintenance_bot]

Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, 
Mohamed-Awnallah, mrephabricator, LennardHofmann, Astuthiodit_1, lbowmaker, 
BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, maantietaja, CBogen, 
ItamarWMDE, Akuckartz, Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, 
GoranSMilovanovic, TJH2018, QZanden, LawExplorer, SundanceRaphael, _jensen, 
rosalieper, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, Dinoguy1000, 
jayvdb, MrStradivarius, Tacsipacsi, Jackmcbarn, Mbch331, Tgr, 
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
786, Biggs657, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, 
joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, 
Lewizho99, Maathavan, Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[ReleaseTaggerBot]

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.10; 
2023-12-19); removed MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ReleaseTaggerBot
Cc: WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Mohamed-Awnallah, Adamm71, Jersione, 
Hellket777, mrephabricator, LennardHofmann, LisafBia6531, Astuthiodit_1, 786, 
lbowmaker, BTullis, Biggs657, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Bsandipan, GoranSMilovanovic, TJH2018, QZanden, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
alex-mashin, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, 
Tacsipacsi, Jackmcbarn, Mbch331, Tgr
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[gerritbot]

gerritbot added a comment.


  Change 982176 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Flow@master] Replace Title::getPageViewLanguage()
  
  https://gerrit.wikimedia.org/r/982176

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Mohamed-Awnallah, Adamm71, Jersione, 
Hellket777, mrephabricator, LennardHofmann, LisafBia6531, Astuthiodit_1, 786, 
lbowmaker, BTullis, Biggs657, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Bsandipan, GoranSMilovanovic, TJH2018, QZanden, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
alex-mashin, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, 
Tacsipacsi, Jackmcbarn, Mbch331, Tgr
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Mohamed-Awnallah, Adamm71, Jersione, 
Hellket777, mrephabricator, LennardHofmann, LisafBia6531, Astuthiodit_1, 786, 
lbowmaker, BTullis, Biggs657, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Bsandipan, GoranSMilovanovic, TJH2018, QZanden, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
alex-mashin, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, 
Tacsipacsi, Jackmcbarn, Mbch331, Tgr
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[gerritbot]

gerritbot added a comment.


  Change 982176 had a related patch set uploaded (by Bartosz Dziewoński; 
author: Bartosz Dziewoński):
  
  [mediawiki/extensions/Flow@master] Replace Title::getPageViewLanguage()
  
  https://gerrit.wikimedia.org/r/982176

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, 
Mohamed-Awnallah, mrephabricator, LennardHofmann, Astuthiodit_1, lbowmaker, 
BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, maantietaja, CBogen, 
ItamarWMDE, Akuckartz, Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, 
GoranSMilovanovic, TJH2018, QZanden, LawExplorer, SundanceRaphael, _jensen, 
rosalieper, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, Dinoguy1000, 
jayvdb, MrStradivarius, Tacsipacsi, Jackmcbarn, Mbch331, Tgr
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[ReleaseTaggerBot]

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.9; 
2023-12-12); removed MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ReleaseTaggerBot
Cc: WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, 
Mohamed-Awnallah, mrephabricator, LennardHofmann, Astuthiodit_1, lbowmaker, 
BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, maantietaja, CBogen, 
ItamarWMDE, Akuckartz, Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, 
GoranSMilovanovic, TJH2018, QZanden, LawExplorer, SundanceRaphael, _jensen, 
rosalieper, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, Dinoguy1000, 
jayvdb, MrStradivarius, Tacsipacsi, Jackmcbarn, Mbch331, Tgr
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[matmarex]

matmarex updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matmarex
Cc: WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, 
Mohamed-Awnallah, mrephabricator, LennardHofmann, Astuthiodit_1, lbowmaker, 
BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, maantietaja, CBogen, 
ItamarWMDE, Akuckartz, Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, 
GoranSMilovanovic, TJH2018, QZanden, LawExplorer, SundanceRaphael, _jensen, 
rosalieper, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, Dinoguy1000, 
jayvdb, MrStradivarius, Tacsipacsi, Jackmcbarn, Mbch331, Tgr
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[Maintenance_bot]

Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, 
Mohamed-Awnallah, mrephabricator, LennardHofmann, Astuthiodit_1, lbowmaker, 
BTullis, karapayneWMDE, toberto, Invadibot, Ywats0ns, maantietaja, CBogen, 
ItamarWMDE, Akuckartz, Nandana, lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, 
GoranSMilovanovic, TJH2018, QZanden, LawExplorer, SundanceRaphael, _jensen, 
rosalieper, Scott_WUaS, Izno, alex-mashin, Wikidata-bugs, aude, Dinoguy1000, 
jayvdb, MrStradivarius, Tacsipacsi, Jackmcbarn, Mbch331, Tgr, 
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
786, Biggs657, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, 
joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, 
Lewizho99, Maathavan, Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[gerritbot]

gerritbot added a comment.


  Change 974276 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Scribunto@master] ScribuntoContentHandler: Remove 
redundant Title::getPageViewLanguage use
  
  https://gerrit.wikimedia.org/r/974276

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Mohamed-Awnallah, Adamm71, Jersione, 
Hellket777, mrephabricator, LennardHofmann, LisafBia6531, Astuthiodit_1, 786, 
lbowmaker, BTullis, Biggs657, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Bsandipan, GoranSMilovanovic, TJH2018, QZanden, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
alex-mashin, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, 
Tacsipacsi, Jackmcbarn, Mbch331, Tgr
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[gerritbot]

gerritbot added a comment.


  Change 976877 **merged** by jenkins-bot:
  
  [mediawiki/extensions/EventLogging@master] ContextAttributesFactory: Use 
Title->getPageLanguage() to avoid global state
  
  https://gerrit.wikimedia.org/r/976877

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Mohamed-Awnallah, Adamm71, Jersione, 
Hellket777, mrephabricator, LennardHofmann, LisafBia6531, Astuthiodit_1, 786, 
lbowmaker, BTullis, Biggs657, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Bsandipan, GoranSMilovanovic, TJH2018, QZanden, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
alex-mashin, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, 
Tacsipacsi, Jackmcbarn, Mbch331, Tgr
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[gerritbot]

gerritbot added a comment.


  Change 974269 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Scribunto@master] ScribuntoContentHandler: Refactor 
fillParserOutput()
  
  https://gerrit.wikimedia.org/r/974269

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Mohamed-Awnallah, Adamm71, Jersione, 
Hellket777, mrephabricator, LennardHofmann, LisafBia6531, Astuthiodit_1, 786, 
lbowmaker, BTullis, Biggs657, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Bsandipan, GoranSMilovanovic, TJH2018, QZanden, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
alex-mashin, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, 
Tacsipacsi, Jackmcbarn, Mbch331, Tgr
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[gerritbot]

gerritbot added a comment.


  Change 976877 had a related patch set uploaded (by Krinkle; author: Krinkle):
  
  [mediawiki/extensions/EventLogging@master] ContextAttributesFactory: Use 
Title->getPageLanguage() to avoid global state
  
  https://gerrit.wikimedia.org/r/976877

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Mohamed-Awnallah, Adamm71, Jersione, 
Hellket777, mrephabricator, LennardHofmann, LisafBia6531, Astuthiodit_1, 786, 
lbowmaker, BTullis, Biggs657, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Bsandipan, GoranSMilovanovic, TJH2018, QZanden, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
alex-mashin, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, 
Tacsipacsi, Jackmcbarn, Mbch331, Tgr
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[ReleaseTaggerBot]

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.7; 
2023-11-28); removed MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ReleaseTaggerBot
Cc: WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Mohamed-Awnallah, Adamm71, Jersione, 
Hellket777, mrephabricator, LennardHofmann, LisafBia6531, Astuthiodit_1, 786, 
lbowmaker, BTullis, Biggs657, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Bsandipan, GoranSMilovanovic, TJH2018, QZanden, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
alex-mashin, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, 
Tacsipacsi, Jackmcbarn, Mbch331, Tgr
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[gerritbot]

gerritbot added a comment.


  Change 973276 **merged** by jenkins-bot:
  
  [mediawiki/extensions/DiscussionTools@master] SpecialDiscussionToolsDebug: 
Replace Title::getPageViewLanguage()
  
  https://gerrit.wikimedia.org/r/973276

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: WMDE-leszek, Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Mohamed-Awnallah, Adamm71, Jersione, 
Hellket777, mrephabricator, LennardHofmann, LisafBia6531, Astuthiodit_1, 786, 
lbowmaker, BTullis, Biggs657, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Bsandipan, GoranSMilovanovic, TJH2018, QZanden, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
alex-mashin, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, 
Tacsipacsi, Jackmcbarn, Mbch331, Tgr
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[gerritbot]

gerritbot added a comment.


  Change 974276 had a related patch set uploaded (by Krinkle; author: Krinkle):
  
  [mediawiki/extensions/Scribunto@master] ScribuntoContentHandler: Remove 
redundant Title::getPageViewLanguage use
  
  https://gerrit.wikimedia.org/r/974276

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Mohamed-Awnallah, Adamm71, Jersione, 
Hellket777, mrephabricator, LennardHofmann, LisafBia6531, Astuthiodit_1, 786, 
lbowmaker, BTullis, Biggs657, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Bsandipan, GoranSMilovanovic, TJH2018, QZanden, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
alex-mashin, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, 
Tacsipacsi, Jackmcbarn, Mbch331, Tgr
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[gerritbot]

gerritbot added a comment.


  Change 974269 had a related patch set uploaded (by Krinkle; author: Krinkle):
  
  [mediawiki/extensions/Scribunto@master] ScribuntoContentHandler: Refactor 
highlight() to reduce dependencies
  
  https://gerrit.wikimedia.org/r/974269

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Mohamed-Awnallah, Adamm71, Jersione, 
Hellket777, mrephabricator, LennardHofmann, LisafBia6531, Astuthiodit_1, 786, 
lbowmaker, BTullis, Biggs657, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Bsandipan, GoranSMilovanovic, TJH2018, QZanden, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
alex-mashin, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, 
Tacsipacsi, Jackmcbarn, Mbch331, Tgr
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[Krinkle]

Krinkle triaged this task as "High" priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Mohamed-Awnallah, Adamm71, Jersione, 
Hellket777, mrephabricator, LennardHofmann, LisafBia6531, Astuthiodit_1, 786, 
lbowmaker, BTullis, Biggs657, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Bsandipan, GoranSMilovanovic, TJH2018, QZanden, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
alex-mashin, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, 
Tacsipacsi, Jackmcbarn, Mbch331, Tgr
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[ReleaseTaggerBot]

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ReleaseTaggerBot
Cc: Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Mohamed-Awnallah, Adamm71, Jersione, 
Hellket777, mrephabricator, LennardHofmann, LisafBia6531, Astuthiodit_1, 786, 
lbowmaker, BTullis, Biggs657, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Bsandipan, GoranSMilovanovic, TJH2018, QZanden, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
alex-mashin, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, 
Tacsipacsi, Jackmcbarn, Mbch331, Tgr
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[gerritbot]

gerritbot added a comment.


  Change 973278 **merged** by jenkins-bot:
  
  [mediawiki/extensions/TemplateSandbox@master] Remove no-longer-needed uses of 
Title::getPageViewLanguage()
  
  https://gerrit.wikimedia.org/r/973278

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Michael, matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Mohamed-Awnallah, Adamm71, Jersione, 
Hellket777, mrephabricator, LennardHofmann, LisafBia6531, Astuthiodit_1, 786, 
lbowmaker, BTullis, Biggs657, karapayneWMDE, toberto, Invadibot, Ywats0ns, 
maantietaja, Juan90264, Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Bsandipan, GoranSMilovanovic, TJH2018, QZanden, LawExplorer, Lewizho99, 
Maathavan, SundanceRaphael, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, 
alex-mashin, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, 
Tacsipacsi, Jackmcbarn, Mbch331, Tgr
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[ItamarWMDE]

ItamarWMDE added a project: wmde-wikidata-tech.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Mohamed-Awnallah, Adamm71, Jersione, Hellket777, mrephabricator, 
LennardHofmann, LisafBia6531, Astuthiodit_1, 786, lbowmaker, BTullis, Biggs657, 
karapayneWMDE, toberto, Invadibot, Ywats0ns, maantietaja, Juan90264, 
Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Patriccck, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, 
GoranSMilovanovic, TJH2018, QZanden, LawExplorer, Lewizho99, Maathavan, 
SundanceRaphael, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, alex-mashin, 
Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Tacsipacsi, 
Jackmcbarn, Mbch331, Tgr
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[matmarex]

matmarex updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matmarex
Cc: matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Mohamed-Awnallah, Adamm71, Jersione, Hellket777, mrephabricator, 
LennardHofmann, LisafBia6531, Astuthiodit_1, 786, lbowmaker, BTullis, Biggs657, 
karapayneWMDE, toberto, Invadibot, Ywats0ns, maantietaja, Juan90264, 
Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Patriccck, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, 
GoranSMilovanovic, TJH2018, QZanden, LawExplorer, Lewizho99, Maathavan, 
SundanceRaphael, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, alex-mashin, 
Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Tacsipacsi, 
Jackmcbarn, Mbch331, Tgr
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[gerritbot]

gerritbot added a comment.


  Change 973278 had a related patch set uploaded (by Bartosz Dziewoński; 
author: Bartosz Dziewoński):
  
  [mediawiki/extensions/TemplateSandbox@master] Remove no-longer-needed uses of 
Title::getPageViewLanguage()
  
  https://gerrit.wikimedia.org/r/973278

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: matmarex, Aklapper, Krinkle, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Mohamed-Awnallah, Adamm71, Jersione, Hellket777, mrephabricator, 
LennardHofmann, LisafBia6531, Astuthiodit_1, 786, lbowmaker, BTullis, Biggs657, 
karapayneWMDE, toberto, Invadibot, Ywats0ns, maantietaja, Juan90264, 
Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Patriccck, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, 
GoranSMilovanovic, TJH2018, QZanden, LawExplorer, Lewizho99, Maathavan, 
SundanceRaphael, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, alex-mashin, 
Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Tacsipacsi, 
Jackmcbarn, Mbch331, Tgr
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[matmarex]

matmarex updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matmarex
Cc: Aklapper, Krinkle, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, 
Mohamed-Awnallah, Adamm71, Jersione, Hellket777, mrephabricator, 
LennardHofmann, LisafBia6531, Astuthiodit_1, 786, lbowmaker, BTullis, Biggs657, 
karapayneWMDE, toberto, Invadibot, Ywats0ns, maantietaja, Juan90264, 
Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Patriccck, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, 
GoranSMilovanovic, TJH2018, QZanden, LawExplorer, Lewizho99, Maathavan, 
SundanceRaphael, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, alex-mashin, 
Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Tacsipacsi, 
Jackmcbarn, Mbch331, Tgr
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Krinkle, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, 
Mohamed-Awnallah, Adamm71, Jersione, Hellket777, mrephabricator, 
LennardHofmann, LisafBia6531, Astuthiodit_1, 786, lbowmaker, BTullis, Biggs657, 
karapayneWMDE, toberto, Invadibot, Ywats0ns, maantietaja, Juan90264, 
Alter-paule, Beast1978, CBogen, ItamarWMDE, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Patriccck, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, 
GoranSMilovanovic, TJH2018, QZanden, LawExplorer, Lewizho99, Maathavan, 
SundanceRaphael, _jensen, rosalieper, Neuronton, Scott_WUaS, Izno, alex-mashin, 
Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Tacsipacsi, 
Jackmcbarn, Mbch331, Tgr
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[gerritbot]

gerritbot added a comment.


  Change 973276 had a related patch set uploaded (by Bartosz Dziewoński; 
author: Bartosz Dziewoński):
  
  [mediawiki/extensions/DiscussionTools@master] SpecialDiscussionToolsDebug: 
Replace Title::getPageViewLanguage()
  
  https://gerrit.wikimedia.org/r/973276

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Krinkle, Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, 
LennardHofmann, Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, 
Invadibot, Ywats0ns, maantietaja, CBogen, ItamarWMDE, Akuckartz, Nandana, 
lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, TJH2018, 
QZanden, LawExplorer, SundanceRaphael, _jensen, rosalieper, Scott_WUaS, Izno, 
alex-mashin, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, 
Tacsipacsi, Jackmcbarn, Mbch331, Tgr
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata

[Krinkle]

Krinkle created this task.
Krinkle added projects: MediaWiki-Platform-Team (Radar), Data-Engineering, 
Wikidata, MediaWiki-extensions-WikibaseRepository, Structured Data Engineering, 
CommonsMetadata, DiscussionTools, MediaWiki-extensions-Scribunto.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Structured-Data-Backlog.

TASK DESCRIPTION
  Background
  --
  
  See T341244: ParserOptions and Title::getPageViewLanguage may disagree on the 
lang/dir . In a nut shell, it is 
(unfortunately) common today for extensions to try to "guess" the language and 
directionality of embedded content. The reason for this is largely that a 
better API didn't exist, and classes like `mw-content-ltr` are important to set 
for correct styling, and are difficult to set by any means other than 
`Title::getPageViewLanguage`. But, Title::getPageViewLanguage involves global 
state and a lot of guess work.
  
  Scope
  -
  
  https://codesearch.wmcloud.org/deployed/?q=%3EgetPageViewLanguage
  
  [ ] EventLogging (MetricsPlatform/ContextAttributesFactory.php). 
#data-engineering 
  [ ] TemplateSandbox (Hook, SpecialPage). **Unassigned: No owner**.
  [ ] Wikibase (EntityHandler.php). #wikidata 

  [ ] CommonsMetadata (Hook). #structured_data_engineering 

  [ ] DiscussionTools (SpecialDiscussionToolsDebug.php). #editing-team 

  [ ] Scribunto (ScribuntoContentHandler.php). **Unassigned: No owner**.
  
  Outcome
  ---
  
  Remove use of Title::getPageViewLanguage.
  
  Example migration:
  
  - **HTML workarounds**: In cases where it is used to manually create CSS 
classes like `mw-content-ltr` and `mw-parser-output`, and the `lang` and `dir` 
attributes, this can probably removed given that nowadays ParserOutput will 
take care of setting these already. Be sure to test the end-user workflow and 
confirm that your workarounds are redundant before removing them. When not 
possible to remove or if not feasible in the short-term, at least use 
`ParserOutput->getLanguage()` to inform your current workarounds instead of the 
global guesswork from Title::getPageViewLanguage.
  
  - **Language code**. If using Title::getPageViewLanguage to associate page 
language outside a pageview perspective, it is likely incorrect. Consider using 
`Title->getPageLanguage()` instead.

TASK DETAIL
  https://phabricator.wikimedia.org/T350806

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Aklapper, Krinkle, Danny_Benjafield_WMDE, Mohamed-Awnallah, mrephabricator, 
LennardHofmann, Astuthiodit_1, lbowmaker, BTullis, karapayneWMDE, toberto, 
Invadibot, Ywats0ns, maantietaja, CBogen, ItamarWMDE, Akuckartz, Nandana, 
lucamauri, Patriccck, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, TJH2018, 
QZanden, LawExplorer, SundanceRaphael, _jensen, rosalieper, Scott_WUaS, Izno, 
alex-mashin, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, 
Tacsipacsi, Jackmcbarn, Mbch331, Tgr, Slack_connector_for_Editing_team_triage
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org