[Wikidata-bugs] [Maniphest] T351644: [MSMF] [TECH] Update linting rules for Mismatch Finder

guergana.tzatchkova added a comment. After doing some research, I have found that ESLint has deprecated all formatting rules: https://eslint.org/blog/2023/10/deprecating-formatting-rules/, the deprecated rules will still be available in a new package called stylistic

[Wikidata-bugs] [Maniphest] T351644: [MSMF] [TECH] Update linting rules for Mismatch Finder

guergana.tzatchkova updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T351644 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova Cc: noarave, ItamarWMDE, Aklapper, HasanAkgun_WMDE, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T351644: [MSMF] [TECH] Update linting rules for Mismatch Finder

guergana.tzatchkova added a comment. After all the back and forth I have just noticed we do have an editorconfig file already in the project , I still think it is a better idea to install stylelint. TASK

[Wikidata-bugs] [Maniphest] T351644: [MSMF] [TECH] Update linting rules for Mismatch Finder

guergana.tzatchkova added a comment. In T351644#9460246 , @guergana.tzatchkova wrote: > PR adding vue/vue3-strongly-recommended: https://github.com/wmde/wikidata-mismatch-finder/pull/836 PR adding stylelint to project

[Wikidata-bugs] [Maniphest] T351644: [MSMF] [TECH] Update linting rules for Mismatch Finder

guergana.tzatchkova updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T351644 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova Cc: noarave, ItamarWMDE, Aklapper, HasanAkgun_WMDE, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T351644: [MSMF] [TECH] Update linting rules for Mismatch Finder

HasanAkgun_WMDE added a comment. I'm totally fine with it, thanks a lot! TASK DETAIL https://phabricator.wikimedia.org/T351644 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova, HasanAkgun_WMDE Cc: noarave, ItamarWMDE, Aklapper,

[Wikidata-bugs] [Maniphest] T351644: [MSMF] [TECH] Update linting rules for Mismatch Finder

ItamarWMDE added a comment. Sounds good to me, thank you! TASK DETAIL https://phabricator.wikimedia.org/T351644 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova, ItamarWMDE Cc: noarave, ItamarWMDE, Aklapper, HasanAkgun_WMDE,

[Wikidata-bugs] [Maniphest] T351644: [MSMF] [TECH] Update linting rules for Mismatch Finder

guergana.tzatchkova added a comment. @HasanAkgun_WMDE @ItamarWMDE @noarave we still have the issue that SCSS files are not being checked by the any linter. I just realized that PostCSS converts to CSS but doesn't lint the files. I would suggest we install stylelint since it could also check

[Wikidata-bugs] [Maniphest] T351644: [MSMF] [TECH] Update linting rules for Mismatch Finder

noarave added a comment. No issue with any of it on my side TASK DETAIL https://phabricator.wikimedia.org/T351644 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova, noarave Cc: noarave, ItamarWMDE, Aklapper, HasanAkgun_WMDE,

[Wikidata-bugs] [Maniphest] T351644: [MSMF] [TECH] Update linting rules for Mismatch Finder

ItamarWMDE added a subscriber: noarave. ItamarWMDE added a comment. Pefect! thanks for clarifying, then I think it should be okay to skip the `.editorconfig` for now. Unless @HasanAkgun_WMDE and @noarave have a particular reason we should. TASK DETAIL

[Wikidata-bugs] [Maniphest] T351644: [MSMF] [TECH] Update linting rules for Mismatch Finder

guergana.tzatchkova added a comment. In T351644#9468109 , @ItamarWMDE wrote: > I don't necessarily mind either or. Although, I'm not sure indentation (or tabs v. spaces) is actually covered by the `vue3-strongly-recommended` plugin. At

[Wikidata-bugs] [Maniphest] T351644: [MSMF] [TECH] Update linting rules for Mismatch Finder

ItamarWMDE added a comment. I don't necessarily mind either or. Although, I'm not sure indentation (or tabs v. spaces) is actually covered by the `vue3-strongly-recommended` plugin. At least, I could not find it in the documentation: https://eslint.vuejs.org/rules/ TASK DETAIL

[Wikidata-bugs] [Maniphest] T351644: [MSMF] [TECH] Update linting rules for Mismatch Finder

guergana.tzatchkova added a comment. Restricted Application added a project: User-ItamarWMDE. @HasanAkgun_WMDE @ItamarWMDE Hello, since the indenting rules are reinforced by Vue 3's strongly-recommended plugin, I don't see what would be the benefit of adding a .editorconfig file. In my

[Wikidata-bugs] [Maniphest] T351644: [MSMF] [TECH] Update linting rules for Mismatch Finder

guergana.tzatchkova updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T351644 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova Cc: ItamarWMDE, Aklapper, HasanAkgun_WMDE, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T351644: [MSMF] [TECH] Update linting rules for Mismatch Finder

guergana.tzatchkova added a comment. Relevant PR: https://github.com/wmde/wikidata-mismatch-finder/pull/836 TASK DETAIL https://phabricator.wikimedia.org/T351644 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova Cc: ItamarWMDE,

[Wikidata-bugs] [Maniphest] T351644: [MSMF] [TECH] Update linting rules for Mismatch Finder

guergana.tzatchkova claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T351644 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: guergana.tzatchkova Cc: ItamarWMDE, Aklapper, HasanAkgun_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1,

[Wikidata-bugs] [Maniphest] T351644: [MSMF] [TECH] Update linting rules for Mismatch Finder

ItamarWMDE moved this task from Unified QT Backlog to Quality Tools "Sprint" on the Wikidata Dev Team board. ItamarWMDE edited projects, added Wikidata Dev Team (Quality Tools "Sprint"); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T351644 WORKBOARD

[Wikidata-bugs] [Maniphest] T351644: [MSMF] [TECH] Update linting rules for Mismatch Finder

ItamarWMDE set the point value for this task to "5". TASK DETAIL https://phabricator.wikimedia.org/T351644 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: ItamarWMDE, Aklapper, HasanAkgun_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1,

[Wikidata-bugs] [Maniphest] T351644: [MSMF] [TECH] Update linting rules for Mismatch Finder

ItamarWMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T351644 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: ItamarWMDE, Aklapper, HasanAkgun_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE,

[Wikidata-bugs] [Maniphest] T351644: [MSMF] [TECH] Update linting rules for Mismatch Finder

ItamarWMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T351644 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: ItamarWMDE, Aklapper, HasanAkgun_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE,

[Wikidata-bugs] [Maniphest] T351644: [MSMF] [TECH] Update linting rules for Mismatch Finder

ItamarWMDE renamed this task from "[SW] [MSMF] [TECH] Update linting rules for Mismatch Finder" to "[MSMF] [TECH] Update linting rules for Mismatch Finder". TASK DETAIL https://phabricator.wikimedia.org/T351644 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T351644: [MSMF] [TECH] Update linting rules for Mismatch Finder

ItamarWMDE added a comment. **Prio Notes**: | Impact Area | Affected | | --- | | | production / end users | no | | monitoring | no | | development efforts | yes | | onboarding efforts | maybe|

[Wikidata-bugs] [Maniphest] T351644: [MSMF] [TECH] Update linting rules for Mismatch Finder

Maintenance_bot added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T351644 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Aklapper, HasanAkgun_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE,