[Wikidata-bugs] [Maniphest] T353807: Stop showing IP warning when editing using Wikidata Bridge when temporary accounts enabled

Arian_Bozorg closed this task as "Resolved". Arian_Bozorg moved this task from Product Verification to Done on the Wikidata Dev Team (Wikidata.org Slice) board. Arian_Bozorg claimed this task. Arian_Bozorg added a comment. This looks good to me, thanks so much TASK DETAIL

[Wikidata-bugs] [Maniphest] T353807: Stop showing IP warning when editing using Wikidata Bridge when temporary accounts enabled

Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T353807 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: ArthurTaylor, Sarai-WMDE, Lucas_Werkmeister_WMDE, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T353807: Stop showing IP warning when editing using Wikidata Bridge when temporary accounts enabled

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.17; 2024-02-06). TASK DETAIL https://phabricator.wikimedia.org/T353807 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ReleaseTaggerBot Cc: ArthurTaylor, Sarai-WMDE, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T353807: Stop showing IP warning when editing using Wikidata Bridge when temporary accounts enabled

Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to Product Verification on the Wikidata Dev Team (Wikidata.org Slice) board. Lucas_Werkmeister_WMDE added a comment. Should be testable on Beta, I think. TASK DETAIL https://phabricator.wikimedia.org/T353807 WORKBOARD

[Wikidata-bugs] [Maniphest] T353807: Stop showing IP warning when editing using Wikidata Bridge when temporary accounts enabled

gerritbot added a comment. Change 987716 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Change anonymous edit warning based on tempuser configuration https://gerrit.wikimedia.org/r/987716 TASK DETAIL https://phabricator.wikimedia.org/T353807 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T353807: Stop showing IP warning when editing using Wikidata Bridge when temporary accounts enabled

ArthurTaylor removed ArthurTaylor as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T353807 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor Cc: ArthurTaylor, Sarai-WMDE, Lucas_Werkmeister_WMDE, Lydia_Pintscher,

[Wikidata-bugs] [Maniphest] T353807: Stop showing IP warning when editing using Wikidata Bridge when temporary accounts enabled

ArthurTaylor added a comment. Okay. Then submitting this code again for peer review. Thanks for the feedback. @Arian_Bozorg - will you file the ticket for the follow-up UX work? TASK DETAIL https://phabricator.wikimedia.org/T353807 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T353807: Stop showing IP warning when editing using Wikidata Bridge when temporary accounts enabled

Lydia_Pintscher added a comment. Additional context: Relatively small number of people means right now no-one as the Bridge is effectively disabled anywhere but test systems until the new team gets going with it. TASK DETAIL https://phabricator.wikimedia.org/T353807 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T353807: Stop showing IP warning when editing using Wikidata Bridge when temporary accounts enabled

Arian_Bozorg added a comment. Hi all, although not an ideal solution as we currently have it, it will only be touching a relatively small number of people. So I think we can go with the current solution as Arthur has presented and address the delayed message and Sarai's design further down

[Wikidata-bugs] [Maniphest] T353807: Stop showing IP warning when editing using Wikidata Bridge when temporary accounts enabled

Sarai-WMDE added a comment. My quick take: - Using the message type "Notice" to display the information to temp-accounts makes sense. - Flashing the warning message in this scenario is definitely confusing. In case this is unavoidable, then my initial suggestion would be to only

[Wikidata-bugs] [Maniphest] T353807: Stop showing IP warning when editing using Wikidata Bridge when temporary accounts enabled

ArthurTaylor added a subscriber: Sarai-WMDE. ArthurTaylor added a comment. Ping @Lydia_Pintscher , @Sarai-WMDE - what should we do here? The data to decide what message to show isn't immediately available, and the messages fill up different amounts of space in the dialog. Are there other

[Wikidata-bugs] [Maniphest] T353807: Stop showing IP warning when editing using Wikidata Bridge when temporary accounts enabled

Lucas_Werkmeister_WMDE added a comment. Also, currently it briefly shows the original warning message, then switches to the notice when the API tells us that temporary accounts are enabled: F41693371: Screencast from 2024-01-16 13-31-37.webm

[Wikidata-bugs] [Maniphest] T353807: Stop showing IP warning when editing using Wikidata Bridge when temporary accounts enabled

ArthurTaylor added a comment. It would be great to have a design for this ticket. I played around with a couple of things, but completely removing the warning makes the layout weird. Displaying the message as a warning, but with text that is actually formulated as an invitation /

[Wikidata-bugs] [Maniphest] T353807: Stop showing IP warning when editing using Wikidata Bridge when temporary accounts enabled

Lucas_Werkmeister_WMDE added a comment. Clarification question for Product: Arthur’s change currently makes it so the temp-accounts version of the message is shown as a notice rather than a warning, is that right? (It sounds sensible to me, but I don’t think it’s specified in the task so

[Wikidata-bugs] [Maniphest] T353807: Stop showing IP warning when editing using Wikidata Bridge when temporary accounts enabled

ArthurTaylor added a comment. @Lucas_Werkmeister_WMDE sorry - my bad. One patch based the behaviour on the TempUser configuration of the client wiki, and one based it on the TempUser configuration of the target repo. The newer patch reflects the discussion in the ticket, and the older patch

[Wikidata-bugs] [Maniphest] T353807: Stop showing IP warning when editing using Wikidata Bridge when temporary accounts enabled

gerritbot added a comment. Change 984211 **abandoned** by Arthur taylor: [mediawiki/extensions/Wikibase@master] Change anonymous edit warning in wikidata-bridge for temp users Reason: Superceded by 987716 https://gerrit.wikimedia.org/r/984211 TASK DETAIL

[Wikidata-bugs] [Maniphest] T353807: Stop showing IP warning when editing using Wikidata Bridge when temporary accounts enabled

Lucas_Werkmeister_WMDE added a comment. I’m confused by the two Gerrit changes attached here, are they both up for review or is one meant to replace the other? TASK DETAIL https://phabricator.wikimedia.org/T353807 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T353807: Stop showing IP warning when editing using Wikidata Bridge when temporary accounts enabled

gerritbot added a comment. Change 987716 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor): [mediawiki/extensions/Wikibase@master] Change anonymous edit warning based on tempuser configuration https://gerrit.wikimedia.org/r/987716 TASK DETAIL

[Wikidata-bugs] [Maniphest] T353807: Stop showing IP warning when editing using Wikidata Bridge when temporary accounts enabled

Lydia_Pintscher added a comment. Since the edit is made on Wikidata, that is what should be taken into account for deciding if IPs are going to be leaked. TASK DETAIL https://phabricator.wikimedia.org/T353807 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T353807: Stop showing IP warning when editing using Wikidata Bridge when temporary accounts enabled

Arian_Bozorg added a comment. Open question: when should the warning be removed? When the client has temp accounts enabled, when Wikdata has temp accounts enabled, or when both have them enabled? TASK DETAIL https://phabricator.wikimedia.org/T353807 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T353807: Stop showing IP warning when editing using Wikidata Bridge when temporary accounts enabled

ArthurTaylor claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T353807 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor Cc: Lydia_Pintscher, Aklapper, Arian_Bozorg, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder,

[Wikidata-bugs] [Maniphest] T353807: Stop showing IP warning when editing using Wikidata Bridge when temporary accounts enabled

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T353807 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Lydia_Pintscher, Aklapper, Arian_Bozorg, Danny_Benjafield_WMDE, Isabelladantes1983,

[Wikidata-bugs] [Maniphest] T353807: Stop showing IP warning when editing using Wikidata Bridge when temporary accounts enabled

gerritbot added a comment. Change 984211 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor): [mediawiki/extensions/Wikibase@master] Change anonymous edit warning in wikidata-bridge for temp users https://gerrit.wikimedia.org/r/984211 TASK DETAIL

[Wikidata-bugs] [Maniphest] T353807: Stop showing IP warning when editing using Wikidata Bridge when temporary accounts enabled

Arian_Bozorg created this task. Arian_Bozorg added projects: Temporary accounts, wmde-wikidata-tech, Wikidata, Wikidata Dev Team (Wikidata.org Slice), Wikidata-Bridge. TASK DESCRIPTION **Problem:** We are showing warnings when editing on Wikidata Bridge and the user isn't logged in. This