[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

gerritbot added a comment. Change #1012674 **abandoned** by Arthur taylor: [mediawiki/extensions/Wikibase@REL1_39] [DNM] test empty commit Reason: Tests are now passing https://gerrit.wikimedia.org/r/1012674 TASK DETAIL https://phabricator.wikimedia.org/T356896 EMAIL

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

gerritbot added a comment. Change #1012674 **restored** by Arthur taylor: [mediawiki/extensions/Wikibase@REL1_39] [DNM] test empty commit https://gerrit.wikimedia.org/r/1012674 TASK DETAIL https://phabricator.wikimedia.org/T356896 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

gerritbot added a comment. Change #1012674 **abandoned** by Arthur taylor: [mediawiki/extensions/Wikibase@REL1_39] [DNM] test empty commit Reason: just a test https://gerrit.wikimedia.org/r/1012674 TASK DETAIL https://phabricator.wikimedia.org/T356896 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

gerritbot added a comment. Change #1016923 **abandoned** by Arthur taylor: [mediawiki/extensions/Wikibase@REL1_40] [DNM] test empty commit Reason: just a test https://gerrit.wikimedia.org/r/1016923 TASK DETAIL https://phabricator.wikimedia.org/T356896 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

ArthurTaylor moved this task from In Tech Verification to Done on the Wikidata Dev Team (Wikidata.org Slice) board. ArthurTaylor closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T356896 WORKBOARD https://phabricator.wikimedia.org/project/board/6751/ EMAIL

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

ArthurTaylor added a comment. Just retested. CI on REL1_40 is green, and REL1_39 fails for reasons unconnected to QUnit. Marking this as done. TASK DETAIL https://phabricator.wikimedia.org/T356896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

ArthurTaylor updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T356896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor Cc: ArthurTaylor, hashar, karapayneWMDE, Lucas_Werkmeister_WMDE, Aklapper, Michael,

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

gerritbot added a comment. Change #1016923 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor): [mediawiki/extensions/Wikibase@REL1_40] [DNM] test empty commit https://gerrit.wikimedia.org/r/1016923 TASK DETAIL https://phabricator.wikimedia.org/T356896

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

ArthurTaylor added a comment. Agreed. I'll move it to tech validation and do a one more set of empty changes against REL1_39 and REL1_40 to confirm, then I'll close it. TASK DETAIL https://phabricator.wikimedia.org/T356896 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

Lucas_Werkmeister_WMDE added a comment. Alright, then I think we can close this task? TASK DETAIL https://phabricator.wikimedia.org/T356896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: ArthurTaylor, hashar,

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

ArthurTaylor removed ArthurTaylor as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T356896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor Cc: ArthurTaylor, hashar, karapayneWMDE, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

ArthurTaylor added a comment. REL1_40 is now passing and REL1_39 is failing but for reasons

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

gerritbot added a comment. Change 1010179 **abandoned** by Arthur taylor: [mediawiki/core@master] Rewrite HtmlJsCode::encodeObject to reduce memory usage Reason: Patch doesn't impact peak memory usage and decreases readability. https://gerrit.wikimedia.org/r/1010179 TASK

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

gerritbot added a comment. Change 1010186 **abandoned** by Arthur taylor: [mediawiki/core@REL1_40] Rewrite XmlJsCode::encodeObject to reduce memory usage Reason: Change is not necessary since we bumped the CI memory limit instead https://gerrit.wikimedia.org/r/1010186

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

gerritbot added a comment. Change 1012674 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor): [mediawiki/extensions/Wikibase@REL1_39] [DNM] test empty commit https://gerrit.wikimedia.org/r/1012674 TASK DETAIL https://phabricator.wikimedia.org/T356896

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

hashar added a comment. This is an exact duplicate of T356402: [ES] Investigate OutOfMemory error in browser test, remove workaround which itself follows up T354179: EntitySchema CI broken on master with OutOfMemory error in browser test

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

Lucas_Werkmeister_WMDE added a comment. I also lean towards increasing memory, see T356402#9623035 . TASK DETAIL https://phabricator.wikimedia.org/T356896 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

ArthurTaylor added a comment. The code on `master` for the same request has a peak memory consumption of 89.16MB without the patch and the patch doesn't seem to have an impact on the peak memory consumption - there has been a substantial refactor of the ResourceLoader to reduce the amount

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

ArthurTaylor added a comment. And just to make this more concrete and compact, the following request: http://127.0.0.1:9413/load.php?modules=test.DiscussionTools=1a741 has a peak memory consumption of 77.47MB (with the old implementation of `{Html,Xml}JsCode::encodeObject`. TASK

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

ArthurTaylor added a comment. A few more updates here. I looked at the memory usage for the above request (in the failing case), and instrumented the run with repeated calls to `memory_get_usage()` in the interactive debugger in PHPStorm. What I saw there is that in

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

gerritbot added a comment. Change 1008855 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor): [mediawiki/extensions/EntitySchema@master] Remove dispensable start-up request introduced as CI workaround https://gerrit.wikimedia.org/r/1008855 TASK DETAIL

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

gerritbot added a comment. Change 1010186 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor): [mediawiki/core@REL1_40] Rewrite XmlJsCode::encodeObject to reduce memory usage https://gerrit.wikimedia.org/r/1010186 TASK DETAIL

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T356896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, gerritbot Cc: karapayneWMDE, Lucas_Werkmeister_WMDE, Aklapper, Michael,

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

gerritbot added a comment. Change 1010179 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor): [mediawiki/core@master] Rewrite HtmlJsCode::encodeObject to reduce memory usage https://gerrit.wikimedia.org/r/1010179 TASK DETAIL

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

ArthurTaylor added a comment. I had a poke around at this the last days. Quick status update from my side. Running Quibble locally it's possible to reproduce the issue: mkdir -p src && mkdir -p cache && mkdir -p log && mkdir -p ref docker run

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

ArthurTaylor claimed this task. ArthurTaylor edited projects, added Wikidata Dev Team (Wikidata.org Slice); removed Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T356896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

Lucas_Werkmeister_WMDE added a comment. On a recheck, the REL1_40 change now failed both in test and in gate-and-submit, so it looks like I just got lucky the first time. TASK DETAIL https://phabricator.wikimedia.org/T356896 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

Lucas_Werkmeister_WMDE added a comment. Also, that build I just linked is from this REL1_40 change – specifically from gate-and-submit: the normal test build worked. So maybe this only fails some of the time? (On the

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

Lucas_Werkmeister_WMDE added a comment. Look what I found in `mw-error.log` (linked under “build artifacts” from the overview page of a failed build like this one ): counterexample Fatal

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

Lucas_Werkmeister_WMDE added a comment. Since we want to backport some fixes to the release branches soon, it would be good to have green CI there. If we can’t figure out the problem and don’t want to spend too much time on it, maybe we’ll end up just disabling the tests temporarily… TASK

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

karapayneWMDE added a comment. triage - is there urgency here? we can maybe handover the article placeholder topic to WD TASK DETAIL https://phabricator.wikimedia.org/T356896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: karapayneWMDE Cc:

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

Lucas_Werkmeister_WMDE moved this task from Incoming to [DOT] By Project on the wmde-wikidata-tech board. Lucas_Werkmeister_WMDE added a project: Wikidata Dev Team. TASK DETAIL https://phabricator.wikimedia.org/T356896 WORKBOARD https://phabricator.wikimedia.org/project/board/5864/ EMAIL

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

Lucas_Werkmeister_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T356896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

Lucas_Werkmeister_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T356896 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE,

[Wikidata-bugs] [Maniphest] T356896: Wikibase CI on REL1_40 broken: QUnit tests failing to run

Michael created this task. Michael added projects: Wikidata, ArticlePlaceholder, wmde-wikidata-tech. TASK DESCRIPTION On REL1_41 the CI for the Wikibase fails with the QUnit tests seemingly failing to run / timing out: 16:47:05 07 02 2024 16:47:05.028:DEBUG [middleware:source-files]: