[Wikidata-bugs] [Maniphest] [Commented On] T211120: Create integration/edge-to-edge ensuring blocked users cannot edit Wikibase entities via Special Pages

2018-12-14 Thread gerritbot
gerritbot added a comment. Change 477825 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add browser test for special pages with blocked users https://gerrit.wikimedia.org/r/477825TASK DETAILhttps://phabricator.wikimedia.org/T211120EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T211927: SnakDeserializer must apply ID prefix mapping

2018-12-14 Thread gerritbot
gerritbot added a comment. Change 479610 had a related patch set uploaded (by Hoo man; owner: Hoo man): [mediawiki/extensions/WikibaseLexeme@master] SenseDeserializerTest: Don't directly construct SnakDeserializer https://gerrit.wikimedia.org/r/479610TASK

[Wikidata-bugs] [Maniphest] [Commented On] T196073: Wikidata primary sources tool deployment review

2018-12-14 Thread Hjfocs
Hjfocs added a comment. In T196073#4822907, @MaxSem wrote: For starters, this extension's code should be in Wikimedia source control. Could you please clarify? It seems to me the code is in Wikimedia source control:

[Wikidata-bugs] [Maniphest] [Commented On] T211800: Resolve ambiguity of entity ID prefixes used on Commons.

2018-12-14 Thread Cparle
Cparle added a comment. +1TASK DETAILhttps://phabricator.wikimedia.org/T211800EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CparleCc: Cparle, Jdforrester-WMF, Abit, EBjune, Ramsey-WMF, Aklapper, daniel, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86,

[Wikidata-bugs] [Maniphest] [Commented On] T211800: Resolve ambiguity of entity ID prefixes used on Commons.

2018-12-14 Thread daniel
daniel added a comment. For option three, we'd have to decide whether the per-entity-type-defaults should be defined separately from the prefix mapping, or whether it should use some kind of special syntax., I'd suggest the hybrid approach we have also been using for including the target slot in

[Wikidata-bugs] [Maniphest] [Edited] T196073: Wikidata primary sources tool deployment review

2018-12-14 Thread Hjfocs
Hjfocs updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- Gerrit repository: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/PrimarySources,dashboards/defaults - Phabricator project: #wikidata-primary-sources ...TASK

[Wikidata-bugs] [Maniphest] [Commented On] T211927: SnakDeserializer must apply ID prefix mapping

2018-12-14 Thread gerritbot
gerritbot added a comment. Change 479604 had a related patch set uploaded (by Hoo man; owner: Hoo man): [mediawiki/vendor@master] Update wikibase/data-model-serialization to 2.9.1 https://gerrit.wikimedia.org/r/479604TASK DETAILhttps://phabricator.wikimedia.org/T211927EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T211927: SnakDeserializer must apply ID prefix mapping

2018-12-14 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T211927EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, hoo, Jdforrester-WMF, Addshore, WMDE-leszek, Aklapper, daniel, CucyNoiD, Nandana,

[Wikidata-bugs] [Maniphest] [Commented On] T211927: SnakDeserializer must apply ID prefix mapping

2018-12-14 Thread gerritbot
gerritbot added a comment. Change 479605 had a related patch set uploaded (by Hoo man; owner: Hoo man): [mediawiki/extensions/Wikibase@master] Require at least wikibase/data-model-serialization 2.9.1 https://gerrit.wikimedia.org/r/479605TASK DETAILhttps://phabricator.wikimedia.org/T211927EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T207150: Move label, description and aliases of interface language to their new positions

2018-12-14 Thread Lea_WMDE
Lea_WMDE added a comment. Meta question :Where should I move this ticket if it is not done? Back to backlog?TASK DETAILhttps://phabricator.wikimedia.org/T207150EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lea_WMDECc: WMDE-leszek, Hanna_Petruschat_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T208924: PHP Fatal from querypage API: Argument passed to SpecialEntityUsage::__construct must implement EntityIdParser

2018-12-14 Thread gerritbot
gerritbot added a comment. Change 479194 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Remove unintended api special page ➜ fix fatal error https://gerrit.wikimedia.org/r/479194TASK DETAILhttps://phabricator.wikimedia.org/T208924EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T204542: Security review for the Wikidata primary sources tool MediaWiki extension

2018-12-14 Thread Hjfocs
Hjfocs added a comment. In T204542#4817688, @sbassett wrote: Not seeing anything in master or REL1_32 for this. Is it somewhere else? Not sure what you mean, the code is here: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/PrimarySources If not, is there an estimate for

[Wikidata-bugs] [Maniphest] [Commented On] T164606: As a user who enjoys adding descriptions, I can easily find other suitable articles to add descriptions to

2018-12-14 Thread cooltey
cooltey added a comment. Thanks for the update, @cmadeo Have a question about the Article preview screen. Since the card view in Adding title descriptions feed is clickable and able to read the article, should I keep the card view clickable? And in our current bottom sheet dialog, we have the

[Wikidata-bugs] [Maniphest] [Commented On] T125976: Run mediawiki::maintenance scripts in Beta Cluster

2018-12-14 Thread Dzahn
Dzahn added a comment. @MarcoAurelio The patch means more specifically just that a host deployment-mwmaint01.deployment-prep.eqiad.wmflabs is receiving mediawiki deployments when/if scap is running in deployment-prep. But yea, on

[Wikidata-bugs] [Maniphest] [Edited] T164606: As a user who enjoys adding descriptions, I can easily find other suitable articles to add descriptions to

2018-12-14 Thread cmadeo
cmadeo updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...===Mocks Portrait | Adding title descriptions feed | Skipping an item | Title description editing UI | Review of edit | Feed overflow menu ...| Related task: T164606 | Related task: T164606 | Related task:

[Wikidata-bugs] [Maniphest] [Commented On] T164606: As a user who enjoys adding descriptions, I can easily find other suitable articles to add descriptions to

2018-12-14 Thread cmadeo
cmadeo added a comment. @cooltey thanks for jumping on a call to help me understand this better! Yes, let's keep the card style as it is currently implemented and include the overflow only if it doesn't cause too much trouble during implementation. Thank you!TASK

[Wikidata-bugs] [Maniphest] [Commented On] T204542: Security review for the Wikidata primary sources tool MediaWiki extension

2018-12-14 Thread sbassett
sbassett added a comment. Ok, thanks for the update, @Hjfocs.TASK DETAILhttps://phabricator.wikimedia.org/T204542EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: sbassettCc: sbassett, Aklapper, Hjfocs, Nandana, Lahi, Gq86, GoranSMilovanovic, Kiailandi,

[Wikidata-bugs] [Maniphest] [Commented On] T164606: As a user who enjoys adding descriptions, I can easily find other suitable articles to add descriptions to

2018-12-14 Thread cmadeo
cmadeo added a comment. @cooltey if it's okay I'd prefer if the card wasn't clickable in the preview and to also not include the overflow menu. Being able to click on the card in the editing mode is helpful for additional context, but it could potentially be a bit confusing in the preview as their

[Wikidata-bugs] [Maniphest] [Commented On] T210901: Stale reads for WDQS Updater

2018-12-14 Thread gerritbot
gerritbot added a comment. Change 479762 had a related patch set uploaded (by Smalyshev; owner: Smalyshev): [wikidata/query/rdf@master] Fix delayed updates https://gerrit.wikimedia.org/r/479762TASK DETAILhttps://phabricator.wikimedia.org/T210901EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T211120: Create integration/edge-to-edge ensuring blocked users cannot edit Wikibase entities via Special Pages

2018-12-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Apparently we decided at some point that these tests should only run on the nightly browser tests, not in regular CI runs. Does anyone remember why? They don’t take particularly long, if I interpret the gate-and-submit CI output correctly (less than ten

[Wikidata-bugs] [Maniphest] [Updated] T211927: SnakDeserializer must apply ID prefix mapping

2018-12-14 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.9; 2018-12-18). TASK DETAILhttps://phabricator.wikimedia.org/T211927EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ReleaseTaggerBotCc: gerritbot, hoo, Jdforrester-WMF, Addshore, WMDE-leszek,

[Wikidata-bugs] [Maniphest] [Updated] T209958: Write a maintenance script to create entities needed for WikibaseQualityConstraints configuration

2018-12-14 Thread ReleaseTaggerBot
ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.9; 2018-12-18); removed MW-1.33-notes (1.33.0-wmf.8; 2018-12-11). TASK DETAILhttps://phabricator.wikimedia.org/T209958EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T209504: Perform more constraint type checks in PHP before falling back to SPARQL

2018-12-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Currently, we are checking about 65%-70% of entities in PHP. I would like to understand if that 20% that I would like to shift to PHP comes from entities with typically 20-40 checks each or from entities with 20-110 checks each. Then we can adjust the config

[Wikidata-bugs] [Maniphest] [Commented On] T211120: Create integration/edge-to-edge ensuring blocked users cannot edit Wikibase entities via Special Pages

2018-12-14 Thread WMDE-leszek
WMDE-leszek added a comment. I believe the point of running those not per-commit, but say once a day was brought as the counterweight to a possible concern that having additional browser tests will lead to siginificant slow down of per-change CI jobs. If this is not the case at this point, I

[Wikidata-bugs] [Maniphest] [Reopened] T210260: Stretch in docker registry forces ascii encoding

2018-12-14 Thread akosiaris
akosiaris reopened this task as "Open".akosiaris added a comment. Oops, closed this by mistake. Re-opened, feel free to close when the issue is indeed resolved.TASK DETAILhttps://phabricator.wikimedia.org/T210260EMAIL

[Wikidata-bugs] [Maniphest] [Closed] T210260: Stretch in docker registry forces ascii encoding

2018-12-14 Thread akosiaris
akosiaris closed this task as "Resolved".akosiaris claimed this task.akosiaris added a comment. In T210260#4820556, @hashar wrote: Following the merge of https://gerrit.wikimedia.org/r/478200 , can you possibly rebuild the two images please? :) RepositoryTagImage idCreatedSize

[Wikidata-bugs] [Maniphest] [Edited] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId

2018-12-14 Thread Addshore
Addshore updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [x] [make generator configurable](https://gerrit.wikimedia.org/r/474731) - [] enable on beta - [] enable on test - [] enable on wikidataTASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL

[Wikidata-bugs] [Maniphest] [Edited] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId

2018-12-14 Thread Addshore
Addshore updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...#patch-for-review / TODO: - [ - [x] [add `UpsertSqlIdGenerator`](https://gerrit.wikimedia.org/r/474278)...- [x] [make generator configurable](https://gerrit.wikimedia.org/r/474731) - [] enable on beta - []

[Wikidata-bugs] [Maniphest] [Unassigned] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId

2018-12-14 Thread Addshore
Addshore removed Addshore as the assignee of this task.Addshore moved this task from Test (Verification) to To Do on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Addshore added a comment. In T194299#4817370, @Lucas_Werkmeister_WMDE wrote: And then also leave it enabled on all

[Wikidata-bugs] [Maniphest] [Changed Status] T209957: Configure WikibaseQualityConstraints on beta

2018-12-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE changed the task status from "Stalled" to "Open".Lucas_Werkmeister_WMDE moved this task from Stalled to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. TASK

[Wikidata-bugs] [Maniphest] [Retitled] T195449: Special:SetLabel and friends crash on entities that do not support terms

2018-12-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE renamed this task from "Special:SetLabel and friends should not accept Labels or Forms as input" to "Special:SetLabel and friends crash on entities that do not support terms".Lucas_Werkmeister_WMDE added a project: Wikimedia-production-error.Lucas_Werkmeister_WMDE updated

[Wikidata-bugs] [Maniphest] [Commented On] T207150: Move label, description and aliases of interface language to their new positions

2018-12-14 Thread Pablo-WMDE
Pablo-WMDE added a comment. @Lea_WMDE I moved it back to ToDo in our iteration board until we are confident again that we have all (our) sub-tasks of it covered.TASK DETAILhttps://phabricator.wikimedia.org/T207150EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T209957: Configure WikibaseQualityConstraints on beta

2018-12-14 Thread Stashbot
Stashbot added a comment. Mentioned in SAL (#wikimedia-releng) [2018-12-14T13:08:54Z] lucaswerkmeister-wmde@deployment-mwmaint01:~$ mwscript extensions/WikibaseQualityConstraints/maintenance/ImportConstraintEntities.php --wiki=wikidatawiki --config-format=wgConf | tee

[Wikidata-bugs] [Maniphest] [Updated] T209957: Configure WikibaseQualityConstraints on beta

2018-12-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Output is available in P7913, and the script took the following time to run: real 1m43.083s user 0m34.344s sys 0m11.012s I’ll submit a config change to add the configuration settings.TASK DETAILhttps://phabricator.wikimedia.org/T209957EMAIL

[Wikidata-bugs] [Maniphest] [Edited] T211119: Create integration/edge-to-edge ensuring blocked users cannot edit Wikibase entities via the API

2018-12-14 Thread Michael
Michael updated the task description. (Show Details) CHANGES TO TASK DESCRIPTIONPart of T211038 but for the API modules Api modules:**Wikibase api modules:** [] wbcreateclaim [] wbcreateredirect [] wbeditentity [] wbmergeitems [] wbremoveclaims [] wbremovequalifiers [] wbremovereferences []

[Wikidata-bugs] [Maniphest] [Closed] T209958: Write a maintenance script to create entities needed for WikibaseQualityConstraints configuration

2018-12-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved".Lucas_Werkmeister_WMDE moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Lucas_Werkmeister_WMDE added a comment. Seems to be working (tested on Beta, successfully this time).TASK

[Wikidata-bugs] [Maniphest] [Unblock] T209957: Configure WikibaseQualityConstraints on beta

2018-12-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed subtask T209958: Write a maintenance script to create entities needed for WikibaseQualityConstraints configuration as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T209957EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T209504: Perform more constraint type checks in PHP before falling back to SPARQL

2018-12-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. In T209504#4823532, @Agabi10 wrote: Isn't this one the rate? Which, by the way, could have a better color choice to make it more accessible. No, sorry, I meant the rate of SPARQL checks over time, not compared to PHP checks. (Though that rate should also

[Wikidata-bugs] [Maniphest] [Commented On] T210260: Stretch in docker registry forces ascii encoding

2018-12-14 Thread hashar
hashar added a comment. I will look at rebiulding the CI images: ci-jessie/Dockerfile.template:ENV LANG='en_US.UTF-8' LANGUAGE='en_US:en' LC_ALL='en_US.UTF-8' ci-stretch/Dockerfile.template:ENV LANG='en_US.UTF-8' LANGUAGE='en_US:en' LC_ALL='en_US.UTF-8' operations-dnslint/Dockerfile.template:ENV

[Wikidata-bugs] [Maniphest] [Reopened] T166491: Encoding of spaces in WDQS URLs in Firefox

2018-12-14 Thread Pigsonthewing
Pigsonthewing reopened this task as "Open".Pigsonthewing added a comment. I have just upgraded to v64 (under win 10) and the problem persists.TASK DETAILhttps://phabricator.wikimedia.org/T166491EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Smalyshev,

[Wikidata-bugs] [Maniphest] [Commented On] T209504: Perform more constraint type checks in PHP before falling back to SPARQL

2018-12-14 Thread Michael
Michael added a comment. In T209504#4821248, @Lucas_Werkmeister_WMDE wrote: New tracking has been deployed and added to Grafana (“PHP Type Check Entities” panel), so we should be able to see how much these numbers move up when we bump the limit. I see now that this gives us only the

[Wikidata-bugs] [Maniphest] [Closed] T204109: Investigate some Wikidata write api queries taking over 30 seconds. (In EntityContent::collectValues?)

2018-12-14 Thread Addshore
Addshore closed this task as "Resolved".Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Addshore added a comment. So the monitoring was deployed with wmf6 The improvement was deployed with wmf.8 I added annotations (which we

[Wikidata-bugs] [Maniphest] [Commented On] T209958: Write a maintenance script to create entities needed for WikibaseQualityConstraints configuration

2018-12-14 Thread gerritbot
gerritbot added a comment. Change 479254 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Don’t create the import user in dry-run mode https://gerrit.wikimedia.org/r/479254TASK DETAILhttps://phabricator.wikimedia.org/T209958EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T209958: Write a maintenance script to create entities needed for WikibaseQualityConstraints configuration

2018-12-14 Thread gerritbot
gerritbot added a comment. Change 479255 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Fix extraction of entity IDs from StorageExceptions https://gerrit.wikimedia.org/r/479255TASK DETAILhttps://phabricator.wikimedia.org/T209958EMAIL

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T193360: Cantonese Wikipedia mobile app interface cannot edit yue descriptions from Wikidata

2018-12-14 Thread JoeWalsh
JoeWalsh added a subscriber: NHarateh_WMF.JoeWalsh added a comment. @cooltey - @bearND is right that the language should be changed from zh-yue to yue. There are a few other entries in the mapping dictionary on iOS so those should be adjusted before passing to language as well. @NHarateh_WMF is

[Wikidata-bugs] [Maniphest] [Commented On] T209504: Perform more constraint type checks in PHP before falling back to SPARQL

2018-12-14 Thread Agabi10
Agabi10 added a comment. In T209504#4823419, @Lucas_Werkmeister_WMDE wrote: In the “Type Check Runtime” panel, I would expect the times of PHP checks to increase slightly, and the times of SPARQL checks probably wouldn’t change (their rate should decrease, but we don’t currently plot that).

[Wikidata-bugs] [Maniphest] [Updated] T209957: Configure WikibaseQualityConstraints on beta

2018-12-14 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAILhttps://phabricator.wikimedia.org/T209957EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, Stashbot, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Aklapper,

[Wikidata-bugs] [Maniphest] [Commented On] T209957: Configure WikibaseQualityConstraints on beta

2018-12-14 Thread gerritbot
gerritbot added a comment. Change 479681 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [operations/mediawiki-config@master] Configure WikibaseQualityConstraints on Beta https://gerrit.wikimedia.org/r/479681TASK

[Wikidata-bugs] [Maniphest] [Commented On] T209399: Update Wikidata reference tracking

2018-12-14 Thread gerritbot
gerritbot added a comment. Change 475807 merged by jenkins-bot: [analytics/wmde/toolkit-analyzer@master] Update metric's items and properties automatically https://gerrit.wikimedia.org/r/475807TASK DETAILhttps://phabricator.wikimedia.org/T209399EMAIL

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T54971: [Goal] Sitelinks and arbitrary accesses to Incubator, OldWikisource and BetaWikiversity

2018-12-14 Thread Liuxinyu970226
Liuxinyu970226 added a subscriber: Shizhao.Liuxinyu970226 added a comment. @Amire80 But some Wikipedias also have reasons (e.g. multi-scripts used, and FWIW #mediawiki-language-converter can't work for at least Min Dong, Hakka, Ladino and (through can work "remotely") Mongolian) and benefits to 1.

[Wikidata-bugs] [Maniphest] [Commented On] T204542: Security review for the Wikidata primary sources tool MediaWiki extension

2018-12-14 Thread Aklapper
Aklapper added a comment. Not sure what you mean, the code is here: @Hjfocs: There is no code. https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/PrimarySources/+/master is empty.TASK DETAILhttps://phabricator.wikimedia.org/T204542EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T211927: SnakDeserializer must apply ID prefix mapping

2018-12-14 Thread gerritbot
gerritbot added a comment. Change 479610 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] SenseDeserializerTest: Don't directly construct SnakDeserializer https://gerrit.wikimedia.org/r/479610TASK DETAILhttps://phabricator.wikimedia.org/T211927EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T204542: Security review for the Wikidata primary sources tool MediaWiki extension

2018-12-14 Thread Hjfocs
Hjfocs added a comment. @Hjfocs: There is no code. https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/PrimarySources/+/master is empty. Interesting, will find out what went wrong. Thanks for the extra pair of eyes!

[Wikidata-bugs] [Maniphest] [Commented On] T209504: Perform more constraint type checks in PHP before falling back to SPARQL

2018-12-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. However, what would be much more useful to know, would be the distribution of checks that exceeded that limit and were handled by SPARQL. Well, that’s the “Type Check Runtimes” and “Type Check Distribution” panels… which information exactly do you want to

[Wikidata-bugs] [Maniphest] [Blocker] T209922: Configure WikibaseQualityConstraints on test

2018-12-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE changed the status of subtask T209957: Configure WikibaseQualityConstraints on beta from "Stalled" to "Open". TASK DETAILhttps://phabricator.wikimedia.org/T209922EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc:

[Wikidata-bugs] [Maniphest] [Edited] T209958: Write a maintenance script to create entities needed for WikibaseQualityConstraints configuration

2018-12-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...- [x] [remove old script](https://gerrit.wikimedia.org/r/476249) - [ - [x] [don’t create user in dry-run mode](https://gerrit.wikimedia.org/r/479254) - [ - [x] [fix error

[Wikidata-bugs] [Maniphest] [Commented On] T209504: Perform more constraint type checks in PHP before falling back to SPARQL

2018-12-14 Thread Michael
Michael added a comment. In T209504#4823419, @Lucas_Werkmeister_WMDE wrote: However, what would be much more useful to know, would be the distribution of checks that exceeded that limit and were handled by SPARQL. Well, that’s the “Type Check Runtimes” and “Type Check Distribution” panels… which

[Wikidata-bugs] [Maniphest] [Commented On] T210260: Stretch in docker registry forces ascii encoding

2018-12-14 Thread hashar
hashar added a comment. $ docker run --rm -it docker-registry.wikimedia.org/wikimedia-stretch:latest # 9086bef6f35b # apt update && apt install python3 ... # locale LANG= LANGUAGE= LC_CTYPE="C.UTF-8" LC_NUMERIC="C.UTF-8" LC_TIME="C.UTF-8" LC_COLLATE="C.UTF-8" LC_MONETARY="C.UTF-8"

[Wikidata-bugs] [Maniphest] [Created] T212019: Whitespace not stripped around sense glosses

2018-12-14 Thread LucasWerkmeister
LucasWerkmeister created this task.LucasWerkmeister added projects: Wikidata, Lexicographical data. TASK DESCRIPTIONI just noticed that when adding glosses for a sense, spaces around the gloss are not removed. I found this surprising, since it’s inconsistent with the behavior for labels,

[Wikidata-bugs] [Maniphest] [Commented On] T196073: Wikidata primary sources tool deployment review

2018-12-14 Thread MaxSem
MaxSem added a comment. Aha, the code is still in a pull request. I've left some comments, but basically this code needs more work. Is the Wikidata team aware of this project?TASK DETAILhttps://phabricator.wikimedia.org/T196073EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T207401: Alignment issue with Glosses

2018-12-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. That screenshot also shows that the language name and gloss text have slightly different baselines :/TASK DETAILhttps://phabricator.wikimedia.org/T207401EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Greta_Doci_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T204697: cloudvps: wikidata-federation project trusty deprecation

2018-12-14 Thread Krenair
Krenair added a comment. Ping. Today is Friday and the deadline is Tuesday.TASK DETAILhttps://phabricator.wikimedia.org/T204697EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszek, KrenairCc: hoo, Krenair, Aklapper, aborrero, Addshore, Ladsgroup,

[Wikidata-bugs] [Maniphest] [Commented On] T208924: PHP Fatal from querypage API: Argument passed to SpecialEntityUsage::__construct must implement EntityIdParser

2018-12-14 Thread gerritbot
gerritbot added a comment. Change 479716 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Clean up QueryPage subclass handling https://gerrit.wikimedia.org/r/479716TASK

[Wikidata-bugs] [Maniphest] [Commented On] T211927: SnakDeserializer must apply ID prefix mapping

2018-12-14 Thread gerritbot
gerritbot added a comment. Change 479604 merged by jenkins-bot: [mediawiki/vendor@master] Update wikibase/data-model-serialization to 2.9.1 https://gerrit.wikimedia.org/r/479604TASK DETAILhttps://phabricator.wikimedia.org/T211927EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T193360: Cantonese Wikipedia mobile app interface cannot edit yue descriptions from Wikidata

2018-12-14 Thread bearND
bearND added a comment. @Tgr Do you know why in Special:ApiSandbox one can only select zh-yue instead of yue in the dropdown for language? I had to change the URL to get it to take yue to try it out.TASK DETAILhttps://phabricator.wikimedia.org/T193360EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T207401: Alignment issue with Glosses

2018-12-14 Thread Michael
Michael added a comment. @Greta_Doci_WMDE @Lydia_Pintscher This is an example where long language names are already breaking the layout: https://www.wikidata.org/wiki/Lexeme:L3338#S1 Setting the width to 100px and removing max-width and min-width as mentioned above, fixes that problem as

[Wikidata-bugs] [Maniphest] [Unassigned] T211749: Invalidate parser cache when Lexeme templates are updated

2018-12-14 Thread Tarrow
Tarrow removed Tarrow as the assignee of this task.Tarrow updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...Obviously we don't want to cause a massive spike in load so we only want to do it for necessary pages. In this case it should only be when the Lexeme frontend pages

[Wikidata-bugs] [Maniphest] [Commented On] T211927: SnakDeserializer must apply ID prefix mapping

2018-12-14 Thread gerritbot
gerritbot added a comment. Change 479605 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Require at least wikibase/data-model-serialization 2.9.1 https://gerrit.wikimedia.org/r/479605TASK DETAILhttps://phabricator.wikimedia.org/T211927EMAIL

[Wikidata-bugs] [Maniphest] [Triaged] T204542: Security review for the Wikidata primary sources tool MediaWiki extension

2018-12-14 Thread sbassett
sbassett triaged this task as "Low" priority. TASK DETAILhttps://phabricator.wikimedia.org/T204542EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: sbassettCc: sbassett, Aklapper, Hjfocs, Nandana, Lahi, Gq86, GoranSMilovanovic, Kiailandi, QZanden, EBjune,

[Wikidata-bugs] [Maniphest] [Commented On] T174031: MCR: Include all slots in XML dumps

2018-12-14 Thread gerritbot
gerritbot added a comment. Change 479711 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler): [mediawiki/core@master] Validate the output of the dump scripts. https://gerrit.wikimedia.org/r/479711TASK DETAILhttps://phabricator.wikimedia.org/T174031EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T174031: MCR: Include all slots in XML dumps

2018-12-14 Thread gerritbot
gerritbot added a comment. Change 479712 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler): [mediawiki/core@master] Make the XML dump schema version configurable. https://gerrit.wikimedia.org/r/479712TASK DETAILhttps://phabricator.wikimedia.org/T174031EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T207401: Alignment issue with Glosses

2018-12-14 Thread Greta_Doci_WMDE
Greta_Doci_WMDE added a comment. In T207401#4823831, @Michael wrote: @Greta_Doci_WMDE @Lydia_Pintscher This is an example where long language names are already breaking the layout: https://www.wikidata.org/wiki/Lexeme:L3338#S1 Yep, this happens in all versions of browsers, not only at the

[Wikidata-bugs] [Maniphest] [Edited] T211120: Create integration/edge-to-edge ensuring blocked users cannot edit Wikibase entities via Special Pages

2018-12-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...#patch-for-review: - [ - [x] [fix some Wikibase special pages](https://gerrit.wikimedia.org/r/478019) - [ - [x] [add tests for Wikibase special pages](https://gerrit.wikimedia.org/r/477825)...TASK

[Wikidata-bugs] [Maniphest] [Commented On] T193360: Cantonese Wikipedia mobile app interface cannot edit yue descriptions from Wikidata

2018-12-14 Thread NHarateh_WMF
NHarateh_WMF added a comment. @JoeWalsh just the language codeTASK DETAILhttps://phabricator.wikimedia.org/T193360EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NHarateh_WMFCc: NHarateh_WMF, Jdforrester-WMF, JMinor, JoeWalsh, Aklapper, ABorbaWMF, cooltey,

[Wikidata-bugs] [Maniphest] [Commented On] T54971: [Goal] Sitelinks and arbitrary accesses to Incubator, OldWikisource and BetaWikiversity

2018-12-14 Thread Amire80
Amire80 added a comment. In T54971#4823687, @Liuxinyu970226 wrote: @Amire80 But some Wikipedias also have reasons (e.g. multi-scripts used, and FWIW #mediawiki-language-converter can't work for at least Min Dong, Hakka, Ladino and (through can work "remotely") Mongolian) and benefits to 1. show

[Wikidata-bugs] [Maniphest] [Commented On] T208924: PHP Fatal from querypage API: Argument passed to SpecialEntityUsage::__construct must implement EntityIdParser

2018-12-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. As far as I can tell, the QueryPage class does at least four things: manage an SQL query with user-configurable offset and limit, and display the list of pages it returns as a special page optionally, cache the results (opt out by overriding isCacheable)

[Wikidata-bugs] [Maniphest] [Edited] T204542: Security review for the Wikidata primary sources tool MediaWiki extension

2018-12-14 Thread sbassett
sbassett updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...* Target date for deployment: N.A. (the related [[https://meta.wikimedia.org/wiki/Grants:IEG/StrepHit:_Wikidata_Statements_Validation_via_References/Renewal/Timeline | project grant]] is over anyway)this code is

[Wikidata-bugs] [Maniphest] [Updated] T110022: Create a library with HTTP related functions/code

2018-12-14 Thread Krinkle
Krinkle added a project: MediaWiki-libs-HTTP. TASK DETAILhttps://phabricator.wikimedia.org/T110022EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KrinkleCc: MGChecker, Imarlier, BPirkle, Nikerabbit, Dereckson, Ladsgroup, Krinkle, PokestarFan, Tgr,

[Wikidata-bugs] [Maniphest] [Commented On] T210901: Stale reads for WDQS Updater

2018-12-14 Thread gerritbot
gerritbot added a comment. Change 479762 merged by jenkins-bot: [wikidata/query/rdf@master] Fix delayed updates https://gerrit.wikimedia.org/r/479762TASK DETAILhttps://phabricator.wikimedia.org/T210901EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:

[Wikidata-bugs] [Maniphest] [Commented On] T193360: Cantonese Wikipedia mobile app interface cannot edit yue descriptions from Wikidata

2018-12-14 Thread Tgr
Tgr added a comment. I see both in the dropdown.TASK DETAILhttps://phabricator.wikimedia.org/T193360EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TgrCc: NHarateh_WMF, Jdforrester-WMF, JMinor, JoeWalsh, Aklapper, ABorbaWMF, cooltey, Dbrant, Hello903hello,

[Wikidata-bugs] [Maniphest] [Commented On] T193360: Cantonese Wikipedia mobile app interface cannot edit yue descriptions from Wikidata

2018-12-14 Thread bearND
bearND added a comment. Oh, you're right. Never mind.TASK DETAILhttps://phabricator.wikimedia.org/T193360EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: bearNDCc: NHarateh_WMF, Jdforrester-WMF, JMinor, JoeWalsh, Aklapper, ABorbaWMF, cooltey, Dbrant,

[Wikidata-bugs] [Maniphest] [Commented On] T207401: Alignment issue with Glosses

2018-12-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Note: if we want to solve this by wrapping the language name (not saying we should, just an option), we could add some indent to the language name to make it clear that the wrapped lines are not new languages: padding-left: 1em; text-indent: -1em;

[Wikidata-bugs] [Maniphest] [Commented On] T209399: Update Wikidata reference tracking

2018-12-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Do we need to do anything to get this change deployed or does it happen automatically?TASK DETAILhttps://phabricator.wikimedia.org/T209399EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Michael,

[Wikidata-bugs] [Maniphest] [Commented On] T209399: Update Wikidata reference tracking

2018-12-14 Thread Michael
Michael added a comment. In T209399#4824419, @Lucas_Werkmeister_WMDE wrote: Do we need to do anything to get this change deployed or does it happen automatically? Yes, we might need to build it and push it to another repo. The description says: Description of T209399 As well as updating the

[Wikidata-bugs] [Maniphest] [Changed Project Column] T209399: Update Wikidata reference tracking

2018-12-14 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE moved this task from Test (Verification) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Lucas_Werkmeister_WMDE added a comment. Sounds good, thanks!TASK

[Wikidata-bugs] [Maniphest] [Commented On] T207401: Alignment issue with Glosses

2018-12-14 Thread Greta_Doci_WMDE
Greta_Doci_WMDE added a comment. More testing: Looks like fixing width will not resolve our problem completely. As seen in the screenshot below, all the other glosses are aligned depending on the longest language name. F27557315: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T207401EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T125976: Run mediawiki::maintenance scripts in Beta Cluster

2018-12-14 Thread MarcoAurelio
MarcoAurelio added a comment. @Dzahn With the patch merged above, I assume that we have now a deployment-mwmaint01 server where to run maintenance scripts. But I assume that maintenance scripts that run in production are not yet running on beta automatically, right?TASK