[Wikidata-bugs] [Maniphest] [Commented On] T233305: delayed kicking in of Bridge

2019-10-16 Thread Michael
Michael added a comment. In T233305#5579153 , @Lucas_Werkmeister_WMDE wrote: > I couldn’t figure out how to make it part of the app module, but extracting the dispatcher into a separate module reduces the size of the init module

[Wikidata-bugs] [Maniphest] [Commented On] T235500: Pywikibot cannot create new property

2019-10-16 Thread DD063520
DD063520 added a comment. Alternatively, is there an option to get the id of the existing Item/Property? TASK DETAIL https://phabricator.wikimedia.org/T235500 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DD063520 Cc: Aklapper, DD063520,

[Wikidata-bugs] [Maniphest] [Commented On] T192452: Find out how many external uses the wbcheckconstraints API action has

2019-10-16 Thread gerritbot
gerritbot added a comment. Change 543470 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Revert "Add HTTP header indicating gadget to API requests"

[Wikidata-bugs] [Maniphest] [Updated] T192452: Find out how many external uses the wbcheckconstraints API action has

2019-10-16 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T192452 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Mvolz, Lucas_Werkmeister_WMDE, Aklapper, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400,

[Wikidata-bugs] [Maniphest] [Commented On] T235622: scrollbar breaks the modal

2019-10-16 Thread Pablo-WMDE
Pablo-WMDE added a comment. "underneath" (on a layer under) vs. "below" (south of)? TASK DETAIL https://phabricator.wikimedia.org/T235622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Aklapper, Charlie_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T128486: [Story] Purge Special:EntityData JSON after edit

2019-10-16 Thread Pablo-WMDE
Pablo-WMDE added a comment. Crazy idea suggested by a pragmatic fellow programmer: why don't we simply use our API if we don't want stale information? TASK DETAIL https://phabricator.wikimedia.org/T128486 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T235500: Pywikibot cannot create new property

2019-10-16 Thread DD063520
DD063520 added a comment. Ok, to give back the error message to the user I propose the following change: if I modify these lines: https://github.com/wikimedia/pywikibot/blob/26deab88936cbf85aa24e1ddfc9b62e81d80a9bb/pywikibot/data/api.py#L2040 to print("result2 ", result)

[Wikidata-bugs] [Maniphest] [Commented On] T233606: Merge dataValues into jquery.valueview

2019-10-16 Thread Rosalie_WMDE
Rosalie_WMDE added a comment. valueParsers.ValueParserStore is defined under node_modules/ it doesn't seem to me like something we should drop or atleast not now? TASK DETAIL https://phabricator.wikimedia.org/T233606 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T235259: Finish merging modules into wikibase.ui.entityViewInit

2019-10-16 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T235259 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Maintenance_bot Cc: Aklapper, Ladsgroup, darthmon_wmde, DannyS712, Nandana, Lahi,

[Wikidata-bugs] [Maniphest] [Commented On] T232468: Illustrate loading

2019-10-16 Thread Michael
Michael added a comment. In T232468#5575133 , @Charlie_WMDE wrote: > @Michael you have a very good point, thank you for voicing it. After talking to the UX-colleagues I think it's the best idea to stick to the 1second rule, but make

[Wikidata-bugs] [Maniphest] [Commented On] T233606: Merge dataValues into jquery.valueview

2019-10-16 Thread Rosalie_WMDE
Rosalie_WMDE added a comment. - ValueParserStore - ExpertStore - UnsupportedValues Cannot be droped now as they are used both in 'wikibase.ui.entityViewInit' and 'jquery.valueview.valueview' TASK DETAIL https://phabricator.wikimedia.org/T233606 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Closed] T235055: Create progressive disabled version of save button

2019-10-16 Thread Michael
Michael closed this task as "Resolved". Michael moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-7 board. TASK DETAIL https://phabricator.wikimedia.org/T235055 WORKBOARD https://phabricator.wikimedia.org/project/board/4316/ EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Unblock] T230342: enable/disable save button depending on Bridge state

2019-10-16 Thread Michael
Michael closed subtask T235055: Create progressive disabled version of save button as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T230342 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Charlie_WMDE, Aklapper, Pablo-WMDE,

[Wikidata-bugs] [Maniphest] [Edited] T232468: Illustrate loading

2019-10-16 Thread Charlie_WMDE
Charlie_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T232468 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Charlie_WMDE Cc: Michael, Lydia_Pintscher, Charlie_WMDE, Aklapper, Pablo-WMDE, darthmon_wmde, DannyS712,

[Wikidata-bugs] [Maniphest] [Edited] T232468: Illustrate loading

2019-10-16 Thread Charlie_WMDE
Charlie_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T232468 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Charlie_WMDE Cc: Michael, Lydia_Pintscher, Charlie_WMDE, Aklapper, Pablo-WMDE, darthmon_wmde, DannyS712,

[Wikidata-bugs] [Maniphest] [Updated] T233790: Untangle datamodel dependency tree

2019-10-16 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T233790 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jakob_WMDE, gerritbot Cc: Ladsgroup, Aklapper, Jakob_WMDE, Hook696, Daryl-TTMG, RomaAmorRoma,

[Wikidata-bugs] [Maniphest] [Updated] T235623: header height too big

2019-10-16 Thread Pablo-WMDE
Pablo-WMDE added a comment. Might by caused by the close button dimensions - T235624: close button size is not correct TASK DETAIL https://phabricator.wikimedia.org/T235623 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T228896: investigate page reload vs. in place replacement after edit

2019-10-16 Thread Pablo-WMDE
Pablo-WMDE added a comment. This is, as I see it, replaced by T235208: Show updated information after saving TASK DETAIL https://phabricator.wikimedia.org/T228896 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T233606: Merge dataValues into jquery.valueview

2019-10-16 Thread gerritbot
gerritbot added a comment. Change 543395 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Drop jquery.valueview.ViewState https://gerrit.wikimedia.org/r/543395 TASK DETAIL https://phabricator.wikimedia.org/T233606 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T235259: Finish merging modules into wikibase.ui.entityViewInit

2019-10-16 Thread gerritbot
gerritbot added a comment. Change 542634 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Merge ToolbarFactory to entityViewInit https://gerrit.wikimedia.org/r/542634 TASK DETAIL https://phabricator.wikimedia.org/T235259 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T233792: Merge dependencies into jquery.view.ViewFactory

2019-10-16 Thread gerritbot
gerritbot added a comment. Change 542986 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Merge EditableTemplatedWidget into ControllerViewFactory, drop entityview https://gerrit.wikimedia.org/r/542986 TASK DETAIL https://phabricator.wikimedia.org/T233792 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T235055: Create progressive disabled version of save button

2019-10-16 Thread gerritbot
gerritbot added a comment. Change 543405 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] bridge: Create progressive disabled version of save button https://gerrit.wikimedia.org/r/543405 TASK DETAIL https://phabricator.wikimedia.org/T235055 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T233792: Merge dependencies into jquery.view.ViewFactory

2019-10-16 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T233792 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Maintenance_bot Cc: Rosalie_WMDE, Aklapper, Ladsgroup, darthmon_wmde, DannyS712,

[Wikidata-bugs] [Maniphest] [Commented On] T235154: show error when editor can't edit the statement because of permission errors on the repository

2019-10-16 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. In MediaWiki core, uneditable pages display two messages: `permissionserrorstext-withaction` , the generic “you can’t edit this”, and then `protectedpagetext`

[Wikidata-bugs] [Maniphest] [Commented On] T235500: Pywikibot cannot create new property

2019-10-16 Thread DD063520
DD063520 added a comment. I suggest to replace this line: https://github.com/wikimedia/pywikibot/blob/26deab88936cbf85aa24e1ddfc9b62e81d80a9bb/pywikibot/data/api.py#L1615 with: messages = None if 'messages' in error: messages = error['messages']

[Wikidata-bugs] [Maniphest] [Commented On] T235622: scrollbar breaks the modal

2019-10-16 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. South of, I assume – that is, only the content excluding the header should be scrollable. TASK DETAIL https://phabricator.wikimedia.org/T235622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Updated] T224013: Implement Shortend version

2019-10-16 Thread alaa_wmde
alaa_wmde edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite. TASK DETAIL https://phabricator.wikimedia.org/T224013 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc: Pintoch, Lea_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T87854: allow showing captchas on Wikibase items and properties

2019-10-16 Thread pdehaye
pdehaye added a comment. If you manage a Wikibase instance and wonder why your users can't enter email addresses or URLs while you can as admin, you have probably hit this bug. TASK DETAIL https://phabricator.wikimedia.org/T87854 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Updated] T235054: Add dirty state getter to store

2019-10-16 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T235054 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE, gerritbot Cc: Lucas_Werkmeister_WMDE, Aklapper, Hook696, Daryl-TTMG,

[Wikidata-bugs] [Maniphest] [Commented On] T235054: Add dirty state getter to store

2019-10-16 Thread gerritbot
gerritbot added a comment. Change 543498 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler): [mediawiki/extensions/Wikibase@master] bridge: Add dirty state getter https://gerrit.wikimedia.org/r/543498 TASK DETAIL https://phabricator.wikimedia.org/T235054

[Wikidata-bugs] [Maniphest] [Commented On] T192452: Find out how many external uses the wbcheckconstraints API action has

2019-10-16 Thread gerritbot
gerritbot added a comment. Change 543470 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Revert "Add HTTP header indicating gadget to API requests" https://gerrit.wikimedia.org/r/543470 TASK DETAIL https://phabricator.wikimedia.org/T192452 EMAIL

[Wikidata-bugs] [Maniphest] [Triaged] T197777: potential issues with planned release of query logs (Wikidata Query Server)

2019-10-16 Thread sbassett
sbassett triaged this task as "Normal" priority. TASK DETAIL https://phabricator.wikimedia.org/T19 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev, sbassett Cc: Krenair, Bawolff, Lydia_Pintscher, APalmer_WMF, Smalyshev, EBjune,

[Wikidata-bugs] [Maniphest] [Commented On] T235110: Constraint results are not cached

2019-10-16 Thread gerritbot
gerritbot added a comment. Change 541847 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Cache suggestion constraint results too https://gerrit.wikimedia.org/r/541847 TASK DETAIL https://phabricator.wikimedia.org/T235110 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Edited] T220696: [Story] Create better edit summaries for wbeditentity API endpoint

2019-10-16 Thread alaa_wmde
alaa_wmde updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T220696 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc: Lea_Lacroix_WMDE, NicoScribe, Rosalie_WMDE, alaa_wmde, Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] [Triaged] T150803: Information leak on wikidata-externalid-url

2019-10-16 Thread sbassett
sbassett triaged this task as "Normal" priority. sbassett removed a project: Cloud-Services. TASK DETAIL https://phabricator.wikimedia.org/T150803 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sbassett Cc: Esc3300, Sjoerddebruin, Multichill,

[Wikidata-bugs] [Maniphest] [Commented On] T235055: Create progressive disabled version of save button

2019-10-16 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Same problem here, I couldn’t get it to work (using `jsub` didn’t help either). For now I’d hope that it’s a temporary problem with Toolforge, and retry later? TASK DETAIL https://phabricator.wikimedia.org/T235055 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Changed Project Column] T235110: Constraint results are not cached

2019-10-16 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Lucas_Werkmeister_WMDE added a comment. Can be verified via Grafana

[Wikidata-bugs] [Maniphest] [Updated] T130856: query.wikidata.org is making requests to http://themes.googleusercontent.com

2019-10-16 Thread sbassett
sbassett removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T130856 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki, sbassett Cc: Gehel, Smalyshev, gerritbot, csteipp, Bovlb, Jonas, Aklapper,

[Wikidata-bugs] [Maniphest] [Updated] T232814: Create controller object

2019-10-16 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T232814 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow, gerritbot Cc: Tarrow, Lydia_Pintscher, Aklapper, Erdinc_Ciftci_WMDE, Jan_Dittrich, noarave,

[Wikidata-bugs] [Maniphest] [Changed Project Column] T224013: Implement Shortend version

2019-10-16 Thread alaa_wmde
alaa_wmde moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. alaa_wmde added a comment. First patch (& first step of isolating summary generation logic) is up for review TASK DETAIL https://phabricator.wikimedia.org/T224013 WORKBOARD

[Wikidata-bugs] [Maniphest] [Commented On] T232814: Create controller object

2019-10-16 Thread gerritbot
gerritbot added a comment. Change 543702 had a related patch set uploaded (by Tarrow; owner: Tarrow): [mediawiki/extensions/Wikibase@master] Introduce HookHandler https://gerrit.wikimedia.org/r/543702 TASK DETAIL https://phabricator.wikimedia.org/T232814 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T174601: Change the language codes of Sakizaya from "ais" (retired by SIL) to "szy" everywhere, and add it to Names.php

2019-10-16 Thread gerritbot
gerritbot added a comment. Change 543679 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit): [translatewiki@master] Add additional tooling for working with repositories https://gerrit.wikimedia.org/r/543679 TASK DETAIL https://phabricator.wikimedia.org/T174601

[Wikidata-bugs] [Maniphest] [Commented On] T224013: Implement Shortend version

2019-10-16 Thread gerritbot
gerritbot added a comment. Change 543701 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan): [mediawiki/extensions/Wikibase@master] Move Summary prepartion into its own helper class https://gerrit.wikimedia.org/r/543701 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T235225: Wikidata: when adding a gloss, the cursor focus does not go to the right field

2019-10-16 Thread Denny
Denny added a comment. In Chrome. But it does not happen on the first gloss (since Remove is grayed out on the first gloss), only on the second and other additional glosses. The part with the "Remove" is kinda OK. I would prefer it would jump to Remove only if I left the gloss field

[Wikidata-bugs] [Maniphest] [Commented On] T235622: scrollbar breaks the modal

2019-10-16 Thread Pablo-WMDE
Pablo-WMDE added a comment. That is my interpretation as well, but @Charlie_WMDE calls the shots. TASK DETAIL https://phabricator.wikimedia.org/T235622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Lucas_Werkmeister_WMDE,

[Wikidata-bugs] [Maniphest] [Updated] T192452: Find out how many external uses the wbcheckconstraints API action has

2019-10-16 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.3; 2019-10-22). TASK DETAIL https://phabricator.wikimedia.org/T192452 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ReleaseTaggerBot Cc: Mvolz, Lucas_Werkmeister_WMDE, Aklapper, Hook696,

[Wikidata-bugs] [Maniphest] [Updated] T235110: Constraint results are not cached

2019-10-16 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.3; 2019-10-22). TASK DETAIL https://phabricator.wikimedia.org/T235110 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot Cc: Aklapper,

[Wikidata-bugs] [Maniphest] [Updated] T235110: Constraint results are not cached

2019-10-16 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T235110 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Maintenance_bot Cc: Aklapper, Lucas_Werkmeister_WMDE, Iflorez,

[Wikidata-bugs] [Maniphest] [Updated] T192452: Find out how many external uses the wbcheckconstraints API action has

2019-10-16 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T192452 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Mvolz, Lucas_Werkmeister_WMDE, Aklapper, darthmon_wmde, DannyS712, Nandana,

[Wikidata-bugs] [Maniphest] [Updated] T124451: Don't make edits if a logged in user gets logged out

2019-10-16 Thread sbassett
sbassett removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T124451 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow, sbassett Cc: gerritbot, Lucas_Werkmeister_WMDE, Addshore, thiemowmde, adrianheine,

[Wikidata-bugs] [Maniphest] [Commented On] T174601: Change the language codes of Sakizaya from "ais" (retired by SIL) to "szy" everywhere, and add it to Names.php

2019-10-16 Thread gerritbot
gerritbot added a comment. Change 543673 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit): [mediawiki/extensions/Translate@master] Add script to rename language codes in repositories https://gerrit.wikimedia.org/r/543673 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Updated] T224013: Implement Shortend version

2019-10-16 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T224013 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Pintoch, Lea_WMDE, Aklapper, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Liuxinyu970226,

[Wikidata-bugs] [Maniphest] [Commented On] T234948: New Wikibase deadlocks on Wikidata wiki since 2019-10-08T00:00:02: Wikibase\Lib\Store\Sql\Terms\{closure} Deadlock found when trying to get lock; tr

2019-10-16 Thread Marostegui
Marostegui added a comment. That link doesn't work for me :( TASK DETAIL https://phabricator.wikimedia.org/T234948 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde, Marostegui Cc: Lydia_Pintscher, alaa_wmde, Jdforrester-WMF, WMDE-leszek,

[Wikidata-bugs] [Maniphest] [Commented On] T234948: New Wikibase deadlocks on Wikidata wiki since 2019-10-08T00:00:02: Wikibase\Lib\Store\Sql\Terms\{closure} Deadlock found when trying to get lock; tr

2019-10-16 Thread alaa_wmde
alaa_wmde added a comment. It seems to have improved the situation a lot since yesterday https://logstash.wikimedia.org/app/kibana#/dashboard/87348b60-90dd-11e8-8687-73968bebd217?_g=h@af6022c&_a=h@d6ea75e There are still few spikes, and it seems that they reach a dead-lock only when so

[Wikidata-bugs] [Maniphest] [Updated] T223452: Restyle "more languages" & "all languages" sections

2019-10-16 Thread alaa_wmde
alaa_wmde added a comment. Created T235605: mobile Termbox should not get narrower than 340px to capture the 340px width limit requirement for later TASK DETAIL https://phabricator.wikimedia.org/T223452 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Created] T235605: Termbox should not get narrower than 340px

2019-10-16 Thread alaa_wmde
alaa_wmde created this task. alaa_wmde added a project: Wikidata-Campsite. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION TASK DETAIL https://phabricator.wikimedia.org/T235605 WORKBOARD

[Wikidata-bugs] [Maniphest] [Retitled] T235605: mobile Termbox should not get narrower than 340px

2019-10-16 Thread alaa_wmde
alaa_wmde renamed this task from "Termbox should not get narrower than 340px" to "mobile Termbox should not get narrower than 340px". TASK DETAIL https://phabricator.wikimedia.org/T235605 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc:

[Wikidata-bugs] [Maniphest] [Commented On] T223452: Restyle "more languages" & "all languages" sections

2019-10-16 Thread gerritbot
gerritbot added a comment. Change 542118 **merged** by jenkins-bot: [wikibase/termbox@master] Add vertical paddings (spacing) between term lists and toggle buttons https://gerrit.wikimedia.org/r/542118 TASK DETAIL https://phabricator.wikimedia.org/T223452 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T223452: Restyle "more languages" & "all languages" sections

2019-10-16 Thread gerritbot
gerritbot added a comment. Change 542068 **merged** by jenkins-bot: [wikibase/termbox@master] Apply white background to input fields in edit mode https://gerrit.wikimedia.org/r/542068 TASK DETAIL https://phabricator.wikimedia.org/T223452 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T233606: Merge dataValues into jquery.valueview

2019-10-16 Thread gerritbot
gerritbot added a comment. Change 543141 **merged** by jenkins-bot: [data-values/value-view@master] Drop jquery.valueview.ViewState https://gerrit.wikimedia.org/r/543141 TASK DETAIL https://phabricator.wikimedia.org/T233606 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Claimed] T235052: Save original revision data in store

2019-10-16 Thread Matthias_Geisler_WMDE
Matthias_Geisler_WMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T235052 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Matthias_Geisler_WMDE Cc: Aklapper, Lucas_Werkmeister_WMDE, darthmon_wmde, Michael, DannyS712, Nandana,

[Wikidata-bugs] [Maniphest] [Claimed] T234948: New Wikibase deadlocks on Wikidata wiki since 2019-10-08T00:00:02: Wikibase\Lib\Store\Sql\Terms\{closure} Deadlock found when trying to get lock; try res

2019-10-16 Thread Ladsgroup
Ladsgroup claimed this task. Ladsgroup added a comment. Restricted Application added a project: User-Ladsgroup. After the puppet patch, this is clean and nice, 134 cases in the last 24 hours only. I suggest we call this done @Marostegui TASK DETAIL https://phabricator.wikimedia.org/T234948

[Wikidata-bugs] [Maniphest] [Commented On] T233606: Merge dataValues into jquery.valueview

2019-10-16 Thread gerritbot
gerritbot added a comment. Change 543395 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)): [mediawiki/extensions/Wikibase@master] Drop jquery.valueview.ViewState https://gerrit.wikimedia.org/r/543395 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T235055: Create progressive disabled version of save button

2019-10-16 Thread Michael
Michael added a comment. While working on this ticket a bug in @vue/test-utils was noticed and reported: https://github.com/vuejs/vue-test-utils/issues/1321 This bug could lead to falsely green tickets. TASK DETAIL https://phabricator.wikimedia.org/T235055 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Closed] T235533: WDCM External Identifiers Dashboard is down

2019-10-16 Thread GoranSMilovanovic
GoranSMilovanovic closed this task as "Resolved". GoranSMilovanovic added a subscriber: Lea_Lacroix_WMDE. GoranSMilovanovic added a comment. Hi @Envlh @Lea_Lacroix_WMDE and thank you for pointing out this to me. The Wikidata External Identifiers

[Wikidata-bugs] [Maniphest] [Created] T235624: close button size is not correct

2019-10-16 Thread Charlie_WMDE
Charlie_WMDE created this task. Charlie_WMDE added a project: Wikidata-Bridge. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Steps to Reproduce: open bridge in beta Actual Results: the button size is 48x48px

[Wikidata-bugs] [Maniphest] [Commented On] T192987: wdqs-frontend BRAND_TITLE env var doesn't appear to work

2019-10-16 Thread Maxlath
Maxlath added a comment. this is likely to be due to the `custom-config.json` file not being properly fetched from the client: it works when building the image from the current `master`, instead of relying on `wikibase/wdqs-frontend:latest` image (it could be that it now also works on

[Wikidata-bugs] [Maniphest] [Claimed] T232814: Create controller object

2019-10-16 Thread Tarrow
Tarrow claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T232814 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Tarrow, Lydia_Pintscher, Aklapper, Erdinc_Ciftci_WMDE, Jan_Dittrich, noarave, darthmon_wmde, DannyS712,

[Wikidata-bugs] [Maniphest] [Commented On] T229241: restrict length of string value input

2019-10-16 Thread Pablo-WMDE
Pablo-WMDE added a comment. This can now be observed on beta . F30760549: Bildschirmfoto von 2019-10-16 11-49-45.png TASK DETAIL https://phabricator.wikimedia.org/T229241 EMAIL

[Wikidata-bugs] [Maniphest] [Closed] T235192: Bump up Termbox Cache version

2019-10-16 Thread alaa_wmde
alaa_wmde closed this task as "Resolved". alaa_wmde moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. alaa_wmde claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T235192 WORKBOARD

[Wikidata-bugs] [Maniphest] [Updated] T223452: Restyle "more languages" & "all languages" sections

2019-10-16 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T223452 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde, Maintenance_bot Cc: Jakob_WMDE, WMDE-leszek, raja_wmde, Aklapper,

[Wikidata-bugs] [Maniphest] [Commented On] T234948: New Wikibase deadlocks on Wikidata wiki since 2019-10-08T00:00:02: Wikibase\Lib\Store\Sql\Terms\{closure} Deadlock found when trying to get lock; tr

2019-10-16 Thread alaa_wmde
alaa_wmde added a comment. So we checked in new store what terms exist on some of the items that had failing inserts due the dead-locks. None of them, except one, has terms stored on them. Meaning the transactions were not repeated later, and we don't know whether they will fail again.

[Wikidata-bugs] [Maniphest] [Commented On] T234948: New Wikibase deadlocks on Wikidata wiki since 2019-10-08T00:00:02: Wikibase\Lib\Store\Sql\Terms\{closure} Deadlock found when trying to get lock; tr

2019-10-16 Thread alaa_wmde
alaa_wmde added a comment. @Ladsgroup is rebuild script close to Q40m? I'm thinking of: 1. we lowering write both to Q40m, 2. stop rebuild script shortly before it reaches Q40m and 3. investigate what is going on here. But if rebuild script still not that close, we can investigate a bit

[Wikidata-bugs] [Maniphest] [Created] T235622: scrollbar breaks the modal

2019-10-16 Thread Charlie_WMDE
Charlie_WMDE created this task. Charlie_WMDE added a project: Wikidata-Bridge. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Steps to Reproduce: open the bridge in beta, minimize the height of the window to force the

[Wikidata-bugs] [Maniphest] [Commented On] T229241: restrict length of string value input

2019-10-16 Thread Charlie_WMDE
Charlie_WMDE added a comment. length restriction looks good from my side \o/ there are some other issues though that i filed separate bug reports for TASK DETAIL https://phabricator.wikimedia.org/T229241 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Closed] T234094: Wikidata "Duplicate references" gadget hangs on saving copied reference

2019-10-16 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T234094 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Lucas_Werkmeister_WMDE Cc: Jakob_WMDE, Laddo, Lea_Lacroix_WMDE, Spinster,

[Wikidata-bugs] [Maniphest] [Commented On] T234948: New Wikibase deadlocks on Wikidata wiki since 2019-10-08T00:00:02: Wikibase\Lib\Store\Sql\Terms\{closure} Deadlock found when trying to get lock; tr

2019-10-16 Thread Marostegui
Marostegui added a comment. That's indeed not ideal (the fact that the transaction isn't retried), and probably merits some investigation and some potential mitigation methods as deadlocks can happen anytime (ideally not often, but are a possibility with high concurrency environments).

[Wikidata-bugs] [Maniphest] [Created] T235623: header hight too big

2019-10-16 Thread Charlie_WMDE
Charlie_WMDE created this task. Charlie_WMDE added a project: Wikidata-Bridge. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Steps to Reproduce: open bridge in beta Actual Results: the header (including buttons)

[Wikidata-bugs] [Maniphest] [Commented On] T233305: delayed kicking in of Bridge

2019-10-16 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. I couldn’t figure out how to make it part of the app module, but extracting the dispatcher into a separate module reduces the size of the init module substantially: diff --git a/client/data-bridge/package.json b/client/data-bridge/package.json

[Wikidata-bugs] [Maniphest] [Retitled] T235623: header height too big

2019-10-16 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE renamed this task from "header hight too big" to "header height too big". TASK DETAIL https://phabricator.wikimedia.org/T235623 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Charlie_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T228412: Deploy Citoid Wikibase integration to Test Wikidata

2019-10-16 Thread gerritbot
gerritbot added a comment. Change 543145 **merged** by jenkins-bot: [operations/mediawiki-config@master] Configure Citoid+Wikibase integration on Test Wikidata https://gerrit.wikimedia.org/r/543145 TASK DETAIL https://phabricator.wikimedia.org/T228412 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Unblock] T228414: Deploy Citoid Wikibase integration

2019-10-16 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed subtask T228412: Deploy Citoid Wikibase integration to Test Wikidata as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T228414 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc:

[Wikidata-bugs] [Maniphest] [Commented On] T235540: SPARQL query causes StackOverflowError and fails to execute

2019-10-16 Thread Evilricepuddin
Evilricepuddin added a comment. Thanks for the workaround, can confirm that the query is working again for me now :) TASK DETAIL https://phabricator.wikimedia.org/T235540 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Evilricepuddin Cc:

[Wikidata-bugs] [Maniphest] [Commented On] T234948: New Wikibase deadlocks on Wikidata wiki since 2019-10-08T00:00:02: Wikibase\Lib\Store\Sql\Terms\{closure} Deadlock found when trying to get lock; tr

2019-10-16 Thread alaa_wmde
alaa_wmde added a comment. In T234948#5579417 , @Ladsgroup wrote: > It's on Q23Mio. Even though the script fails, it logs all of them in mwmaint node, I can get list of all of them and fix them via a script (python to do purge,

[Wikidata-bugs] [Maniphest] [Commented On] T235540: SPARQL query causes StackOverflowError and fails to execute

2019-10-16 Thread Stashbot
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2019-10-16T12:26:56Z] Started deploy [wdqs/wdqs@217cac5]: redeploy 0.3.4-SNAPSHOT - T235540 TASK DETAIL https://phabricator.wikimedia.org/T235540 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T174601: Change the language codes of Sakizaya from "ais" (retired by SIL) to "szy" everywhere, and add it to Names.php

2019-10-16 Thread jhsoby
jhsoby added a comment. I was chatting with @Nikerabbit and @Raymond about this yesterday in `#mediawiki-i18n`. My proposed action plan in order to move this language from `ais` to `szy` is as follows: 1. Disable translations into `ais`. 2. Enable translation into `szy`. 3. Move

[Wikidata-bugs] [Maniphest] [Commented On] T174601: Change the language codes of Sakizaya from "ais" (retired by SIL) to "szy" everywhere, and add it to Names.php

2019-10-16 Thread gerritbot
gerritbot added a comment. Change 543453 had a related patch set uploaded (by Jon Harald Søby; owner: Jon Harald Søby): [translatewiki@master] Disable language code ais and enable szy https://gerrit.wikimedia.org/r/543453 TASK DETAIL https://phabricator.wikimedia.org/T174601 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T174601: Change the language codes of Sakizaya from "ais" (retired by SIL) to "szy" everywhere, and add it to Names.php

2019-10-16 Thread jhsoby
jhsoby added a comment. In T174601#5579618 , @Nikerabbit wrote: > I don't like the idea of "figure out later". It just piles more unplanned work on us (or worse, mess is left behind). Let's make a proper plan and get it resourced.

[Wikidata-bugs] [Maniphest] [Created] T235643: [Epic] Provide a Proof of Concept SPARQL endpoint in support of SDoC project

2019-10-16 Thread Gehel
Gehel created this task. Gehel added projects: Wikidata-Query-Service, Discovery-Wikidata-Query-Service-Sprint, Epic. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION This is an umbrella task for the steps that need to

[Wikidata-bugs] [Maniphest] [Edited] T235622: scrollbar breaks the modal

2019-10-16 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T235622 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Charlie_WMDE, darthmon_wmde, Michael, DannyS712, Nandana,

[Wikidata-bugs] [Maniphest] [Commented On] T228412: Deploy Citoid Wikibase integration to Test Wikidata

2019-10-16 Thread Stashbot
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2019-10-16T11:16:23Z] Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:543145|Configure Citoid+Wikibase integration on Test Wikidata (T228412 )]] (duration: 01m

[Wikidata-bugs] [Maniphest] [Updated] T235055: Create progressive disabled version of save button

2019-10-16 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T235055 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, gerritbot Cc: Lucas_Werkmeister_WMDE, Aklapper, Hook696, Daryl-TTMG, RomaAmorRoma,

[Wikidata-bugs] [Maniphest] [Commented On] T235055: Create progressive disabled version of save button

2019-10-16 Thread gerritbot
gerritbot added a comment. Change 543405 had a related patch set uploaded (by Michael Große; owner: Michael Große): [mediawiki/extensions/Wikibase@master] bridge: Create progressive disabled version of save button https://gerrit.wikimedia.org/r/543405 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Edited] T235540: SPARQL query causes StackOverflowError and fails to execute

2019-10-16 Thread Evilricepuddin
Evilricepuddin updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T235540 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Evilricepuddin Cc: Smalyshev, Lucas_Werkmeister_WMDE, Igorkim78, Aklapper, Evilricepuddin,

[Wikidata-bugs] [Maniphest] [Commented On] T235540: SPARQL query causes StackOverflowError and fails to execute

2019-10-16 Thread Stashbot
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2019-10-16T11:56:26Z] Started deploy [wdqs/wdqs@c90503b]: Revert to fix T235540 TASK DETAIL https://phabricator.wikimedia.org/T235540 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T235540: SPARQL query causes StackOverflowError and fails to execute

2019-10-16 Thread Mathew.onipe
Mathew.onipe added a comment. @Evilricepuddin We are currently deploying a revert. So you can keep your old query. TASK DETAIL https://phabricator.wikimedia.org/T235540 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mathew.onipe Cc:

[Wikidata-bugs] [Maniphest] [Commented On] T235625: Get list of gadgets that depend on wikibase production frontend code

2019-10-16 Thread Ladsgroup
Ladsgroup added a comment. Okay I downloaded all of them and looked through any use of wikibase or wb. These depend on our wikibase hooks. **Nothing is going to break for them**: MediaWiki:Gadget-DuplicateReferences.js:mw.hook( 'wikibase.entityPage.entityLoaded' ).add(

[Wikidata-bugs] [Maniphest] [Commented On] T174601: Change the language codes of Sakizaya from "ais" (retired by SIL) to "szy" everywhere, and add it to Names.php

2019-10-16 Thread gerritbot
gerritbot added a comment. Change 543410 had a related patch set uploaded (by Jon Harald Søby; owner: Jon Harald Søby): [mediawiki/core@master] Add [szy] Sakizaya to Names.php https://gerrit.wikimedia.org/r/543410 TASK DETAIL https://phabricator.wikimedia.org/T174601 EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T174601: Change the language codes of Sakizaya from "ais" (retired by SIL) to "szy" everywhere, and add it to Names.php

2019-10-16 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T174601 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: abi_, Vickylin77amis, Pasleim, Addshore, daniel, Liuxinyu970226, Htchien, Reke,

[Wikidata-bugs] [Maniphest] [Changed Project Column] T223452: Restyle "more languages" & "all languages" sections

2019-10-16 Thread alaa_wmde
alaa_wmde moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. alaa_wmde added a comment. @Hanna_Petruschat_WMDE background and vertical spacing fixes can be tested on beta now TASK DETAIL

  1   2   >