[Wikidata-bugs] [Maniphest] T289332: Importing a Wikibase entity via XML breaks creating new entites

2021-08-22 Thread CtrlZvi
CtrlZvi added a project: MediaWiki-extensions-WikibaseRepository. TASK DETAIL https://phabricator.wikimedia.org/T289332 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: CtrlZvi Cc: CtrlZvi, Aklapper, Biggs657, Lalamarie69, Juan90264, Alter-paule

[Wikidata-bugs] [Maniphest] T289838: Wikibase Geographic coordinate changes may not propagate to GeoData database table

2021-08-27 Thread CtrlZvi
CtrlZvi created this task. CtrlZvi added projects: GeoData, MediaWiki-Core-JobQueue, Wikibase (3rd party installations), MediaWiki-extensions-WikibaseClient. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Discovery-Search. TASK DESCRIPTION **List

[Wikidata-bugs] [Maniphest] T289838: Wikibase Geographic coordinate changes may not propagate to GeoData database table

2021-08-27 Thread CtrlZvi
CtrlZvi updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T289838 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: CtrlZvi Cc: Aklapper, CtrlZvi, MPhamWMF, CBogen, Akuckartz, darthmon_wmde, lucamauri, EBjune, Wikidata-bugs

[Wikidata-bugs] [Maniphest] T155926: Use OSM/Wikidata data for Special:Nearby

2021-08-27 Thread CtrlZvi
Restricted Application added a project: Discovery-Search. TASK DETAIL https://phabricator.wikimedia.org/T155926 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: CtrlZvi Cc: CtrlZvi, mxn, PokestarFan, JJMC89, Jc86035, Aklapper, Invadibot, MPhamWMF

[Wikidata-bugs] [Maniphest] T114092: Add tests for GeoData hooks handling

2021-08-27 Thread CtrlZvi
Restricted Application added a project: Discovery-Search. TASK DETAIL https://phabricator.wikimedia.org/T114092 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: CtrlZvi Cc: CtrlZvi, PokestarFan, aude, Aklapper, Invadibot, MPhamWMF, maantietaja

[Wikidata-bugs] [Maniphest] T289838: Wikibase Geographic coordinate changes may not propagate to GeoData database table

2021-08-28 Thread CtrlZvi
CtrlZvi updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T289838 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: CtrlZvi Cc: Aklapper, CtrlZvi, Invadibot, MPhamWMF, maantietaja, CBogen, Akuckartz, darthmon_wmde, Nandana

[Wikidata-bugs] [Maniphest] T303099: Changes from all revisions have metadata overridden with data from the first change.

2022-03-07 Thread CtrlZvi
CtrlZvi added a comment. Sure. I have a personal wiki I'm running (currently MW 1.37.1) with some custom extensions. One of these extensions is one I'm developing that will automatically geocode an address (stored in a property on an item) and store the resulting coordinates

[Wikidata-bugs] [Maniphest] T278510: Make SqlChangeDispatchCoordinator more db-agnostic

2022-03-08 Thread CtrlZvi
CtrlZvi added a comment. I have a local change that removes the CAST in favor of more portable syntax, but it does not solve the table prefix issue. I haven't had time to look into replacing this with something truly portable yet. Would the CAST removal be potentially welcome

[Wikidata-bugs] [Maniphest] T278511: Make Postgres tests a voting CI job in gate-submit

2022-08-23 Thread CtrlZvi
CtrlZvi added a comment. GeoData was not fixed with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GeoData/+/805460. While support was added in the schema, GeoData has a bug preventing insertion of data into the geo_tags table. TASK DETAIL https://phabricator.wikimedia.org/T278511

[Wikidata-bugs] [Maniphest] T316487: Wikibase cannot save properties on SQLite with PHP 8.1

2022-08-29 Thread CtrlZvi
CtrlZvi added a comment. I agree 100% with using the not being coupled to strings and using the native integer types. It seems like a positive change for a whole host of reasons. But that's a much larger change in a system I don't have experience in, and my experiments with trying

[Wikidata-bugs] [Maniphest] T316487: Wikibase cannot save properties on SQLite with PHP 8.1

2022-08-29 Thread CtrlZvi
CtrlZvi added a comment. I wonder if there's benefit in migrating the MySQL and PostgreSQL implementations to PDO? That would probably resolve the issue where they return strings and unify behavior. I suspect it might be at the expense of performance, though? TASK DETAIL https

[Wikidata-bugs] [Maniphest] T316487: Wikibase cannot save properties on SQLite with PHP 8.1

2022-08-28 Thread CtrlZvi
CtrlZvi added a comment. Digging a bit more, the type mismatch comes from loading the wbt_type table into the cache using the NameTableStore::loadTable() function. This function stores the returned values into an associative array by their key, and although PostgreSQL, MySQL, and SQLite

[Wikidata-bugs] [Maniphest] T316487: Wikibase cannot save properties on SQLite with PHP 8.1

2022-08-28 Thread CtrlZvi
CtrlZvi added a project: MediaWiki-libs-Rdbms. CtrlZvi added a comment. Restricted Application added a project: Performance-Team. Although discovered with Wikibase, this is not actually a Wikibase issue. PHP 8.1 introduces a breaking change into the SqliteResultWrapper. Leaving the Wikibase

[Wikidata-bugs] [Maniphest] T233520: Wikidata changes do not get sent to client sites on initial sitelink addition (in some cases), leading to things such as missing page props in page_props table

2022-09-25 Thread CtrlZvi
CtrlZvi closed this task as "Resolved". CtrlZvi added a comment. Upon even more digging, my issue was similar, but actually subtly different. I've opened a separate issue (T318501 <https://phabricator.wikimedia.org/T318501>) for it. TASK DETAIL https://phabricator.wikim

[Wikidata-bugs] [Maniphest] T233520: Wikidata changes do not get sent to client sites on initial sitelink addition (in some cases), leading to things such as missing page props in page_props table

2022-09-23 Thread CtrlZvi
CtrlZvi reopened this task as "Open". CtrlZvi added a comment. Reopening because after digging further, I'm more convinced that my above analysis is correct. tl;dr: There is a race condition between change dispatch and subscription creation that used to be resolvable via manua

[Wikidata-bugs] [Maniphest] T233520: Wikidata changes do not get sent to client sites on initial sitelink addition (in some cases), leading to things such as missing page props in page_props table

2022-09-23 Thread CtrlZvi
CtrlZvi added a comment. @Michael I am running Wikibase REL1_38 (from source, commit 33c2c9226c <https://phabricator.wikimedia.org/rEWBA33c2c9226c0866f1fecfec5ba97a636c6d217cd0>) and am still seeing what I believe is this issue. TASK DETAIL https://phabricator.wikimedia.org/T233520

[Wikidata-bugs] [Maniphest] T233520: Wikidata changes do not get sent to client sites on initial sitelink addition (in some cases), leading to things such as missing page props in page_props table

2022-09-23 Thread CtrlZvi
CtrlZvi added a comment. For more information, I think I'm encountering a race condition between making changes, the recent changes process, and refreshing links. If the recent change is processed before the refreshLinks job runs, then there is no new recent change processing to trigger