[Wikidata-bugs] [Maniphest] [Commented On] T125522: Show preview when entering value for math data type

2016-02-04 Thread Esanders
Esanders added a comment. The VE dialogs weren't designed to be separated from VE, so with all the dependencies it might end up being a bit heavy weight unless VE was already loaded. If you want lightweight you could probably make a simple preview gadget using Mathoid. TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Commented On] T141394: Add a "search location" box in the map dialog (VE edit)

2016-07-31 Thread Esanders
Esanders added a comment. It looks like wbgetclaims only lets us get one set of coordinates at a time, so we wouldn't be able to filter results based on things that have coordinates without doing a query for each search suggestion.TASK DETAILhttps://phabricator.wikimedia.org/T141394EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T165600: Template to ping everybody who participated in a discussion

2017-05-17 Thread Esanders
Esanders added a comment. What's the relation to VisualEditor?TASK DETAILhttps://phabricator.wikimedia.org/T165600EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: EsandersCc: Esanders, Aklapper, ChristianKl, Robinma, GoranSMilovanovic, QZanden, merbst, Wess

[Wikidata-bugs] [Maniphest] [Updated] T186308: "Your skin is incompatible with VisualEditor" in Wikidata

2018-02-02 Thread Esanders
Esanders added a comment. This appears on all wikidata item pages: https://www.wikidata.org/wiki/Q45554042 This is similar to T186174. VE is attempting to register itself because wgIsArticle is true, but then stops because the page doesn't have the correct UI components for article editing

[Wikidata-bugs] [Maniphest] [Commented On] T200693: Test failure in WikibaseLexeme selenium tests block merging patches to ContentTranslation

2018-08-04 Thread Esanders
Esanders added a comment. Is there a plan B here? Having a WMF project blocked on CI for over a week is not good. Can we disable these tests in CX until the issue is resolved?TASK DETAILhttps://phabricator.wikimedia.org/T200693EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Commented On] T200693: Test failure in WikibaseLexeme selenium tests block merging patches to ContentTranslation

2018-08-06 Thread Esanders
Esanders added a comment. Thanks everyone for getting this fixed! In T200693#4480095, @WMDE-leszek wrote: Is there some general practice/guidelines here that could be applied? I am especially thinking of a case when (especially unexpected) test failures of extension X cause CI jobs for Y, Z or H

[Wikidata-bugs] [Maniphest] [Commented On] T201928: Editing welcome dialog pops up on Wikibase entity undo page on the very first edit a user tries to make

2018-08-23 Thread Esanders
Esanders added a comment. Ping @DeskanaTASK DETAILhttps://phabricator.wikimedia.org/T201928EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: EsandersCc: Jdforrester-WMF, Addshore, Deskana, Pablo-WMDE, Esanders, Aklapper, Jakob_WMDE, iamjessklein, marcella, Lahi

[Wikidata-bugs] [Maniphest] [Commented On] T201928: Editing welcome dialog pops up on Wikibase entity undo page on the very first edit a user tries to make

2018-08-23 Thread Esanders
Esanders added a comment. I think that might be fairly simple: we could add a check to make sure the page at least has #wpTextbox1 textarea on it, assuming it isn't just hidden with CSS?TASK DETAILhttps://phabricator.wikimedia.org/T201928EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings

[Wikidata-bugs] [Maniphest] [Commented On] T201928: Editing welcome dialog pops up on Wikibase entity undo page on the very first edit a user tries to make

2018-08-23 Thread Esanders
Esanders added a comment. Just had a poke around - it's not completely trivial, but not impossible.TASK DETAILhttps://phabricator.wikimedia.org/T201928EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: EsandersCc: Jdforrester-WMF, Addshore, Deskana, Pablo-WMDE

[Wikidata-bugs] [Maniphest] [Claimed] T201928: Editing welcome dialog pops up on Wikibase entity undo page on the very first edit a user tries to make

2018-08-23 Thread Esanders
Esanders claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T201928EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: EsandersCc: Jdforrester-WMF, Addshore, Deskana, Pablo-WMDE, Esanders, Aklapper, Jakob_WMDE, iamjessklein, stebsco, marcella, Lahi

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T201928: VisualEditor welcome dialog pops up on Wikibase entity undo page

2018-08-22 Thread Esanders
Esanders added a subscriber: Jdforrester-WMF.Esanders added a comment. This is the "Welcome to editing" dialog - it's not a VE welcome dialog. It was a product decision to show this in both VE and wikitext editors. It may be possible to disable it on a per site basis. @Jdforrester-WMF ma

[Wikidata-bugs] [Maniphest] [Updated] T208139: Georgian words are automatically (incorrectly) capitalized when entered

2019-03-27 Thread Esanders
Esanders added a comment. See also T141723 <https://phabricator.wikimedia.org/T141723> and T219279 <https://phabricator.wikimedia.org/T219279> TASK DETAIL https://phabricator.wikimedia.org/T208139 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emai

[Wikidata-bugs] [Maniphest] [Commented On] T222707: switch eslint to require dangling comma with "always-multiline"

2019-05-08 Thread Esanders
Esanders added a comment. Object literal trailing comma support was only added to IE in version 9. IE8 support was only dropped a few years ago. We also need to support IE8 in the resource loader init file, which is currently enforceable just by setting the environment to ES3, so this would

[Wikidata-bugs] [Maniphest] [Commented On] T208139: Georgian words are automatically (incorrectly) capitalized when entered

2019-04-10 Thread Esanders
Esanders added a comment. The plan in T219279 <https://phabricator.wikimedia.org/T219279> is write a compatibility mapping for PHP7 to behave like PHP5. We could add per-language exceptions to that list as well, which would trigger updates to mw.Title.js as that has a maintenance

[Wikidata-bugs] [Maniphest] T264382: Review Wikidata error dashboard. Create/adjust phabricator ticket priorities

2020-10-07 Thread Esanders
Esanders added a comment. `TypeError: OO.ui is undefined` is often being thrown by https://www.wikidata.org/w/index.php?title=MediaWiki:Gadget-Merge.js, which is strange because https://www.wikidata.org/wiki/MediaWiki:Gadgets-definition correctly adds a dependency on oojs-ui-windows. I

[Wikidata-bugs] [Maniphest] T264382: Review Wikidata error dashboard. Create/adjust phabricator ticket priorities

2020-10-07 Thread Esanders
Esanders added a comment. `TypeError: context is undefined` is T105637 <https://phabricator.wikimedia.org/T105637>, which I've also fixed. TASK DETAIL https://phabricator.wikimedia.org/T264382 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailprefe

[Wikidata-bugs] [Maniphest] T264382: Review Wikidata error dashboard. Create/adjust phabricator ticket priorities

2020-10-08 Thread Esanders
Esanders added subscribers: Catrope, Krinkle. Esanders added a comment. In T264382#6525610 <https://phabricator.wikimedia.org/T264382#6525610>, @Michael wrote: > It hasn't happened for some hours now. Maybe you got all of them? > F32376991: image.png <https://phabricato

[Wikidata-bugs] [Maniphest] T265131: Kibana: Sort normalized messages by how many users they affect

2020-10-09 Thread Esanders
Esanders added a comment. I've added this table to the dashboard: F32379523: image.png <https://phabricator.wikimedia.org/F32379523> TASK DETAIL https://phabricator.wikimedia.org/T265131 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Es

[Wikidata-bugs] [Maniphest] T265131: Kibana: Sort normalized messages by how many users they affect

2020-10-09 Thread Esanders
Esanders added a comment. Arguably this is a better metric than error volume in most scenarios. Maybe we can use the unique IP count by default, e.g. for the graph across the top. TASK DETAIL https://phabricator.wikimedia.org/T265131 EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] T265131: Kibana: Sort normalized messages by how many users they affect

2020-10-09 Thread Esanders
Esanders added a comment. This should be possible with the unique count feature TASK DETAIL https://phabricator.wikimedia.org/T265131 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Esanders Cc: Esanders, Aklapper, Michael, Akuckartz

[Wikidata-bugs] [Maniphest] T264382: Review Wikidata error dashboard, fix gadgets and create/adjust phabricator ticket priorities

2020-10-05 Thread Esanders
Esanders added a comment. This was generating 1,000/day: https://www.wikidata.org/w/index.php?title=User:Ch1902/ancestry.js=prev=1287017332 TASK DETAIL https://phabricator.wikimedia.org/T264382 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] T264382: Review Wikidata error dashboard, fix gadgets and create/adjust phabricator ticket priorities

2020-10-05 Thread Esanders
Esanders added a comment. See also T105637 <https://phabricator.wikimedia.org/T105637> TASK DETAIL https://phabricator.wikimedia.org/T264382 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Esanders Cc: Lucas_Werkmeister_WMDE, WMDE-

[Wikidata-bugs] [Maniphest] T278522: Grammatical features field is now right-aligned

2021-04-16 Thread Esanders
Esanders added a comment. I'd rather fix this downstream. The upstream behaviour is correct and not broken. TASK DETAIL https://phabricator.wikimedia.org/T278522 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Esanders Cc: Tchanders

[Wikidata-bugs] [Maniphest] T278522: Grammatical features field is now right-aligned

2021-04-16 Thread Esanders
Esanders added a comment. This looks wrong: name=GrammaticalFeatureListWidget.js /** * @protected */ onChangeTags: function () { this.updateInputPlaceHolder(); }, There is no call to the parent method. TASK DETAIL https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] T213426: Deprecate jquery.throttle-debounce in favour of mw.util.debounce or OO.ui.debounce/throttle

2022-02-04 Thread Esanders
Esanders added a comment. It would've been nice to use the same function signature as OOUI, now we have OO.ui.debounce( callback, wait [, immediate] ); //and mw.util.debounce( wait, callback ); (ContentTranslation's utils also uses `callback, wait, immedate` as ported from

[Wikidata-bugs] [Maniphest] T213426: Deprecate jquery.throttle-debounce in favour of (mw.util|OO.ui).debounce/throttle

2022-02-08 Thread Esanders
Esanders renamed this task from "Deprecate jquery.throttle-debounce in favour of mw.util.debounce or OO.ui.debounce/throttle" to "Deprecate jquery.throttle-debounce in favour of (mw.util|OO.ui).debounce/throttle". TASK DETAIL https://phabricator.wikimedia.org/T21342

[Wikidata-bugs] [Maniphest] T350777: 1.42.0-wmf.4: Structured Data on Wikimedia Commons not longer available

2023-11-08 Thread Esanders
Esanders added a comment. In T350777#9316258 <https://phabricator.wikimedia.org/T350777#9316258>, @jnuche wrote: > The only recent change to the extension that went in wmf.4 is: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/971246 > &g

[Wikidata-bugs] [Maniphest] T243382: Embedded map does not display in IE11

2023-04-17 Thread Esanders
Esanders closed this task as "Invalid". Esanders added a comment. IE11 is no longer supported. TASK DETAIL https://phabricator.wikimedia.org/T243382 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Esanders Cc: Esand

[Wikidata-bugs] [Maniphest] T299337: wikit-Dialog component presents visual issues on IE11

2023-04-17 Thread Esanders
Esanders closed this task as "Invalid". Esanders added a comment. IE11 is no longer supported. TASK DETAIL https://phabricator.wikimedia.org/T299337 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Esanders Cc: Esanders, TheDJ, Aklap

[Wikidata-bugs] [Maniphest] T243382: Embedded map does not display in IE11

2023-04-17 Thread Esanders
Esanders added a comment. In T243382#8786397 <https://phabricator.wikimedia.org/T243382#8786397>, @Lucas_Werkmeister_WMDE wrote: > In T243382#8786354 <https://phabricator.wikimedia.org/T243382#8786354>, @Esanders wrote: > >> IE11 is no longer supported

[Wikidata-bugs] [Maniphest] T352526: Enable visual editor in the property talk namespace on Wikidata

2023-12-01 Thread Esanders
Esanders added a comment. We generally don't enable VE on talk namespaces, as it doesn't support indented discussion threads well. One can still add `?veaction=edit` to the URL to force the visual editor to load. TASK DETAIL https://phabricator.wikimedia.org/T352526 EMAIL PREFERENCES