[Wikidata-bugs] [Maniphest] [Created] T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null)

2019-07-29 Thread brennen
brennen created this task. brennen added projects: Wikimedia-production-error, Wikibase-DataModel-Services, Wikibase-DataModel. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Error - Request URL: https

[Wikidata-bugs] [Maniphest] [Commented On] T229482: PHP Warning: Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup::getEntityRevision: Entity not loaded

2019-07-31 Thread brennen
brennen added a comment. A fuller message in case the ErrorException is relevant: /wiki/Special:EntityData/M37306574.json?revision=356182947 ErrorException from line 309 of /srv/mediawiki/php-1.34.0-wmf.16/includes/debug/MWDebug.php: PHP Warning: Wikibase\Lib\Store\Sql

[Wikidata-bugs] [Maniphest] [Commented On] T229482: PHP Warning: Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup::getEntityRevision: Entity not loaded

2019-07-31 Thread brennen
brennen added a comment. It's a non-trivial amount of logspam - some ~1000 log messages a minute when deployed to Group1 - and will make diagnosing other issues correspondingly more difficult if rolled out. Per the logspam section of our docs on holding the train <ht

[Wikidata-bugs] [Maniphest] [Created] T229982: SuggesterParamsParser: provide either entity-id parameter 'entity' or a list of properties 'properties'

2019-08-06 Thread brennen
brennen created this task. brennen added projects: Wikimedia-production-error, Wikidata, MediaWiki-extensions-PropertySuggester, MediaWiki-REST-API. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Error - Request ID: `XUn58ApAAEgAAB9eGKcAAACN` Request URL

[Wikidata-bugs] [Maniphest] [Commented On] T229482: PHP Warning: Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup::getEntityRevision: Entity not loaded

2019-08-01 Thread brennen
brennen added a comment. Thanks all. I'll roll this forward shortly. TASK DETAIL https://phabricator.wikimedia.org/T229482 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: daniel, WMDE-leszek, Smalyshev, egardner, Mholloway

[Wikidata-bugs] [Maniphest] [Commented On] T142017: LangLinkHandler hook error on page views: "getEntityLinks could not load item Q7082645 for Okstad School"

2019-10-31 Thread brennen
brennen added a comment. Similar cropping up a few times in 1.35.0-wmf.4: [Exception ErrorException] (/srv/mediawiki/php-1.35.0-wmf.4/includes/debug/MWDebug.php:333) PHP Warning: Wikibase\Client\LangLinkHandler::getEntityLinks: Could not load item Q9074174 for Categoria:Cancellazioni

[Wikidata-bugs] [Maniphest] [Commented On] T233349: A data update callback triggered a fail-safe exception in DataUpdateAdapter

2019-10-30 Thread brennen
brennen added a comment. This remains pretty noisy in production: brennen@mwlog1001:/srv/mw-log$ head -1 error.log

[Wikidata-bugs] [Maniphest] [Commented On] T234948: New Wikibase deadlocks on Wikidata wiki since 2019-10-08T00:00:02: Wikibase\Lib\Store\Sql\Terms\{closure} Deadlock found when trying to get lock; tr

2019-12-09 Thread brennen
brennen added a comment. I'm seeing a handful of these in 1.35.0-wmf.8: PHP Warning: [data-update-failed]: A data update callback triggered an exception (Fail-safe exception. Number of ids to be restored is not equal to the number of records that are about to be inserted into master

[Wikidata-bugs] [Maniphest] [Updated] T240316: Issue with QuickStatements "you are blocked on Wikidata"

2019-12-10 Thread brennen
brennen removed a parent task: T233856: 1.35.0-wmf.8 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T240316 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Anomie, Liuxinyu970226, brennen, Multichill, Agabi10

[Wikidata-bugs] [Maniphest] [Triaged] T240316: Issue with QuickStatements "you are blocked on Wikidata"

2019-12-10 Thread brennen
brennen triaged this task as "Unbreak Now!" priority. Restricted Application added a subscriber: Liuxinyu970226. TASK DETAIL https://phabricator.wikimedia.org/T240316 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Liuxinyu97022

[Wikidata-bugs] [Maniphest] [Commented On] T240316: Issue with QuickStatements "you are blocked on Wikidata"

2019-12-10 Thread brennen
brennen added a comment. > I can't check right now but for whoever is debugging, this is very likely regression from wmf.8 that got deployed yesterday. (List of patches that got deployed) In terms of timeline for yesterday's rollout of wmf.8, from production SAL <

[Wikidata-bugs] [Maniphest] [Commented On] T233414: Merge triggered warning about unequal numbers of ids to be restored and records to be inserted into master

2019-10-23 Thread brennen
brennen added a comment. Seeing quite a bit of this in production logs at present: brennen@mwlog1001:/srv/mw-log$ grep -c 'A data update callback triggered an exception' error.log 1018 TASK DETAIL https://phabricator.wikimedia.org/T233414 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Retitled] T239165: PHP Warning: count(): Parameter must be an array or an object that implements Countable in WikibaseMediaInfo

2019-11-25 Thread brennen
brennen renamed this task from "PHP Warning: count(): Parameter must be an array or an object that implements Countable" to "PHP Warning: count(): Parameter must be an array or an object that implements Countable in WikibaseMediaInfo". brennen added projects

[Wikidata-bugs] [Maniphest] [Updated] T243415: Multiple repo/includes/Rdf errors, when wmgUseEntitySourceBasedFederation true on Wikidata.org

2020-01-23 Thread brennen
brennen added a project: User-brennen. TASK DETAIL https://phabricator.wikimedia.org/T243415 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, brennen Cc: Ladsgroup, WMDE-leszek, Aklapper, Michael, Addshore, Iflorez, darthmon_wmde, alaa_wmde

[Wikidata-bugs] [Maniphest] [Updated] T242856: PHP Warning: Invalid argument supplied for foreach()

2020-01-15 Thread brennen
brennen added a project: User-brennen. TASK DETAIL https://phabricator.wikimedia.org/T242856 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Lucas_Werkmeister_WMDE, Aklapper, LarsWirzenius, darthmon_wmde, Nandana, Lahi, Gq86, Pablo-WMDE

[Wikidata-bugs] [Maniphest] [Updated] T242846: Argument 4 passed to WikibaseQuality\ConstraintReport\Specials\SpecialConstraintReport::newFromGlobalState() must be an instance of WikibaseQuality\Const

2020-01-15 Thread brennen
brennen added a project: User-brennen. TASK DETAIL https://phabricator.wikimedia.org/T242846 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, brennen Cc: Pablo-WMDE, Lucas_Werkmeister_WMDE, Aklapper, LarsWirzenius, Hook696

[Wikidata-bugs] [Maniphest] [Updated] T223410: Split group1 so that Commons and Wikidata aren't in the general group1, but their own buckets

2020-01-07 Thread brennen
brennen added a project: User-brennen. TASK DETAIL https://phabricator.wikimedia.org/T223410 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: brennen, mmodell, greg, hashar, Aklapper, Jdforrester-WMF, darthmon_wmde, Nandana, NebulousIris

[Wikidata-bugs] [Maniphest] [Updated] T229982: SuggesterParamsParser: provide either entity-id parameter 'entity' or a list of properties 'properties'

2020-01-07 Thread brennen
brennen added a project: User-brennen. TASK DETAIL https://phabricator.wikimedia.org/T229982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, brennen Cc: Krinkle, Aklapper, brennen, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Updated] T237067: "PHP Notice: A non well formed numeric value encountered" from DmsCoordinateParser.php in API action=wbparsevalue [Story Points 5]

2020-01-07 Thread brennen
brennen added a project: User-brennen. TASK DETAIL https://phabricator.wikimedia.org/T237067 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, brennen Cc: Ladsgroup, Addshore, WMDE-leszek, Krinkle, Aklapper, brennen, Iflorez, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Retitled] T247546: DataUpdateAdapter::doUpdate: Cannot execute query

2020-03-12 Thread brennen
brennen renamed this task from "Wikibase\Repo\Content\DataUpdateAdapter::doUpdate: Commit failed on server(s) 10.64.48.172: Cannot execute query from Wikibase\Repo\Content\DataUpdateAdapter::doUpdate while transaction status is ERROR" to "DataUpdateAdapter::doUpdate: Canno

[Wikidata-bugs] [Maniphest] [Updated] T247546: DataUpdateAdapter::doUpdate: Cannot execute query

2020-03-12 Thread brennen
brennen added a parent task: T233871: 1.35.0-wmf.23 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T247546 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Aklapper, brennen, darthmon_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Commented On] T247546: DataUpdateAdapter::doUpdate: Cannot execute query

2020-03-12 Thread brennen
brennen added a comment. I'm guessing this was probably transient and isn't in fact a blocker, but someone should probably check me on that. TASK DETAIL https://phabricator.wikimedia.org/T247546 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Updated] T247546: DataUpdateAdapter::doUpdate: Cannot execute query

2020-03-12 Thread brennen
brennen added a project: User-brennen. TASK DETAIL https://phabricator.wikimedia.org/T247546 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Aklapper, brennen, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer

[Wikidata-bugs] [Maniphest] [Lowered Priority] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

2020-03-12 Thread brennen
brennen lowered the priority of this task from "Unbreak Now!" to "Medium". TASK DETAIL https://phabricator.wikimedia.org/T247466 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Ladsgroup, Tarrow, Jdforres

[Wikidata-bugs] [Maniphest] [Updated] T247546: DataUpdateAdapter::doUpdate: Cannot execute query

2020-03-12 Thread brennen
brennen removed a parent task: T233871: 1.35.0-wmf.23 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T247546 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Aklapper, brennen, darthmon_wmde, Nandana, Lahi, Gq86

[Wikidata-bugs] [Maniphest] [Lowered Priority] T247458: PHP Notice: Undefined index: wgKartographerLiveData

2020-03-12 Thread brennen
brennen lowered the priority of this task from "Unbreak Now!" to "Medium". brennen added a comment. Per conversation in RelEng and input here, this doesn't seem severe enough to hold up the train (particularly over the weekend). TASK DETAIL https://phabricator.wikimedi

[Wikidata-bugs] [Maniphest] [Updated] T247458: PHP Notice: Undefined index: wgKartographerLiveData

2020-03-12 Thread brennen
brennen removed a parent task: T233871: 1.35.0-wmf.23 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T247458 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Liuxinyu970226, Mholloway, hoo, thiemowmde, Agusbou2015

[Wikidata-bugs] [Maniphest] [Commented On] T247458: PHP Notice: Undefined index: wgKartographerLiveData

2020-03-12 Thread brennen
brennen added a comment. Setting as UBN as long as this is marked a train blocker. Sounds like it's not serious in terms of real impact but it would be nice to eliminate logspam. TASK DETAIL https://phabricator.wikimedia.org/T247458 EMAIL PREFERENCES https://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Triaged] T247458: PHP Notice: Undefined index: wgKartographerLiveData

2020-03-12 Thread brennen
brennen triaged this task as "Unbreak Now!" priority. Restricted Application added a subscriber: Liuxinyu970226. TASK DETAIL https://phabricator.wikimedia.org/T247458 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Liux

[Wikidata-bugs] [Maniphest] [Created] T247546: Wikibase\Repo\Content\DataUpdateAdapter::doUpdate: Commit failed on server(s) 10.64.48.172: Cannot execute query from Wikibase\Repo\Content\DataUpdateAda

2020-03-12 Thread brennen
brennen created this task. brennen added projects: Wikimedia-production-error, Wikidata. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Error - `MediaWiki version:` **`1.35.0-wmf.23`** name=message Wikibase\Repo\Content\DataUpdateAdapter

[Wikidata-bugs] [Maniphest] [Updated] T246898: Wikibase\Repo\Content\DataUpdateAdapter::doUpdate: Commit failed on server(s) 10.64.48.172: Cannot execute query from Wikibase\Repo\Content\DataUpdateAda

2020-03-12 Thread brennen
brennen added a project: User-brennen. TASK DETAIL https://phabricator.wikimedia.org/T246898 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: brennen, Magnus, Agusbou2015, Addshore, Liuxinyu970226, Aklapper, darthmon_wmde, Nandana, Lahi

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

2020-03-12 Thread brennen
brennen added a comment. Given pre-existing nature of this breakage and per conversation in RelEng, we'll go ahead and remove this as a train blocker. It'd still definitely be good to reduce the log noise if possible. TASK DETAIL https://phabricator.wikimedia.org/T247466 EMAIL

[Wikidata-bugs] [Maniphest] [Updated] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

2020-03-12 Thread brennen
brennen removed a parent task: T233871: 1.35.0-wmf.23 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T247466 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Ladsgroup, Tarrow, Jdforrester-WMF, Agusbou2015

[Wikidata-bugs] [Maniphest] [Commented On] T247466: SimpleCacheWithBagOStuff: Cache key contains characters that are not allowed

2020-03-12 Thread brennen
brennen added a comment. Thanks - and yeah, let's backport. TASK DETAIL https://phabricator.wikimedia.org/T247466 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Ladsgroup, Tarrow, Jdforrester-WMF, Agusbou2015, Liuxinyu970226, Krinkle

[Wikidata-bugs] [Maniphest] [Commented On] T247553: PHP Warning: [data-update-failed]: A data update callback triggered an exception (Fail-safe exception. Avoiding infinite loop due to possibily undet

2020-03-12 Thread brennen
brennen added a comment. Currently under discussion in `#wikimedia-operations`, seems likely a fix is inbound. TASK DETAIL https://phabricator.wikimedia.org/T247553 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: brennen, Agusbou2015

[Wikidata-bugs] [Maniphest] [Updated] T247553: PHP Warning: [data-update-failed]: A data update callback triggered an exception (Fail-safe exception. Avoiding infinite loop due to possibily undetectab

2020-03-12 Thread brennen
brennen removed a parent task: T233871: 1.35.0-wmf.23 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T247553 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: brennen, Agusbou2015, Jdforrester-WMF, Liuxinyu970226

[Wikidata-bugs] [Maniphest] [Commented On] T247553: PHP Warning: [data-update-failed]: A data update callback triggered an exception (Fail-safe exception. Avoiding infinite loop due to possibily undet

2020-03-12 Thread brennen
brennen added a comment. This appears to have been mitigated by the above patch. Unclear whether this task should remain open, but removing as train blocker. TASK DETAIL https://phabricator.wikimedia.org/T247553 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Created] T247458: PHP Notice: Undefined index: wgKartographerLiveData

2020-03-11 Thread brennen
brennen created this task. brennen added projects: Wikimedia-production-error, Wikidata, User-brennen. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Error - `MediaWiki version:` **`1.35.0-wmf.23`** name=message PHP Notice: Undefined index

[Wikidata-bugs] [Maniphest] [Commented On] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2020-04-28 Thread brennen
brennen added a comment. Just saw 11 of these on 1.35.0-wmf.28. `logspam-watch` output: 11 Patcherwmf.28 e/W/r/i/C/EntityContent.php:544 EntityContent must not contain Entity data as well as a redirect after applying the patch! TASK DETAIL https

[Wikidata-bugs] [Maniphest] [Retitled] T251421: PHP Warning: Wikibase\Rdf\DispatchingValueSnakRdfBuilder::getValueBuilder: No RDF builder defined for data type wikibase-form nor for value type bad.

2020-04-29 Thread brennen
brennen renamed this task from "PHP Warning: Wikibase\Rdf\DispatchingValueSnakRdfBuilder::getValueBuilder: No RDF builder defined for data type wikibase-form nor for value type bad. [Called from Wikibase\Rdf\DispatchingValueSnakRdfBuilder::getValueBuilder in /srv/mediawiki/php-1.35.0-w

[Wikidata-bugs] [Maniphest] [Created] T251421: PHP Warning: Wikibase\Rdf\DispatchingValueSnakRdfBuilder::getValueBuilder: No RDF builder defined for data type wikibase-form nor for value type bad. [Ca

2020-04-29 Thread brennen
brennen created this task. brennen added projects: Wikimedia-production-error, User-brennen, Wikidata, Lexicographical data, Wikidata-Campsite, MediaWiki-extensions-WikibaseRepository. TASK DESCRIPTION Error - `MediaWiki version:` **`1.35.0-wmf.30`** name=message

[Wikidata-bugs] [Maniphest] [Triaged] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-04-30 Thread brennen
brennen triaged this task as "Unbreak Now!" priority. Restricted Application added a subscriber: Liuxinyu970226. TASK DETAIL https://phabricator.wikimedia.org/T251457 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Liuxinyu97022

[Wikidata-bugs] [Maniphest] [Updated] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-04-30 Thread brennen
brennen added a parent task: T249962: 1.35.0-wmf.30 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T251457 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Liuxinyu970226, brennen, Bugreporter, LarsWirzenius, Hogue

[Wikidata-bugs] [Maniphest] [Raised Priority] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-04-30 Thread brennen
brennen raised the priority of this task from "High" to "Unbreak Now!". brennen added a comment. Ok, so this likely warrants a rollback after all. TASK DETAIL https://phabricator.wikimedia.org/T251457 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/pa

[Wikidata-bugs] [Maniphest] [Merged] T251457: Error by Saving a Edit

2020-04-30 Thread brennen
brennen merged a task: T251505: Transaction spent 4.7531268596649 second(s) in writes, exceeding the limit of 3. brennen added subscribers: LarsWirzenius, Bugreporter. TASK DETAIL https://phabricator.wikimedia.org/T251457 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel

[Wikidata-bugs] [Maniphest] [Lowered Priority] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-04-30 Thread brennen
brennen lowered the priority of this task from "Unbreak Now!" to "High". brennen added a comment. Ok, per @Marostegui and conversation in RelEng I'm removing this as a blocker. That said it does seem clear that something changed here at least in terms of the error repor

[Wikidata-bugs] [Maniphest] [Updated] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-04-30 Thread brennen
brennen added a project: DBA. brennen added a comment. Adding DBA in case this reflects load balancing issues. TASK DETAIL https://phabricator.wikimedia.org/T251457 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Liuxinyu970226

[Wikidata-bugs] [Maniphest] [Retitled] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-04-30 Thread brennen
brennen renamed this task from "Error by Saving a Edit" to "LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]". TASK DETAIL https://phabricator.wikimedia.org/T251457 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/pa

[Wikidata-bugs] [Maniphest] [Updated] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-04-30 Thread brennen
brennen removed a parent task: T249962: 1.35.0-wmf.30 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T251457 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Marostegui, Liuxinyu970226, brennen, Bugreporter

[Wikidata-bugs] [Maniphest] [Updated] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-04-30 Thread brennen
brennen added a project: User-brennen. TASK DETAIL https://phabricator.wikimedia.org/T251457 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: brennen, Bugreporter, LarsWirzenius, Hogue, Aklapper, darthmon_wmde, WDoranWMF, holger.knust

[Wikidata-bugs] [Maniphest] [Updated] T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n]

2020-04-30 Thread brennen
brennen added a comment. This is still happening now that 1.35.0-wmf.30 (T249962 <https://phabricator.wikimedia.org/T249962>) is on all wikis, at a rate of ~100 in the last hour or so. I mistakenly believed this was fully accounted for, but I now think it likely should hav

[Wikidata-bugs] [Maniphest] [Created] T251834: PrivateSettings: PHP Notice: Undefined offset: 1

2020-05-04 Thread brennen
brennen created this task. brennen added projects: Wikimedia-production-error, MediaWiki-extensions-WikibaseRepository, Commons, WikibaseMediaInfo. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Error

[Wikidata-bugs] [Maniphest] [Reassigned] T251834: PrivateSettings: PHP Notice: Undefined offset: 1

2020-05-04 Thread brennen
brennen reassigned this task from brennen to sbassett. TASK DETAIL https://phabricator.wikimedia.org/T251834 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sbassett, brennen Cc: Urbanecm, sbassett, Aklapper, brennen, CBogen, darthmon_wmde, Nandana

[Wikidata-bugs] [Maniphest] [Closed] T251834: PrivateSettings: PHP Notice: Undefined offset: 1

2020-05-04 Thread brennen
brennen closed this task as "Resolved". brennen claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T251834 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: sbassett, Aklapper, brennen, CBogen, darthmon_wmd

[Wikidata-bugs] [Maniphest] [Created] T252061: PHP Warning: [data-update-failed]: A data update callback triggered an exception (Fail-safe exception. Avoiding infinite loop due to possibily undetectab

2020-05-06 Thread brennen
brennen created this task. brennen added projects: Wikimedia-production-error, Wikidata, MediaWiki-extensions-WikibaseRepository. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Error - `MediaWiki version:` **`1.35.0-wmf.31`** name=message PHP

[Wikidata-bugs] [Maniphest] [Created] T252077: WikimediaPrometheusQueryServiceLagProvider: PHP Warning: A non-numeric value encountered

2020-05-06 Thread brennen
brennen created this task. brennen added projects: Wikimedia-production-error, Wikidata, Wikidata-Query-Service, User-brennen. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Error - `MediaWiki version:` **`1.35.0-wmf.31`** name=message PHP

[Wikidata-bugs] [Maniphest] [Updated] T252077: WikimediaPrometheusQueryServiceLagProvider: PHP Warning: A non-numeric value encountered

2020-05-06 Thread brennen
brennen added a parent task: T249963: 1.35.0-wmf.31 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T252077 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Liuxinyu970226, Aklapper, brennen, CBogen, darthmon_wmde

[Wikidata-bugs] [Maniphest] [Triaged] T252077: WikimediaPrometheusQueryServiceLagProvider: PHP Warning: A non-numeric value encountered

2020-05-06 Thread brennen
brennen triaged this task as "Unbreak Now!" priority. Restricted Application added a subscriber: Liuxinyu970226. TASK DETAIL https://phabricator.wikimedia.org/T252077 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Liux

[Wikidata-bugs] [Maniphest] [Updated] T252061: DeferredUpdates: PHP Warning: [data-update-failed]: A data update callback triggered an exception

2020-05-06 Thread brennen
brennen added a project: User-brennen. TASK DETAIL https://phabricator.wikimedia.org/T252061 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Aklapper, brennen, darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Retitled] T252061: DeferredUpdates: PHP Warning: [data-update-failed]: A data update callback triggered an exception

2020-05-06 Thread brennen
brennen renamed this task from "PHP Warning: [data-update-failed]: A data update callback triggered an exception (Fail-safe exception. Avoiding infinite loop due to possibily undetectable existing records in master. It may be due to encoding incompatibility between database values and v

[Wikidata-bugs] [Maniphest] [Lowered Priority] T252077: WikimediaPrometheusQueryServiceLagProvider: PHP Warning: A non-numeric value encountered

2020-05-06 Thread brennen
brennen lowered the priority of this task from "Unbreak Now!" to "Needs Triage". brennen added a comment. After discussion in `#wikimedia-operations`, unblocking train on the assumption that this is likely to be bad data from Prometheus. 16:25 meanwhile:

[Wikidata-bugs] [Maniphest] [Updated] T252077: WikimediaPrometheusQueryServiceLagProvider: PHP Warning: A non-numeric value encountered

2020-05-06 Thread brennen
brennen removed a parent task: T249963: 1.35.0-wmf.31 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T252077 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: #wikidata-campsite, Addshore, Liuxinyu970226, Aklapper

[Wikidata-bugs] [Maniphest] [Commented On] T252079: mw.wikibase.getLabelByLang('Q1', 'en') returning nil today

2020-05-06 Thread brennen
brennen added a comment. Been offline for a while and just catching up here. Does this warrant a rollback to group0? TASK DETAIL https://phabricator.wikimedia.org/T252079 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: brennen

[Wikidata-bugs] [Maniphest] [Commented On] T252079: mw.wikibase.getLabelByLang('Q1', 'en') returning nil today

2020-05-06 Thread brennen
brennen added a comment. ...welp, that sure sounds like it does. TASK DETAIL https://phabricator.wikimedia.org/T252079 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: brennen, Dominicbm, Mholloway, WilliamGraham, LucasWerkmeister

[Wikidata-bugs] [Maniphest] [Updated] T252077: WikimediaPrometheusQueryServiceLagProvider: PHP Warning: A non-numeric value encountered

2020-05-06 Thread brennen
brennen added a subscriber: Addshore. brennen added a comment. Just realizing this is due to ` /srv/mediawiki-staging/multiversion/MWScript.php extensions/Wikidata.org/maintenance/updateQueryServiceLag.php --wiki wikidatawiki --cluster wdqs --prometheus prometheus.svc.eqiad.wmnet

[Wikidata-bugs] [Maniphest] [Updated] T248012: PHP Notice: Undefined property: Wikibase\DataModel\Term\TermList::$Ø

2020-03-18 Thread brennen
brennen closed this task as a duplicate of T248006: PHP Notice: Undefined property: Wikibase\DataModel\Term\TermList::$Ø. TASK DETAIL https://phabricator.wikimedia.org/T248012 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Aklapper

[Wikidata-bugs] [Maniphest] [Created] T248012: PHP Notice: Undefined property: Wikibase\DataModel\Term\TermList::$Ø

2020-03-18 Thread brennen
brennen created this task. brennen added projects: Wikimedia-production-error, Wikibase-DataModel. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Error - `MediaWiki version:` **`1.35.0-wmf.23

[Wikidata-bugs] [Maniphest] [Merged] T248006: PHP Notice: Undefined property: Wikibase\DataModel\Term\TermList::$Ø

2020-03-18 Thread brennen
brennen merged a task: T248012: PHP Notice: Undefined property: Wikibase\DataModel\Term\TermList::$Ø. TASK DETAIL https://phabricator.wikimedia.org/T248006 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: brennen, Agusbou2015

[Wikidata-bugs] [Maniphest] [Commented On] T246898: Wikibase\Repo\Content\DataUpdateAdapter::doUpdate: Commit failed on server(s) 10.64.48.172: Cannot execute query from Wikibase\Repo\Content\DataUpda

2020-03-16 Thread brennen
brennen added a comment. Seeing quite a bit of this, or what I think is this, in logstash over the last several hours. TASK DETAIL https://phabricator.wikimedia.org/T246898 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: brennen

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-06 Thread brennen
brennen removed a parent task: T257971: 1.36.0-wmf.3 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T259745 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ammarpad, brennen Cc: thiemowmde, Umherirrender, Agusbou2015, Catrope

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

2020-08-06 Thread brennen
brennen added a comment. Thanks all. TASK DETAIL https://phabricator.wikimedia.org/T259744 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Lucas_Werkmeister_WMDE, thiemowmde, Agusbou2015, toan, Ladsgroup, Addshore, Pablo-WMDE

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

2020-08-05 Thread brennen
brennen added a parent task: T257971: 1.36.0-wmf.3 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T259744 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Aklapper, brennen, CBogen, Akuckartz, darthmon_wmde, Nandana

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

2020-08-05 Thread brennen
brennen triaged this task as "Unbreak Now!" priority. brennen added a comment. Since we're already rolled back due to T259745 <https://phabricator.wikimedia.org/T259745>, I'm going to err on the side of marking this a blocker until triaged. TASK DETAIL https://phabricat

[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

2020-08-05 Thread brennen
brennen created this task. brennen added projects: Wikimedia-production-error, Wikidata-Campsite, MediaWiki-extensions-Scribunto, Commons, User-brennen. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION name=Error message

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-05 Thread brennen
brennen triaged this task as "Unbreak Now!" priority. TASK DETAIL https://phabricator.wikimedia.org/T259745 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Aklapper, brennen, CBogen, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq8

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-05 Thread brennen
brennen added a parent task: T257971: 1.36.0-wmf.3 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T259745 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Aklapper, brennen, CBogen, Akuckartz, darthmon_wmde, Nandana

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-05 Thread brennen
brennen created this task. brennen added projects: Wikimedia-production-error, Wikidata-Campsite, Commons, OOjs, User-brennen. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Error - `MediaWiki version

[Wikidata-bugs] [Maniphest] [Commented On] T255658: PHP Warning: {"type":"error", "message":"cirrussearch-backend-error", "params":[]} [Called from Wikibase\Search\Elastic\EntitySearchElastic::getRank

2020-06-17 Thread brennen
brennen added a comment. Yeah, I can confirm from notes these were happening last week during Thursday's train window. I had the idea this one had been captured in an existing task, but I'm not seeing anything obvious on searching. TASK DETAIL https://phabricator.wikimedia.org/T255658

[Wikidata-bugs] [Maniphest] [Updated] T255704: Role mediainfo is already defined

2020-06-17 Thread brennen
brennen added a project: User-brennen. TASK DETAIL https://phabricator.wikimedia.org/T255704 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Aklapper, thcipriani, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden

[Wikidata-bugs] [Maniphest] [Updated] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2020-06-25 Thread brennen
brennen added a project: User-brennen. TASK DETAIL https://phabricator.wikimedia.org/T97146 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: brennen, Krinkle, thiemowmde, gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, Aklapper

[Wikidata-bugs] [Maniphest] [Created] T256293: HookContainer: Call to a member function serialize() on null

2020-06-24 Thread brennen
brennen created this task. brennen added projects: Wikimedia-production-error, Two-Column-Edit-Conflict-Merge, Wikidata-Campsite, User-brennen. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Error - `MediaWiki

[Wikidata-bugs] [Maniphest] T265521: No formatter defined for value type unknown.

2020-11-09 Thread brennen
brennen added a project: User-brennen. TASK DETAIL https://phabricator.wikimedia.org/T265521 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Michael, Aklapper, thcipriani, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic

[Wikidata-bugs] [Maniphest] T272508: PropertyInfoSnakUrlExpander: Bad value for parameter $snak->getDataValue(): must be a DataValues\StringValue

2021-01-20 Thread brennen
brennen triaged this task as "Unbreak Now!" priority. brennen moved this task from Backlog to Logs/Train on the User-brennen board. TASK DETAIL https://phabricator.wikimedia.org/T272508 WORKBOARD https://phabricator.wikimedia.org/project/board/4463/ EMAIL PREFERENC

[Wikidata-bugs] [Maniphest] T272508: PropertyInfoSnakUrlExpander: Bad value for parameter $snak->getDataValue(): must be a DataValues\StringValue

2021-01-20 Thread brennen
brennen added a parent task: T271341: 1.36.0-wmf.27 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T272508 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Aklapper, brennen, Akuckartz, darthmon_wmde, Nandana, Lahi

[Wikidata-bugs] [Maniphest] T272508: PropertyInfoSnakUrlExpander: Bad value for parameter $snak->getDataValue(): must be a DataValues\StringValue

2021-01-20 Thread brennen
brennen created this task. brennen added projects: Wikimedia-production-error, Wikidata-Campsite, WikibaseMediaInfo, User-brennen. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION name=Error message Bad value

[Wikidata-bugs] [Maniphest] T272508: PropertyInfoSnakUrlExpander: Bad value for parameter $snak->getDataValue(): must be a DataValues\StringValue

2021-01-20 Thread brennen
brennen removed a parent task: T271341: 1.36.0-wmf.27 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T272508 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: egardner, matthiasmullie, MarkTraceur, WMDE-leszek, RhinosF1

[Wikidata-bugs] [Maniphest] T272508: PropertyInfoSnakUrlExpander: Bad value for parameter $snak->getDataValue(): must be a DataValues\StringValue

2021-01-20 Thread brennen
brennen lowered the priority of this task from "Unbreak Now!" to "Needs Triage". brennen added a comment. Thanks - makes sense. I'll proceed with wmf.27 to group1 and monitor just in case. TASK DETAIL https://phabricator.wikimedia.org/T272508 EMAIL

[Wikidata-bugs] [Maniphest] T271402: TypeError on a diff of Wikidata talk page

2021-01-21 Thread brennen
brennen added a project: User-brennen. brennen added a comment. Noticed a further 11 of these this morning in 1.36.0-wmf.27. TASK DETAIL https://phabricator.wikimedia.org/T271402 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE

[Wikidata-bugs] [Maniphest] T273506: [M] Sporadic “TypeError: Return value of EntityContentFactory::getTitleForId() must be an instance of Title, null returned” for Special:EntityData on Commons

2021-03-11 Thread brennen
brennen added a project: User-brennen. TASK DETAIL https://phabricator.wikimedia.org/T273506 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: matthiasmullie, Umherirrender, MarkTraceur, CBogen, Cparle, WMDE-leszek, Addshore, Jdforrester

[Wikidata-bugs] [Maniphest] T277593: ErrorException: Invalid cross-wiki page Q[id]. Expected: wikidatawiki, got local

2021-03-16 Thread brennen
brennen added a project: Crosswiki. brennen added a comment. Unsure if #Crosswiki <https://phabricator.wikimedia.org/tag/crosswiki/> is relevant, any help in tagging welcome. TASK DETAIL https://phabricator.wikimedia.org/T277593 EMAIL PREFERENCES https://phabricator.wikimed

[Wikidata-bugs] [Maniphest] T277593: ErrorException: Invalid cross-wiki page Q[id]. Expected: wikidatawiki, got local

2021-03-16 Thread brennen
brennen created this task. brennen added projects: Wikimedia-production-error, Wikidata-Campsite, User-brennen. brennen triaged this task as "Unbreak Now!" priority. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTI

[Wikidata-bugs] [Maniphest] T277593: ErrorException: Invalid cross-wiki page Q[id]. Expected: wikidatawiki, got local

2021-03-16 Thread brennen
brennen added a parent task: T274939: 1.36.0-wmf.35 deployment blockers. Restricted Application added a project: wdwb-tech-focus. TASK DETAIL https://phabricator.wikimedia.org/T277593 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc

[Wikidata-bugs] [Maniphest] T277362: Deprecation warning client-repo wikitext link

2021-03-17 Thread brennen
brennen added a comment. A handful of responses: 1. Deployers have no way to know in the moment that something is only a deprecation warning with no other consequences. If a warning isn't material to production health, it should probably either be labeled in a way that makes

[Wikidata-bugs] [Maniphest] T277089: WikibaseLexeme: Call to a member function getLemmas() on null

2021-03-10 Thread brennen
brennen created this task. brennen added projects: Wikimedia-production-error, Wikidata-Campsite, Wikidata Lexicographical data, User-brennen. Restricted Application added a project: Wikidata. TASK DESCRIPTION Error - `MediaWiki version:` **`1.36.0-wmf.33`** name

[Wikidata-bugs] [Maniphest] T277691: Argument 1 passed to DataValues\Geo\Values\LatLongValue::__construct() must be of the type float, string given

2021-03-17 Thread brennen
brennen added a project: User-brennen. Restricted Application added a project: wdwb-tech-focus. TASK DETAIL https://phabricator.wikimedia.org/T277691 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Aklapper, brennen, MPhamWMF, maantietaja

[Wikidata-bugs] [Maniphest] T277691: Argument 1 passed to DataValues\Geo\Values\LatLongValue::__construct() must be of the type float, string given

2021-03-17 Thread brennen
brennen created this task. brennen added projects: Wikimedia-production-error, Wikidata-Campsite, GeoData. Restricted Application added a subscriber: Aklapper. Restricted Application added projects: Wikidata, Discovery-Search. TASK DESCRIPTION Error - `MediaWiki version

[Wikidata-bugs] [Maniphest] T292446: Change Dispatching should not stumble over mowiki redirecting to rowiki

2021-10-07 Thread brennen
brennen added a comment. Continuing to see these in wmf.3 for mowiki and testcommonswiki. 1count 2histo 3first 4last 5exception 6message 55 ▅▆▃▅▅▆▆ 09531917MW...3 e/W/r/i/C/DispatchChangesJob:238 No client wiki with site ID mowiki

[Wikidata-bugs] [Maniphest] T292667: WikidataPageBanner: Cannot instantiate interface Wikibase\DataModel\Entity\PropertyId

2021-10-06 Thread brennen
brennen added a parent task: T281167: 1.38.0-wmf.3 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T292667 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: brennen Cc: Aklapper, Masumrezarock100, brennen, darthmon_wmde, Verdy_p

[Wikidata-bugs] [Maniphest] T292667: Error: Cannot instantiate interface Wikibase\DataModel\Entity\PropertyId

2021-10-06 Thread brennen
brennen created this task. brennen added projects: Wikimedia-production-error, Wikidata-Campsite, Wikidata-Page-Banner, User-brennen. Restricted Application added subscribers: Masumrezarock100, Aklapper. TASK DESCRIPTION Error - - mwversion: `1.38.0-wmf.3` - reqId: `a8cd263c-2791

[Wikidata-bugs] [Maniphest] T292667: WikidataPageBanner: Cannot instantiate interface Wikibase\DataModel\Entity\PropertyId

2021-10-06 Thread brennen
brennen renamed this task from "Error: Cannot instantiate interface Wikibase\DataModel\Entity\PropertyId" to "WikidataPageBanner: Cannot instantiate interface Wikibase\DataModel\Entity\PropertyId". TASK DETAIL https://phabricator.wikimedia.org/T292667 EMAIL

  1   2   >