[Wikidata-bugs] [Maniphest] [Changed CC] T69238: Factor diff logic out of EntityContent

2014-11-24 Thread daniel
daniel added a subscriber: daniel. daniel added a comment. EntityContent wraps an Entity. It acts as a glue between the Wikibase world (Entity objects) and the MediaWiki world (Content objects). (Some types of) EntityContents can be redirects, Entities never are. EntityDiff represents a diff

[Wikidata-bugs] [Maniphest] [Closed] T74678: json dumps have duplicate items (one for the redirect, one for the target)

2014-11-24 Thread daniel
daniel closed this task as Resolved. daniel claimed this task. daniel added a comment. fix merged TASK DETAIL https://phabricator.wikimedia.org/T74678 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel Cc: wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T73352: Usage Tracking: changes should trigger an appropriate update of pages that use the corresponding aspect of the change item

2014-11-25 Thread daniel
daniel added a comment. Worked on this in sprint 2014-11-11 In review: https://gerrit.wikimedia.org/r/#/c/170961/ https://gerrit.wikimedia.org/r/#/c/167856/ TASK DETAIL https://phabricator.wikimedia.org/T73352 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Wikidata-bugs] [Maniphest] [Created] T75875: Move wikibase formatters into separate component

2014-11-25 Thread daniel
daniel created this task. daniel added a subscriber: daniel. daniel added a project: MediaWiki-extensions-WikidataRepo. daniel changed Security from none to none. TASK DESCRIPTION WikibaseFormatters would depend on DataValueFormatters, and possibly on some storage services etc. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Updated] T75875: Move wikibase formatters into separate component

2014-11-25 Thread daniel
daniel added a blocking task: T75863: split wikibase.git. TASK DETAIL https://phabricator.wikimedia.org/T75875 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel Cc: wikidata-bugs, daniel

[Wikidata-bugs] [Maniphest] [Updated] T75863: split wikibase.git

2014-11-25 Thread daniel
daniel added a blocking task: T75875: Move wikibase formatters into separate component. TASK DETAIL https://phabricator.wikimedia.org/T75863 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: Wikidata-bugs, daniel Cc: wikidata

[Wikidata-bugs] [Maniphest] [Updated] T75875: Move wikibase formatters into separate component

2014-11-25 Thread daniel
daniel removed a blocking task: T75863: split wikibase.git. TASK DETAIL https://phabricator.wikimedia.org/T75875 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel Cc: wikidata-bugs, daniel

[Wikidata-bugs] [Maniphest] [Updated] T75863: split wikibase.git

2014-11-25 Thread daniel
daniel added a blocking task: T75875: Move wikibase formatters into separate component. TASK DETAIL https://phabricator.wikimedia.org/T75863 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: Wikidata-bugs, daniel Cc: wikidata

[Wikidata-bugs] [Maniphest] [Retitled] T75875: Find a home for EntityChange and friends

2014-11-25 Thread daniel
daniel changed the title from Move wikibase formatters into separate component to Find a home for EntityChange and friends. daniel edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T75875 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Wikidata-bugs] [Maniphest] [Created] T75877: Split lib/storage into a separate component

2014-11-25 Thread daniel
daniel created this task. daniel added a subscriber: daniel. daniel added a project: MediaWiki-extensions-WikidataRepo. daniel changed Security from none to none. TASK DESCRIPTION many storage services are shared between repo and client, especially when the client accesses the repo database

[Wikidata-bugs] [Maniphest] [Updated] T75863: split wikibase.git

2014-11-25 Thread daniel
daniel added a blocking task: T75877: Split lib/storage into a separate component. TASK DETAIL https://phabricator.wikimedia.org/T75863 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: Wikidata-bugs, daniel Cc: wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T75863: split wikibase.git

2014-11-25 Thread daniel
daniel added a blocking task: T75877: Split lib/storage into a separate component. TASK DETAIL https://phabricator.wikimedia.org/T75863 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: Wikidata-bugs, daniel Cc: wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T75863: split wikibase.git

2014-11-25 Thread daniel
daniel added a blocking task: T64188: Replace old serialization code in lib with datamodel serialization. TASK DETAIL https://phabricator.wikimedia.org/T75863 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: Wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T75863: split wikibase.git

2014-11-25 Thread daniel
daniel added a blocking task: T64188: Replace old serialization code in lib with datamodel serialization. TASK DETAIL https://phabricator.wikimedia.org/T75863 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: Wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T75879: move wikibase parsers and validators (to repo, or a separate component)

2014-11-25 Thread daniel
daniel added a project: MediaWiki-extensions-WikidataRepo. TASK DETAIL https://phabricator.wikimedia.org/T75879 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel Cc: wikidata-bugs, daniel

[Wikidata-bugs] [Maniphest] [Updated] T75863: split wikibase.git

2014-11-25 Thread daniel
daniel added a blocking task: T75879: move wikibase parsers and validators (to repo, or a separate component). TASK DETAIL https://phabricator.wikimedia.org/T75863 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: Wikidata

[Wikidata-bugs] [Maniphest] [Updated] T75863: split wikibase.git

2014-11-25 Thread daniel
daniel added a blocking task: T75879: move wikibase parsers and validators (to repo, or a separate component). TASK DETAIL https://phabricator.wikimedia.org/T75863 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: Wikidata

[Wikidata-bugs] [Maniphest] [Updated] T75863: split wikibase.git

2014-11-25 Thread daniel
daniel added a blocking task: T75887: Find a home for shared utilities like reporters, sites, etc.. TASK DETAIL https://phabricator.wikimedia.org/T75863 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: Wikidata-bugs, daniel

[Wikidata-bugs] [Maniphest] [Updated] T75863: split wikibase.git

2014-11-25 Thread daniel
daniel added a blocking task: T75887: Find a home for shared utilities like reporters, sites, etc.. TASK DETAIL https://phabricator.wikimedia.org/T75863 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: Wikidata-bugs, daniel

[Wikidata-bugs] [Maniphest] [Created] T75887: Find a home for shared utilities like reporters, sites, etc.

2014-11-25 Thread daniel
daniel created this task. daniel added a subscriber: daniel. daniel added a project: MediaWiki-extensions-WikidataRepo. daniel changed Security from none to none. TASK DESCRIPTION what do we want, many tiny modules, or a kitchen sink?... TASK DETAIL https://phabricator.wikimedia.org/T75887

[Wikidata-bugs] [Maniphest] [Updated] T75895: When the client extension is active on the repo, treat Item pages as linked with themselves.

2014-11-25 Thread daniel
daniel added a project: MediaWiki-extensions-WikidataRepo. TASK DETAIL https://phabricator.wikimedia.org/T75895 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel Cc: wikidata-bugs, daniel

[Wikidata-bugs] [Maniphest] [Updated] T74314: Rollout of statements on properties with old serialization code

2014-11-25 Thread daniel
daniel removed blocking tasks: T75278: Stop using Property::getClaims in PropertyView, T74879: support statements on properties in changeops. TASK DETAIL https://phabricator.wikimedia.org/T74314 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Updated] T74348: Wikidata dumps contain old-style serialization.

2014-11-26 Thread daniel
daniel added a comment. @ariel: My patch for T74361 hooks into TextPassDumper::getText() and applies on-the-fly transformation regardless of whether the text comes from a previous dump (prefetch), or the database. Can you confirm that this will indeed fix the issu? The relevant diff is here

[Wikidata-bugs] [Maniphest] [Updated] T74348: Wikidata dumps contain old-style serialization.

2014-11-26 Thread daniel
daniel removed a blocking task: T74478: SHA1 checksum in XML dump is wrong for revisions that had an export transformation applied.. TASK DETAIL https://phabricator.wikimedia.org/T74348 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign

[Wikidata-bugs] [Maniphest] [Created] T76047: Overhaul LanguageFallbackChainFactory, use appropriate fallback depending on context.

2014-11-26 Thread daniel
daniel created this task. daniel added a subscriber: daniel. daniel added projects: MediaWiki-extensions-WikidataRepo, MediaWiki-extensions-WikidataClient, i18n. daniel changed Security from none to none. TASK DESCRIPTION LanguageFallbackChainFactory currently contains a lot of methods

[Wikidata-bugs] [Maniphest] [Commented On] T76210: don't show fallback label when editing labels

2014-11-28 Thread daniel
daniel added a comment. Technically, wbEntity should only contain labels and other terms that were explicitly defined; no language fallback should apply when generating wbEntity. TASK DETAIL https://phabricator.wikimedia.org/T76210 REPLY HANDLER ACTIONS Reply to comment or attach files

[Wikidata-bugs] [Maniphest] [Changed CC] T74309: Investigate how prefetching labels would work for watchlist and recent changes

2014-11-28 Thread daniel
daniel added a subscriber: daniel. daniel added a comment. Change 176378 introduces the RecentChangesRowsForDisplay hook, which would allow us to pre-fetch labels fro entities present in the RC rows. TASK DETAIL https://phabricator.wikimedia.org/T74309 REPLY HANDLER ACTIONS Reply

[Wikidata-bugs] [Maniphest] [Changed CC] T74309: Investigate how prefetching labels would work for watchlist and recent changes

2014-11-28 Thread daniel
daniel added a subscriber: daniel. daniel added a comment. Change 176378 introduces the RecentChangesRowsForDisplay hook, which would allow us to pre-fetch labels fro entities present in the RC rows. TASK DETAIL https://phabricator.wikimedia.org/T74309 REPLY HANDLER ACTIONS Reply

[Wikidata-bugs] [Maniphest] [Commented On] T74309: Investigate how prefetching labels would work for watchlist and recent changes

2014-11-30 Thread daniel
daniel added a comment. As Katie pointed out, the existing ChangesListInitRows hook should fit the bill already. The rest of the investigation should be to outline which services/interfaces we need to make the pre-fetching work. TASK DETAIL https://phabricator.wikimedia.org/T74309 REPLY

[Wikidata-bugs] [Maniphest] [Commented On] T74309: Investigate how prefetching labels would work for watchlist and recent changes

2014-11-30 Thread daniel
daniel added a comment. As Katie pointed out, the existing ChangesListInitRows hook should fit the bill already. The rest of the investigation should be to outline which services/interfaces we need to make the pre-fetching work. TASK DETAIL https://phabricator.wikimedia.org/T74309 REPLY

[Wikidata-bugs] [Maniphest] [Commented On] T74309: Investigate how prefetching labels would work for watchlist and recent changes

2014-11-30 Thread daniel
daniel added a comment. Here's a rough outline of the pre-fetching infrastructure for labels and other Terms: We need a TermCache service like this: ``` TermCache { /** * Update terms for the given entity. Any old terms associated with the entity are discarded. **/ public

[Wikidata-bugs] [Maniphest] [Commented On] T74309: Investigate how prefetching labels would work for watchlist and recent changes

2014-11-30 Thread daniel
daniel added a comment. Here's a rough outline of the pre-fetching infrastructure for labels and other Terms: We need a TermCache service like this: ``` TermCache { /** * Update terms for the given entity. Any old terms associated with the entity are discarded. **/ public

[Wikidata-bugs] [Maniphest] [Commented On] T74309: Investigate how prefetching labels would work for watchlist and recent changes

2014-11-30 Thread daniel
daniel added a comment. Jan and Thiemo brought up an idea for pre-fetching labels accessed via Lua or {{#property}} with arbitrary access enabled: we pre-fetch based on the usage tracking info, so that when parsing a new revision of a page, pre have fast access to all labels/terms used

[Wikidata-bugs] [Maniphest] [Commented On] T74309: Investigate how prefetching labels would work for watchlist and recent changes

2014-11-30 Thread daniel
daniel added a comment. Jan and Thiemo brought up an idea for pre-fetching labels accessed via Lua or {{#property}} with arbitrary access enabled: we pre-fetch based on the usage tracking info, so that when parsing a new revision of a page, pre have fast access to all labels/terms used

[Wikidata-bugs] [Maniphest] [Changed CC] T72767: Do not load full entities when invoking LinkBegin hook

2014-12-01 Thread daniel
daniel added a subscriber: daniel. daniel added a comment. See T74309 for a draft of how label caching could work TASK DETAIL https://phabricator.wikimedia.org/T72767 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel Cc

[Wikidata-bugs] [Maniphest] [Changed CC] T72767: Do not load full entities when invoking LinkBegin hook

2014-12-01 Thread daniel
daniel added a subscriber: daniel. daniel added a comment. See T74309 for a draft of how label caching could work TASK DETAIL https://phabricator.wikimedia.org/T72767 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel Cc

[Wikidata-bugs] [Maniphest] [Commented On] T74309: Investigate how prefetching labels would work for watchlist and recent changes

2014-12-01 Thread daniel
daniel added a comment. @aude: memcached retrieval of entities is faster than sql queries of term table -- i'm not sure this is true, especially for large items. I have sent mail to Springle and Ori asking for input. Will do some benchmarking. For course, fre-fetching/batching plus in-process

[Wikidata-bugs] [Maniphest] [Commented On] T74309: Investigate how prefetching labels would work for watchlist and recent changes

2014-12-01 Thread daniel
daniel added a comment. @aude: memcached retrieval of entities is faster than sql queries of term table -- i'm not sure this is true, especially for large items. I have sent mail to Springle and Ori asking for input. Will do some benchmarking. For course, fre-fetching/batching plus in-process

[Wikidata-bugs] [Maniphest] [Updated] T72767: Do not load full entities when invoking LinkBegin hook

2014-12-01 Thread daniel
daniel added a blocking task: T74309: Investigate how prefetching labels would work for watchlist and recent changes. TASK DETAIL https://phabricator.wikimedia.org/T72767 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username

[Wikidata-bugs] [Maniphest] [Updated] T72767: Do not load full entities when invoking LinkBegin hook

2014-12-01 Thread daniel
daniel added a blocking task: T74309: Investigate how prefetching labels would work for watchlist and recent changes. TASK DETAIL https://phabricator.wikimedia.org/T72767 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username

[Wikidata-bugs] [Maniphest] [Unblock] T75087: Efficient entity label lookup (tracking)

2014-12-01 Thread daniel
daniel closed blocking task T70026: Create EntityFingerprintLookup service for use with EntityLabelFormatter and simmilar classes. as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T75087 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Unblock] T70025: Dispatching formatters should have factory methods for derived instances, to allow overriding individual inner formatters.

2014-12-01 Thread daniel
daniel closed blocking task T70026: Create EntityFingerprintLookup service for use with EntityLabelFormatter and simmilar classes. as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T70025 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Unblock] T72767: Do not load full entities when invoking LinkBegin hook

2014-12-01 Thread daniel
daniel closed blocking task T70026: Create EntityFingerprintLookup service for use with EntityLabelFormatter and simmilar classes. as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T72767 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Unblock] T70025: Dispatching formatters should have factory methods for derived instances, to allow overriding individual inner formatters.

2014-12-01 Thread daniel
daniel closed blocking task T70026: Create EntityFingerprintLookup service for use with EntityLabelFormatter and simmilar classes. as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T70025 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Unblock] T75087: Efficient entity label lookup (tracking)

2014-12-01 Thread daniel
daniel closed blocking task T70026: Create EntityFingerprintLookup service for use with EntityLabelFormatter and simmilar classes. as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T75087 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Unblock] T72767: Do not load full entities when invoking LinkBegin hook

2014-12-01 Thread daniel
daniel closed blocking task T70026: Create EntityFingerprintLookup service for use with EntityLabelFormatter and simmilar classes. as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T72767 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Closed] T70026: Create EntityFingerprintLookup service for use with EntityLabelFormatter and simmilar classes.

2014-12-01 Thread daniel
daniel closed this task as Resolved. daniel claimed this task. daniel added a comment. This is covered by the TermIndex service, fopr which we have precisely the three implementations requested above. TASK DETAIL https://phabricator.wikimedia.org/T70026 REPLY HANDLER ACTIONS Reply

[Wikidata-bugs] [Maniphest] [Closed] T70026: Create EntityFingerprintLookup service for use with EntityLabelFormatter and simmilar classes.

2014-12-01 Thread daniel
daniel closed this task as Resolved. daniel claimed this task. daniel added a comment. This is covered by the TermIndex service, fopr which we have precisely the three implementations requested above. TASK DETAIL https://phabricator.wikimedia.org/T70026 REPLY HANDLER ACTIONS Reply

[Wikidata-bugs] [Maniphest] [Closed] T70025: Dispatching formatters should have factory methods for derived instances, to allow overriding individual inner formatters.

2014-12-01 Thread daniel
daniel closed this task as Resolved. daniel claimed this task. daniel added a comment. This request has become mute, since the default LabelLookup can now be overwritten via the FormatterOptions, see I3c6ead36f501d6. TASK DETAIL https://phabricator.wikimedia.org/T70025 REPLY HANDLER ACTIONS

[Wikidata-bugs] [Maniphest] [Unblock] T70022: Make formatter for referenced Items use pre-fetched labels.

2014-12-01 Thread daniel
daniel closed blocking task T70025: Dispatching formatters should have factory methods for derived instances, to allow overriding individual inner formatters. as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T70022 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close

[Wikidata-bugs] [Maniphest] [Closed] T70025: Dispatching formatters should have factory methods for derived instances, to allow overriding individual inner formatters.

2014-12-01 Thread daniel
daniel closed this task as Resolved. daniel claimed this task. daniel added a comment. This request has become mute, since the default LabelLookup can now be overwritten via the FormatterOptions, see I3c6ead36f501d6. TASK DETAIL https://phabricator.wikimedia.org/T70025 REPLY HANDLER ACTIONS

[Wikidata-bugs] [Maniphest] [Unblock] T70022: Make formatter for referenced Items use pre-fetched labels.

2014-12-01 Thread daniel
daniel closed blocking task T70025: Dispatching formatters should have factory methods for derived instances, to allow overriding individual inner formatters. as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T70022 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close

[Wikidata-bugs] [Maniphest] [Commented On] T70022: Make formatter for referenced Items use pre-fetched labels.

2014-12-01 Thread daniel
daniel added a comment. This is largely fixed since I3c6ead36f501d6 got merged, but Ia0be6bf52790a9c is still pending review. TASK DETAIL https://phabricator.wikimedia.org/T70022 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username

[Wikidata-bugs] [Maniphest] [Commented On] T70022: Make formatter for referenced Items use pre-fetched labels.

2014-12-01 Thread daniel
daniel added a comment. This is largely fixed since I3c6ead36f501d6 got merged, but Ia0be6bf52790a9c is still pending review. TASK DETAIL https://phabricator.wikimedia.org/T70022 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username

[Wikidata-bugs] [Maniphest] [Updated] T64724: Reuse EntityInfoBuilder arrays when generating html

2014-12-01 Thread daniel
daniel added blocking tasks: T70022: Make formatter for referenced Items use pre-fetched labels., T75888: Use EntityIdFormatter for PropertyLabels in ClaimHtmlFormatter. TASK DETAIL https://phabricator.wikimedia.org/T64724 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close

[Wikidata-bugs] [Maniphest] [Retitled] T64724: Reuse EntityInfoBuilder arrays when generating html (tracking)

2014-12-01 Thread daniel
daniel changed the title from Reuse EntityInfoBuilder arrays when generating html to Reuse EntityInfoBuilder arrays when generating html (tracking). daniel added a project: tracking. TASK DETAIL https://phabricator.wikimedia.org/T64724 REPLY HANDLER ACTIONS Reply to comment or attach files

[Wikidata-bugs] [Maniphest] [Retitled] T64724: Reuse EntityInfoBuilder arrays when generating html (tracking)

2014-12-01 Thread daniel
daniel changed the title from Reuse EntityInfoBuilder arrays when generating html to Reuse EntityInfoBuilder arrays when generating html (tracking). daniel added a project: tracking. TASK DETAIL https://phabricator.wikimedia.org/T64724 REPLY HANDLER ACTIONS Reply to comment or attach files

[Wikidata-bugs] [Maniphest] [Updated] T64724: Reuse EntityInfoBuilder arrays when generating html

2014-12-01 Thread daniel
daniel added blocking tasks: T70022: Make formatter for referenced Items use pre-fetched labels., T75888: Use EntityIdFormatter for PropertyLabels in ClaimHtmlFormatter. TASK DETAIL https://phabricator.wikimedia.org/T64724 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close

[Wikidata-bugs] [Maniphest] [Commented On] T64724: Reuse EntityInfoBuilder arrays when generating html (tracking)

2014-12-01 Thread daniel
daniel added a comment. Marked this as a tracking bug, since it's autmatically resolved once the remaining blockers are resolved. TASK DETAIL https://phabricator.wikimedia.org/T64724 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign

[Wikidata-bugs] [Maniphest] [Commented On] T64724: Reuse EntityInfoBuilder arrays when generating html (tracking)

2014-12-01 Thread daniel
daniel added a comment. Marked this as a tracking bug, since it's autmatically resolved once the remaining blockers are resolved. TASK DETAIL https://phabricator.wikimedia.org/T64724 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign

[Wikidata-bugs] [Maniphest] [Created] T76339: Implement caching for TermLookup

2014-12-01 Thread daniel
daniel created this task. daniel added subscribers: wikidata-bugs, Tobi_WMDE_SW, Liuxinyu970226, Wikidata-bugs, daniel. daniel added a project: MediaWiki-extensions-WikidataRepo. daniel changed Security from none to none. TASK DESCRIPTION For prefetching to work, we need a caching TermLookup

[Wikidata-bugs] [Maniphest] [Updated] T74309: Investigate how prefetching labels would work for watchlist and recent changes

2014-12-01 Thread daniel
daniel added a comment. Created T74310 Batched label query for watchlists and recent changes for tracking the caching aspect. TASK DETAIL https://phabricator.wikimedia.org/T74309 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username

[Wikidata-bugs] [Maniphest] [Updated] T74309: Investigate how prefetching labels would work for watchlist and recent changes

2014-12-01 Thread daniel
daniel added a comment. Created T74310 Batched label query for watchlists and recent changes for tracking the caching aspect. TASK DETAIL https://phabricator.wikimedia.org/T74309 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username

[Wikidata-bugs] [Maniphest] [Changed CC] T74310: Batched label query for watchlists and recent changes

2014-12-01 Thread daniel
daniel added a subscriber: daniel. daniel added a comment. This can be done using the ChangesListInitRows, once we have a caching infrastructure for terms. TASK DETAIL https://phabricator.wikimedia.org/T74310 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Wikidata-bugs] [Maniphest] [Changed CC] T74310: Batched label query for watchlists and recent changes

2014-12-01 Thread daniel
daniel added a subscriber: daniel. daniel added a comment. This can be done using the ChangesListInitRows, once we have a caching infrastructure for terms. TASK DETAIL https://phabricator.wikimedia.org/T74310 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Wikidata-bugs] [Maniphest] [Commented On] T43790: Work on XML backup/export formats

2014-12-01 Thread daniel
daniel added a comment. We should compare the //compressed// size of the current encoding with the CDATA encoding to see if this actually makes a significant difference. If yes, we should indeed start using CDATA in XML exports. Otherwise, I don't think it 's worth the trouble. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Up For Grabs] T47535: Allow a page's language links to be manipulated in a consistent way

2014-12-01 Thread daniel
daniel placed this task up for grabs. TASK DETAIL https://phabricator.wikimedia.org/T47535 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel Cc: Anomie, Reedy, Krinkle, daniel, Catrope, Wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T73512: create filter by language that can be applied to objects before passing to serialization

2014-12-01 Thread daniel
daniel added a comment. @jan: a good entry point is probably LanguageFallbackChain::extractPreferredValue() TASK DETAIL https://phabricator.wikimedia.org/T73512 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel Cc

[Wikidata-bugs] [Maniphest] [Commented On] T74309: Investigate how prefetching labels would work for watchlist and recent changes

2014-12-02 Thread daniel
daniel added a comment. @aude: thanks for the benchmark! I'm surprised that loading the full entities does not have a bigger impact on memory usage. How many different entities where hit, and how big are these entities? TASK DETAIL https://phabricator.wikimedia.org/T74309 REPLY HANDLER

[Wikidata-bugs] [Maniphest] [Updated] T73519: Unblock editing the item for Germany (Q183) (Was: Wikimedia Error page on)

2014-12-02 Thread daniel
daniel edited tasks, added: 1; removed: 4 TASK DETAIL https://phabricator.wikimedia.org/T73519 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel Cc: Elitre, Quiddity, Liuxinyu970226, greg, Legoktm, coren, Raymond

[Wikidata-bugs] [Maniphest] [Changed CC] T74308: Inject term lookup into formatters

2014-12-02 Thread daniel
daniel added subscribers: wikidata-bugs, Lydia_Pintscher. daniel merged a task: T74036: Use terms-lookup service in EntityID formatters. TASK DETAIL https://phabricator.wikimedia.org/T74308 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign

[Wikidata-bugs] [Maniphest] [Changed CC] T74308: Inject term lookup into formatters

2014-12-02 Thread daniel
daniel added subscribers: wikidata-bugs, Lydia_Pintscher. daniel merged a task: T74036: Use terms-lookup service in EntityID formatters. TASK DETAIL https://phabricator.wikimedia.org/T74308 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign

[Wikidata-bugs] [Maniphest] [Merged] T74036: Use terms-lookup service in EntityID formatters

2014-12-02 Thread daniel
daniel merged this task into T74308: Inject term lookup into formatters. TASK DETAIL https://phabricator.wikimedia.org/T74036 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: Tobi_WMDE_SW, daniel Cc: wikidata-bugs

[Wikidata-bugs] [Maniphest] [Merged] T74036: Use terms-lookup service in EntityID formatters

2014-12-02 Thread daniel
daniel merged this task into T74308: Inject term lookup into formatters. TASK DETAIL https://phabricator.wikimedia.org/T74036 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: Tobi_WMDE_SW, daniel Cc: wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T74308: Inject term lookup into formatters

2014-12-02 Thread daniel
daniel added a blocking task: T64724: Reuse EntityInfoBuilder arrays when generating html (tracking). TASK DETAIL https://phabricator.wikimedia.org/T74308 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel Cc

[Wikidata-bugs] [Maniphest] [Updated] T74308: Inject term lookup into formatters

2014-12-02 Thread daniel
daniel added a blocking task: T64724: Reuse EntityInfoBuilder arrays when generating html (tracking). TASK DETAIL https://phabricator.wikimedia.org/T74308 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel Cc

[Wikidata-bugs] [Maniphest] [Updated] T74308: Inject term lookup into formatters

2014-12-02 Thread daniel
daniel removed a blocking task: T64724: Reuse EntityInfoBuilder arrays when generating html (tracking). TASK DETAIL https://phabricator.wikimedia.org/T74308 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel Cc

[Wikidata-bugs] [Maniphest] [Updated] T74308: Inject term lookup into formatters

2014-12-02 Thread daniel
daniel removed a blocking task: T64724: Reuse EntityInfoBuilder arrays when generating html (tracking). TASK DETAIL https://phabricator.wikimedia.org/T74308 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel Cc

[Wikidata-bugs] [Maniphest] [Updated] T70022: Make formatter for referenced Items use pre-fetched labels.

2014-12-02 Thread daniel
daniel added a blocking task: T74308: Inject term lookup into formatters. TASK DETAIL https://phabricator.wikimedia.org/T70022 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel Cc: Lydia_Pintscher, daniel, Wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T73512: create filter by language that can be applied to objects before passing to serialization

2014-12-02 Thread daniel
daniel added a comment. Related task: T73992 JSON should (optionally) contain full URIs for referenced external entities TASK DETAIL https://phabricator.wikimedia.org/T73512 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username

[Wikidata-bugs] [Maniphest] [Commented On] T73512: create filter by language that can be applied to objects before passing to serialization

2014-12-02 Thread daniel
daniel added a comment. I suggest an EntityLocalizer service as follows: ``` interface EntityLocalizer { /** ** @return Entity **/ public function localizeEntity( Entity $e, LanguageFallbackChain $chain ); } ``` TASK DETAIL https://phabricator.wikimedia.org/T73512 REPLY

[Wikidata-bugs] [Maniphest] [Commented On] T69238: Factor diff logic out of EntityContent

2014-12-03 Thread daniel
daniel added a comment. In EntityContent::getDiff(), we have: ``` $redirectDiffOps = $differ-doDiff( $fromContent-getRedirectData(), $toContent-getRedirectData() ); ``` As you noted, getRedirectData() returns an array representation of the redirects, and $differ-doDiff

[Wikidata-bugs] [Maniphest] [Closed] T45734: soft uniqueness checks must only be performed on item creation.

2014-12-03 Thread daniel
daniel closed this task as Resolved. daniel claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T45734 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel Cc: Aklapper, Lydia_Pintscher, daniel, jeblad

[Wikidata-bugs] [Maniphest] [Created] T76705: SiteStore / SiteList performance and caching (tracking)

2014-12-04 Thread daniel
daniel created this task. daniel added a subscriber: daniel. daniel added projects: MediaWiki-extensions-WikibaseRepository, Performance, tracking, MediaWiki-Core-Team. daniel changed Security from none to none. TASK DESCRIPTION The SiteStore and SiteList classes were designed to replace

[Wikidata-bugs] [Maniphest] [Updated] T76705: SiteStore / SiteList performance and caching (tracking)

2014-12-04 Thread daniel
daniel added blocking tasks: T47532: Add file-based cached implementation of SiteStore, T58602: avoid fetching SiteList object from memcached. TASK DETAIL https://phabricator.wikimedia.org/T76705 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Updated] T76705: SiteStore / SiteList performance and caching (tracking)

2014-12-04 Thread daniel
daniel edited projects, added MediaWiki-General-or-Unknown; removed MediaWiki-Core-Team. TASK DETAIL https://phabricator.wikimedia.org/T76705 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel Cc: Aklapper, daniel

[Wikidata-bugs] [Maniphest] [Updated] T76705: SiteStore / SiteList performance and caching (tracking)

2014-12-04 Thread daniel
daniel added blocking tasks: T47532: Add file-based cached implementation of SiteStore, T58602: avoid fetching SiteList object from memcached. TASK DETAIL https://phabricator.wikimedia.org/T76705 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe

[Wikidata-bugs] [Maniphest] [Updated] T76705: SiteStore / SiteList performance and caching (tracking)

2014-12-04 Thread daniel
daniel edited projects, added MediaWiki-General-or-Unknown; removed MediaWiki-Core-Team. TASK DETAIL https://phabricator.wikimedia.org/T76705 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel Cc: Aklapper, daniel

[Wikidata-bugs] [Maniphest] [Edited] T75087: Efficient entity label lookup (tracking)

2014-12-04 Thread daniel
daniel edited the task description. daniel added a project: Performance. TASK DETAIL https://phabricator.wikimedia.org/T75087 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel Cc: Lydia_Pintscher, daniel, Wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T76705: SiteStore / SiteList performance and caching (tracking)

2014-12-04 Thread daniel
daniel edited projects, added MediaWiki-extensions-WikibaseClient; removed MediaWiki-extensions-WikibaseRepository. TASK DETAIL https://phabricator.wikimedia.org/T76705 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel

[Wikidata-bugs] [Maniphest] [Updated] T76705: SiteStore / SiteList performance and caching (tracking)

2014-12-04 Thread daniel
daniel edited projects, added MediaWiki-extensions-WikibaseClient; removed MediaWiki-extensions-WikibaseRepository. TASK DETAIL https://phabricator.wikimedia.org/T76705 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel

[Wikidata-bugs] [Maniphest] [Updated] T76705: SiteStore / SiteList performance and caching (tracking)

2014-12-04 Thread daniel
daniel added a blocking task: T76706: Design caching infrastructure for SiteStore. TASK DETAIL https://phabricator.wikimedia.org/T76705 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel Cc: Aklapper, daniel, Wikidata

[Wikidata-bugs] [Maniphest] [Updated] T76705: SiteStore / SiteList performance and caching (tracking)

2014-12-04 Thread daniel
daniel added a blocking task: T76706: Design caching infrastructure for SiteStore. TASK DETAIL https://phabricator.wikimedia.org/T76705 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel Cc: Aklapper, daniel, Wikidata

[Wikidata-bugs] [Maniphest] [Commented On] T54843: expand error messages by default in error bubbles?

2014-12-04 Thread daniel
daniel added a comment. After some more discussion, especially with Adrian, and some more consolidation in the API code as well as changes to the core API, where's what I now think: First of all, consider that the caller (the UI) usually knows best what the user was trying to do, while

[Wikidata-bugs] [Maniphest] [Retitled] T54843: Improve display of API error messages in the UI

2014-12-04 Thread daniel
daniel changed the title from expand error messages by default in error bubbles? to Improve display of API error messages in the UI. daniel set Security to none. TASK DETAIL https://phabricator.wikimedia.org/T54843 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim

[Wikidata-bugs] [Maniphest] [Commented On] T47532: Add file-based cached implementation of SiteStore

2014-12-05 Thread daniel
daniel added a comment. Note that SiteListFileCache was merged in Iaee4c1f9fb5d54e, but is not hooked up anywhere, as far as I can see. More work is needed to start using this. TASK DETAIL https://phabricator.wikimedia.org/T47532 REPLY HANDLER ACTIONS Reply to comment or attach files

[Wikidata-bugs] [Maniphest] [Created] T76854: N-Triples encoding for RDF output uses invalid escaping

2014-12-05 Thread daniel
daniel created this task. daniel added a subscriber: daniel. daniel added projects: MediaWiki-extensions-WikibaseRepository, upstream. daniel changed Security from none to none. TASK DESCRIPTION Example for Q42 (ru: Дуглас Адамс) Expected escaping: `\u0414\u0443\u0433\u043b\u0430\u0441

[Wikidata-bugs] [Maniphest] [Commented On] T72205: Mono-lingual text datatype should support no linguistic content and undetermined language

2014-12-05 Thread daniel
daniel added a comment. For no linguistic content, the string data type seems like a better match. But I suppose the intention here is to always use the same property to represent the inscription text, no matter whether it's natural language or not (what about symbols though? QR codes

[Wikidata-bugs] [Maniphest] [Commented On] T76854: N-Triples encoding for RDF output uses invalid escaping

2014-12-05 Thread daniel
daniel added a comment. Upstream ticket: https://github.com/njh/easyrdf/issues/219 TASK DETAIL https://phabricator.wikimedia.org/T76854 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel Cc: Aklapper, daniel, Wikidata

[Wikidata-bugs] [Maniphest] [Closed] T73352: Usage Tracking: changes should trigger an appropriate update of pages that use the corresponding aspect of the change item

2014-12-08 Thread daniel
daniel closed this task as Resolved. daniel claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T73352 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. To: daniel Cc: Lydia_Pintscher, daniel, Wikidata-bugs

  1   2   3   4   5   6   7   8   9   10   >