[Wikidata-bugs] [Maniphest] [Commented On] T102324: [Bug] Property suggestions for qualifiers and references are bad when adding new statements

2019-04-17 Thread Envlh 
Envlh added a comment.


  Thank you for the reply and for having clarified that this issue has no 
assignee at the moment.

TASK DETAIL
  https://phabricator.wikimedia.org/T102324

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Envlh
Cc: MichaelSchoenitzer, Envlh, Jan_Dittrich, Lea_Lacroix_WMDE, PokestarFan, 
Agabi10, Liuxinyu970226, gerritbot, Multichill, TerraCodes, hoo, Nikki, Jonas, 
thiemowmde, Mbch331, Sjoerddebruin, Lydia_Pintscher, aude, matej_suchanek, 
Aklapper, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Wikidata-bugs
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T102324: [Bug] Property suggestions for qualifiers and references are bad when adding new statements

2019-04-17 Thread Lea_Lacroix_WMDE 
Lea_Lacroix_WMDE added a comment.


  Thanks for pinging again about this issue. This task is not worked on at the 
moment, I will check if we can bring it to the development process soon.

TASK DETAIL
  https://phabricator.wikimedia.org/T102324

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lea_Lacroix_WMDE
Cc: MichaelSchoenitzer, Envlh, Jan_Dittrich, Lea_Lacroix_WMDE, PokestarFan, 
Agabi10, Liuxinyu970226, gerritbot, Multichill, TerraCodes, hoo, Nikki, Jonas, 
thiemowmde, Mbch331, Sjoerddebruin, Lydia_Pintscher, aude, matej_suchanek, 
Aklapper, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Wikidata-bugs
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T102324: [Bug] Property suggestions for qualifiers and references are bad when adding new statements

2019-04-13 Thread Envlh 
Envlh added a comment.


  Hello,
  
  @thiemowmde Are you still working on this issue?

TASK DETAIL
  https://phabricator.wikimedia.org/T102324

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde, Envlh
Cc: MichaelSchoenitzer, Envlh, Jan_Dittrich, Lea_Lacroix_WMDE, PokestarFan, 
Agabi10, Liuxinyu970226, gerritbot, Multichill, TerraCodes, hoo, Nikki, Jonas, 
thiemowmde, Mbch331, Sjoerddebruin, Lydia_Pintscher, aude, matej_suchanek, 
Aklapper, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Wikidata-bugs
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T102324: [Bug] Property suggestions for qualifiers and references are bad when adding new statements

2017-07-26 Thread gerritbot 
gerritbot added a comment.
Change 356071 merged by jenkins-bot:
[mediawiki/extensions/PropertySuggester@master] Don't show suggestions for qualifiers/references of new statements

https://gerrit.wikimedia.org/r/356071TASK DETAILhttps://phabricator.wikimedia.org/T102324EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, gerritbotCc: PokestarFan, Agabi10, Liuxinyu970226, gerritbot, Multichill, TerraCodes, hoo, Nikki, Jonas, thiemowmde, Mbch331, Sjoerddebruin, Lydia_Pintscher, aude, matej_suchanek, Aklapper, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T102324: [Bug] Property suggestions for qualifiers and references are bad when adding new statements

2017-05-29 Thread gerritbot 
gerritbot added a comment.
Change 356071 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/PropertySuggester@master] Don't show suggestions for qualifiers/references of new statements

https://gerrit.wikimedia.org/r/356071TASK DETAILhttps://phabricator.wikimedia.org/T102324EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, gerritbotCc: gerritbot, Multichill, TerraCodes, hoo, Nikki, Jonas, thiemowmde, Mbch331, Sjoerddebruin, Lydia_Pintscher, aude, matej_suchanek, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T102324: [Bug] Property suggestions for qualifiers and references are bad when adding new statements

2016-10-12 Thread hoo 
hoo added a comment.
The change above is not enough, see also https://github.com/Wikidata-lib/PropertySuggester/pull/177#issuecomment-25327.TASK DETAILhttps://phabricator.wikimedia.org/T102324EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, hooCc: TerraCodes, hoo, Nikki, Jonas, thiemowmde, Mbch331, Sjoerddebruin, Lydia_Pintscher, aude, matej_suchanek, Aklapper, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T102324: [Bug] Property suggestions for qualifiers and references are bad when adding new statements

2016-10-09 Thread matej_suchanek 
matej_suchanek added a comment.
Meanwhile I found where the bug comes from:
https://github.com/Wikidata-lib/PropertySuggester/blob/master/modules/ext.PropertySuggester.EntitySelector.js#L142-L152

_getPropertyContext: function() {
	if ( this._isInNewStatementView() ) {
		return 'item';
	} else if ( this._isQualifier() ) {
		return 'qualifier';
	} else if ( this._isReference() ) {
		return 'reference';
	} else {
		return null;
	}
},

Maybe if the order of these conditions changed...TASK DETAILhttps://phabricator.wikimedia.org/T102324EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matej_suchanekCc: Nikki, Jonas, thiemowmde, Mbch331, Sjoerddebruin, Lydia_Pintscher, aude, matej_suchanek, Aklapper, D3r1ck01, Izno, Wikidata-bugs___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T102324: [Bug] Property suggestions for qualifiers and references are bad when adding new statements

2016-10-09 Thread Sjoerddebruin 
Sjoerddebruin added a comment.
Is it possible to hide these until we have a decent solution? People are getting confused by these, like adding statements as qualifiers.TASK DETAILhttps://phabricator.wikimedia.org/T102324EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SjoerddebruinCc: Nikki, Jonas, thiemowmde, Mbch331, Sjoerddebruin, Lydia_Pintscher, aude, matej_suchanek, Aklapper, D3r1ck01, Izno, Wikidata-bugs___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs