[Wikidata-bugs] [Maniphest] [Commented On] T117674: [Task] ESC key should close property suggester dropdown and statement edit mode
Jan_Dittrich added a comment. If we deem this as important (or just interesting) we could make this part of a small, informal usability test – we could ask in-house, since I assume not everyone is familiar with data entry behavior in wikidata. TASK DETAIL https://phabricator.wikimedia.org/T117674 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jonas, Jan_Dittrich Cc: Jan_Dittrich, gerritbot, Lydia_Pintscher, adrianheine, JanZerebecki, Tobi_WMDE_SW, Aklapper, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T117674: [Task] ESC key should close property suggester dropdown and statement edit mode
Jan_Dittrich added a comment. Thiemo asked me about my UX view on that issue. In general, the single-escape = out (Thiemos suggestion) makes sense, but I can not judge how much people may rely on that and got used to it. TASK DETAIL https://phabricator.wikimedia.org/T117674 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jonas, Jan_Dittrich Cc: Jan_Dittrich, gerritbot, Lydia_Pintscher, adrianheine, JanZerebecki, Tobi_WMDE_SW, Aklapper, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T117674: [Task] ESC key should close property suggester dropdown and statement edit mode
gerritbot added a comment. Change 288391 had a related patch set uploaded (by Jonas Kress (WMDE)): Introduce step "I Close the entity selector if present" https://gerrit.wikimedia.org/r/288391 TASK DETAIL https://phabricator.wikimedia.org/T117674 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jonas, gerritbot Cc: gerritbot, Lydia_Pintscher, adrianheine, JanZerebecki, Tobi_WMDE_SW, Aklapper, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T117674: [Task] ESC key should close property suggester dropdown and statement edit mode
gerritbot added a comment. Change 288209 merged by jenkins-bot: Fix: Property suggester leads to test fail https://gerrit.wikimedia.org/r/288209 TASK DETAIL https://phabricator.wikimedia.org/T117674 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jonas, gerritbot Cc: gerritbot, Lydia_Pintscher, adrianheine, JanZerebecki, Tobi_WMDE_SW, Aklapper, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T117674: [Task] ESC key should close property suggester dropdown and statement edit mode
Jonas added a comment. Browsertests are failing, because when property suggester is present entity selector opens directly when entering edit mode. There is no race condition whatsoever... TASK DETAIL https://phabricator.wikimedia.org/T117674 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jonas Cc: gerritbot, Lydia_Pintscher, adrianheine, JanZerebecki, Tobi_WMDE_SW, Aklapper, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T117674: [Task] ESC key should close property suggester dropdown and statement edit mode
gerritbot added a comment. Change 288209 had a related patch set uploaded (by Jonas Kress (WMDE)): Fix: Property suggester leads to test fail https://gerrit.wikimedia.org/r/288209 TASK DETAIL https://phabricator.wikimedia.org/T117674 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jonas, gerritbot Cc: gerritbot, Lydia_Pintscher, adrianheine, JanZerebecki, Tobi_WMDE_SW, Aklapper, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T117674: [Task] ESC key should close property suggester dropdown and statement edit mode
Tobi_WMDE_SW added a comment. @lydia_pintscher I've updated the task description according to @janzerebecki's comment. TASK DETAIL https://phabricator.wikimedia.org/T117674 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tobi_WMDE_SW Cc: Lydia_Pintscher, adrianheine, JanZerebecki, Tobi_WMDE_SW, Aklapper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T117674: [Task] ESC key should close property suggester dropdown and statement edit mode
Lydia_Pintscher added a subscriber: Lydia_Pintscher. Lydia_Pintscher added a comment. Please be more specific in writing these tasks. Is this about a behavior change of the existing UI? Is this about testing something as the blocker seems to indicate? TASK DETAIL https://phabricator.wikimedia.org/T117674 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lydia_Pintscher, adrianheine, JanZerebecki, Tobi_WMDE_SW, Aklapper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T117674: [Task] ESC key should close property suggester dropdown and statement edit mode
JanZerebecki added a comment. This is about changing the exiting UI. Currently there is a race conditions in the UI for editing an item value in a statement. After typing but before the PropertySuggester shows its item suggestions, ESC cancels the edit. If the PropertySuggester shows, ESC only closes the property suggester. The current behavior is different depending on latency. Making the UI more predictable has the nice effect of allowing us to easily make a non-flaky browser test. TASK DETAIL https://phabricator.wikimedia.org/T117674 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: Lydia_Pintscher, adrianheine, JanZerebecki, Tobi_WMDE_SW, Aklapper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T117674: [Task] ESC key should close property suggester dropdown and statement edit mode
Lydia_Pintscher added a comment. Ok thanks. This really isn't clear from the initial description. TASK DETAIL https://phabricator.wikimedia.org/T117674 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Lydia_Pintscher, adrianheine, JanZerebecki, Tobi_WMDE_SW, Aklapper, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
